Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Michel Dänzer
be able to draw some kind of sensible conclusions from > that? Yes, of course. How else would you do regular regression testing with current Git of everything? It's been working fine for me. -- Earthling Michel Dänzer| http://www.amd.

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Michel Dänzer
On 29.05.2014 13:18, Dylan Baker wrote: > On Thursday, May 29, 2014 13:15:54 Michel Dänzer wrote: >> On 29.05.2014 13:09, Matt Turner wrote: >>> On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin > wrote: >>>> Dylan, I'm sure you hate this, but it does seem to w

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Michel Dänzer
On 29.05.2014 13:22, Matt Turner wrote: > On Wed, May 28, 2014 at 9:15 PM, Michel Dänzer wrote: >> On 29.05.2014 13:09, Matt Turner wrote: >>> On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin wrote: >>>> Dylan, I'm sure you hate this, but it does seem to work fo

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-29 Thread Michel Dänzer
fore checking this in. > That'll indicate I'm not the only crazy person who wants this. > - Perhaps an additional difference is one of approach. Nouveau fails a > lot of tests. Some tests fail on only some chips, that can make it > easier to identify what is wrong and why.

Re: [Piglit] [PATCH] profile: Fix mixed concurrency runs

2014-06-04 Thread Michel Dänzer
this. It would be great if somebody could work on distinguishing between the second and third case above, and allowing one second case test to run concurrently with first case tests again. This would cut down the runtime of gpu.py by several minutes for me. -- Earthling Michel Dänzer

Re: [Piglit] [PATCH] profile: Fix mixed concurrency runs

2014-06-05 Thread Michel Dänzer
On 05.06.2014 16:48, Dylan Baker wrote: > On Thursday, June 05, 2014 12:50:26 PM Michel Dänzer wrote: >> On 25.04.2014 07:51, Marek Olšák wrote: >>> There are 3 categories of tests: >>> - concurrent, these are off-screen and can be run anytime >>> - non-concurr

Re: [Piglit] [PATCH] profile: Fix mixed concurrency runs

2014-06-05 Thread Michel Dänzer
On 05.06.2014 17:14, Michel Dänzer wrote: > On 05.06.2014 16:48, Dylan Baker wrote: >> On Thursday, June 05, 2014 12:50:26 PM Michel Dänzer wrote: >>> On 25.04.2014 07:51, Marek Olšák wrote: >>>> There are 3 categories of tests: >>>> - concurrent, t

Re: [Piglit] [PATCH] profile: Fix mixed concurrency runs

2014-06-05 Thread Michel Dänzer
On 05.06.2014 16:48, Dylan Baker wrote: > On Thursday, June 05, 2014 12:50:26 PM Michel Dänzer wrote: >> On 25.04.2014 07:51, Marek Olšák wrote: >>> There are 3 categories of tests: >>> - concurrent, these are off-screen and can be run anytime >>> - non-concurr

[Piglit] [PATCH] Hook up two new EXT_packed_depth_stencil tests added recently

2014-06-10 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- tests/all.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/all.py b/tests/all.py index 3830013..4cd5e97 100644 --- a/tests/all.py +++ b/tests/all.py @@ -2497,7 +2497,9 @@ add_depthstencil_render_miplevels_tests( &#x

Re: [Piglit] [PATCH] Hook up two new EXT_packed_depth_stencil tests added recently

2014-06-11 Thread Michel Dänzer
On 11.06.2014 21:03, Brian Paul wrote: > On 06/11/2014 12:09 AM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Signed-off-by: Michel Dänzer >> --- >> tests/all.py | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/all

[Piglit] [PATCH piglit] Fix piglit-util-gl-common.h -> piglit-util-gl.h

2014-07-23 Thread Michel Dänzer
From: Michel Dänzer The file was recently renamed. Fixes build failure since commit 4ee589ec1c4af7439e1f10a8fd4333c ('gles-3.0: Verify gl_VertexID when used with glDrawArrays'). Signed-off-by: Michel Dänzer --- I can't push this myself, so whoever reviews it please push it.

[Piglit] [PATCH] Allow one 'non-concurrent' test to run in parallel with concurrent tests again

2014-08-19 Thread Michel Dänzer
From: Michel Dänzer This reverts commit acb824ddc53c446124d88e37db610a4f8c59d56c. This decreases the runtime of the gpu.py profile from around 15 minutes to around 12 minutes on my machine, with no change in results. If in the future there are tests which really can't run in parallel wit

Re: [Piglit] [PATCH] Allow one 'non-concurrent' test to run in parallel with concurrent tests again

2014-08-20 Thread Michel Dänzer
On 21.08.2014 05:42, Jason Ekstrand wrote: > On Aug 19, 2014 8:13 PM, "Michel Dänzer" <mailto:mic...@daenzer.net>> wrote: >> >> From: Michel Dänzer <mailto:michel.daen...@amd.com>> >> >> This reverts commit acb824ddc53c446124d88e37db610a4f8

Re: [Piglit] [PATCH] Allow one 'non-concurrent' test to run in parallel with concurrent tests again

2014-08-21 Thread Michel Dänzer
don't want to use for piglit as I explained before. I'll just continue using this patch locally if it isn't applied. I thought others might be interested in saving a little time for each piglit run by default, but apparently not. -- Earthling Michel Dänzer|

Re: [Piglit] [RFC] Piglit tags/releases

2014-10-05 Thread Michel Dänzer
the output of 'git describe' will look funny. -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer ___ Piglit mailing list Piglit@li

[Piglit] [PATCH] tests/all.py: GLX tests can run on the 'mixed_glx_egl' platform

2014-10-14 Thread Michel Dänzer
From: Michel Dänzer Which is the default platform on Linux. Signed-off-by: Michel Dänzer --- tests/all.py | 178 +-- 1 file changed, 89 insertions(+), 89 deletions(-) diff --git a/tests/all.py b/tests/all.py index 5462f8d..578c9a0

Re: [Piglit] [PATCH] tests/all.py: GLX tests can run on the 'mixed_glx_egl' platform

2014-10-15 Thread Michel Dänzer
On 15.10.2014 16:19, Dylan Baker wrote: Reviewed-by: Dylan Baker Thanks, can you push it for me please? -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer

[Piglit] [PATCH] glx-oml-sync-control-*: Don't fail with -auto on the command line

2014-10-15 Thread Michel Dänzer
From: Michel Dänzer Looks like basically all tests are passed -auto since Dylan's recent changes, and these tests always behave the same way as other tests do with -auto anyway. Signed-off-by: Michel Dänzer --- tests/spec/glx_oml_sync_control/timing.c | 2 ++ 1 file changed, 2 inser

Re: [Piglit] [PATCH] glx-oml-sync-control-*: Don't fail with -auto on the command line

2014-10-15 Thread Michel Dänzer
On 15.10.2014 19:23, Eric Anholt wrote: Michel Dänzer writes: From: Michel Dänzer Looks like basically all tests are passed -auto since Dylan's recent changes, and these tests always behave the same way as other tests do with -auto anyway. Reviewed-by: Eric Anholt Thanks, can you

Re: [Piglit] [PATCH 2/2] Removed Glean read pixels sanity test.

2014-10-19 Thread Michel Dänzer
ean['stencil2'] = GleanTest('stencil2') glean['texCombine'] = GleanTest('texCombine') This also needs to be removed from tests/sanity.py, and the new test should probably be added there instead. -- Earthling Michel Dän

Re: [Piglit] [PATCH 2/2] Removed Glean read pixels sanity test.

2014-10-20 Thread Michel Dänzer
esults may not be reliable. I'm not sure that the glean basic test needs to be replaced with anything for that purpose, but it might be nice to keep sanity.py even just for the test you added in patch 1. -- Earthling Michel Dänzer| http://www.amd.com Libre

Re: [Piglit] [PATCH 2/2] Removed Glean read pixels sanity test.

2014-10-21 Thread Michel Dänzer
. Probably not as urgent though. On Tue, Oct 21, 2014 at 10:04 AM, Laura Ekstrand mailto:la...@jlekstrand.net>> wrote: Ok, I just sent a patch to update sanity.py. Please squash that into patch 1 of this series. -- Earthling Michel Dänzer| http://www.am

Re: [Piglit] [PATCH 29/34] cl tests: move non-generated tests out of the generated tests dir

2015-02-23 Thread Michel Dänzer
c: symbolic link to ../../../tests/cl/store/store-kernels-global.inc generated_tests/cl/store/store-kernels-local.inc: symbolic link to ../../../tests/cl/store/store-kernels-local.inc -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] Some glean test names broken in HTML summary since "all.py: Convert all.py to use TestProfile.group_manager"

2015-03-05 Thread Michel Dänzer
Hi Dylan, your commit b799e8c57ec77c4cfbabb165dcd45294d80e9f6c broke the names of some glean tests in the HTML summary for me. They now have a space between every character, e.g. "a p i 2" instead of "api2". -- Earthling Michel Dänzer | http

Re: [Piglit] [PATCH] profile.py: Support automatic naming of tests with string arguments

2015-03-08 Thread Michel Dänzer
t I couldn't justify. > > Signed-off-by: Dylan Baker > --- > > Michel, does this fix your problem? It does, thanks. Tested-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

[Piglit] [PATCH] ext_image_dma_buf_import: Include image_common.h from sample_common.c

2015-05-14 Thread Michel Dänzer
From: Michel Dänzer Fixes build failure against current Mesa Git master: .../sample_common.c.o: In function `sample_and_destroy_img': .../sample_common.c:107: undefined reference to `eglDestroyImageKHR' .../sample_common.c.o: In function `sample_buffer': .../sample_common.c

Re: [Piglit] [PATCH] ext_image_dma_buf_import: Include image_common.h from sample_common.c

2015-05-17 Thread Michel Dänzer
On 15.05.2015 19:12, Emil Velikov wrote: > On 15 May 2015 at 03:09, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Fixes build failure against current Mesa Git master: >> >> .../sample_common.c.o: In function `sample_and_destroy_img': >> ...

Re: [Piglit] [PATCH 00/40] Replace vpfp-generic with shader_runner.

2015-06-08 Thread Michel Dänzer
that only people actively working on driver dev incur the > extra cost. Is the extra cost actually significant? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer __

[Piglit] Issues with xz compression support using the xz command line utility

2015-07-22 Thread Michel Dänzer
eline/results.json.']' returned non-zero exit status 1 -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 0/4] framework: baceknds fixes, mostly in xz shell

2015-07-22 Thread Michel Dänzer
On 23.07.2015 10:11, Dylan Baker wrote: > This is mostly small fixups for the xz shell path, as well as some > additional unit tests to spot these issues. > > Michel, could you give these a whirl and see if they fix your problems? They do, thanks. Tested-by: Michel Dänzer -

[Piglit] New tests no longer appearing on changes.html

2015-10-20 Thread Michel Dänzer
I recently noticed that newly added tests are no longer appearing on the changes.html page. It would be nice to have that back. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [Piglit] [PATCH v2 2/2] framework/summary/common.py: Add enabled, disabled, and skip to changes

2015-10-22 Thread Michel Dänzer
failing unit tests from the previous commit. > > v2: - don't include skip <-> notrun (Ilia) > > cc: Michel Dänzer > Signed-off-by: Dylan Baker Tested-by: Michel Dänzer Thanks Dylan, -- Earthling Michel Dänzer | http://www.amd.com Libre sof

Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos

2015-12-02 Thread Michel Dänzer
-- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos

2015-12-07 Thread Michel Dänzer
On 05.12.2015 12:53, Ian Romanick wrote: > On 12/02/2015 07:03 PM, Michel Dänzer wrote: >> On 03.12.2015 01:42, Ian Romanick wrote: >>> >>> +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます。 >> >> The nouns are reversed in the Japanese text, so it actual

Re: [Piglit] [PATCH v2 1/4] pbo-read-argb8888: make it endian-safe

2016-03-30 Thread Michel Dänzer
ARB); > > - pass &= probe(10, 10, 0xff00, addr[0]); > - pass &= probe(10, 10, 0x00ff, addr[1]); > + pass &= probe(10, 10, exp_green, &addr[0]); > + pass &= probe(10, 10, exp_red, &addr[1]); And this

Re: [Piglit] [PATCH v3 1/4] pbo-read-argb8888: make it endian-safe

2016-04-01 Thread Michel Dänzer
d[1], expected[2], > expected[3]); > + printf(" Observed: b = 0x%02x g = 0x%02x r = 0x%02x a = > 0x%02x\n", > + observed[0], observed[1], observed[2], > observed[3]); Some lines aren't indented properly to line

[Piglit] [PATCH] EGL_KHR_cl_event2: Clean up gl_extensions array from test_cleanup()

2016-05-12 Thread Michel Dänzer
From: Michel Dänzer Fixes a crash with multiple OpenCL devices available, due to re-using the stale gl_extensions array from a previous EGL context. Signed-off-by: Michel Dänzer --- tests/cl/interop/egl_khr_cl_event2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/cl/interop

Re: [Piglit] [PATCH] EGL_KHR_cl_event2: Clean up gl_extensions array from test_cleanup()

2016-05-24 Thread Michel Dänzer
On 13.05.2016 22:09, Eduardo Lima Mitev wrote: > Patch looks good, but I was not able to test it fully. > > Acked-by: Eduardo Lima Mitev Thanks Eduardo. Unless there are any objections, can somebody push this for me please? -- Earthling Michel Dänzer |

[Piglit] [PATCH] shader_test.py: Check for GL ES 3.1 as well

2016-08-09 Thread Michel Dänzer
From: Michel Dänzer Fixes piglit runs failing with Fatal Error: In File .../piglit/tests/spec/oes_geometry_shader/sso_validation/user-defined-gs-input-in-block.shader_test: No GL ES version set Fixes: 25ef19627966 ("OES_geometry_shader: Basic SSO IO validation tests") Signed-off-

Re: [Piglit] [PATCH] framework: fix binary assignment for shader_runner

2016-08-09 Thread Michel Dänzer
o shares this picking mechanism with the Fast Skip > mechanism, so they always have the same result. > > Signed-off-by: Dylan Baker Tested-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

[Piglit] [PATCH 2/3] egl-create-largest-pbuffer-surface: Don't call eglSwapBuffers

2016-08-23 Thread Michel Dänzer
From: Michel Dänzer Calling eglSwapBuffers may invalidate the back buffer contents, so we must not do so before probing the back buffer contents. The test exits immediately even without -auto, so just remove the eglSwapBuffers call. Signed-off-by: Michel Dänzer --- tests/egl/egl-create

[Piglit] [PATCH 1/3] egl-create-pbuffer-surface: Don't call eglSwapBuffers

2016-08-23 Thread Michel Dänzer
From: Michel Dänzer Calling eglSwapBuffers may invalidate the back buffer contents, so we must not do so before probing the back buffer contents. The test exits immediately even without -auto, so just remove the eglSwapBuffers call. Signed-off-by: Michel Dänzer --- tests/egl/egl-create

[Piglit] [PATCH 3/3] egl-nok-texture-from-pixmap: Call SwapBuffers after probing back buffer

2016-08-23 Thread Michel Dänzer
From: Michel Dänzer Calling eglSwapBuffers may invalidate the back buffer contents. Signed-off-by: Michel Dänzer --- tests/egl/egl-nok-texture-from-pixmap.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/egl/egl-nok-texture-from-pixmap.c b/tests/egl/egl-nok

Re: [Piglit] [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-08-23 Thread Michel Dänzer
On 20/08/16 04:42 AM, Eric Anholt wrote: > Michel Dänzer writes: > >> From: Michel Dänzer >> >> Always use 3 buffers when flipping. With only 2 buffers, we have to wait >> for a flip to complete (which takes non-0 time even with asynchronous >> flips) bef

Re: [Piglit] [PATCH 1/3] egl-create-pbuffer-surface: Don't call eglSwapBuffers

2016-08-23 Thread Michel Dänzer
On 23/08/16 05:46 PM, Tapani Pälli wrote: > All 3 patches > > Reviewed-by: Tapani Pälli Thanks! Can you push them for me? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X

Re: [Piglit] [PATCH] framework: fix binary assignment for shader_runner

2016-08-23 Thread Michel Dänzer
eaks piglit here. Reverting the patch fixes the > problem for me. What does "breaks piglit" mean? What are the symptoms? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer signatur

Re: [Piglit] [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-08-25 Thread Michel Dänzer
On 24/08/16 06:35 AM, Eric Anholt wrote: > Michel Dänzer writes: >> On 20/08/16 04:42 AM, Eric Anholt wrote: >>> Michel Dänzer writes: >>> >>>> From: Michel Dänzer >>>> >>>> Always use 3 buffers when flipping. With only 2 buffers,

Re: [Piglit] [PATCH v3 3/3] framework/backends/json: Don't convert to TestrunResult while updating

2016-10-24 Thread Michel Dänzer
lts, destination, exclude) File "/home/daenzer/src/piglit-git/piglit/framework/summary/html_.py", line 100, in _make_testrun_info time=each.time_elapsed.delta, AttributeError: 'dict' object has no attribute 'delta' -- Earthling Michel Dänzer |

Re: [Piglit] [PATCH 0/3] Fix summary breakage

2016-10-25 Thread Michel Dänzer
ip/fix-summary > > Mark and Michel, > I'd appreciate if you could test this and make sure it fixes your respective > problems. It does, thanks. Patches 1 & 2 are Tested-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre sof

Re: [Piglit] [PATCH] framework/test/shader_test: Fix MultiShaderRunner handling of directories

2016-11-08 Thread Michel Dänzer
> + 'Cannot pick a shader_runner binary!') > else: > prog = parser.prog > > Tested-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

[Piglit] spec@arb_vertex_attrib_64bit@execution@vs_in tests

2017-04-09 Thread Michel Dänzer
Hi Dylan, the subset of these tests varies wildly between my daily gpu.py runs, which makes the changes/enabled/disabled.html summary pages pretty awkward to look at. Is there anything that can be done to improve this? -- Earthling Michel Dänzer | http

[Piglit] [PATCH 3/3] glx-oml-sync-control-timing: Perform warm-up swap / wait before loop

2017-04-14 Thread Michel Dänzer
From: Michel Dänzer Without this, the first iteration of the loop can start at any point of the display refresh cycle. If it's close to the next vertical blank period, it may be too late for the swap / wait to hit the target MSC, which would result in at least a warning. Signed-off-by: M

[Piglit] [PATCH 1/3] glx-oml-sync-control-timing: Fix error message if glXWaitForMscOML fails

2017-04-14 Thread Michel Dänzer
From: Michel Dänzer It said "glXWaitForSbcOML failed", which could be confusing. Signed-off-by: Michel Dänzer --- tests/spec/glx_oml_sync_control/timing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/glx_oml_sync_control/timing.c b/

[Piglit] [PATCH 0/3] glx-oml-sync-control-timing fixes

2017-04-14 Thread Michel Dänzer
From: Michel Dänzer Patch 1 fixes an error message typo I noticed along the way. Patches 2 & 3 allow the glx-oml-sync-control-timing tests to consistently pass for me, at least if the system isn't otherwise loaded. Before, they would randomly generate warnings even in that case. Mich

[Piglit] [PATCH 2/3] glx-oml-sync-control-timing: Refactor helper functions for swap / wait

2017-04-14 Thread Michel Dänzer
From: Michel Dänzer Preparation for the following fix, no functional change intended. Signed-off-by: Michel Dänzer --- tests/spec/glx_oml_sync_control/timing.c | 83 1 file changed, 51 insertions(+), 32 deletions(-) diff --git a/tests/spec

Re: [Piglit] [PATCH 4/5] framework: Add command.setter method to Test

2017-05-18 Thread Michel Dänzer
ile to no longer pass --quick to glean tests. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ Piglit mailing list Piglit@lists.

Re: [Piglit] [PATCH] test/gleantest: fix missing --quick property from quick profile

2017-05-22 Thread Michel Dänzer
gt; self._command = [n for n in new if not n in self.GLOBAL_PARAMS] > > def interpret_result(self): > if self.result.returncode != 0 or 'FAIL' in self.result.out: > self.result.result = 'fail' > else: >

Re: [Piglit] [PATCH 1/4] utils/glx: Don't create X pixmaps deeper than the root window.

2017-09-06 Thread Michel Dänzer
depth 24, bits_per_pixel 32, scanline_pad 32 depth 32, bits_per_pixel 32, scanline_pad 32 It sounds like this doesn't list depth 30 for you, which indicates an issue with the Xorg (driver) changes for depth 30 support. -- Earthling Michel Dänzer |

Re: [Piglit] [PATCH 1/4] utils/glx: Don't create X pixmaps deeper than the root window.

2017-09-06 Thread Michel Dänzer
On 06/09/17 05:13 PM, Mario Kleiner wrote: > On 09/06/2017 09:30 AM, Michel Dänzer wrote: >> On 05/09/17 02:52 PM, Mario Kleiner wrote: >>> XCreatePixmap doesn't like that. Fixes piglit regression if the >>> GL implementation exposes RGB10 depth 30 FBConfigs, but th

Re: [Piglit] [PATCH 1/4] utils/glx: Don't create X pixmaps unsupported by x-screen. (v2)

2017-09-07 Thread Michel Dänzer
by Michel. > > Signed-off-by: Mario Kleiner Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ Pigl

Re: [Piglit] Remove remaing Glean tests.

2017-12-11 Thread Michel Dänzer
m not supported by mesa (anymore) > makeCurrent glX api n/a to piglit What does "glX api n/a to piglit" mean exactly? What about the tests in tests/glx/? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-05-07 Thread Michel Dänzer
l-routing', ... >>> >>> Successful CI runlog: >>> http://gfx-ci.fi.intel.com/tree/drm-tip/CI_DRM_4148/pig-glk-j5005/run0.log >>> >>> Unsuccessful CI runlog: >>> http://gfx-ci.fi.intel.com/tree/drm-tip/CI_DRM_4149/pig-glk-j5005/run0.log

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-05-08 Thread Michel Dänzer
On 2018-05-07 06:49 PM, Michel Dänzer wrote: > On 2018-05-07 06:44 PM, Dylan Baker wrote: >> Quoting Tomi Sarvela (2018-05-07 01:20:46) >>> >>> piglit/framework$ diff -c profile.py.orig profile.py >>> *** profile.py.orig 2018-05-07 19:11:37.649994643 +0300

Re: [Piglit] [PATCH] framework: fix running with mixed concurrency (neither -c or -1)

2018-05-09 Thread Michel Dänzer
gt; File "/home/user/piglit/framework/programs/run.py", line 370, in run > backend.finalize({'time_elapsed': time_elapsed.to_json()}) > File "/home/user/piglit/framework/backends/json.py", line 163, in finalize > assert data['tests'] > AssertionEr

Re: [Piglit] [PATCH 1/4] framework: ensure that all tests are run before exiting

2018-05-09 Thread Michel Dänzer
eviously accurately listed as "crash" in the summary, now it's "notrun". Tested-by: Michel Dänzer The bigger remaining issue is that --process-isolation false gpu takes almost twice as long as it did before 9461d92301e72807eba4776a16a05207e3a164

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-05-09 Thread Michel Dänzer
On 2018-05-08 07:19 PM, Dylan Baker wrote: > Quoting Michel Dänzer (2018-05-08 07:07:34) >> >> I just bisected another problem to >> 9461d92301e72807eba4776a16a05207e3a16477: The xts-render profile doesn't >> work anymore. Most of the time, it doesn't even

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-05-11 Thread Michel Dänzer
On 2018-05-10 03:08 AM, Matt Turner wrote: > On Tue, May 8, 2018 at 7:07 AM, Michel Dänzer wrote: >> On 2018-05-07 06:49 PM, Michel Dänzer wrote: >>> On 2018-05-07 06:44 PM, Dylan Baker wrote: >>>> Quoting Tomi Sarvela (2018-05-07 01:20:46) >>>>> &g

Re: [Piglit] [PATCH 1/4] framework: ensure that all tests are run before exiting

2018-05-11 Thread Michel Dänzer
On 2018-05-09 07:38 PM, Dylan Baker wrote: > Quoting Michel Dänzer (2018-05-09 02:33:13) >> On 2018-05-08 11:27 PM, Dylan Baker wrote: >> >> The bigger remaining issue is that --process-isolation false gpu takes >> almost twice as long as it did before >> 9461d92

Re: [Piglit] [PATCH 1/3] profile: add the idea of process-isolated xml file

2018-05-11 Thread Michel Dänzer
he set of tests run by the gpu profile is almost identical to what it was before 9461d92301e72807eba4776a16a05207e3a16477. I assume the remaining minor differences are expected due to unrelated other changes in the meantime. Overall, this series looks great from my end, thanks Dylan! Tested-by: Mich

[Piglit] [PATCH] Use _exit() instead of exit() in child processes

2018-06-06 Thread Michel Dänzer
From: Michel Dänzer A child process which doesn't call exec() shouldn't use exit(), as that will attempt to run any atexit handlers of the parent, which may break. It actually results in crashing with the Mesa radeonsi driver. Signed-off-by: Michel Dänzer --- .../spec/glx_ext_impo

Re: [Piglit] [PATCH 0/3] glx-oml-sync-control-timing fixes

2018-06-07 Thread Michel Dänzer
On 2017-04-14 09:06 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Patch 1 fixes an error message typo I noticed along the way. > > Patches 2 & 3 allow the glx-oml-sync-control-timing tests to > consistently pass for me, at least if the system isn't otherwise &

Re: [Piglit] [PATCH 0/3] glx-oml-sync-control-timing fixes

2018-06-08 Thread Michel Dänzer
On 2018-06-07 01:02 PM, Emil Velikov wrote: > On 7 June 2018 at 10:58, Michel Dänzer wrote: >> On 2017-04-14 09:06 AM, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> Patch 1 fixes an error message typo I noticed along the way. >>> >>&g

Re: [Piglit] [PATCH 7/7] EXT_shader_framebuffer_fetch: Add test cases specific to desktop GL.

2018-07-18 Thread Michel Dänzer
quot;/home/daenzer/src/piglit-git/piglit/tests/../tests/shader.py", line 79, in profile.test_list[group] = MultiShaderTest.new(files, installedfiles) File "/home/daenzer/src/piglit-git/piglit/tests/../framework/test/shader_test.py", line 253, in new 'GLES and GL shaders in the same command!\n

Re: [Piglit] [PATCH 2/2] generated_tests: Make API a subdir in gen_shader_framebuffer_fetch_tests

2018-07-19 Thread Michel Dänzer
On 2018-07-18 08:53 PM, Dylan Baker wrote: > This is required to make the shader_runner multiple tests in one process > mode work, as it cannot mix gles and gl shaders together. Both patches are Tested-by: Michel Dänzer Thanks! -- Earthling Michel Dänzer |

[Piglit] [PATCH] shader_runner: Take spirv_replaces_glsl into account for current_config

2018-09-04 Thread Michel Dänzer
From: Michel Dänzer Without this, validate_current_gl_context never returns true if spirv_replaces_glsl == true, resulting in repeatedly calling recreate_gl_context indefinitely after the first subtest. Fixes: 0baf4e2708c "shader_runner/spirv: support loading SPIR-V shaders" Sig

Re: [Piglit] [PATCH] shader_runner: Take spirv_replaces_glsl into account for current_config

2018-09-05 Thread Michel Dänzer
On 2018-09-05 6:29 p.m., Alejandro Piñeiro wrote: > On 04/09/18 17:24, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Without this, validate_current_gl_context never returns true if >> spirv_replaces_glsl == true, resulting in repeatedly calling >> recreate_

Re: [Piglit] [PATCH] shader_runner: Take spirv_replaces_glsl into account for current_config

2018-09-07 Thread Michel Dänzer
On 2018-09-05 6:56 p.m., Alejandro Piñeiro wrote: > On 05/09/18 18:44, Michel Dänzer wrote: >> On 2018-09-05 6:29 p.m., Alejandro Piñeiro wrote: >>> On 04/09/18 17:24, Michel Dänzer wrote: >>>> From: Michel Dänzer >>>> >>>> Without t

Re: [Piglit] [Patch v2 09/13] quick.tests: Make quick.tests import all.tests

2014-01-13 Thread Michel Dänzer
a piglit run last week, but I only noticed today that the killed tests are recorded as 'pass'. -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer __

Re: [Piglit] Fix bad behavior in GleanTest

2014-01-14 Thread Michel Dänzer
the > solution fixes it. > > Patch 2 fixes the problem, using getters and setters to apply the > globalParams dynamically rather than statically > > Patch 3 reverts the workaround, since the problem is now fixed, and the > workaround is not pep8 compliant Th

[Piglit] [REGRESSION] runtime of gpu.py doubled by commit 26326d4032631cdb4eb6816aada6c81db6f186d7

2014-04-08 Thread Michel Dänzer
26326d4032631cdb4eb6816aada6c81db6f186d7 Author: Dylan Baker Date: Wed Feb 5 15:44:37 2014 -0800 framework/shader_test.py: simplify ShaderTest This is on an A10-7850K (quad core Kaveri) APU FWIW. -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast

Re: [Piglit] [REGRESSION] runtime of gpu.py doubled by commit 26326d4032631cdb4eb6816aada6c81db6f186d7

2014-04-14 Thread Michel Dänzer
On 12.04.2014 04:35, Dylan Baker wrote: On Tuesday, April 08, 2014 18:42:47 Michel Dänzer wrote: > I was away for the last two weeks, and when I came back I noticed that > gpu.py is now taking around 20 minutes to complete, whereas it only took > around 10 minutes before. I wa

Re: [Piglit] [PATCH 03/15] arb_occlusion_query: use default window size

2014-05-14 Thread Michel Dänzer
nough to contain everything rendered by the test. The spec/NV_conditional_render/clear test was also broken for me by the corresponding change, but there it's not obvious to me whether it's a test or driver bug. How are you testing changes like these? -- Earthling Michel Dänzer

Re: [Piglit] [PATCH] arb_occlusion_query: restore window size specification

2014-05-15 Thread Michel Dänzer
,9 @@ > PIGLIT_GL_TEST_CONFIG_BEGIN > > config.supports_gl_compat_version = 10; > + > + config.window_width = 180; > + config.window_height = 100; > config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE | > PIGLIT_GL_VISUAL_DEPTH; > > PIGLIT_GL_TEST_CONFIG

Re: [Piglit] [PATCH 03/15] arb_occlusion_query: use default window size

2014-05-15 Thread Michel Dänzer
On 15.05.2014 21:44, Brian Paul wrote: > On 05/14/2014 09:53 PM, Michel Dänzer wrote: >> On 14.05.2014 10:06, Brian Paul wrote: >>> >>> diff --git a/tests/spec/arb_occlusion_query/occlusion_query.c >>> b/tests/spec/arb_occlusion_query/occlusion_query.c >>

[Piglit] [PATCH] Using waffle, only prevent X11 windows from taking focus in automatic mode.

2013-02-06 Thread Michel Dänzer
From: Michel Dänzer Otherwise this prevents any interaction with the windows in non-automatic mode, not even the Escape key or the window decoration close button works. That's quite annoying for investigating test failures. Signed-off-by: Michel Dänzer --- tests/util/piglit-framewo

Re: [Piglit] [PATCH] Using waffle, only prevent X11 windows from taking focus in automatic mode.

2013-02-06 Thread Michel Dänzer
On Mit, 2013-02-06 at 07:44 -0700, Brian Paul wrote: > On 02/06/2013 02:38 AM, Michel Dänzer wrote: > > From: Michel Dänzer > > > > Otherwise this prevents any interaction with the windows in non-automatic > > mode, not even the Escape key or the window decoration clo

Re: [Piglit] [PATCH 1/6] shader_runner and glslparsertest: choose GL version more accurately.

2013-02-18 Thread Michel Dänzer
ts to skip more than 2000 tests on radeonsi (GL 2.1, GLSL 1.2). Almost all of the skipped tests were previously passing. Was this intended? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

Re: [Piglit] [PATCH 1/6] shader_runner and glslparsertest: choose GL version more accurately.

2013-02-19 Thread Michel Dänzer
On Mon, 2013-02-18 at 10:14 -0800, Paul Berry wrote: > On 18 February 2013 07:53, Michel Dänzer wrote: > On Don, 2013-02-14 at 08:50 -0800, Paul Berry wrote: > > Previously, both shader_runner and glslparsertest contained > switch > > stateme

Re: [Piglit] [PATCH 1/6] shader_runner and glslparsertest: choose GL version more accurately.

2013-02-19 Thread Michel Dänzer
On Die, 2013-02-19 at 12:52 +0100, Michel Dänzer wrote: > On Mon, 2013-02-18 at 10:14 -0800, Paul Berry wrote: > > On 18 February 2013 07:53, Michel Dänzer wrote: > > On Don, 2013-02-14 at 08:50 -0800, Paul Berry wrote: > > > Previously, both shader_r

Re: [Piglit] [PATCH 0/3] Fix shader_runner tests for drivers that lack GLX_ARB_create_context

2013-02-21 Thread Michel Dänzer
eanup. > Finally, patch 3 implements Paul's suggested fix in the above thread. > > Michel, could you please verify that this fix works? I don't have a driver on > hand that lacks GLX_ARB_create_context. Yes, this fixes the regression for me and thus gets Tested-by: Michel Dänzer