On 2018-09-05 6:56 p.m., Alejandro Piñeiro wrote:
> On 05/09/18 18:44, Michel Dänzer wrote:
>> On 2018-09-05 6:29 p.m., Alejandro Piñeiro wrote:
>>> On 04/09/18 17:24, Michel Dänzer wrote:
>>>> From: Michel Dänzer
>>>>
>>>> Withou
On 2018-09-05 6:29 p.m., Alejandro Piñeiro wrote:
> On 04/09/18 17:24, Michel Dänzer wrote:
>> From: Michel Dänzer
>>
>> Without this, validate_current_gl_context never returns true if
>> spirv_replaces_glsl == true, resulting in repeatedly calling
>> recre
From: Michel Dänzer
Without this, validate_current_gl_context never returns true if
spirv_replaces_glsl == true, resulting in repeatedly calling
recreate_gl_context indefinitely after the first subtest.
Fixes: 0baf4e2708c "shader_runner/spirv: support loading SPIR-V shaders"
On 2018-07-18 08:53 PM, Dylan Baker wrote:
> This is required to make the shader_runner multiple tests in one process
> mode work, as it cannot mix gles and gl shaders together.
Both patches are
Tested-by: Michel Dänzer
Thanks!
--
Earthling Michel Dänzer |
tests/shader.py", line 79,
in
profile.test_list[group] = MultiShaderTest.new(files, installedfiles)
File
"/home/daenzer/src/piglit-git/piglit/tests/../framework/test/shader_test.py",
line 253, in new
'GLES and GL shaders in the same command!\n'
framework.exceptions.PiglitInternalError: An internal err
On 2018-06-07 01:02 PM, Emil Velikov wrote:
> On 7 June 2018 at 10:58, Michel Dänzer wrote:
>> On 2017-04-14 09:06 AM, Michel Dänzer wrote:
>>> From: Michel Dänzer
>>>
>>> Patch 1 fixes an error message typo I noticed along the way.
>>>
>>&g
On 2017-04-14 09:06 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Patch 1 fixes an error message typo I noticed along the way.
>
> Patches 2 & 3 allow the glx-oml-sync-control-timing tests to
> consistently pass for me, at least if the system isn't otherwise
> l
From: Michel Dänzer
A child process which doesn't call exec() shouldn't use exit(), as that
will attempt to run any atexit handlers of the parent, which may break.
It actually results in crashing with the Mesa radeonsi driver.
Signed-off-by: Michel Dänzer
---
.../spec/glx_ext_import_context
the set of tests run by the gpu profile is
almost identical to what it was before
9461d92301e72807eba4776a16a05207e3a16477. I assume the remaining minor
differences are expected due to unrelated other changes in the meantime.
Overall, this series looks great from my end, thanks Dylan!
Tested-by: Miche
On 2018-05-09 07:38 PM, Dylan Baker wrote:
> Quoting Michel Dänzer (2018-05-09 02:33:13)
>> On 2018-05-08 11:27 PM, Dylan Baker wrote:
>>
>> The bigger remaining issue is that --process-isolation false gpu takes
>> almost twice as long as it did before
>> 9461d92
On 2018-05-10 03:08 AM, Matt Turner wrote:
> On Tue, May 8, 2018 at 7:07 AM, Michel Dänzer <mic...@daenzer.net> wrote:
>> On 2018-05-07 06:49 PM, Michel Dänzer wrote:
>>> On 2018-05-07 06:44 PM, Dylan Baker wrote:
>>>> Quoting Tomi Sarvela (2018-05-07 01:20:46
On 2018-05-08 07:19 PM, Dylan Baker wrote:
> Quoting Michel Dänzer (2018-05-08 07:07:34)
>>
>> I just bisected another problem to
>> 9461d92301e72807eba4776a16a05207e3a16477: The xts-render profile doesn't
>> work anymore. Most of the time, it doesn't even start:
>
sly
accurately listed as "crash" in the summary, now it's "notrun".
Tested-by: Michel Dänzer <michel.daen...@amd.com>
The bigger remaining issue is that --process-isolation false gpu takes
almost twice as long as it did before
9461d92301e72807eba4776a16a05207e3a16477.
File "/home/user/piglit/framework/programs/run.py", line 370, in run
> backend.finalize({'time_elapsed': time_elapsed.to_json()})
> File "/home/user/piglit/framework/backends/json.py", line 163, in finalize
> assert data['tests']
> AssertionError
>
> Thanks Tom
On 2018-05-07 06:49 PM, Michel Dänzer wrote:
> On 2018-05-07 06:44 PM, Dylan Baker wrote:
>> Quoting Tomi Sarvela (2018-05-07 01:20:46)
>>>
>>> piglit/framework$ diff -c profile.py.orig profile.py
>>> *** profile.py.orig 2018-05-07 19:11:37.649994643 +0300
t; Successful CI runlog:
>>> http://gfx-ci.fi.intel.com/tree/drm-tip/CI_DRM_4148/pig-glk-j5005/run0.log
>>>
>>> Unsuccessful CI runlog:
>>> http://gfx-ci.fi.intel.com/tree/drm-tip/CI_DRM_4149/pig-glk-j5005/run0.log
>>>
>>> Between those two runs, o
gram not supported by mesa (anymore)
> makeCurrent glX api n/a to piglit
What does "glX api n/a to piglit" mean exactly? What about the tests in
tests/glx/?
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast |
chel.
>
> Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com>
Reviewed-by: Michel Dänzer <michel.daen...@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_
On 06/09/17 05:13 PM, Mario Kleiner wrote:
> On 09/06/2017 09:30 AM, Michel Dänzer wrote:
>> On 05/09/17 02:52 PM, Mario Kleiner wrote:
>>> XCreatePixmap doesn't like that. Fixes piglit regression if the
>>> GL implementation exposes RGB10 depth 30 FBConfigs, but the X-S
6, scanline_pad 32
depth 24, bits_per_pixel 32, scanline_pad 32
depth 32, bits_per_pixel 32, scanline_pad 32
It sounds like this doesn't list depth 30 for you, which indicates an
issue with the Xorg (driver) changes for depth 30 support.
--
Earthling Michel Dänzer |
nd(self, new):
> self._command = [n for n in new if not n in self.GLOBAL_PARAMS]
>
> def interpret_result(self):
> if self.result.returncode != 0 or 'FAIL' in self.result.out:
> self.result.result = 'fail'
> else:
> self.re
r <dylanx.c.ba...@intel.com>
This change caused the gpu profile to no longer pass --quick to glean tests.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_
From: Michel Dänzer <michel.daen...@amd.com>
Preparation for the following fix, no functional change intended.
Signed-off-by: Michel Dänzer <michel.daen...@amd.com>
---
tests/spec/glx_oml_sync_control/timing.c | 83
1 file changed, 51 insertions(+),
From: Michel Dänzer <michel.daen...@amd.com>
Patch 1 fixes an error message typo I noticed along the way.
Patches 2 & 3 allow the glx-oml-sync-control-timing tests to
consistently pass for me, at least if the system isn't otherwise
loaded. Before, they would randomly generate war
From: Michel Dänzer <michel.daen...@amd.com>
Without this, the first iteration of the loop can start at any point of
the display refresh cycle. If it's close to the next vertical blank
period, it may be too late for the swap / wait to hit the target MSC,
which would result in at least a w
From: Michel Dänzer <michel.daen...@amd.com>
It said "glXWaitForSbcOML failed", which could be confusing.
Signed-off-by: Michel Dänzer <michel.daen...@amd.com>
---
tests/spec/glx_oml_sync_control/timing.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
Hi Dylan,
the subset of these tests varies wildly between my daily gpu.py runs,
which makes the changes/enabled/disabled.html summary pages pretty
awkward to look at. Is there anything that can be done to improve this?
--
Earthling Michel Dänzer | http
LES and GL shaders in the same command!\n'
> + 'Cannot pick a shader_runner binary!')
> else:
> prog = parser.prog
>
>
Tested-by: Michel Dänzer <michel.daen...@amd.com>
--
Earthling Michel Dänzer | http://www.am
ip/fix-summary
>
> Mark and Michel,
> I'd appreciate if you could test this and make sure it fixes your respective
> problems.
It does, thanks. Patches 1 & 2 are
Tested-by: Michel Dänzer <michel.daen...@amd.com>
--
Earthling Michel Dänzer
nation, exclude)
File "/home/daenzer/src/piglit-git/piglit/framework/summary/html_.py", line
100, in _make_testrun_info
time=each.time_elapsed.delta,
AttributeError: 'dict' object has no attribute 'delta'
--
Earthling Michel Dänzer | http://www.amd.com
Libre
On 24/08/16 06:35 AM, Eric Anholt wrote:
> Michel Dänzer <mic...@daenzer.net> writes:
>> On 20/08/16 04:42 AM, Eric Anholt wrote:
>>> Michel Dänzer <mic...@daenzer.net> writes:
>>>
>>>> From: Michel Dänzer <michel.daen...@amd.com>
>>
ly, the patch breaks piglit here. Reverting the patch fixes the
> problem for me.
What does "breaks piglit" mean? What are the symptoms?
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X develop
On 23/08/16 05:46 PM, Tapani Pälli wrote:
> All 3 patches
>
> Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
Thanks! Can you push them for me?
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast |
On 20/08/16 04:42 AM, Eric Anholt wrote:
> Michel Dänzer <mic...@daenzer.net> writes:
>
>> From: Michel Dänzer <michel.daen...@amd.com>
>>
>> Always use 3 buffers when flipping. With only 2 buffers, we have to wait
>> for a flip to complete (which takes
From: Michel Dänzer <michel.daen...@amd.com>
Calling eglSwapBuffers may invalidate the back buffer contents.
Signed-off-by: Michel Dänzer <michel.daen...@amd.com>
---
tests/egl/egl-nok-texture-from-pixmap.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
From: Michel Dänzer <michel.daen...@amd.com>
Calling eglSwapBuffers may invalidate the back buffer contents, so we
must not do so before probing the back buffer contents. The test exits
immediately even without -auto, so just remove the eglSwapBuffers call.
Signed-off-by: Michel
t also shares this picking mechanism with the Fast Skip
> mechanism, so they always have the same result.
>
> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com>
Tested-by: Michel Dänzer <michel.daen...@amd.com>
--
Earthling Michel Dänzer |
From: Michel Dänzer <michel.daen...@amd.com>
Fixes piglit runs failing with
Fatal Error: In File
.../piglit/tests/spec/oes_geometry_shader/sso_validation/user-defined-gs-input-in-block.shader_test:
No GL ES version set
Fixes: 25ef19627966 ("OES_geometry_shader: Basic SSO IO valid
On 13.05.2016 22:09, Eduardo Lima Mitev wrote:
> Patch looks good, but I was not able to test it fully.
>
> Acked-by: Eduardo Lima Mitev <el...@igalia.com>
Thanks Eduardo.
Unless there are any objections, can somebody push this for me please?
--
Earthlin
From: Michel Dänzer <michel.daen...@amd.com>
Fixes a crash with multiple OpenCL devices available, due to re-using
the stale gl_extensions array from a previous EGL context.
Signed-off-by: Michel Dänzer <michel.daen...@amd.com>
---
tests/cl/interop/egl_khr_cl_event2.c | 1 +
1 fil
expected[0], expected[1], expected[2],
> expected[3]);
> + printf(" Observed: b = 0x%02x g = 0x%02x r = 0x%02x a =
> 0x%02x\n",
> + observed[0], observed[1], observed[2],
> observed[3]);
Some lines
PIXEL_PACK_BUFFER, GL_READ_ONLY_ARB);
>
> - pass &= probe(10, 10, 0xff00, addr[0]);
> - pass &= probe(10, 10, 0x00ff, addr[1]);
> + pass &= probe(10, 10, exp_green, [0]);
> + pass &= probe(10, 10, exp_red, [1]);
And this would b
On 05.12.2015 12:53, Ian Romanick wrote:
> On 12/02/2015 07:03 PM, Michel Dänzer wrote:
>> On 03.12.2015 01:42, Ian Romanick wrote:
>>>
>>> +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます。
>>
>> The nouns are reversed in the Japanese text, so it actual
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
>
> This fixes the failing unit tests from the previous commit.
>
> v2: - don't include skip <-> notrun (Ilia)
>
> cc: Michel Dänzer <mic...@daenzer.net>
> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com>
Tested-by: Michel Dänzer <
I recently noticed that newly added tests are no longer appearing on the
changes.html page. It would be nice to have that back.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 23.07.2015 10:11, Dylan Baker wrote:
This is mostly small fixups for the xz shell path, as well as some
additional unit tests to spot these issues.
Michel, could you give these a whirl and see if they fix your problems?
They do, thanks.
Tested-by: Michel Dänzer michel.daen...@amd.com
working on driver dev incur the
extra cost.
Is the extra cost actually significant?
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
Piglit mailing
On 15.05.2015 19:12, Emil Velikov wrote:
On 15 May 2015 at 03:09, Michel Dänzer mic...@daenzer.net wrote:
From: Michel Dänzer michel.daen...@amd.com
Fixes build failure against current Mesa Git master:
.../sample_common.c.o: In function `sample_and_destroy_img':
.../sample_common.c:107
From: Michel Dänzer michel.daen...@amd.com
Fixes build failure against current Mesa Git master:
.../sample_common.c.o: In function `sample_and_destroy_img':
.../sample_common.c:107: undefined reference to `eglDestroyImageKHR'
.../sample_common.c.o: In function `sample_buffer
your problem?
It does, thanks.
Tested-by: Michel Dänzer michel.daen...@amd.com
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
Piglit mailing list
Hi Dylan,
your commit b799e8c57ec77c4cfbabb165dcd45294d80e9f6c broke the names of
some glean tests in the HTML summary for me. They now have a space
between every character, e.g. a p i 2 instead of api2.
--
Earthling Michel Dänzer | http://www.amd.com
Libre
around this for now with these symlinks:
generated_tests/cl/store/store-kernels-global.inc: symbolic link to
../../../tests/cl/store/store-kernels-global.inc
generated_tests/cl/store/store-kernels-local.inc: symbolic link to
../../../tests/cl/store/store-kernels-local.inc
--
Earthling Michel Dänzer
though.
On Tue, Oct 21, 2014 at 10:04 AM, Laura Ekstrand la...@jlekstrand.net
mailto:la...@jlekstrand.net wrote:
Ok, I just sent a patch to update sanity.py.
Please squash that into patch 1 of this series.
--
Earthling Michel Dänzer| http://www.amd.com
Libre
not be reliable. I'm not sure that the glean basic test needs to be
replaced with anything for that purpose, but it might be nice to keep
sanity.py even just for the test you added in patch 1.
--
Earthling Michel Dänzer| http://www.amd.com
Libre software enthusiast
From: Michel Dänzer michel.daen...@amd.com
Which is the default platform on Linux.
Signed-off-by: Michel Dänzer michel.daen...@amd.com
---
tests/all.py | 178 +--
1 file changed, 89 insertions(+), 89 deletions(-)
diff --git a/tests/all.py
On 15.10.2014 16:19, Dylan Baker wrote:
Reviewed-by: Dylan Baker dylanx.c.ba...@intel.com
Thanks, can you push it for me please?
--
Earthling Michel Dänzer| http://www.amd.com
Libre software enthusiast |Mesa and X developer
From: Michel Dänzer michel.daen...@amd.com
Looks like basically all tests are passed -auto since Dylan's recent
changes, and these tests always behave the same way as other tests do
with -auto anyway.
Signed-off-by: Michel Dänzer michel.daen...@amd.com
---
tests/spec/glx_oml_sync_control
of 'git
describe' will look funny.
--
Earthling Michel Dänzer| http://www.amd.com
Libre software enthusiast |Mesa and X developer
___
Piglit mailing list
Piglit@lists.freedesktop.org
http
as I explained before.
I'll just continue using this patch locally if it isn't applied. I
thought others might be interested in saving a little time for each
piglit run by default, but apparently not.
--
Earthling Michel Dänzer| http://www.amd.com
Libre software
On 21.08.2014 05:42, Jason Ekstrand wrote:
On Aug 19, 2014 8:13 PM, Michel Dänzer mic...@daenzer.net
mailto:mic...@daenzer.net wrote:
From: Michel Dänzer michel.daen...@amd.com
mailto:michel.daen...@amd.com
This reverts commit acb824ddc53c446124d88e37db610a4f8c59d56c.
This decreases
From: Michel Dänzer michel.daen...@amd.com
This reverts commit acb824ddc53c446124d88e37db610a4f8c59d56c.
This decreases the runtime of the gpu.py profile from around 15 minutes to
around 12 minutes on my machine, with no change in results.
If in the future there are tests which really can't run
From: Michel Dänzer michel.daen...@amd.com
The file was recently renamed. Fixes build failure since commit
4ee589ec1c4af7439e1f10a8fd4333c ('gles-3.0: Verify gl_VertexID when used
with glDrawArrays').
Signed-off-by: Michel Dänzer michel.daen...@amd.com
---
I can't push this myself, so whoever
On 11.06.2014 21:03, Brian Paul wrote:
On 06/11/2014 12:09 AM, Michel Dänzer wrote:
From: Michel Dänzer michel.daen...@amd.com
Signed-off-by: Michel Dänzer michel.daen...@amd.com
---
tests/all.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/all.py b/tests/all.py
index
On 05.06.2014 16:48, Dylan Baker wrote:
On Thursday, June 05, 2014 12:50:26 PM Michel Dänzer wrote:
On 25.04.2014 07:51, Marek Olšák wrote:
There are 3 categories of tests:
- concurrent, these are off-screen and can be run anytime
- non-concurrent, because they render to a window (usually
could
work on distinguishing between the second and third case above, and
allowing one second case test to run concurrently with first case tests
again. This would cut down the runtime of gpu.py by several minutes for me.
--
Earthling Michel Dänzer| http://www.amd.com
. Please don't let nay-sayers demotivate you.
We should always try to keep piglit handling old results files as
gracefully as possible.
--
Earthling Michel Dänzer| http://www.amd.com
Libre software enthusiast |Mesa and X developer
that?
Yes, of course. How else would you do regular regression testing with
current Git of everything? It's been working fine for me.
--
Earthling Michel Dänzer| http://www.amd.com
Libre software enthusiast |Mesa and X developer
On 29.05.2014 13:18, Dylan Baker wrote:
On Thursday, May 29, 2014 13:15:54 Michel Dänzer wrote:
On 29.05.2014 13:09, Matt Turner wrote:
On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin imir...@alum.mit.edu
wrote:
Dylan, I'm sure you hate this, but it does seem to work for me. Not
sure
where
On 29.05.2014 13:22, Matt Turner wrote:
On Wed, May 28, 2014 at 9:15 PM, Michel Dänzer mic...@daenzer.net wrote:
On 29.05.2014 13:09, Matt Turner wrote:
On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
Dylan, I'm sure you hate this, but it does seem to work for me
;
+
+ config.window_width = 180;
+ config.window_height = 100;
config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE |
PIGLIT_GL_VISUAL_DEPTH;
PIGLIT_GL_TEST_CONFIG_END
Reviewed-by: Michel Dänzer michel.daen...@amd.com
--
Earthling Michel Dänzer
On 15.05.2014 21:44, Brian Paul wrote:
On 05/14/2014 09:53 PM, Michel Dänzer wrote:
On 14.05.2014 10:06, Brian Paul wrote:
diff --git a/tests/spec/arb_occlusion_query/occlusion_query.c
b/tests/spec/arb_occlusion_query/occlusion_query.c
index e099f06..b8ea664 100644
--- a/tests/spec
.
The spec/NV_conditional_render/clear test was also broken for me by the
corresponding change, but there it's not obvious to me whether it's a
test or driver bug.
How are you testing changes like these?
--
Earthling Michel Dänzer| http://www.amd.com
Libre software
On 12.04.2014 04:35, Dylan Baker wrote:
On Tuesday, April 08, 2014 18:42:47 Michel Dänzer wrote:
I was away for the last two weeks, and when I came back I noticed that
gpu.py is now taking around 20 minutes to complete, whereas it only took
around 10 minutes before. I was able to bisect
26326d4032631cdb4eb6816aada6c81db6f186d7
Author: Dylan Baker baker.dyla...@gmail.com
Date: Wed Feb 5 15:44:37 2014 -0800
framework/shader_test.py: simplify ShaderTest
This is on an A10-7850K (quad core Kaveri) APU FWIW.
--
Earthling Michel Dänzer| http://www.amd.com
Libre software
getters and setters to apply the
globalParams dynamically rather than statically
Patch 3 reverts the workaround, since the problem is now fixed, and the
workaround is not pep8 compliant
The series is
Tested-by: Michel Dänzer michel.daen...@amd.com
--
Earthling Michel Dänzer
that the killed
tests are recorded as 'pass'.
--
Earthling Michel Dänzer| http://www.amd.com
Libre software enthusiast |Mesa and X developer
___
Piglit mailing list
Piglit@lists.freedesktop.org
http
On Die, 2013-02-19 at 12:52 +0100, Michel Dänzer wrote:
On Mon, 2013-02-18 at 10:14 -0800, Paul Berry wrote:
On 18 February 2013 07:53, Michel Dänzer mic...@daenzer.net wrote:
On Don, 2013-02-14 at 08:50 -0800, Paul Berry wrote:
Previously, both shader_runner
2.1, GLSL 1.2). Almost all of the skipped tests were
previously passing.
Was this intended?
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
___
Piglit
From: Michel Dänzer michel.daen...@amd.com
Otherwise this prevents any interaction with the windows in non-automatic
mode, not even the Escape key or the window decoration close button works.
That's quite annoying for investigating test failures.
Signed-off-by: Michel Dänzer michel.daen
On Mit, 2013-02-06 at 07:44 -0700, Brian Paul wrote:
On 02/06/2013 02:38 AM, Michel Dänzer wrote:
From: Michel Dänzermichel.daen...@amd.com
Otherwise this prevents any interaction with the windows in non-automatic
mode, not even the Escape key or the window decoration close button works
82 matches
Mail list logo
