d "gl_SamplePosition"
> + * can be used to read properties of the current sample, which wouldn't
> + * make much sense if the fragment shader were run at a lower frequency
> + * than per-sample.
> + *
> **/
&
LID_ENUM) &&
> pass;
> + pass = piglit_check_gl_error(GL_INVALID_OPERATION)
> && pass;
> }
> /* This is legal. */
> glTextureStorage2D(name, 1, internalformat,
> --
> 2.11.0
>
> ______
gl_error(GL_INVALID_OPERATION);
> --
> 2.12.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
Both patches are:
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
On Mon, Feb 27, 2017 at 12:11 AM, Samuel Iglesias Gonsálvez
wrote:
>
>
> On 24/02/17 20:39, Anuj Phogat wrote:
>> On Tue, Feb 14, 2017 at 2:20 AM, Samuel Iglesias Gonsálvez
>> wrote:
>>> Signed-off-by: Samuel Iglesias Gonsálvez
>>> ---
>>> ..
On Tue, Feb 14, 2017 at 2:20 AM, Samuel Iglesias Gonsálvez
wrote:
> Signed-off-by: Samuel Iglesias Gonsálvez
> ---
> ...t-indirect-non-uniform-control-flow.shader_test | 52 +
> ...t-indirect-non-uniform-control-flow.shader_test | 68
> ++
> 2 files changed,
iglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
}
>
> enum piglit_result
> piglit_display(void)
> {
> -return PIGLIT_FAIL;
> + return PIGLIT_FAIL;
> }
> --
> 2.11.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedes
Signed-off-by: Anuj Phogat
---
tests/all.py | 5 ++
tests/spec/CMakeLists.txt | 1 +
tests/spec/ext_frag_depth/CMakeLists.gles2.txt | 7 ++
tests/spec/ext_frag_depth/CMakeLists.txt | 1 +
tests/spec/ext_frag_depth/fragdepth.c
t; + piglit_get_gl_error_name(err));
> + subtest_pass = false;
> + }
> + }
> +
> + glNamedFramebufferReadBuffer(framebuffer,
> +GL_COLOR_ATTACHMENT0 + max_attachments);
> + subtest_pass = subtest_pass &&
> + piglit_check_gl_error(GL_INVALID_OPERATION);
> + SUBTESTCONDITION(subtest_pass, pass, "An INVALID_OPERATION error is "
> +"generated if a framebuffer object is affected, and "
> +"src is one of the constants from table 17.4 (other "
> +"than NONE, or COLOR_ATTACHMENTm where m is greater "
> +"than or equal to the value of
> MAX_COLOR_ATTACHMENTS)");
> +
> + /* clean up */
> + glDeleteFramebuffers(1, &framebuffer);
> +
> + piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +}
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> + /* UNREACHED */
> + return PIGLIT_FAIL;
> +}
> --
> 2.9.3
>
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
pointed to by bufs.");
> +
> + /*
> +* From OpenGL 4.5 spec:
> +* "An INVALID_ENUM error is generated if any value in bufs is
> +* FRONT, LEFT, RIGHT, or FRONT_AND_BACK . This restriction
> +* applies to both the default framebuff
glit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
How about changing the names of macros to:
PIGLIT_SUBTEST_ERROR and PIGLIT_SUBTEST_CONDITION ?
They go well with piglit's global naming conventions.
I'm fine with the patch otherwise. With the suggested change, patch is:
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
EL_UNPACK_BUFFER, dim * dim * 4,
> pixels, GL_STREAM_DRAW);
> }
> glTexSubImage2D(GL_TEXTURE_2D, i, 0, 0, dim, dim,
> --
> 2.11.0
>
> ___
> Piglit mailing list
> Piglit@lists.
_
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
Patches 2-3 are:
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
On Wed, Jan 11, 2017 at 1:46 PM, Alejandro Piñeiro wrote:
> Equivalent to the already existing gl-3.1/draw-buffers-errors and
> spec/gles-2.0/draw-buffers, but using the 4.5 API. The errors are
> the same that with DrawBuffers so we are testing this method too,
> although indirectly.
>
> Used as r
Signed-off-by: Anuj Phogat
---
tests/all.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/all.py b/tests/all.py
index 63e4250..938013a 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -3030,7 +3030,6 @@ with profile.group_manager(
'sample-alpha-t
On Wed, Nov 2, 2016 at 3:05 PM, Brian Paul wrote:
> On 11/02/2016 03:36 PM, Anuj Phogat wrote:
>>
>> In a situation when there are multiple render targets with alpha to
>> coverage enabled, if fragment shader doesn't write to draw buffer
>> zero, alpha value use
In a situation when there are multiple render targets with alpha to
coverage enabled, if fragment shader doesn't write to draw buffer
zero, alpha value used for coverage will be undefined. Such case
should not cause a GPU hang.
Signed-off-by: Anuj Phogat
---
Not everythi
Signed-off-by: Anuj Phogat
---
.../alpha-to-coverage-dual-src-blend.cpp| 3 ++-
.../alpha-to-coverage-no-draw-buffer-zero.cpp | 3 ++-
.../alpha-to-one-dual-src-blend.cpp | 3 ++-
.../alpha-to-one-msaa-disabled.cpp
In a situation when there are multiple render targets with alpha testing
enabled, if fragment shader doesn't write to draw buffer zero, alpha
value used for alpha testing will be undefined. Such case should not
cause a GPU hang.
Signed-off-by: Anuj Phogat
---
tests/a
On Tue, Oct 25, 2016 at 10:34 PM, Tapani Pälli wrote:
>
>
> On 10/26/2016 03:05 AM, Brian Paul wrote:
>>
>> On 10/25/2016 03:58 PM, Anuj Phogat wrote:
>>>
>>> In a situation when there are multiple render targets with alpha testing
>>> enabled, if f
On Tue, Oct 25, 2016 at 3:58 PM, Anuj Phogat wrote:
> In a situation when there are multiple render targets with alpha testing
> enabled, if fragment shader doesn't write to draw buffer zero, alpha
> value used for alpha testing will be undefined. Such case should not
>
In a situation when there are multiple render targets with alpha testing
enabled, if fragment shader doesn't write to draw buffer zero, alpha
value used for alpha testing will be undefined. Such case should not
cause a GPU hang.
Signed-off-by: Anuj Phogat
---
tests/a
t;
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
For the series:
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
t; + pass = false;
> + }
> +
> + if (piglit_is_extension_supported("GL_EXT_texture_integer")) {
> + /* This query is only part of the extension, not core GL */
> + GLboolean intMode = 0;
> + glGetBooleanv(GL_RGBA_INTEGER_MODE_EXT, &intMode);
> + if (!intMode) {
> + printf("GL_RGBA_INTEGER_MODE_EXT incorrectly"
> + " returned false.\n");
> + pass = false;
> + }
> + }
> +
> + pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
> +
> + return pass ? PIGLIT_PASS : PIGLIT_FAIL;
> +}
> +
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> + if (argc > 1 && strcmp(argv[1], "int_second") == 0) {
> + int_output_first = false;
> + }
> +
> + GLuint fbo = create_fbo();
> + GLuint program = create_program();
> +
> + glBindFramebuffer(GL_FRAMEBUFFER, fbo);
> + glUseProgram(program);
> +}
> --
> 1.9.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
On Mon, Oct 3, 2016 at 12:20 PM, Brian Paul wrote:
> On 10/03/2016 12:12 PM, Anuj Phogat wrote:
>>
>> On Thu, Sep 29, 2016 at 8:51 AM, Brian Paul wrote:
>>>
>>> Create an FBO with two color attachments: one integer, the other
>>> unorm/float. Use a fr
On Thu, Sep 29, 2016 at 8:51 AM, Brian Paul wrote:
> Create an FBO with two color attachments: one integer, the other
> unorm/float. Use a fragment shader to write to both buffers and
> probe the results.
>
> Also, test the value of querying GL_RGBA_INTEGER_MODE_EXT. It should
> be true whenever
On Thu, Sep 29, 2016 at 8:51 AM, Brian Paul wrote:
> Create an FBO with two color attachments: one integer, the other
> unorm/float. Use a fragment shader to write to both buffers and
> probe the results.
>
> Also, test the value of querying GL_RGBA_INTEGER_MODE_EXT. It should
> be true whenever
This is required following a change in 8X multisample positions
in i965 driver.
Signed-off-by: Anuj Phogat
---
.../ext_framebuffer_multisample_blit_scaled/blit-scaled.cpp| 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/spec
.c
> @@ -310,7 +310,6 @@ test_miptrees(void* input_type)
> if (!check_error)
> glDeleteTextures(1, &tex_decompressed);
>
> - block_dims++;
> }
> return PIGLIT_PASS;
> }
> --
> 2.7.4
>
Reviewed-by: Anuj Phogat
__
.0, 0.0, 0.0};
> -
> /**
> * The \a filename is relative to the current test's source directory.
> *
> --
> 2.7.4
>
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
On Mon, Aug 1, 2016 at 3:36 PM, Nanley Chery wrote:
> On Mon, Aug 01, 2016 at 03:16:17PM -0700, Anuj Phogat wrote:
> > Cc: Nanley Chery
> > Signed-off-by: Anuj Phogat
> > ---
> > .../khr_compressed_astc-sliced-3d-miptree.c| 39
> +++-
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
.../khr_compressed_astc-sliced-3d-miptree.c| 39 +++---
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git
a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-sliced-3d-miptree.c
b/tests/spec
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
.../khr_compressed_astc-sliced-3d-miptree.c| 37 ++
1 file changed, 17 insertions(+), 20 deletions(-)
diff --git
a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-sliced-3d-miptree.c
b/tests/spec
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
.../oes_compressed_astc-miptree-3d.c | 35 +++---
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git
a/tests/spec/oes_texture_compression_astc/oes_compressed_astc-miptree-3d.c
b/tests/spec
Also update the comment reflecting the texture depth.
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
.../khr_compressed_astc-sliced-3d-miptree.c| 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
a/tests/spec/khr_texture_compression_astc
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
.../oes_compressed_astc-miptree-3d.c | 36 ++
1 file changed, 17 insertions(+), 19 deletions(-)
diff --git
a/tests/spec/oes_texture_compression_astc/oes_compressed_astc-miptree-3d.c
b/tests/spec
Also update the comment reflecting texture depth.
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
.../oes_compressed_astc-miptree-3d.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
a/tests/spec/oes_texture_compression_astc
As srgb full precision bits have already landed in astc_sliced_3d
test, it doesn't hurt to add it to all.py as well.
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
tests/all.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/all.py b/tests/all.py
index fe
On Wed, Jul 27, 2016 at 4:24 PM, Nanley Chery wrote:
> On Fri, Jul 22, 2016 at 02:01:37PM -0700, Anuj Phogat wrote:
> > V2: Loosen up the tolerence for sRGB tests. This will allow testing sRGB
> > formats which have known precision issues in astcenc in void extent
>
On Fri, Jul 22, 2016 at 2:06 PM, Ilia Mirkin wrote:
> On Fri, Jul 22, 2016 at 5:01 PM, Anuj Phogat wrote:
>> V2: Loosen up the tolerence for sRGB tests. This will allow testing sRGB
>> formats which have known precision issues in astcenc in void extent
>> blocks.
V2: Loosen up the tolerence for sRGB tests. This will allow testing sRGB
formats which have known precision issues in astcenc in void extent
blocks. See khronos bug#11294 for details.
Run each subtest separately in all.py
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
Acked-by: Ben
This will allow us to keep track of known precision issue in astcenc
with sRGB void extent blocks (Khronos bug#11294).
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
tests/all.py | 2 +-
.../khr_texture_compression_astc/khr_compressed_astc
This adds the testing of EXT_texture_sRGB_decode with ASTC
compressed textures.
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
tests/all.py | 2 +-
.../khr_compressed_astc-miptree.c | 26 +++---
2 files changed, 24
This will allow testing sRGB formats which have known precision issues
in astcenc in void extent blocks. See khronos bug#11294 for details.
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
.../khr_texture_compression_astc/khr_compressed_astc-miptree.c | 10 ++
1 file changed, 10
Skipping the decoding in non-sRGB cases isn't serving any purpose.
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
.../khr_compressed_astc-miptree.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git
a/tests
Cc: Nanley Chery
Signed-off-by: Anuj Phogat
---
tests/all.py | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/all.py b/tests/all.py
index 96a3e46..dfad955 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -4354,8 +4354,12 @@ with profile.group_manager(
g
This will give way to creating a new directory under compressed and
decompressed directory in an upcoming patch.
Signed-off-by: Anuj Phogat
---
Patch is trimmed to keep the size under limit.
See full patch at: https://github.com/aphogat/piglit.git, branch: review
diff --git
a/tests/spec
On Mon, Jul 18, 2016 at 3:07 PM, Nanley Chery wrote:
> On Thu, Jul 07, 2016 at 04:28:09PM -0700, Anuj Phogat wrote:
>
> Why does it require this extension?
Shaders use "#version 300 es".
>
> - Nanley
>
>> Signed-off-by: Anuj Phogat
>> ---
>> .../kh
OLOR);
> pass = piglit_probe_image_color(x, y, IMAGE_WIDTH, IMAGE_HEIGHT,
> --
> 2.7.3
>
Thanks for fixing the test.
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Signed-off-by: Anuj Phogat
---
.../khr_texture_compression_astc/khr_compressed_astc-basic.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-basic.c
b/tests/spec/khr_texture_compression_astc
, IMAGE_HEIGHT, GL_COLOR);
> pass = piglit_probe_image_color(x, y, IMAGE_WIDTH, IMAGE_HEIGHT,
> GL_RGBA, expected) && pass;
> + free(expected);
> return pass;
> }
>
> --
> 2.7.4
>
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
: Anuj Phogat
---
I deleted the texture files from the patch to keep the patch size under
limit. The full patch is available at:
https://github.com/aphogat/piglit.git, branch: review
tests/all.py | 6 +
tests/spec/CMakeLists.txt | 1
Cc: Ben Widawsky
Signed-off-by: Anuj Phogat
---
I deleted the texture files from the patch to keep the patch size under limit.
The full patch is available at:
https://github.com/aphogat/piglit.git, branch: review
tests/all.py | 2
This will give way to creating a new directory under compressed and
decompressed directory in an upcoming patch.
Signed-off-by: Anuj Phogat
---
I deleted the texture files from the patch to keep the patch size under limit.
The full patch is available at:
https://github.com/aphogat/piglit.git
g any purpose.
Signed-off-by: Anuj Phogat
---
.../spec/khr_texture_compression_astc/khr_compressed_astc-miptree.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree.c
b/tests/spec/khr_texture_compression
Signed-off-by: Anuj Phogat
---
.../khr_texture_compression_astc/khr_compressed_astc-miptree-array.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree-array.c
b/tests/spec/khr_texture_compression_astc/khr_compressed_astc
Signed-off-by: Anuj Phogat
---
.../khr_compressed_astc-miptree-array.c| 24 ---
.../khr_compressed_astc-miptree.c | 34 +++---
2 files changed, 30 insertions(+), 28 deletions(-)
diff --git
a/tests/spec/khr_texture_compression_astc
- Tests for overlapping and non-overlapping CopyPixels.
Driver might take different rendering paths based on
overlap or no-overlap in CopyPixels.
- Uses RGBW color pattern in place of flat color.
This might catch rendering issues with overlapping
CopyPixels.
Signed-off-by: Anuj Phogat
enum piglit_result subtest;
> - struct texture_format *src_format_list, *dst_format_list;
> - struct texture_format *src_format, *dst_format;
> + const struct texture_format *src_format_list, *dst_format_list;
> + const struct texture_format *src
Other than simplifications there are few changes to make the shader
look like the one in Mesa. This will make it easier to port the
future changes to the test shader from driver shader code.
Signed-off-by: Anuj Phogat
---
.../blit-scaled.cpp| 59
Signed-off-by: Anuj Phogat
---
.../blit-scaled.cpp| 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/tests/spec/ext_framebuffer_multisample_blit_scaled/blit-scaled.cpp
b/tests/spec/ext_framebuffer_multisample_blit_scaled
Signed-off-by: Anuj Phogat
---
tests/util/piglit-util-gl.c | 6 ++
tests/util/piglit-util-gl.h | 5 +
tests/util/piglit_ktx.c | 7 +--
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index d636810..e350d49
2D textures worked fine without defining these filters but
3D textures don't work.
Signed-off-by: Anuj Phogat
---
tests/util/piglit_ktx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/util/piglit_ktx.c b/tests/util/piglit_ktx.c
index b96cb26..d47a2ed 100644
--- a/tests
Signed-off-by: Anuj Phogat
---
tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree.c
b/tests/spec/khr_texture_compression_astc/khr_compressed_astc
For cubemaps and cubemap arrays this should be 6. For non cubemaps
this should be 1.
Signed-off-by: Anuj Phogat
---
tests/util/piglit_ktx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/util/piglit_ktx.c b/tests/util/piglit_ktx.c
index a95300e..b96cb26 100644
--- a
Signed-off-by: Anuj Phogat
---
.../khr_compressed_astc-miptree-array.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git
a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree-array.c
b/tests/spec/khr_texture_compression_astc
On Mon, Feb 29, 2016 at 2:41 PM, Brian Paul wrote:
> On 02/29/2016 12:32 PM, Anuj Phogat wrote:
>>
>> On Thu, Feb 25, 2016 at 6:54 AM, Brian Paul wrote:
>>>
>>> This test puts the pos, size, rotation and color info for four objects
>>> in an array w
}
>
> --
> 1.9.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
Series is: Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
On Thu, Feb 25, 2016 at 6:54 AM, Brian Paul wrote:
> This test puts the pos, size, rotation and color info for four objects
> in an array which is stored in a UBO. For each drawing command, index
> into the array to get the object parameters.
> ---
> tests/all.py
___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
> @@ -147,6 +169,13 @@ load_texture(int formats_idx, int tex_size_idx)
> void
> piglit_init(int argc, char **argv)
> {
> + for (int i = 1; i < argc; ++i) {
> + if (!strcmp(argv[i], "pbo")) {
> +
> piglit_require_extension(
iglit_require_extension("GL_ARB_texture_multisample");
> for (int i = 0; i < config.num_tex_attachments; i++)
> attach_multisample_color_texture(new_config,
> i);
> }
> --
> 2.1.4
>
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
ferent
> - * buffer formats, do blitting operation between them and then query the gl
> - * error.
> + * We initialize two FBOs with minimum supported sample count and
> + * different buffer formats, do blitting operation between them and
> + * verify the expected results.
> *
&
> --
> 1.9.1
>
> _______
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
ll error managed to slip by.
>
> 2.6.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
pass) goto cleanup;
> + if (!pass)
> + goto cleanup;
> +
> warn |= !check_texture(texture[1], dst_level, dst_format, dst_data);
>
> glCopyImageSubData(texture[0], GL_TEXTURE_2D, src_level,
> --
> 1.9.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
de. I don't have Nvidia system
setup anymore. But I'm planning to set it up sometime this week. I'll update
you with the results.
> On 09/21/2015 01:50 PM, Anuj Phogat wrote:
>> On Mon, Sep 21, 2015 at 8:57 AM, Ian Romanick wrote:
>>>
>>> From: Ian Roman
d as the backing
> * store for both the depth and stencil attachment points.
> * Defaults to true.
> --
> 2.1.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Series is: Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
t; +piglit_add_executable(arb_texture_view-texsubimage-layers
> texsubimage-layers.c common.c)
> +piglit_add_executable(arb_texture_view-texsubimage-levels
> texsubimage-levels.c common.c)
> +piglit_add_executable(arb_texture_view-texture-immutable-levels
> texture-immutable-levels.c)
>
>
On Fri, Sep 11, 2015 at 3:50 PM, Brian Paul wrote:
> Instead of printing potentially a thousand error messages when
> there's a failure.
>
> Also, some minor code reformatting.
> ---
> tests/spec/arb_copy_image/formats.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff -
On Wed, Sep 9, 2015 at 11:22 AM, Ian Romanick wrote:
> From: Ian Romanick
>
> The shaders in the test use GLSL 1.30.
>
> Signed-off-by: Ian Romanick
> Cc: Anuj Phogat
> ---
> tests/spec/ext_framebuffer_multisample_blit_scaled/blit-scaled.cpp | 3 +--
> 1 file
ufferTexture2D(GL_FRAMEBUFFER,
> + GL_COLOR_ATTACHMENT0,
> + GL_TEXTURE_2D,
> + tex,
> + 0);
Check for FBO completeness.
> +
> + glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA8, 2, 2);
> +
& pass;
> pass = test_cubemap_faces() && pass;
> + pass = test_zero_size_image() && pass;
>
> piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> }
> --
> 1.9.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
ch clamp lod to a particular mipmap level) */
> --
> 1.9.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
respectively.
See glBindFragDataLocationIndexed() for details.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91151
Signed-off-by: Anuj Phogat
Cc: Eric Anholt
Cc: Mark Janes
---
tests/spec/ext_framebuffer_multisample/draw-buffers-common.cpp | 10 ++
1 file changed, 6 insertions(+), 4
ool
> dual_src_blend)
> strlen(out_type_glsl) + 4;
> char *frag = (char *) malloc(frag_alloc_len);
> sprintf(frag, frag_template, need_glsl130 ? "130" : "120",
> + num_draw_buffers,
> is_dual_src_blending,
> sample_alpha_to_coverage, out_type_glsl);
>
> --
> 2.1.4
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
_shader5/execution/sampler_array_indexing/vs-weird-uniforms.shader_test
> @@ -19,7 +19,7 @@ out vec4 color;
> void main()
> {
> gl_Position = piglit_vertex;
> - color = texture(s[n], vec2(0.5, 0.5));
> + color = texture(s[n], vec2(0.75, 0.25));
> }
>
> [fragment
On Tue, May 12, 2015 at 2:36 PM, Anuj Phogat wrote:
> Testing with PBO currently fails on Mesa i965 driver.
>
> Signed-off-by: Anuj Phogat
> ---
> tests/texturing/getteximage-luminance.c | 66
> ++---
> 1 file changed, 60 insertions(+), 6 deleti
Testing with PBO currently fails on Mesa i965 driver.
V2: Fix a copy-paste error.
Signed-off-by: Anuj Phogat
---
tests/texturing/getteximage-luminance.c | 67 ++---
1 file changed, 61 insertions(+), 6 deletions(-)
diff --git a/tests/texturing/getteximage
Testing with PBO currently fails on Mesa i965 driver.
Signed-off-by: Anuj Phogat
---
tests/texturing/getteximage-luminance.c | 67 ++---
1 file changed, 61 insertions(+), 6 deletions(-)
diff --git a/tests/texturing/getteximage-luminance.c
b/tests/texturing
Testing with PBO currently fails on Mesa i965 driver.
Signed-off-by: Anuj Phogat
---
tests/texturing/getteximage-luminance.c | 66 ++---
1 file changed, 60 insertions(+), 6 deletions(-)
diff --git a/tests/texturing/getteximage-luminance.c
b/tests/texturing
Signed-off-by: Anuj Phogat
---
tests/util/piglit-test-pattern.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/util/piglit-test-pattern.cpp
b/tests/util/piglit-test-pattern.cpp
index 2f51666..12d9918 100644
--- a/tests/util/piglit-test-pattern.cpp
+++ b/tests
_height = 160;
> \
> -
> \
> /* Open a new scope so that tests can declare locals */
> \
> /* between here and PIGLIT_GL_TEST_CONFIG_END. */
> \
>
_framebuffer_no_attachments");
>
OpenGL 3.0 or ARB_framebuffer_object is required.
> + piglit_print_minmax_header();
> +
> + test_min_int(GL_MAX_FRAMEBUFFER_WIDTH, GL_MAX_TEXTURE_SIZE);
> + test_min_int(GL_MAX_FRAMEBUFFER_HEIGHT, GL_MAX_TEXTURE_SIZE);
> + test_min_int(GL_MAX_FRAMEBUFFER_SAMPLES, GL_MAX_SAMPLES);
> +
> + texture_array_subtest();
> +
> + if (!piglit_check_gl_error(GL_NO_ERROR))
> + piglit_report_result(PIGLIT_FAIL);
> +
> + piglit_report_result(piglit_minmax_pass ? PIGLIT_PASS :
> PIGLIT_FAIL);
> +}
> --
> 2.1.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
With above comments fixed:
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Signed-off-by: Anuj Phogat
---
tests/all.py | 8 +--
tests/texturing/getteximage-targets.c | 121 ++
2 files changed, 82 insertions(+), 47 deletions(-)
diff --git a/tests/all.py b/tests/all.py
index 4d47c4c..c1fac8f 100755
--- a/tests
On Fri, Apr 10, 2015 at 1:02 PM, Emil Velikov
wrote:
> Hi Anuj,
>
> On 10 April 2015 at 18:41, Anuj Phogat wrote:
> > Signed-off-by: Anuj Phogat
> > ---
> > tests/texturing/getteximage-targets.c | 43
> ---
> > 1 file ch
) {
> + test = CLEAR;
> + continue;
> + }
> + if (!strcmp(argv[p], "readpixels")) {
> + test = READPIXELS;
> + continue;
> + }
> + if (!strcmp(argv[p], "blit")) {
> + test = BLIT;
> + continue;
> + }
> + for (i = 0; i < sizeof(formats)/sizeof(*formats); i++) {
> + if (!strcmp(argv[p], formats[i].name)) {
> + if (formats[i].extension)
> +
> piglit_require_extension(formats[i].extension);
> + f = formats[i];
> + printf("Testing %s.\n", f.name);
> + break;
> + }
> + }
> + }
> +
> + if (!f.name) {
> + printf("Not enough parameters.\n");
> + piglit_report_result(PIGLIT_SKIP);
> + }
> +
> +fs = piglit_compile_shader_text(GL_FRAGMENT_SHADER, fs_text);
> +vs = piglit_compile_shader_text(GL_VERTEX_SHADER, vs_text);
> +prog = piglit_link_simple_program(vs, fs);
> +
> + glUseProgram(prog);
> + glGenVertexArrays(1, &vao);
> + glBindVertexArray(vao);
> +}
> --
> 2.1.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
With above comments fixed, patch is:
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
bool pass;
> +
> + piglit_require_extension("GL_ARB_texture_stencil8");
> +
> + pass = test_s8();
> +
> + piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +}
> +
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> + /* unused */
> + return PIGLIT_FAIL;
> +}
> --
> 2.1.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Anuj Phogat
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
gt; + "}\n";
> +
> + const char *fs_stencil =
> + "#version 130\n"
> + "in vec2 texcoords;\n"
> + "uniform usampler2D tex;\n"
> + "void main()\n"
> + "{\n"
> +
1 - 100 of 468 matches
Mail list logo
