[
https://issues.apache.org/jira/browse/PIVOT-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751062#action_12751062
]
Greg Brown commented on PIVOT-273:
--
This happens because the menu item has no way to know t
Mousing over a different menu item does not close any open menu popup
-
Key: PIVOT-273
URL: https://issues.apache.org/jira/browse/PIVOT-273
Project: Pivot
Issue Type: Bug
TerraPanoramaSkin: scrollTop and scrollLeft are not used after
Ah, I see - the warning is just saying that the variable is only
used once
(same as above). This is intentional. I often do this to assist in
debugging. You can ignore these.
If you want I could change in a way to keep the variabl
Hi,
>> if (map != null) {
> We'll just drop it. The call to this() has to be the first line in the
> constructor.
Ok, I'll wait your commit ...
> I believe the bounds values were supposed to be used in the call to
> regionUpdated(). Fixed.
Ok, I'll wait your commit ...
> That's odd - it
- HashMap.java:122 Nullcheck of map at line 124 of value previously
dereferenced
public HashMap(Map map) {
this(Math.max((int)((float)map.getCount() /
DEFAULT_LOAD_FACTOR) + 1, DEFAULT_CAPACITY));
if (map != null) {
=> we can move at the start of the method the check for not nu
Ok, bur for the others, what do you think ?
- and finally, some other Comparator that doesn't implement
Serializable: TreeNodeComparator, TableView, and some others (few)
You can ignore this one. We have already verified that these
comparators do not need to be serializable.
Hi, others little things, just seen (this time) with FindBugs:
- HashMap.java:122 Nullcheck of map at line 124 of value previously dereferenced
public HashMap(Map map) {
this(Math.max((int)((float)map.getCount() /
DEFAULT_LOAD_FACTOR) + 1, DEFAULT_CAPACITY));
if (map != null)
[
https://issues.apache.org/jira/browse/PIVOT-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Volkert resolved PIVOT-263.
Resolution: Fixed
> SVN properties missing for lots of files
> -
[
https://issues.apache.org/jira/browse/PIVOT-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Volkert updated PIVOT-263:
---
Issue Type: Task (was: Bug)
> SVN properties missing for lots of files
>
Ok, don't worry, no problem ...
>
> but I've just seen has been dropped by another fix from
>
Todd, sigh ...
Yeah, your check-in reminded me that I didn't need those any more :)
Hi Greg,
me too ... but I've just seen has been dropped by another fix from
Todd, sigh ... but ok, I hope we can remember (and use) this trick
other times ...
Bye
[
https://issues.apache.org/jira/browse/PIVOT-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751007#action_12751007
]
Todd Volkert commented on PIVOT-263:
I just executed the following commands on the v1.3-
[
https://issues.apache.org/jira/browse/PIVOT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandro Martini closed PIVOT-262.
> Add @Override annotations where applicable
> --
>
>
[
https://issues.apache.org/jira/browse/PIVOT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandro Martini resolved PIVOT-262.
--
Resolution: Fixed
Now fixed some missing sources (warnings not seen before).
And fixed also in
[
https://issues.apache.org/jira/browse/PIVOT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandro Martini reopened PIVOT-262:
--
Some sources not included before (in the fix).
> Add @Override annotations where applicable
> -
@SuppressWarnings("unused")
I was not familiar with that one. Cool.
[
https://issues.apache.org/jira/browse/PIVOT-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Volkert updated PIVOT-21:
--
Issue Type: Improvement (was: New Feature)
> TablePane rows and columns should collapse when vacant
> --
ListButton doesn't automatically scroll the selected item to be visible
---
Key: PIVOT-272
URL: https://issues.apache.org/jira/browse/PIVOT-272
Project: Pivot
Issue Type: Bu
Hi Greg,
I haven't modified the logic in the loop to avoid problems ... i can
try to make what you say, but to ensure that all works good, what
tests con i make after: at least do you remember a class to run and
see if all it's good ?
Bye
for (int n = visibleNodes.getLength(), nodeDepth =
youngerSibling.depth;
insertIndex < n &&
visibleNodes.get(insertIndex).depth > nodeDepth;
-insertIndex++);
+insertIndex++) {
+}
}
This c
Voting has expired. The final tally of the vote is:
+1 votes: 3, all binding
0 votes: 0
-1 votes: 0
Thus, the vote passes and will now be put to the Incubator PMC. Note that
Niclas Hedhman abstained due to time constraints, and Chris Brind abstained
because he was on holiday.
Greg Brown:
http:
- there are many warnings on "Local variable hides a field" (in many
sources), and i know the the code works good also with this, but what
do you think on changing a little these variables, to avoid this ?
Using Best practices always help ...
I actually think it's ok to have local variables hid
> > No, the fields are protected, and the class is private, which is what is
> > generating the warning. If the class were protected as well as the
> fields,
> > all would be well :)
> Moving the fields to private solve the warning, without changing the class,
> Ok ?
> Or do you think it's better
Hi Todd,
> Yep. You want me to make the change or you?
I can do it ...
> No, the fields are protected, and the class is private, which is what is
> generating the warning. If the class were protected as well as the fields,
> all would be well :)
Moving the fields to private solve the warning, w
> > In those cases, there are comments right before the loops explaining
> what's
> > going on, and they're just scanning loops (used to position an int
> > variable). Can you suggest a different phrasing so we can see the
> options?
> Very simple ... instead of the ";", use an empty { } ... ok, m
> Thanks! Can you resolve the JIRA ticket?
Ok, fixed.
> In those cases, there are comments right before the loops explaining what's
> going on, and they're just scanning loops (used to position an int
> variable). Can you suggest a different phrasing so we can see the options?
Very simple ... i
[
https://issues.apache.org/jira/browse/PIVOT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandro Martini closed PIVOT-262.
> Add @Override annotations where applicable
> --
>
>
[
https://issues.apache.org/jira/browse/PIVOT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandro Martini resolved PIVOT-262.
--
Resolution: Fixed
> Add @Override annotations where applicable
> ---
[
https://issues.apache.org/jira/browse/PIVOT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750970#action_12750970
]
Sandro Martini commented on PIVOT-262:
--
Add (many) missing @Override , everywhere (but
> i think to have just finished to add missing @Override in pivot
> sources (i hope :-) ).
>
Thanks! Can you resolve the JIRA ticket?
> I've seen some small things:
> - in TerraTreeViewSkin, there are a warning on two empty for, in
> addVisibleNode() and in removeVisibleNodes() ... as seen befo
Hi to all,
i think to have just finished to add missing @Override in pivot
sources (i hope :-) ).
I've seen some small things:
- in TerraTreeViewSkin, there are a warning on two empty for, in
addVisibleNode() and in removeVisibleNodes() ... as seen before for
other warnings on while empty I think
[
https://issues.apache.org/jira/browse/PIVOT-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Volkert resolved PIVOT-271.
Resolution: Fixed
> TablePane padding should not affect grid lines
> ---
34 matches
Mail list logo
