I don't feel particularly strongly about this either way, so that
seems fine to me.
On Oct 5, 2009, at 6:09 PM, Todd Volkert wrote:
What's weird in this case is that width can be -1 or relative, which
isn't
its real width (the same is not true for a component's width). I'd
vote
that we ca
What's weird in this case is that width can be -1 or relative, which isn't
its real width (the same is not true for a component's width). I'd vote
that we call the limits minimumWidth and maximumWidth, but I'm fine with
allowing the width to exist outside the limits, and it's up to the skin to
rec
No, width would still be "width", in the same way that a component has
a preferred size and an actual size.
On Oct 5, 2009, at 5:58 PM, Scott Lanham wrote:
If the width limits were preferred would the width also need to be
called
preferred?
Project wide consistency is not my domain so I am
If the width limits were preferred would the width also need to be called
preferred?
Project wide consistency is not my domain so I am happy to go with whatever
you guys decide :-)
On Tue, 6 Oct 2009 05:42:58 am Greg Brown wrote:
> I think it actually may be OK to skip the bounds checking in th
I think it actually may be OK to skip the bounds checking in this case
as well as in Component:
1) In Component, we're currently validating an explicitly set
preferred dimension against its limits. However, there is no real need
to do this, because getPreferredSize() does it automatically:
* We should probably throw if the column is fixed-width and outside
the
limits (both in setWidth() and in setWidthLimits()). This check
obviously
wouldn't apply to relative and default width columns.
I agree that we should throw in setWidth(), but I'm not sure we can do
that in setWidthLi
Scott,
This looks great! Only a few comments, most of them coding-style nitpicks.
* We should probably throw if the column is fixed-width and outside the
limits (both in setWidth() and in setWidthLimits()). This check obviously
wouldn't apply to relative and default width columns.
* [style nit
Hi Guys,
I have not disappeared, just didn't touch a line of code for two weeks while
on holiday :-)
I couldn't sign up to JIRA as it gave me a big long error message when I tried
to do so. I will keep on trying but if you could take a look at the patch in
the mean time it would be great.
Che
