Re: [Pixman] [PATCH] test: Add a new benchmarker targeting affine operations

2015-04-14 Thread Lennart Sorensen
On Tue, Apr 14, 2015 at 07:20:50PM +0100, Ben Avison wrote: > On Tue, 14 Apr 2015 11:28:51 +0100, Pekka Paalanen > wrote: > >you asked about reading the cache sizes; I have no idea about that. > > > >>+#define PAGE_SIZE (4 * 1024) > > > >Hm, sysconf(3) has PAGESIZE query, but I don't know if it i

Re: [Pixman] [PATCH 5/5] test: Add a new benchmarker targeting affine operations

2015-04-14 Thread Ben Avison
On Tue, 14 Apr 2015 11:28:42 +0100, Pekka Paalanen wrote: So the matrices are indexed as matrix[row][column] in Pixman? That's my understanding, yes. A short'ish comment somewhere to say why you are doing this offsetting would be nice, and that the offsetting is the reason to allocate a marg

Re: [Pixman] [PATCH] test: Add a new benchmarker targeting affine operations

2015-04-14 Thread Ben Avison
On Tue, 14 Apr 2015 11:28:51 +0100, Pekka Paalanen wrote: you asked about reading the cache sizes; I have no idea about that. +#define PAGE_SIZE (4 * 1024) Hm, sysconf(3) has PAGESIZE query, but I don't know if it is appropriate here. I also tend to forget that Windows might be relevant for

Re: [Pixman] [PATCH 0/7] lowlevel-blt-bench test pattern parser

2015-04-14 Thread Ben Avison
On Tue, 14 Apr 2015 09:36:38 +0100, Pekka Paalanen wrote: On Mon, 13 Apr 2015 18:42:45 +0100 "Ben Avison" wrote: On Mon, 13 Apr 2015 12:31:35 +0100, Pekka Paalanen wrote: > None of the existing tests has a solid mask for CA tests. I'm not > sure how much it makes sense. When you're in comp

Re: [Pixman] [PATCH 5/5] test: Add a new benchmarker targeting affine operations

2015-04-14 Thread Pekka Paalanen
On Wed, 08 Apr 2015 02:27:48 +0100 "Ben Avison" wrote: > On Tue, 17 Mar 2015 11:12:53 -, Pekka Paalanen > wrote: > > If there is no transform, why not return the original extents? > > These have been reduced by a half unit in all four directions. > > It's more obviously relevant in the bi

Re: [Pixman] [PATCH] test: Add a new benchmarker targeting affine operations

2015-04-14 Thread Pekka Paalanen
On Wed, 8 Apr 2015 14:20:09 +0100 Ben Avison wrote: > --- > .gitignore|1 + > test/Makefile.sources |1 + > test/affine-bench.c | 394 > + > 3 files changed, 396 insertions(+), 0 deletions(-) > create mode 100644 test/affi

Re: [Pixman] [PATCH 0/7] lowlevel-blt-bench test pattern parser

2015-04-14 Thread Pekka Paalanen
On Mon, 13 Apr 2015 18:42:45 +0100 "Ben Avison" wrote: > On Mon, 13 Apr 2015 12:31:35 +0100, Pekka Paalanen > wrote: > > Apart from restructuring, there is one significant(?) difference to > > Ben's patches: for a solid mask, Ben used a8r8g8b8, but my code uses a8. > > I had to remind myself h