Re: [pkg-discuss] Code review request: issue 2542

2008-08-15 Thread Shawn Walker
Tom Mueller wrote: > Others also made comments about why it was win rather than windows. See > the comments in the issue. > I rewrote this change to use "windows" instead of all the win* > variants. The detail is not needed in the OS name because that > information is available from the releas

Re: [pkg-discuss] Code review request: issue 2542

2008-08-15 Thread Tom Mueller
Others also made comments about why it was win rather than windows. See the comments in the issue. I rewrote this change to use "windows" instead of all the win* variants. The detail is not needed in the OS name because that information is available from the release information that is put i

Re: [pkg-discuss] Code review request: issue 2542

2008-08-14 Thread Danek Duvall
On Thu, Aug 14, 2008 at 03:41:49PM -0500, Tom Mueller (pkg-discuss) wrote: > Webrev: http://cr.opensolaris.org/~tmueller/cr-2542/ Not that this matters for my platform of choice, but it seems like we're calling platform.system().lower() and platform.release().lower() a heck of a lot, rather than

Re: [pkg-discuss] Code review request: issue 2542

2008-08-14 Thread Stephen Hahn
* Tom Mueller (pkg-discuss) <[EMAIL PROTECTED]> [2008-08-14 20:42]: > Issue: 2542 Make User-agent value deal with newer Windows versions > http://defect.opensolaris.org/bz/show_bug.cgi?id=2542 > > Webrev: http://cr.opensolaris.org/~tmueller/cr-2542/ > > The fix here is to explicitly detect Window

Re: [pkg-discuss] Code review request: issue 2542

2008-08-14 Thread Shawn Walker
Tom Mueller (pkg-discuss) wrote: > Issue: 2542 Make User-agent value deal with newer Windows versions > http://defect.opensolaris.org/bz/show_bug.cgi?id=2542 > > Webrev: http://cr.opensolaris.org/~tmueller/cr-2542/ > > The fix here is to explicitly detect Windows Server 2008, and for other > Win

[pkg-discuss] Code review request: issue 2542

2008-08-14 Thread Tom Mueller (pkg-discuss)
Issue: 2542 Make User-agent value deal with newer Windows versions http://defect.opensolaris.org/bz/show_bug.cgi?id=2542 Webrev: http://cr.opensolaris.org/~tmueller/cr-2542/ The fix here is to explicitly detect Windows Server 2008, and for other Windows platforms that we don't yet know about jus