Re: [pkg-discuss] code review: deployment fixes

2009-02-02 Thread Dan Price
On Mon 02 Feb 2009 at 09:28AM, Danek Duvall wrote: > On Mon, Feb 02, 2009 at 03:42:17AM -0800, Dan Price wrote: > > > http://cr.opensolaris.org/~dp/deploy-fixes > > setup.py: > > - line 392: will the use of -R/usr/sfw/lib put this in the openssl > modules even on systems where it's no

Re: [pkg-discuss] code review: deployment fixes

2009-02-02 Thread David . Comay
> Why is the ksh93 syntax a problem? Because not all platforms that might deploy IPS include ksh93 (such as Solaris 10). ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Re: [pkg-discuss] code review: deployment fixes

2009-02-02 Thread Shawn Walker
I. Szczesniak wrote: > Why is the ksh93 syntax a problem? Because we still run the depot server on Solaris 10 systems where /bin/sh is not ksh93. -- Shawn Walker ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mail

Re: [pkg-discuss] code review: deployment fixes

2009-02-02 Thread I. Szczesniak
Why is the ksh93 syntax a problem? Irek On 2/2/09, Dan Price wrote: > > Hi all, > > Please review the following fixes: > > 3813 pkg build needs to fail when sub-builds fail > 6293 ksh93-isms in depot start method > 6294 mako, pyopenssl, cherrypy package makefiles try to be too clever > 629

Re: [pkg-discuss] code review: deployment fixes

2009-02-02 Thread Shawn Walker
Dan Price wrote: > Hi all, > > Please review the following fixes: > > 3813 pkg build needs to fail when sub-builds fail > 6293 ksh93-isms in depot start method > 6294 mako, pyopenssl, cherrypy package makefiles try to be too clever > 6295 pkg(5) doesn't build on /usr/sfw openssl nevada systems >

Re: [pkg-discuss] code review: deployment fixes

2009-02-02 Thread Brock Pytlik
This LGTM Brock Dan Price wrote: > Hi all, > > Please review the following fixes: > > 3813 pkg build needs to fail when sub-builds fail > 6293 ksh93-isms in depot start method > 6294 mako, pyopenssl, cherrypy package makefiles try to be too clever > 6295 pkg(5) doesn't build on /usr/sfw openssl n

Re: [pkg-discuss] code review: deployment fixes

2009-02-02 Thread Danek Duvall
On Mon, Feb 02, 2009 at 09:28:31AM -0800, Danek Duvall wrote: > On Mon, Feb 02, 2009 at 03:42:17AM -0800, Dan Price wrote: > > > http://cr.opensolaris.org/~dp/deploy-fixes > > setup.py: > > - line 490: this seems a bit sketchy. Why is it okay to do this here? > Does the call to byte

Re: [pkg-discuss] code review: deployment fixes

2009-02-02 Thread Danek Duvall
On Mon, Feb 02, 2009 at 03:42:17AM -0800, Dan Price wrote: > http://cr.opensolaris.org/~dp/deploy-fixes setup.py: - line 392: will the use of -R/usr/sfw/lib put this in the openssl modules even on systems where it's not required? Or are you simply depending on the fact that we're

[pkg-discuss] code review: deployment fixes

2009-02-02 Thread Dan Price
Hi all, Please review the following fixes: 3813 pkg build needs to fail when sub-builds fail 6293 ksh93-isms in depot start method 6294 mako, pyopenssl, cherrypy package makefiles try to be too clever 6295 pkg(5) doesn't build on /usr/sfw openssl nevada systems 6304 Add syntax check earlier in t