Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1948 --- hmm, I can't really comment on the nontrivial parts of the code... I

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
On 2009-08-10 06:41:57, Chani wrote: /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, line 43 http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line43 42 + 13? This is taken from Imageshack backend, strange notation indeed. ;-) On

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Patrick Aljord
This is kind of unrelated but wouldn't it be a good thing to turn the upload backends into a plasma data engine? I can see other plasmoids making use of uploading pics and even kde apps like ksnapshot but I have no idea whether kde apps can make use of plasma engines. -Pat

Review Request: activities support in opendesktop widget

2009-08-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1253/ --- Review request for Plasma. Summary --- no, not plasma activities :p this

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Artur Souza (MoRpHeUz)
On Monday 10 August 2009, 03:41 Chani wrote: /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting. cpp http://reviewboard.kde.org/r/1251/#comment1305 42 + 13? If I'm not wrong, this was taken from flickr upload plugin on kipi_plugins.

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1950 ---

Re: Adding a runner to KDE

2009-08-10 Thread Jan Gerrit Marker
Hello, I committed my source code to playground. Could you have a look at it? (I added me to Copyright, is it OK?) Jan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New systray spec

2009-08-10 Thread Marco Martin
On Sunday 09 August 2009, Riccardo Iaconelli wrote: On Sunday 09 August 2009 16:01:05 Marco Martin wrote: so if someone feels like giving it a read to point out most obviously missing/wrong stuff is welcome :D just some brain.dump() of stuff that may be missing in the popup text: - basic

Re: Review Request: activities support in opendesktop widget

2009-08-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1253/#review1953 --- Ship it! Code looks clean and correct, nice work :) I really,

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Chani
On August 10, 2009 00:13:41 Patrick Aljord wrote: This is kind of unrelated but wouldn't it be a good thing to turn the upload backends into a plasma data engine? I can see other plasmoids making use of uploading pics and even kde apps like ksnapshot but I have no idea whether kde apps can

Re: Review Request: activities support in opendesktop widget

2009-08-10 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1253/#review1957 --- /trunk/KDE/kdeplasma-addons/applets/opendesktop/activitywidget.cpp

Re: Review Request: activities support in opendesktop widget

2009-08-10 Thread Marco Martin
On 2009-08-10 15:43:54, Chani wrote: /trunk/KDE/kdeplasma-addons/applets/opendesktop/activitywidget.cpp, line 51 http://reviewboard.kde.org/r/1253/diff/1/?file=9826#file9826line51 just a little detail... using [] will create the key if it doesn't exist, so generally using

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
On 2009-08-10 12:00:23, Artur de Souza (MoRpHeUz) wrote: /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, line 54 http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line54 maybe you get the error post icon even after a successful post

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-10 16:41:16.451067) Review request for Plasma. Changes

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1964 ---

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-10 16:56:55.220998) Review request for Plasma. Changes

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
On 2009-08-10 16:51:06, Artur de Souza (MoRpHeUz) wrote: /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, line 57 http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line57 Minor but important: not sure if kdeplasma-addons have coding style

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Artur Souza (MoRpHeUz)
On Monday 10 August 2009, 14:00 Michal Dutkiewicz wrote: By the way, I could try to rewrite this applet from scratch and add for example support for error messages (SIH returns different error messages for example), that could be passed as signal parameter. Actually rewriting it to support

[tutorial][python] problems with self.engine.connectSource

2009-08-10 Thread Maik Beckmann
Hello, The code in this tutorial - http://techbase.kde.org/Development/Tutorials/Plasma/PythonPlasmoid after getting it to work by changing charge = data[QString(Charge Percent)].toInt()[0] to charge = data[QString(Charge Percent)] gives {{{ Connecting to battery

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Chani
On August 10, 2009 08:28:47 Chani wrote: On August 10, 2009 00:13:41 Patrick Aljord wrote: This is kind of unrelated but wouldn't it be a good thing to turn the upload backends into a plasma data engine? I can see other plasmoids making use of uploading pics and even kde apps like ksnapshot