Re: Review Request: Frame applet should give valid message when dropped folder doesn't have any images

2010-09-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/#review7637 --- Ship it! One small issue with i18n context left, otherwise it's

Re: Review Request: Frame applet should give valid message when dropped folder doesn't have any images

2010-09-16 Thread Anne-Marie Mahfouf
On 2010-09-16 11:20:34, Sebastian Kügler wrote: trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp, line 88 http://svn.reviewboard.kde.org/r/5362/diff/4/?file=36015#file36015line88 i18n context should be more useful. I agree with Sebas, ship it and thanks for looking in this

Re: Review Request: new kwin effect: roundedcorners - make corners of the desktop rounded

2010-09-16 Thread Christoph Fritz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5225/ --- (Updated 2010-09-16 12:35:26.606956) Review request for kwin, Plasma and

QML and Plasma - progress()

2010-09-16 Thread Marco Martin
Hi all, the status of an AppletScript for writing plasmoids in pure QML is progressing rather well, i thought to write a detailed status report/documentation before significative design problems go too far in the implementation, be patient, is really long, but it can be used as a basis for a

R: QML and Plasma - progress()

2010-09-16 Thread LucaTringali
Extremely interesting... this will open new possibilities. Will these functionalities implemented into PlasMate, to give developers a simple way to write QML plasma widgets? Luca Tringali Messaggio originale Da: notm...@gmail.com Data: 16/09/2010 15.11 A: Plasmaplasma-devel@kde.org Ogg:

Re: QML and Plasma - progress()

2010-09-16 Thread Artur Duque de Souza
On Thursday 16 September 2010 15:11:42 Marco Martin wrote: * Plasma widgets are binded in the QML language, with the Plasma.* prefix * QGraphicsLayouts are binded in plasma bindings themselves, it is not going to be in Qt sadly (but QGraphicsWidget subclasses are starting to work pretty well

Re: QML and Plasma - progress()

2010-09-16 Thread Marco Martin
On Thursday 16 September 2010, Aaron J. Seigo wrote: On Thursday, September 16, 2010, Marco Martin wrote: * Plasma::QMLWidget - i a qgraphicswidget that loads a qml file in it, and keeps the context/engine/etc, it shortens an otherwise long and repetitive task of loding qml files with

Re: QML and Plasma - progress()

2010-09-16 Thread Aaron J. Seigo
On Thursday, September 16, 2010, Marco Martin wrote: as i said, i don't think would really simplify the learning curve, because one would have to manage two types of javascript, with a difference between them that is quite an implementation detail (being on two engines) is it possible to

Re: QML and Plasma - progress()

2010-09-16 Thread Marco Martin
On Thursday 16 September 2010, Aaron J. Seigo wrote: On Thursday, September 16, 2010, Marco Martin wrote: as i said, i don't think would really simplify the learning curve, because one would have to manage two types of javascript, with a difference between them that is quite an

Re: QML and Plasma - progress()

2010-09-16 Thread Aaron J. Seigo
On Thursday, September 16, 2010, Marco Martin wrote: On Thursday 16 September 2010, Aaron J. Seigo wrote: On Thursday, September 16, 2010, Marco Martin wrote: as i said, i don't think would really simplify the learning curve, because one would have to manage two types of javascript, with

Re: QML and Plasma - progress()

2010-09-16 Thread Marco Martin
On Thursday 16 September 2010, Aaron J. Seigo wrote: it is not possible to override plasmoid functions in javascript with things like plasmoid.dataUpdated = function() as far i know, but i could be wrong, i don't thik we really need this tough. it's probably avoidable now that we have

Re: Review Request: Frame applet should give valid message when dropped folder doesn't have any images

2010-09-16 Thread Sujith H
On 2010-09-16 11:20:34, Sebastian Kügler wrote: One small issue with i18n context left, otherwise it's good to go in (from my point of view, better wait for annma to mark it as ship it as well). Thanks. I will do it right away :) On 2010-09-16 11:20:34, Sebastian Kügler wrote:

Re: QML and Plasma - progress()

2010-09-16 Thread Aaron J. Seigo
On Thursday, September 16, 2010, Marco Martin wrote: On Thursday 16 September 2010, Aaron J. Seigo wrote: it is not possible to override plasmoid functions in javascript with things like plasmoid.dataUpdated = function() as far i know, but i could be wrong, i don't thik we really need

Re: Review Request: Cleanups in pager

2010-09-16 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5355/ --- (Updated 2010-09-17 02:29:59.112027) Review request for Plasma. Changes