KDE/kdelibs/plasma

2011-01-16 Thread Aaron J . Seigo
SVN commit 1214926 by aseigo: QString is not thread-safe; since the matches get shuttled around between threads, we need to protect access to it. as writing is rare, this should hopefully not degrade performance too much. if it passes testing, then i will backport this. CCBUG:238556 CCMAIL:plas

Re: Review Request: Mime-type in NepomukSearchRunner

2011-01-16 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6338/#review9639 --- some code style issues, but otherwise looks good. /trunk/KDE/kde

Re: Review Request: ClockApplet : show seconds in the tooltip

2011-01-16 Thread Aaron Seigo
> On Jan. 15, 2011, 8:08 p.m., Aaron Seigo wrote: > > i agree with Marco, that this should end up in the ClockApplet class shared > > by all clocks. > > > > the way this probably will need to be done is to have a QObject with a > > dataUpdated method used for this purpose in ClockApplet that i

Review Request: Mime-type in NepomukSearchRunner

2011-01-16 Thread Amir Pakdel
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6338/ --- Review request for Plasma, Sebastian Trueg and Vishesh Handa. Summary --

Re: Review Request: ClockApplet : show seconds in the tooltip

2011-01-16 Thread Marco Martin
> On Jan. 15, 2011, 8:08 p.m., Aaron Seigo wrote: > > i agree with Marco, that this should end up in the ClockApplet class shared > > by all clocks. > > > > the way this probably will need to be done is to have a QObject with a > > dataUpdated method used for this purpose in ClockApplet that i