Re: Review Request: kickoff breadcrumb cursor

2011-11-16 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103159/ --- (Updated Nov. 16, 2011, 11:28 p.m.) Review request for Plasma. Changes -

Re: Review Request: kickoff breadcrumb cursor

2011-11-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103159/#review8242 --- thanks for the patch :) i think you can do it in a simpler way (

Review Request: kickoff breadcrumb cursor

2011-11-16 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103159/ --- Review request for Plasma. Description --- aseigo told me to do it. S

Krunner using both actions and runoptions

2011-11-16 Thread David Baron
In this case, the right-most (last) action icon overlays the runoptions icon. Since they are not exactly the same positions, one can actually get to both with a little skill. However, this is not the desired placement, obviously. Workaround tried was a dummy action with no visible icon. Not much

Re: "console desktop" crash :)

2011-11-16 Thread Nowardev-Team
:) ty 2011/11/16 Aaron J. Seigo > ** > > On Wednesday, November 16, 2011 17:30:41 Nowardev-Team wrote: > > > i have 4.7.3 right now > > > > ok, so the crash is still expected there. i was able to reproduce it here > as well, but after the fix it doesn't happen anymore. :) > > > > -- > > Aaron J

Re: "console desktop" crash :)

2011-11-16 Thread Aaron J. Seigo
On Wednesday, November 16, 2011 17:30:41 Nowardev-Team wrote: > i have 4.7.3 right now ok, so the crash is still expected there. i was able to reproduce it here as well, but after the fix it doesn't happen anymore. :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47

Re: Review Request: Bug fix for 278765

2011-11-16 Thread Aaron J. Seigo
> On Nov. 16, 2011, 5 p.m., Aaron J. Seigo wrote: > > plasma/desktop/applets/tasks/abstracttaskitem.cpp, lines 172-176 > > > > > > much simpler is: > > > > data.setInstantPopup(KWindowSystem::compositingAct

Re: Review Request: Bug fix for 278765

2011-11-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102304/#review8236 --- plasma/desktop/applets/tasks/abstracttaskitem.cpp

Re: Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

2011-11-16 Thread Aaron J. Seigo
> On Oct. 30, 2011, 8:03 a.m., Aaron J. Seigo wrote: > > why is a CMakeLists.txt needed? plasmapkg is enough, no? > > Sebastian Kügler wrote: > CMakeLists.txt is needed if you want to package the package (for OBS, for > example). > > Aaron J. Seigo wrote: > shouldn't that be part of th

Re: Review Request: Plasmate:images can now be added to projects

2011-11-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102290/#review8234 --- Ship it! to minor issues and this can go in... editors/imagev

Re: "console desktop" crash :)

2011-11-16 Thread Nowardev-Team
i have 4.7.3 right now 2011/11/16 Aaron J. Seigo > ** > > On Wednesday, November 16, 2011 11:23:30 Nowardev-Team wrote: > > > this is the minimum function i have tested , it removes panels and > > > create a new one adding systemtray. > > > if you have already the systemtray on your old panels

Re: "console desktop" crash :)

2011-11-16 Thread Aaron J. Seigo
On Wednesday, November 16, 2011 11:23:30 Nowardev-Team wrote: > this is the minimum function i have tested , it removes panels and > create a new one adding systemtray. > if you have already the systemtray on your old panels you get the > crash if you have not you can't get the crash this should

RssNOW QML

2011-11-16 Thread Giorgos Tsiapaliwkas
Hello, yesterday thanks to notmart i ported the rssnow plasmoid to plasma components. But as far as i am concerned the rss plasmoid is missing of two features. 1.Is the ability to add more rss with drag&drop.I didn't get into that yet. 2.When someone clicks the left/right arrow it was supposed th

Re: Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt

2011-11-16 Thread Marco Martin
On Wednesday 16 November 2011, Giorgos Tsiapaliwkas wrote: > On 16 November 2011 14:45, Sebastian Kügler wrote: > > Ah, we are moving away from this separate subdir, sorry for the > > confusion. > > So if i understood correctly,the plasmoids will be > > $my_plasmoid/contents/ > $my_plasmoid/meta

Re: Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt

2011-11-16 Thread Giorgos Tsiapaliwkas
On 16 November 2011 14:45, Sebastian Kügler wrote: > Ah, we are moving away from this separate subdir, sorry for the confusion. So if i understood correctly,the plasmoids will be $my_plasmoid/contents/ $my_plasmoid/metadata.desktop please verify me. -- Giorgos Tsiapaliwkas (terietor) KDE Deve

knowledgebase is not getting any data from the dataengine

2011-11-16 Thread Giorgos Tsiapaliwkas
Hello, today i was trying to port the knowledgebase to the plasma components. Thanks to notmart i figured that the specific plasmoid is not working in my regular user only. It works in a machine of a friend(who is using the same distro),in notmart's machine,in my machine but in a test use but not

Re: Extenders in libplasma2 (or.. not)

2011-11-16 Thread Hans Chen
>From a user's POV, I second what Ivan wrote. I still think it was a neat idea but there were several reasons why I didn't use extenders: 1. Crash-prone. Plasma would often crash when playing around with them (the Extender section in Plasma HowTo was, hands down, the hardest section to record due

Re: Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt

2011-11-16 Thread Sebastian Kügler
On Wednesday, November 16, 2011 10:00:56 Giorgos Tsiapaliwkas wrote: > > On Nov. 15, 2011, 4:28 p.m., Marco Martin wrote: > > > why a subdirectory more? this is not used anywhere else > > i saw the other plasmoids and all of them have a package subdir,so i > thought to make the microblog like the

Re: Extenders in libplasma2 (or.. not)

2011-11-16 Thread Sebastian Kügler
On Tuesday, November 15, 2011 16:08:17 Marco Martin wrote: > > so ... i'd like to propose that we kill Extender, ExtenderItem and > > ExtenderGroup in libplasma2. > > i say kill it. > > to me extender is the typical "seemed a good idea at the time" My thoughts exactly. :) +1 for killing them.

Re: Review Request: Don't set Icon if iconName is Empty in ActivityBar

2011-11-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103153/#review8228 --- This review has been submitted with commit 95c8c4e68674ca4e8161

Re: "console desktop" crash :)

2011-11-16 Thread Nowardev-Team
this is the minimum function i have tested , it removes panels and create a new one adding systemtray. if you have already the systemtray on your old panels you get the crash if you have not you can't get the crash it seems panels are removed but the systemtray is still alive func

Re: Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt

2011-11-16 Thread Giorgos Tsiapaliwkas
> On Nov. 15, 2011, 4:28 p.m., Marco Martin wrote: > > why a subdirectory more? this is not used anywhere else i saw the other plasmoids and all of them have a package subdir,so i thought to make the microblog like the others.no? - Giorgos ---

Re: Looking for Advisory on ActivityBar Size Policy

2011-11-16 Thread todd rme
On Wed, Nov 16, 2011 at 9:38 AM, Aaron J. Seigo wrote: > On Wednesday, November 16, 2011 09:29:21 todd rme wrote: >> should resize.  But with the bugs with panel sizes right now, maybe it > > which bugs are these? https://bugs.kde.org/show_bug.cgi?id=248186 https://bugs.kde.org/show_bug.cgi?id=19

Re: Looking for Advisory on ActivityBar Size Policy

2011-11-16 Thread Aaron J. Seigo
On Wednesday, November 16, 2011 01:00:33 David Narvaez wrote: > sense, what's the correct QSizePolicy combination between tab > bars,layouts an applets to get it working that way? set a preferredSize on the applet that reflects the preferredSize of the contents and it should behave as requested (

Re: Looking for Advisory on ActivityBar Size Policy

2011-11-16 Thread Aaron J. Seigo
On Wednesday, November 16, 2011 09:29:21 todd rme wrote: > should resize. But with the bugs with panel sizes right now, maybe it which bugs are these? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt

Re: Review Request: Don't set Icon if iconName is Empty in ActivityBar

2011-11-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103153/#review8224 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 16, 2011, 5:51 a.

Re: Looking for Advisory on ActivityBar Size Policy

2011-11-16 Thread todd rme
On Wed, Nov 16, 2011 at 7:00 AM, David Narvaez wrote: > Hi all, > > My first disclaimer is that I'm not a UI developer at all, so I'm > pretty lost here. I'm trying to address bug 225078, trying to fix the > situation described in comment 7. The problem is I'm not clear on what > is the expected b