Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-12 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/ --- Review request for Plasma. Description --- This bug report is quite

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-12 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105987/#review17265 --- As I understand it, the notify system is for attributes, where

Re: plasma components ContextMenu

2012-08-12 Thread Marco Martin
On Saturday 11 August 2012, Gregor Tätzner wrote: On Friday 10 August 2012 19:20:46 Marco Martin wrote: On Friday 10 August 2012, Gregor Tätzner wrote: I need a nice context menu for kickoff qml. Is someone working on this? There is a ContextMenu.qml file in plasmacomponents, but it's

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-12 Thread Marco Martin
On Aug. 12, 2012, 10:41 a.m., Christoph Feck wrote: As I understand it, the notify system is for attributes, where the object changes the value _itself_ (e.g. in response to user interaction), as opposed to where the application changed the value. In that light, an

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105987/#review17267 --- Ship it! yep, thoseshould always have been there, i think it

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105987/#review17273 --- Just 2 minor issues for naming consistency.

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105987/#review17276 --- This review has been submitted with commit

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105987/#review17277 --- This review has been submitted with commit

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-12 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105973/#review17282 --- Thanks for the patch! I'd say that it looks good code-wise