Re: Re: QML style guide

2012-10-29 Thread Martin Gräßlin
On Monday 29 October 2012 22:52:33 Marco Martin wrote: > On Monday 29 October 2012, Martin Gräßlin wrote: > > For JavaScript I would recommend to use coding style which validates on > > JSLint [1] and I would say that we should make it a requirement that our > > JavaScript code is JSLint compliant.

Re: QML style guide

2012-10-29 Thread Sebastian Kügler
On Monday, October 29, 2012 21:42:18 Aaron J. Seigo wrote: > http://community.kde.org/Plasma/QMLStyle I'm probably cool with the outcome, whatever the details are and will start adopting right now. :) Thanks for bringing it up, -- sebas http://www.kde.org | http://vizZzion.org | GPG Ke

Re: QML style guide

2012-10-29 Thread Marco Martin
On Monday 29 October 2012, Aaron J. Seigo wrote: > On Monday, October 29, 2012 21:52:38 Ivan Čukić wrote: > > > property declarations > > > signal declarations > > > JavaScript functions > > > object properties > > > child objects > > > states > > > transitions > > other than object properties f

Re: QML style guide

2012-10-29 Thread Ivan Čukić
> other than object properties following functions, this looks nice. the example > on that wiki page does not have signals, states or transitions which do indeed > all need to be added. I agree. It might be nice to have the sections also with comment headers. Currently, my template has them like

Re: QML style guide

2012-10-29 Thread Marco Martin
On Monday 29 October 2012, Aaron J. Seigo wrote: > i did spend some time considering why this happens ... and here's my guess > (though it is only that): one tends to start with and also change most > frequently the geometry properties (anchors, widths/heights, spacing, > margins) and so those "na

Re: QML style guide

2012-10-29 Thread Marco Martin
On Monday 29 October 2012, Martin Gräßlin wrote: > For JavaScript I would recommend to use coding style which validates on > JSLint [1] and I would say that we should make it a requirement that our > JavaScript code is JSLint compliant. Next step then: make build.kde.org > run JSLint on all our Ja

Re: QML style guide

2012-10-29 Thread Aaron J. Seigo
On Monday, October 29, 2012 21:57:40 Marco Martin wrote: > it seems quite sensible, > only thing i would put declared properties immediately after the id: sounds good; note, however, that pretty much NONE of our QML does this. it's almost always id, anchors/geometry, declared properties. since th

Re: QML style guide

2012-10-29 Thread Aaron J. Seigo
On Monday, October 29, 2012 22:01:06 Martin Gräßlin wrote: > For JavaScript I would recommend to use coding style which validates on > JSLint [1] and I would say that we should make it a requirement that our > JavaScript code is JSLint compliant. Next step then: make build.kde.org run > JSLint on a

Re: QML style guide

2012-10-29 Thread Aaron J. Seigo
On Monday, October 29, 2012 21:52:38 Ivan Čukić wrote: > > property declarations > > signal declarations > > JavaScript functions > > object properties > > child objects > > states > > transitions other than object properties following functions, this looks nice. the example on that wiki page do

Re: QML style guide

2012-10-29 Thread Martin Gräßlin
On Monday 29 October 2012 21:42:18 Aaron J. Seigo wrote: > hi.. > > we have a style guide for our C++ code: the kdelibs style, which was mostly > borrowed from Qt. unfortunately for us there was no QML guide we could > similarly abscond with. > > and it shows. > > summary -> i've started putting

Re: QML style guide

2012-10-29 Thread Marco Martin
On Monday 29 October 2012, Aaron J. Seigo wrote: > hi.. > > we have a style guide for our C++ code: the kdelibs style, which was mostly > borrowed from Qt. unfortunately for us there was no QML guide we could > similarly abscond with. > > and it shows. > > summary -> i've started putting togethe

Re: QML style guide

2012-10-29 Thread Ivan Čukić
+1 I've been using a template found somewhere on the Qt-tubes, which goes like this > property declarations > signal declarations > JavaScript functions > object properties > child objects > states > transitions I'd argue that property and signal declarations should be moved to the top - it is k

QML style guide

2012-10-29 Thread Aaron J. Seigo
hi.. we have a style guide for our C++ code: the kdelibs style, which was mostly borrowed from Qt. unfortunately for us there was no QML guide we could similarly abscond with. and it shows. summary -> i've started putting together a QML style guide draft and would like your input and to bring

Re: Wrong plasmoid size on taskbar

2012-10-29 Thread Marco Martin
On Sunday 28 October 2012, Nicolas Vinot wrote: > Hi everybody, > > I'm writing a new declarative plasmoid, but I have some trouble with size > in taskbar. > When placed on desktop, no problem, it size is correct, but on taskbar, > size is just wider than a button : > http://img15.hostingpics.net/

Wrong plasmoid size on taskbar

2012-10-29 Thread Nicolas Vinot
Hi everybody, I'm writing a new declarative plasmoid, but I have some trouble with size in taskbar. When placed on desktop, no problem, it size is correct, but on taskbar, size is just wider than a button : http://img15.hostingpics.net/pics/130396pomodoro.png Corresponding code is here : https

Re: Microblog port to Akonadi pushed into a branch

2012-10-29 Thread Martin Klapetek
On Sat, Oct 27, 2012 at 7:23 PM, Martin Klapetek wrote: > * sometimes the plasmoid can get really really slow or even freeze when > scrolling very fast as it tries to fetch all the avatars and post images, > this might need some optimizations > Just fixed this^. The model was queuing the same i

Re: QActions in QML

2012-10-29 Thread Marco Martin
On Monday 29 October 2012, Daker Fernandes Pinheiro wrote: > > > Daker Fernandes Pinheiro > > > http://codecereal.blogspot.com > > > > isn't QAction already registered as "action" primitive type? > > At least not on QtQuick 1.1 > not sure if is really qaction or some wrapper class, but http://q

Re: QActions in QML

2012-10-29 Thread Daker Fernandes Pinheiro
2012/10/28 Aleix Pol > On Mon, Oct 29, 2012 at 1:33 AM, Daker Fernandes Pinheiro > wrote: > > Sebas, > > > > This just worked: > > http://paste.kde.org/584660/ > > Where QAction is > > http://paste.kde.org/584672/ > > > > Cheers, > > > > Daker Fernandes Pinheiro > > http://codecereal.blogspot.co

Re: QActions in QML

2012-10-29 Thread Daker Fernandes Pinheiro
2012/10/29 Marco Martin > On Monday 29 October 2012, Daker Fernandes Pinheiro wrote: > > Sebas, > > > > This just worked: > > http://paste.kde.org/584660/ > > Where QAction is > > http://paste.kde.org/584672/ > > > > Cheers, > > > > Daker Fernandes Pinheiro > > http://codecereal.blogspot.com > >

Re: dependency problem with logout from kde-runtime scriptengine

2012-10-29 Thread Aaron J. Seigo
On Sunday, October 28, 2012 23:45:14 Sebastian Kügler wrote: > I'm running into a dependency problem, while working on the toolbox actions. > ToolBoxes are plugins, but as we're moving to a fully QML-based workspace, > we need to be able to do everything from the QML runtime -- including we don't

Re: Microblog port to Akonadi pushed into a branch

2012-10-29 Thread Marco Martin
On Monday 29 October 2012, Martin Klapetek wrote: > On Mon, Oct 29, 2012 at 10:09 AM, Marco Martin wrote: > > On Saturday 27 October 2012, Martin Klapetek wrote: > > > Hey all, > > > > > > I've just pushed my port of Microblog declarative plasmoid in a branch > > > - mklapetek/akonadi_port (kde:d

Re: Microblog port to Akonadi pushed into a branch

2012-10-29 Thread Martin Klapetek
On Mon, Oct 29, 2012 at 10:09 AM, Marco Martin wrote: > On Saturday 27 October 2012, Martin Klapetek wrote: > > Hey all, > > > > I've just pushed my port of Microblog declarative plasmoid in a branch - > > mklapetek/akonadi_port (kde:declarative-plasmoids). Setting this up needs > > sounds great

Re: Microblog port to Akonadi pushed into a branch

2012-10-29 Thread Marco Martin
On Saturday 27 October 2012, Martin Klapetek wrote: > Hey all, > > I've just pushed my port of Microblog declarative plasmoid in a branch - > mklapetek/akonadi_port (kde:declarative-plasmoids). Setting this up needs sounds great :D i've still not checked at it, hope will find time those next day

Re: QActions in QML

2012-10-29 Thread Marco Martin
On Monday 29 October 2012, Daker Fernandes Pinheiro wrote: > Sebas, > > This just worked: > http://paste.kde.org/584660/ > Where QAction is > http://paste.kde.org/584672/ > > Cheers, > > Daker Fernandes Pinheiro > http://codecereal.blogspot.com > isn't QAction already registered as "action" pr