Re: Review Request 108857: Plasmate: Plasmakconfigxteditor is now able to load/edit xml files

2013-02-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108857/#review27270 --- This review has been submitted with commit

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/#review27273 --- Ship it! Ship It! - David Faure On Feb. 12, 2013, 4 a.m.,

Plasma2 API review

2013-02-12 Thread Marco Martin
Hi, all Yesterday there was a discussion with a couple of people about the API of the Applet class, to see what should be changed, what should be removed, how much we can manage to clean it up, and the result is a plan for an indeed massive cleanup:

Re: Review Request 106112: Pager QML port

2013-02-12 Thread Mark Gaiser
On Feb. 9, 2013, 6:49 p.m., Mark Gaiser wrote: Just wanted to add that it has a regression that slipped in the 4.10.0 release. https://bugs.kde.org/show_bug.cgi?id=312684 If you have only one virtual desktop the pager just shows an empty area. That is obviously wrong. It is

Re: Plasma2 API review

2013-02-12 Thread Aaron J. Seigo
On Tuesday, February 12, 2013 10:57:41 Marco Martin wrote: We'll do other meetings like that for other classes (luckily Applet was probably the hardest one) so if someone is interested in torough (and boring :p) API reviews is welcome ;) i thought it was quite enjoyable. perhaps i'm just

[frameworks] QML2_IMPORT_PATH now needed for Plasma imports

2013-02-12 Thread Sebastian Kügler
Hi, I've just pushed a change to plasma-frameworks which introduces a change to the installation path for your QtQuick2 imports, moving it under $PREFIX/lib/qml basically. (They previously went into $PREFIX/qml, which is a bit ugly.) It also means you have to update extra-cmake-modules. This

Re: Review Request 108223: use Plasma::Dialog for kmix osd

2013-02-12 Thread Aaron J. Seigo
On Feb. 10, 2013, 10:04 a.m., Christian Esken wrote: Just got a bug report that is likely realted to this change (started happening on kde 4.10): Bug 314803 - OSD glitches out and freezes https://bugs.kde.org/show_bug.cgi?id=314803 what leads you believe it is related to this change?

Re: Review Request 104281: Drop Decorations B2, Laptop and Plastik

2013-02-12 Thread Aaron J. Seigo
On Feb. 7, 2013, 9:25 p.m., Albert Astals Cid wrote: I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited? Aaron J. Seigo wrote: plastik is gone, but b2 and laptop are still there. Albert Astals Cid wrote:

Re: Review Request 104281: Drop Decorations B2, Laptop and Plastik

2013-02-12 Thread Martin Gräßlin
On Feb. 7, 2013, 10:25 p.m., Albert Astals Cid wrote: I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited? Aaron J. Seigo wrote: plastik is gone, but b2 and laptop are still there. Albert Astals Cid wrote:

Re: Review Request 108223: use Plasma::Dialog for kmix osd

2013-02-12 Thread Kai Uwe Broulik
On Feb. 10, 2013, 10:04 a.m., Christian Esken wrote: Just got a bug report that is likely realted to this change (started happening on kde 4.10): Bug 314803 - OSD glitches out and freezes https://bugs.kde.org/show_bug.cgi?id=314803 Aaron J. Seigo wrote: what leads you believe it

Re: Review Request 106097: Config cleanup on removeActivity

2013-02-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/#review27287 --- This review has been submitted with commit

Re: Review Request 106118: Plasmate: Add KWin Scripting support to konsolepreviewer.

2013-02-12 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- (Updated Feb. 12, 2013, 12:26 p.m.) Review request for kwin, Plasma,

Re: Review Request 108891: Force row settings in Task Manager should use column major sorting

2013-02-12 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108891/#review27288 --- the change was not made in a vacuum. we also received feedback

Re: Review Request 106112: Pager QML port

2013-02-12 Thread Aaron J. Seigo
On Feb. 9, 2013, 6:49 p.m., Mark Gaiser wrote: Just wanted to add that it has a regression that slipped in the 4.10.0 release. https://bugs.kde.org/show_bug.cgi?id=312684 If you have only one virtual desktop the pager just shows an empty area. That is obviously wrong. It is

Re: Review Request 106112: Pager QML port

2013-02-12 Thread Luís Gabriel Lima
On Feb. 9, 2013, 6:49 p.m., Mark Gaiser wrote: Just wanted to add that it has a regression that slipped in the 4.10.0 release. https://bugs.kde.org/show_bug.cgi?id=312684 If you have only one virtual desktop the pager just shows an empty area. That is obviously wrong. It is

Re: Review Request 106112: Pager QML port

2013-02-12 Thread Mark Gaiser
On Feb. 9, 2013, 6:49 p.m., Mark Gaiser wrote: Just wanted to add that it has a regression that slipped in the 4.10.0 release. https://bugs.kde.org/show_bug.cgi?id=312684 If you have only one virtual desktop the pager just shows an empty area. That is obviously wrong. It is

QML Placces design discussion

2013-02-12 Thread Mark
Hi, As requested, posting this on the plasma-devel mailing list. A little background information otherwise the first few lines are odd. With the KDE 4.10 release the places plasmoid is partly recreated in QML (much kudos to that!). However, it looks like an odd decision was made to make the

Review Request 108922: Fix off-by-one error in RunnerModel

2013-02-12 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108922/ --- Review request for Plasma and Aaron J. Seigo. Description --- Fix

Re: QML Placces design discussion

2013-02-12 Thread Martin Gräßlin
On Tuesday 12 February 2013 15:59:36 Mark wrote: Hi, As requested, posting this on the plasma-devel mailing list. A little background information otherwise the first few lines are odd. With the KDE 4.10 release the places plasmoid is partly recreated in QML (much kudos to that!). However,

Plasma Media Center release delayed

2013-02-12 Thread Shantanu Tushar Jha
[cross posting to plasma-devel and active] Hi all, Today was supposed to be the first release of Plasma Media Center after we went into a feature freeze during December last year. We made lot of bugfixes and usability improvements during most of the last few months and its really coming out

Re: Plasma Media Center release delayed

2013-02-12 Thread sujith h
Hi, I am working on the scroll bar part of Plasma Media Center. The intention is to highlight the playlist songs and move the scroll bar to the position where the song is played. Thanks, Sujith H On Wed, Feb 13, 2013 at 12:13 AM, Shantanu Tushar Jha shaan...@gmail.comwrote: [cross posting to

Re: QML Placces design discussion

2013-02-12 Thread Shaun Reich
On Tue, Feb 12, 2013 at 10:40 AM, Martin Gräßlin mgraess...@kde.org wrote: Technical implementation aside: I think that makes absolute sense: * one vd by default * do not show pager for one vd * show pager if user uses more vds i agree that showing the pager only for on vd is a bit weird.

Re: Plasma Media Center release delayed

2013-02-12 Thread Sinny Kumari
Thanks Sujith for your great work :) Looking forward to see more people working on Plasma Media Center. Thanks On Wed, Feb 13, 2013 at 12:24 AM, sujith h sujit...@gmail.com wrote: Hi, I am working on the scroll bar part of Plasma Media Center. The intention is to highlight the playlist

Re: Review Request 104281: Drop Decorations B2, Laptop and Plastik

2013-02-12 Thread Albert Astals Cid
On Feb. 7, 2013, 9:25 p.m., Albert Astals Cid wrote: I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited? Aaron J. Seigo wrote: plastik is gone, but b2 and laptop are still there. Albert Astals Cid wrote:

Re: Review Request 104281: Drop Decorations B2, Laptop and Plastik

2013-02-12 Thread Martin Gräßlin
On Feb. 7, 2013, 10:25 p.m., Albert Astals Cid wrote: I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited? Aaron J. Seigo wrote: plastik is gone, but b2 and laptop are still there. Albert Astals Cid wrote:

Re: QML Placces design discussion

2013-02-12 Thread Mark
On Tue, Feb 12, 2013 at 8:06 PM, Shaun Reich sre...@kde.org wrote: On Tue, Feb 12, 2013 at 10:40 AM, Martin Gräßlin mgraess...@kde.org wrote: Technical implementation aside: I think that makes absolute sense: * one vd by default * do not show pager for one vd * show pager if user uses more

Re: QML Placces design discussion

2013-02-12 Thread Mark
On Tue, Feb 12, 2013 at 11:55 PM, Mark mark...@gmail.com wrote: On Tue, Feb 12, 2013 at 8:06 PM, Shaun Reich sre...@kde.org wrote: On Tue, Feb 12, 2013 at 10:40 AM, Martin Gräßlin mgraess...@kde.org wrote: Technical implementation aside: I think that makes absolute sense: * one vd by default

Re: Re: QML Placces design discussion

2013-02-12 Thread Martin Gräßlin
On Tuesday 12 February 2013 23:55:39 Mark wrote: Why are you folks discarding my usecase completely? Not even one comment on it. My usecase is very valid, i'm having it right now as i type this mail. it's not a usecase, it's a workaround for a bug. Windows should never ever ever be opened on a

Re: Re: QML Placces design discussion

2013-02-12 Thread Mark
On Wed, Feb 13, 2013 at 7:58 AM, Martin Gräßlin mgraess...@kde.org wrote: On Tuesday 12 February 2013 23:55:39 Mark wrote: Why are you folks discarding my usecase completely? Not even one comment on it. My usecase is very valid, i'm having it right now as i type this mail. it's not a usecase,