Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-07-29 Thread Sebastian Kügler
> On July 29, 2013, 10:58 a.m., Aaron J. Seigo wrote: > > src/plasma/private/dataengine_p.h, line 37 > > > > > > see above Thanks for the review. I'll merge this branch, and related changes once https://git.revi

Re: Review Request 111618: Fix launcher regression, only show icons instead of icons + text

2013-07-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111618/ --- (Updated July 29, 2013, 9:25 p.m.) Status -- This change has been dis

Re: Review Request 101543: Code review for the newspaper containment

2013-07-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101543/ --- (Updated July 29, 2013, 2:46 p.m.) Status -- This change has been dis

Re: plasma-framework compile error

2013-07-29 Thread Sebastian Kügler
On Monday, July 29, 2013 11:42:40 Heena Mahour wrote: > Now, plasma-shell is giving out error > > :~/plasma-framework$ plasma-shell > > plasma-shell: symbol lookup error: > /home/heena/kf5/lib/i386-linux-gnu/libKDE4Support.so.5: undefined symbol: > kde_kiosk_admin Look into your LD_LIBRARY_PATH

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-07-29 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111770/#review36734 --- I see couple issues here: - Pressing esc key always gives focus

Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-07-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111691/#review36732 --- Ship it! other than the args member in the private class which

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-07-29 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111770/#review36728 --- Ship it! Ship It! browsingbackends/localfiles/localfilesabst

Re: framework5/plasma2

2013-07-29 Thread Heena Mahour
also I did git pull --rebase and rebuild it .Then I did ~/plasma-framework/build$ nm -D /opt/kf5/lib64/libkdecore.so | grep kde_kiosk_admin nm: '/opt/kf5/lib64/libkdecore.so': No such file On Mon, Jul 29, 2013 at 8:37 AM, Martin Graesslin wrote: > On Monday 29 July 2013 08:14:20 Heena Mahour w

Re: framework5/plasma2

2013-07-29 Thread Martin Graesslin
On Monday 29 July 2013 08:14:20 Heena Mahour wrote: > I did heena@heena-Aspire-5750:~/plasma-framework$ plasma-shell > plasma-shell: symbol lookup error: > /home/heena/kf5/lib/i386-linux-gnu/libKDE4Support.so.5: undefined symbol: > kde_kiosk_admin > How to exactly test the plasma2 plasmoid (as plas

Re: Mondaily pow-wow at 12

2013-07-29 Thread Ivan Čukić
On Monday 29 July 2013 10:14:32 Marco Martin wrote: > still traveling, next time for me I'll be there today. Cheerio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Mondaily pow-wow at 12

2013-07-29 Thread Marco Martin
still traveling, next time for me On 7/29/13, Sebastian Kügler wrote: > Hi all, > > Let's do our weekly Plasma hangout at 12.00 Europe/Amsterdam (and most of > Europe, except Greece). > > If you'd like to join in, show up in #plasma right before, and shout my > name. > > See you, > -- > sebas > >