Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Ben Cooksley
> On Oct. 7, 2013, 9:35 a.m., Stephen Kelly wrote: > > src/plasma/CMakeLists.txt, line 173 > > > > > > The if-else shouldn't be needed. INSTALL_INTERFACE should already check > > if ${INCLUDE_INSTALL_DIR} is abso

Re: Review Request 113127: Fix click on trash plasmoid when on desktop and widgets are unlocked

2013-10-07 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113127/ --- (Updated Oct. 7, 2013, 5:42 p.m.) Status -- This change has been mark

Re: Review Request 113127: Fix click on trash plasmoid when on desktop and widgets are unlocked

2013-10-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113127/#review41362 --- This review has been submitted with commit 6f49908ee013c851571

Re: Review Request 113127: Fix click on trash plasmoid when on desktop and widgets are unlocked

2013-10-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113127/#review41359 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 7, 2013, 8:36 a.

Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Stephen Kelly
> On Oct. 7, 2013, 9:35 a.m., Stephen Kelly wrote: > > src/plasma/CMakeLists.txt, line 173 > > > > > > The if-else shouldn't be needed. INSTALL_INTERFACE should already check > > if ${INCLUDE_INSTALL_DIR} is abso

Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113139/ --- (Updated Oct. 7, 2013, 10:48 a.m.) Status -- This change has been mar

Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113139/#review41333 --- This review has been submitted with commit d2115ae9383bd01b001

Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113139/#review41331 --- Ship it! > Unfortunately it isn't entirely successful as it se

Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Ben Cooksley
> On Oct. 7, 2013, 9:35 a.m., Stephen Kelly wrote: > > Which kde-workspace branch should I use to test this? Master branch. > On Oct. 7, 2013, 9:35 a.m., Stephen Kelly wrote: > > src/plasma/CMakeLists.txt, line 173 > >

Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113139/#review41324 --- Which kde-workspace branch should I use to test this? src/pla

Re: Review Request 113127: Fix click on trash plasmoid when on desktop and widgets are unlocked

2013-10-07 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113127/ --- (Updated Oct. 7, 2013, 10:36 a.m.) Review request for kde-workspace, Plasm

Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113139/ --- Review request for kdelibs, Plasma and Stephen Kelly. Repository: plasma-f