Re: Review Request 113420: port activitybar applet to Plasma2

2013-10-26 Thread Bhushan Shah
> On Oct. 27, 2013, 2:12 a.m., David Edmundson wrote: > > Looks good to me. > > > > FWIW, when you move files it's best if you make diffs with "git diff > > --find-copies-harder" that way reviewboard doesn't show that you deleted > > and created a file. Otherwise I end up commenting on things

Re: Wrong translation catalog names in kde-workspace/plasma/ master

2013-10-26 Thread David Edmundson
Both kickoff and analog clock are my fault, thanks for point it out. Will fix, and the others too. To me it would be best if we could mod the Messages.sh to match the new org.kde.blah names, would that cause translators to retranslate everything? Obviously I don't want to do that. David

Re: Review Request 113420: port activitybar applet to Plasma2

2013-10-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113420/#review42409 --- Ship it! Looks good to me. FWIW, when you move files it's bes

Re: Can we drop kcontrol/workspaceoptions?

2013-10-26 Thread Eike Hein
On Thursday 17 October 2013 19:51:24 Martin Graesslin wrote: > It offers the following features: > * switch between workspace type "Desktop" and "Netbook" > * configure dashboard to "show Desktop widgets" or "Show an independent > widget set" > * checkbox for "show informational tips" (whatever tha

Re: a much needed plasma2 coordination meeting

2013-10-26 Thread Marco Martin
On Saturday 26 October 2013 17:01:58 Aaron J. Seigo wrote: > hi ... > > i’ve mentioned this a few times on irc now, but since nobody seems to step > up to do this, and despite not really having much time in my schedule right > now, i’ll step up: > > we need to have a coordination meeting for plas

Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-26 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113447/ --- Review request for Plasma, Aaron J. Seigo and Marco Martin. Repository: kd

Re: Review Request 113443: Attempt to unbreak pre-configuring QML applets via desktop scripting

2013-10-26 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113443/ --- (Updated Oct. 26, 2013, 3:27 p.m.) Status -- This change has been dis

a much needed plasma2 coordination meeting

2013-10-26 Thread Aaron J. Seigo
hi ... i’ve mentioned this a few times on irc now, but since nobody seems to step up to do this, and despite not really having much time in my schedule right now, i’ll step up: we need to have a coordination meeting for plasma2’s kde-workspace efforts. “port all the codes” will not give us goo

Re: Revamping KSplash KCM

2013-10-26 Thread Aaron J. Seigo
On Saturday, October 26, 2013 14:42:34 Martin Klapetek wrote: > Also please let's not discuss "why not get rid of ksplash altogether/put it > into kwin" in here, we'll need the kcm even if it gets moved elsewhere, so > let's stay focused on the kcm. no, we won’t need the kcm if we get rid of kspla

Re: Review Request 113443: Attempt to unbreak pre-configuring QML applets via desktop scripting

2013-10-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113443/#review42401 --- syncing after every change will be horrible for performance; th

Re: Revamping KSplash KCM

2013-10-26 Thread Martin Klapetek
On Sat, Oct 26, 2013 at 2:55 PM, Ivan Čukić wrote: > > > First of all I wanted it to look similar to our wallpaper setting dialog, > > so I took its delegate and made it work for list view (in contrast to > grid > > view of the wallpaper kcm). The backend is a full fledged > > Any particular reas

Re: Revamping KSplash KCM

2013-10-26 Thread Ivan Čukić
> First of all I wanted it to look similar to our wallpaper setting dialog, > so I took its delegate and made it work for list view (in contrast to grid > view of the wallpaper kcm). The backend is a full fledged Any particular reason for not choosing a grid? > Also please let's not discuss "why

Revamping KSplash KCM

2013-10-26 Thread Martin Klapetek
Hey all, I was about to port the KSplash KCM but a) the code is quite ugly, b) the kcm is quite ugly. So I decided to rewrite it from scratch (I guess fresh code after 15 years is in place) using slightly different approach. First of all I wanted it to look similar to our wallpaper setting dialog