Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 9, 2014, 7:04 p.m., Thomas Lübking wrote: File Attachment: New advanced compositing KCM - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment173 OOC: Is there any HIG on this? Is the situation on QML better than on QWidget? (The issue is that

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 9, 2014, 7:04 p.m., Thomas Lübking wrote: File Attachment: New advanced compositing KCM - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment174 OOC: Is there any HIG on this? Is the situation on QML better than on QWidget? (The issue is that

Review Request 116690: Export CompositingTypeIndex enum to QML

2014-03-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116690/ --- Review request for kwin, Plasma, David Edmundson, and Antonis

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 7, 2014, 10:52 a.m., David Edmundson wrote: qml/CompositingView.qml, line 76 https://git.reviewboard.kde.org/r/116648/diff/1/?file=252688#file252688line76 This is really liable to break. If someone were to add an entry in the earlier in the model and everything

Review Request 116691: Use TextField of QtQuickControls instead of Plasma

2014-03-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116691/ --- Review request for kwin, Plasma and Antonis Tsiapaliokas. Repository:

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Thomas Pfeiffer
On March 9, 2014, 6:04 p.m., Thomas Lübking wrote: File Attachment: New advanced compositing KCM - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment175 OOC: Is there any HIG on this? Is the situation on QML better than on QWidget? (The issue is that

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 9, 2014, 7:04 p.m., Thomas Lübking wrote: File Attachment: New advanced compositing KCM - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment176 OOC: Is there any HIG on this? Is the situation on QML better than on QWidget? (The issue is that

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 10, 2014, 10:02 a.m.) Review request for kwin, Plasma and

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 10, 2014, 10:03 a.m.) Review request for kwin, Plasma and

Re: Locale settings in Plasma Next

2014-03-10 Thread Martin Klapetek
Hey John, On Sun, Feb 23, 2014 at 8:10 PM, John Layt jl...@kde.org wrote: Hi, With the countdown to Plasma Next underway, I thought I'd better outline what needs to be done for locale settings, in particular the KCM, in case I don't find the time to do it. Thanks for that ;) In KF5

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/#review52495 --- File Attachment: Latest kcmcompositing screenshot -

Review Request 116693: Improve layout of Effect View

2014-03-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/ --- Review request for kwin, Plasma, David Edmundson, Thomas Pfeiffer, and

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Thomas Pfeiffer
On March 10, 2014, 9:20 a.m., Thomas Lübking wrote: File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment181 Would this rather belong into the FX kcm? The Enable Desktop Effects on Startup option is one which

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment182 Would this rather belong into the FX kcm? Thomas Pfeiffer wrote: The Enable Desktop Effects on

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Hugo Pereira Da Costa
On March 7, 2014, 3:15 p.m., Hugo Pereira Da Costa wrote: Hi Martin, Any idea why the background behind the shells is flat ? Does it happend with all KCMs ? (I'll double check asap but right now my systemsettings is crashing because my kauth is fubared. Links against incorrect

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Hugo Pereira Da Costa
On March 7, 2014, 3:15 p.m., Hugo Pereira Da Costa wrote: Hi Martin, Any idea why the background behind the shells is flat ? Does it happend with all KCMs ? (I'll double check asap but right now my systemsettings is crashing because my kauth is fubared. Links against incorrect

Re: Review Request 116691: Use TextField of QtQuickControls instead of Plasma

2014-03-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116691/#review52503 --- Ship it! Please open a bug somewhere. IMHO in Qt, as

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment184 acceptable to remove this from the for layout (and put on top and a splitter below?) splitter is

Re: Review Request 116690: Export CompositingTypeIndex enum to QML

2014-03-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116690/#review52505 --- Ship it! Ship It! - David Edmundson On March 10, 2014,

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment185 Scale method and vsync are backend dependent, so i'd move this below the two (resp. them right below

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 7, 2014, 4:15 p.m., Hugo Pereira Da Costa wrote: Hi Martin, Any idea why the background behind the shells is flat ? Does it happend with all KCMs ? (I'll double check asap but right now my systemsettings is crashing because my kauth is fubared. Links against incorrect

Re: Locale settings in Plasma Next

2014-03-10 Thread John Layt
On 10 March 2014 10:11, Martin Klapetek martin.klape...@gmail.com wrote: On Sun, Feb 23, 2014 at 8:10 PM, John Layt jl...@kde.org wrote: Any ETA on the QLocale changes? Any particular plans with which we can help? I'd be happy to help out there. I'm hoping for Qt 5.4, but this is something

Re: Review Request 116693: Improve layout of Effect View

2014-03-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/#review52507 --- Ship it! qml/Video.qml

Re: Bughunting Season!

2014-03-10 Thread Marco Martin
On Sunday 09 March 2014, Sebastian Kügler wrote: Hi all, With the feature freeze looming in less than 24 hours, it's time to shift or focus to quality improvements. We have a whole bunch of new awesomeness, and perhaps even more new ideas. For now, we'll have to take a step back and admit

Re: Review Request 116691: Use TextField of QtQuickControls instead of Plasma

2014-03-10 Thread Martin Gräßlin
On March 10, 2014, 11:02 a.m., David Edmundson wrote: Please open a bug somewhere. IMHO in Qt, as QLineEdit now has a clear button - https://bugreports.qt-project.org/browse/QTBUG-37373 - Martin --- This is an automatically

Re: Review Request 116693: Improve layout of Effect View

2014-03-10 Thread Martin Gräßlin
On March 10, 2014, 11:15 a.m., David Edmundson wrote: qml/Video.qml, line 51 https://git.reviewboard.kde.org/r/116693/diff/1/?file=253176#file253176line51 can this become: visible: videoItem.playbackState != MediaPlayer.StoppedState and then remove the one

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Thomas Lübking
On March 10, 2014, 9:20 a.m., Thomas Lübking wrote: File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment186 Scale method and vsync are backend dependent, so i'd move this below the two (resp. them right below

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment188 Scale method and vsync are backend dependent, so i'd move this below the two (resp. them right below

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Thomas Pfeiffer
On March 10, 2014, 9:20 a.m., Thomas Lübking wrote: File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment189 Scale method and vsync are backend dependent, so i'd move this below the two (resp. them right below

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png https://git.reviewboard.kde.org/r/116648/#fcomment190 Scale method and vsync are backend dependent, so i'd move this below the two (resp. them right below

Re: Review Request 116693: Improve layout of Effect View

2014-03-10 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/#review52526 --- Ah, much better now! Just three things: - The search field

Re: Review Request 116693: Improve layout of Effect View

2014-03-10 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/#review52527 --- Ah, much better now! Just three things: - The search field

Re: Review Request 116693: Improve layout of Effect View

2014-03-10 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/#review52528 --- Much better now, thanks for fixing these issues so quickly!

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/#review52530 --- This review has been submitted with commit

Re: Review Request 116693: Improve layout of Effect View

2014-03-10 Thread Thomas Pfeiffer
On March 10, 2014, 1:01 p.m., Thomas Pfeiffer wrote: Ah, much better now! Just three things: - The search field still says Search Plugins but should say Search Effects (for consistency) or better still just Search (because what else should it search for?). Reminds me that I really

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

2014-03-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 10, 2014, 1:04 p.m.) Status -- This change has been

Re: Review Request 116690: Export CompositingTypeIndex enum to QML

2014-03-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116690/#review52531 --- This review has been submitted with commit

Re: Review Request 116690: Export CompositingTypeIndex enum to QML

2014-03-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116690/ --- (Updated March 10, 2014, 1:07 p.m.) Status -- This change has been

Re: Review Request 116691: Use TextField of QtQuickControls instead of Plasma

2014-03-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116691/ --- (Updated March 10, 2014, 1:09 p.m.) Status -- This change has been

Re: Review Request 116691: Use TextField of QtQuickControls instead of Plasma

2014-03-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116691/#review52532 --- This review has been submitted with commit

Minutes Monday Plasma hangout

2014-03-10 Thread Sebastian Kügler
Minutes Plasma Hangout 10 March 2014 Present: Alex Fiestas, Aleix Pol, David Edmundson, Ivan Cukic, Martin Gräßlin, Martin Klapetek, Marco Martin, Sebastian Kügler, Jens Reuterberg Alex: - fixed bugs in empty plasma next session start - planning to fix keyboard layout switcher - will send

[plasma-shell] [Bug 327683] Crash at login (no activities found?)

2014-03-10 Thread Ivan Čukić
https://bugs.kde.org/show_bug.cgi?id=327683 Ivan Čukić ivan.cu...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[plasma-shell] [Bug 327683] Crash at login (no activities found?)

2014-03-10 Thread Ivan Čukić
https://bugs.kde.org/show_bug.cgi?id=327683 --- Comment #7 from Ivan Čukić ivan.cu...@kde.org --- @Chistoph It should build even with 1.49. Can you send me the error log you're getting? -- You are receiving this mail because: You are on the CC list for the bug.

Re: Minutes Monday Plasma hangout

2014-03-10 Thread Martin Gräßlin
On Monday 10 March 2014 14:22:53 Sebastian Kügler wrote: Martin G: - systray: feedback on blogpost overall positive - will communicate tips for distros to integrate SNI - has prepped a blog for expectation management on Wayland - removed OpenGL 1 support in kwin to gauge feedback - open

Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media

2014-03-10 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/#review52555 --- You don't really need to add this method, you can just use

[plasma-shell] [Bug 327683] Crash at login (no activities found?)

2014-03-10 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=327683 --- Comment #8 from Christoph Feck christ...@maxiom.de --- Ivan, you already fixed that with e15fc07bdb4bf2379098d048fd2f8dc9024e2ffd :) -- You are receiving this mail because: You are on the CC list for the bug.

Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media

2014-03-10 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/ --- (Updated March 10, 2014, 9:21 p.m.) Review request for Plasma, Shantanu

[plasma-shell] [Bug 328419] Context menu of task not visible with highlight windows

2014-03-10 Thread Bhushan
https://bugs.kde.org/show_bug.cgi?id=328419 Bhushan bhus...@gmail.com changed: What|Removed |Added CC||bhus...@gmail.com

Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media

2014-03-10 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/#review52557 --- Works fine for me, other than the following nitpick. As you

[plasma-shell] [Bug 327683] Crash at login (no activities found?)

2014-03-10 Thread Ivan Čukić
https://bugs.kde.org/show_bug.cgi?id=327683 --- Comment #9 from Ivan Čukić ivan.cu...@kde.org --- Wow, I really am good! :D -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media

2014-03-10 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/ --- (Updated March 10, 2014, 10:20 p.m.) Review request for Plasma, Shantanu

Re: Bughunting Season!

2014-03-10 Thread Sebastian Kügler
On Monday, March 10, 2014 11:22:05 Marco Martin wrote: On Sunday 09 March 2014, Sebastian Kügler wrote: Hi all, With the feature freeze looming in less than 24 hours, it's time to shift or focus to quality improvements. We have a whole bunch of new awesomeness, and perhaps even

Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media

2014-03-10 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/ --- (Updated March 10, 2014, 5:08 p.m.) Status -- This change has been

Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media

2014-03-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/#review52564 --- This review has been submitted with commit

Re: Bughunting Season!

2014-03-10 Thread David Edmundson
Visit here https://bugs.kde.org/userprefs.cgi?tab=saved-searches ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-shell] [Bug 328419] Context menu of task not visible with highlight windows

2014-03-10 Thread Bhushan Shah
https://bugs.kde.org/show_bug.cgi?id=328419 Bhushan Shah bhus...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

Re: Bughunting Season!

2014-03-10 Thread Bhushan Shah
On Mon, Mar 10, 2014 at 10:47 PM, Sebastian Kügler se...@kde.org wrote: Ah, thanks! I've shared it to canconfirm now, can anybody confirm it's visible now? nope, same. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___

Re: Bughunting Season!

2014-03-10 Thread Bhushan Shah
This link works, so you can bookmark it. https://bugs.kde.org/buglist.cgi?cmdtype=doremremaction=runnamedcmd=plasma-shellsharer_id=38926list_id=942707 On Mon, Mar 10, 2014 at 10:50 PM, Bhushan Shah bhus...@gmail.com wrote: On Mon, Mar 10, 2014 at 10:47 PM, Sebastian Kügler se...@kde.org wrote:

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-10 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review52579 --- Ship it! Before pushing it, contact with the sysadmins to

Re: Review Request 115409: Workaround battery detection at runtime

2014-03-10 Thread Kai Uwe Broulik
On March 7, 2014, 12:19 p.m., Christoph Feck wrote: plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 75 https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75 Removal of this causes two other regressions: bug 331797, bug 331831.

Re: Bughunting Season!

2014-03-10 Thread Sebastian Kügler
On Monday, March 10, 2014 18:11:28 Thomas Pfeiffer wrote: On 09.03.2014 14:13, Luca Beltrame wrote: In data domenica 09 marzo 2014 14:00:25, Sebastian Kügler ha scritto: We'll also open up for feedback from the community shortly, with the Alpha release that will be tagged on Thursday (and

Re: Review Request 115409: Workaround battery detection at runtime

2014-03-10 Thread Christoph Feck
On March 7, 2014, 12:19 p.m., Christoph Feck wrote: plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 75 https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75 Removal of this causes two other regressions: bug 331797, bug 331831.

Trying out the work-in-progress

2014-03-10 Thread Jens Reuterberg
So with the herculian efforts of Andrew Lake, Marco and Ivan - the Plasma Theme is available for wild testing. I've also bundled it up with an Aurorae theme for window decorations, Qtcurve theme for widgets, Color theme and a theme for Chrome/Chromium - now all of this is for the light