Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58340 --- applets/batterymonitor/contents/ui/BatteryItem.qml

Re: Icons for Paste Bin and Paste

2014-05-23 Thread Jens Reuterberg
Haha! That was AWESOME! ok okokok I wanna do that! On Thursday 22 May 2014 21.54.33 Marco Martin wrote: what about the paperclip bended in cloud shape? (admittely this attempt isn't that great, but maybe can be evolved a bit) On Thursday 22 May 2014, Jens wrote: I already tried it and it

Re: Notification bloat (4.xx)

2014-05-23 Thread Martin Klapetek
Hey, On Thu, May 22, 2014 at 8:23 PM, Mark Gaiser mark...@gmail.com wrote: Hi, First of all, i have no solution for this. I've just observed an issue with the notification system that might benefit of improvements when we all brainstorm here about how it should behave. This is for KDE

Build failed in Jenkins: plasma-desktop_master_qt5 #222

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/222/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER

Build failed in Jenkins: plasma-workspace_master_qt5 #263

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/263/changes Changes: [mgraesslin] [klipper] Show filter widget before sending key events to it [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with

Re: Notification bloat (4.xx)

2014-05-23 Thread Kai Uwe Broulik
In Plasma Next, the notifications stack/history now contains only and only persistent notifications, all the rest just flies by and disappears forever after the timeout. Hi, I think I already brought this up somewhere but do the notification watch for user interaction? Would be great if

Re: Notification bloat (4.xx)

2014-05-23 Thread Martin Klapetek
On Fri, May 23, 2014 at 10:23 AM, Kai Uwe Broulik k...@privat.broulik.dewrote: In Plasma Next, the notifications stack/history now contains only and only persistent notifications, all the rest just flies by and disappears forever after the timeout. Hi, I think I already brought this up

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/ --- (Updated May 23, 2014, 10:45 a.m.) Review request for Plasma and David

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-23 Thread Aurélien Gâteau
On May 20, 2014, 5:08 p.m., Alexander Potashev wrote: You probably need to check in CMakeLists.txt that version of shared-mime-info is at least 0.40. Aurélien Gâteau wrote: shared-mime-info is only required at run time so I am not sure it makes sense to check at build time.

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58343 --- Looks great, thanks! I was actually thinking of removing

Build failed in Jenkins: plasma-desktop_master_qt5 #223

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/223/changes Changes: [notmart] remove the notebook case -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in

Build failed in Jenkins: plasma-desktop_master_qt5 #224

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/224/changes Changes: [notmart] don't auto resize when the panel controller is open -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4

Build failed in Jenkins: plasma-workspace_master_qt5 #264

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/264/changes Changes: [notmart] don't delete the config immediately -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER

Build failed in Jenkins: plasma-workspace_master_qt5 #265

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/265/changes Changes: [notmart] don't use a lambda -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/ --- Review request for Plasma. Bugs: 335147

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58345 --- Love it.

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Sebastian Kügler
CC:ing plasma-devel. Any input on this? (I just fixed the build in the most obvious way, perhaps someone knows why Qt5::Gui had been removed from the implicit public targets in the first place? On Friday, May 23, 2014 00:54:17 Aleix Pol wrote: KF5::Plasma should have Qt5::Gui as public

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Marco Martin
I think it's a counter-effect of when i removed KConfigWidgets from libplasma. there is definitely a problem in the cmake there, qt5::gui should be in public in libplasma, right? On Friday 23 May 2014, Sebastian Kügler wrote: CC:ing plasma-devel. Any input on this? (I just fixed the build in

Re: Icons for Paste Bin and Paste

2014-05-23 Thread Sebastian Kügler
On Thursday, May 22, 2014 19:33:40 Thomas Pfeiffer wrote: On Thursday 22 May 2014 19:17:22 Jens wrote: Ah the issue that there are TWO pastebin, one good for images (of all kinds, including the link above btw) as well as text and one not so good that is just for text Perhaps a

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Sebastian Kügler
On Friday, May 23, 2014 12:18:55 Marco Martin wrote: I think it's a counter-effect of when i removed KConfigWidgets from libplasma. there is definitely a problem in the cmake there, qt5::gui should be in public in libplasma, right? That's how I understand Aleix. -- sebas http://www.kde.org |

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread Martin Klapetek
On May 23, 2014, 12:07 p.m., David Edmundson wrote: applets/digital-clock/package/contents/ui/DigitalClock.qml, line 84 https://git.reviewboard.kde.org/r/118274/diff/1/?file=274305#file274305line84 we should take this size from the sizeHelper I think? They might potentially be

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/ --- (Updated May 23, 2014, 12:36 p.m.) Review request for Plasma. Changes

Build failed in Jenkins: plasma-workspace_master_qt5 #266

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/266/changes Changes: [mklapetek] Don't check for free disk space right after module load -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58347 --- applets/digital-clock/package/contents/ui/DigitalClock.qml

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread Martin Klapetek
On May 23, 2014, 12:46 p.m., David Edmundson wrote: applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 87-88 https://git.reviewboard.kde.org/r/118274/diff/2/?file=274306#file274306line87 So I'm thinking these 2 are unused now? No, they still are. The sizehelper is

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58350 --- Ship it! Ship It! - David Edmundson On May 23, 2014,

Re: Icons for Paste Bin and Paste

2014-05-23 Thread Jens
Oh awesome... TBH I've been thinking of talking to Albert Vaca and some other guys about doing some unified Sharing/Cloudbox thing... and then market the SHIT out of it. (This is wy OT but the Pastebin was one of the things that attracted me directly to KDE in the first place. It's such an

Re: Notification bloat (4.xx)

2014-05-23 Thread Thomas Pfeiffer
On Friday 23 May 2014 10:16:03 Martin Klapetek wrote: Thomas - what's your opinion here? Should notifications about file operations be persistent or not? I just invited Celeste to this discussion. Given that she wrote her PhD thesis about desktop notifications, she's the expert here ;)

Re: Icons for Paste Bin and Paste

2014-05-23 Thread Marco Martin
btw, we do have an embyonic framework for sharing stuff since a while, it was never really finished or added by default, or marketed in any way mostly for two reasons, we are still waiting for a global login thing to be finished (to be logged in system wide to twitter/social web BS whatever) and,

Re: Icons for Paste Bin and Paste

2014-05-23 Thread Jens
I know that the work with global login is appearently rather frustrating (as I've heard from you guys) since Google and Facebook and Twitter all enjoy to swap stuff around making one method completely useless after a short while. Marco if you feel like it lets talk more via G+ about this. I

Re: Icons for Paste Bin and Paste

2014-05-23 Thread Sebastian Kügler
On Friday, May 23, 2014 13:24:20 Jens wrote: I know that the work with global login is appearently rather frustrating (as I've heard from you guys) since Google and Facebook and Twitter all enjoy to swap stuff around making one method completely useless after a short while. Marco if you

Re: Icons for Paste Bin and Paste

2014-05-23 Thread Jens
Good point... maybe we are overthinking this? On Friday 23 May 2014 13.38.49 Sebastian Kügler wrote: On Friday, May 23, 2014 13:24:20 Jens wrote: I know that the work with global login is appearently rather frustrating (as I've heard from you guys) since Google and Facebook and Twitter all

Build failed in Jenkins: plasma-workspace_master_qt5 #267

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/267/changes Changes: [kde] Don't change visibility mode on panel when opening config [kde] Remove pointless double config sync -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by

Review Request 118275: Remove duplicated code in showEvent and constructor

2014-05-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Sebastian Kügler
On May 23, 2014, 8:05 a.m., Martin Klapetek wrote: applets/batterymonitor/contents/ui/BatteryItem.qml, line 156 https://git.reviewboard.kde.org/r/118272/diff/1/?file=274298#file274298line156 Use .floor/.round here to avoid half-pixels ...and basically everywhere else

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/ --- (Updated May 23, 2014, 2:05 p.m.) Review request for Plasma and Kai Uwe

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Sebastian Kügler
On May 22, 2014, 11:08 p.m., Mark Gaiser wrote: applets/batterymonitor/contents/ui/PopupDialog.qml, lines 78-81 https://git.reviewboard.kde.org/r/118272/diff/1/?file=274300#file274300line78 I don't know this code so i'm not going to comment on how it should or should not work.

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58357 --- Ship it! Ship It! - Sebastian Kügler On May 23, 2014,

Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/ --- (Updated May 23, 2014, 3:24 p.m.) Status -- This change has been

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58358 --- This review has been submitted with commit

Review Request 118278: [2/2] Make sure we update the calendar on date change

2014-05-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118278/ --- Review request for Plasma. Repository: plasma-workspace Description

Build failed in Jenkins: plasma-workspace_master_qt5 #268

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/268/changes Changes: [mklapetek] [digital-clock] Replace sizing timer with fontSizeMode property -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on

Re: Review Request 118278: [2/2] Make sure we update the calendar on date change

2014-05-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118278/#review58359 --- Ship it! Ship It! - David Edmundson On May 23, 2014, 3:25

Re: Review Request 118278: [2/2] Make sure we update the calendar on date change

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118278/#review58360 --- Ship it! Looks good. Thanks!

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/#review58361 --- Ship it! Ship It! - Sebastian Kügler On May 23, 2014,

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/#review58362 --- Hi Martin, I would like to suggest a different approach. 1.

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-23 Thread Mark Gaiser
On May 23, 2014, 4:02 p.m., Mark Gaiser wrote: Hi Martin, I would like to suggest a different approach. 1. You want to know the current day (which the model and calendar component don't expose). 2. You want the daysModel data to update when the clock ticks over 12.00 PM into

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58364 --- Ship it! I haven't tested but I trust you on this. Any

Re: Review Request 118275: Remove duplicated code in showEvent and constructor

2014-05-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/#review58365 --- flags and type might be needed in the show event. I recommend

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-23 Thread Martin Klapetek
On May 23, 2014, 6:02 p.m., Mark Gaiser wrote: Hi Martin, I would like to suggest a different approach. 1. You want to know the current day (which the model and calendar component don't expose). 2. You want the daysModel data to update when the clock ticks over 12.00 PM into

Build failed in Jenkins: plasma-workspace_master_qt5 #269

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/269/changes Changes: [notmart] the shell package allows external paths -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-23 Thread Mark Gaiser
On May 23, 2014, 4:02 p.m., Mark Gaiser wrote: Hi Martin, I would like to suggest a different approach. 1. You want to know the current day (which the model and calendar component don't expose). 2. You want the daysModel data to update when the clock ticks over 12.00 PM into

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-23 Thread Martin Klapetek
On May 23, 2014, 6:02 p.m., Mark Gaiser wrote: Hi Martin, I would like to suggest a different approach. 1. You want to know the current day (which the model and calendar component don't expose). 2. You want the daysModel data to update when the clock ticks over 12.00 PM into

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58379 --- This review has been submitted with commit

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/ --- (Updated May 23, 2014, 7:21 p.m.) Status -- This change has been

Build failed in Jenkins: plasma-workspace_master_qt5 #270

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/270/changes Changes: [sebas] noise-- [sebas] Less chatty systray [sebas] less chatty devicenotifier [sebas] Clean up Battery Monitor [sebas] Align extra info to the slider [sebas] improve spacing and alignment a bit more [sebas] Fix

Re: Notification bloat (4.xx)

2014-05-23 Thread Mark Gaiser
On Thu, May 22, 2014 at 8:41 PM, Christoph Feck christ...@maxiom.de wrote: On Thursday 22 May 2014 20:23:00 Mark Gaiser wrote: Hi, First of all, i have no solution for this. I've just observed an issue with the notification system that might benefit of improvements when we all brainstorm

Build failed in Jenkins: plasma-desktop_master_qt5 #225

2014-05-23 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/225/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) [notmart] remove the notebook case [notmart] don't auto resize when the panel controller is open -- Started by user Ben

Plasma Addons

2014-05-23 Thread David Edmundson
Hey, we've started to get bug reports on plasma-addons. It appears they're distributed as part of OpenSuse RPMs. Can I confirm our position on what we're doing here, based on our conversation last sprint. 1) They will not be released with the plasma release next month I think to do so would

Re: Notification bloat (4.xx)

2014-05-23 Thread Christoph Feck
On Friday 23 May 2014 22:58:21 Mark Gaiser wrote: On Thu, May 22, 2014 at 8:41 PM, Christoph Feck christ...@maxiom.de wrote: On Thursday 22 May 2014 20:23:00 Mark Gaiser wrote: Hi, First of all, i have no solution for this. I've just observed an issue with the notification system that

Plasma Next visual polish feedback from VDG core folks

2014-05-23 Thread Andrew Lake
Hello all, I just had a quick question. If I have some feedback on areas to visually polish up for the Plasma Next release, should I file a bug or just share them via the email list? I honestly would rather just pitch in and submit review requests for patches but, unfortunately, I just don't

Re: Notification bloat (4.xx)

2014-05-23 Thread Celeste Lyn Paul
There definitely needs to be better logic when it comes to showing certain types of notifications. One of KDE's strengths is that all notifications are channeled through the same system, and so KDE can control the behavior of all notification interruptions. I'm not sure at what level this

Re: Notification bloat (4.xx)

2014-05-23 Thread Mark Gaiser
On Sat, May 24, 2014 at 12:54 AM, Christoph Feck christ...@maxiom.de wrote: On Friday 23 May 2014 22:58:21 Mark Gaiser wrote: On Thu, May 22, 2014 at 8:41 PM, Christoph Feck christ...@maxiom.de wrote: On Thursday 22 May 2014 20:23:00 Mark Gaiser wrote: Hi, First of all, i have no

Oxygen font, underline looks odd

2014-05-23 Thread Mark Gaiser
Hi, I noticed this in a review request from sebas that included a few screenshots [1, 2]. If you look at the C in configure and the D in defaults you will see that the underline is way to close to the character. It shouldn't touch it. There should be some space between the character and the

Review Request 118290: Streamline Comment fields of KCMs

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- Review request for Plasma. Repository: plasma-desktop Description