Review Request 118342: [klipper] Port to new KAboutData

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118342/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 118343: [klipper] Port from KMenu to QMenu

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118343/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 118341: [klipper] Port from KCmdLineArgs to QCommandLineParser

2014-05-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118341/#review58541 --- Ship it! Ship It! - Martin Klapetek On May 27, 2014, 7:43

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58542 --- Could you attach a screenshot of the Compositing KCM with the

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:25 a.m.) Review request for Plasma, Hugo

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58545 --- File Attachment: compositing_kcm - bustle1.png

4.x autostart compat

2014-05-27 Thread Harald Sitter
Heya Something that just occured to me is that it appears we currently have no autostart compatibility with kdelibs4 applications. Namely when an application installs an autostart desktop file in 4.x they'd end up in $PREFIX/share/autostart which by default does not appear to be searched by

Review Request 118346: [klipper] Re-enable prison support

2014-05-27 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118346/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew

Re: Review Request 118346: [klipper] Re-enable prison support

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118346/#review58547 --- at the moment this cannot be enabled yet. I have already

Re: Review Request 118342: [klipper] Port to new KAboutData

2014-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118342/#review58548 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 27, 2014,

Re: Review Request 118346: [klipper] Re-enable prison support

2014-05-27 Thread Johannes Huber
On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote: at the moment this cannot be enabled yet. I have already prepared a similar change and backed away from it, due to no way to figure out whether prison is compiled against Qt4 or Qt5. Further more on Debian based systems the

Re: Review Request 118346: [klipper] Re-enable prison support

2014-05-27 Thread Martin Gräßlin
On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote: at the moment this cannot be enabled yet. I have already prepared a similar change and backed away from it, due to no way to figure out whether prison is compiled against Qt4 or Qt5. Further more on Debian based systems the

Re: Review Request 118343: [klipper] Port from KMenu to QMenu

2014-05-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118343/#review58552 --- Ship it! Ship It! - Sebastian Kügler On May 27, 2014,

Re: Review Request 118346: [klipper] Re-enable prison support

2014-05-27 Thread Johannes Huber
On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote: at the moment this cannot be enabled yet. I have already prepared a similar change and backed away from it, due to no way to figure out whether prison is compiled against Qt4 or Qt5. Further more on Debian based systems the

Re: High DPI issues

2014-05-27 Thread Teo Mrnjavac
On Monday, May 26, 2014 17:47:35 Teo Mrnjavac wrote: On Tuesday, May 20, 2014 15:16:25 Teo Mrnjavac wrote: On Tuesday, May 20, 2014 14:55:16 David Edmundson wrote: On Tue, May 20, 2014 at 2:28 PM, Teo Mrnjavac t...@kde.org wrote: Another important issue is that currently the only tested

Re: Review Request 118254: Plasma-Framework: Add new a shell intrerceptor

2014-05-27 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118254/ --- (Updated May 27, 2014, 11:27 a.m.) Status -- This change has been

Re: Review Request 118346: [klipper] Re-enable prison support

2014-05-27 Thread Martin Gräßlin
On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote: at the moment this cannot be enabled yet. I have already prepared a similar change and backed away from it, due to no way to figure out whether prison is compiled against Qt4 or Qt5. Further more on Debian based systems the

Re: Review Request 118346: [klipper] Re-enable prison support

2014-05-27 Thread Johannes Huber
On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote: at the moment this cannot be enabled yet. I have already prepared a similar change and backed away from it, due to no way to figure out whether prison is compiled against Qt4 or Qt5. Further more on Debian based systems the

Re: Review Request 118341: [klipper] Port from KCmdLineArgs to QCommandLineParser

2014-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118341/#review58556 --- This review has been submitted with commit

Re: Review Request 118342: [klipper] Port to new KAboutData

2014-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118342/#review58557 --- This review has been submitted with commit

Re: Review Request 118342: [klipper] Port to new KAboutData

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118342/ --- (Updated May 27, 2014, 11:38 a.m.) Status -- This change has been

Re: Review Request 118341: [klipper] Port from KCmdLineArgs to QCommandLineParser

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118341/ --- (Updated May 27, 2014, 11:38 a.m.) Status -- This change has been

Re: Review Request 118346: [klipper] Re-enable prison support

2014-05-27 Thread Martin Gräßlin
On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote: at the moment this cannot be enabled yet. I have already prepared a similar change and backed away from it, due to no way to figure out whether prison is compiled against Qt4 or Qt5. Further more on Debian based systems the

Re: Review Request 118346: [klipper] Re-enable prison support

2014-05-27 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118346/ --- (Updated May 27, 2014, 1:45 p.m.) Status -- This change has been

Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 118348: [klipper] Port KSaveFile - QSaveFile

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118348/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58565 --- Makes sense, do we know why they used to be -1? - Aleix Pol

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread David Edmundson
On May 27, 2014, 1:11 p.m., Aleix Pol Gonzalez wrote: Makes sense, do we know why they used to be -1? If negative it would go into combinedLayoutSpacing which we don't implement. Which would in turn use the (now deprecated) defaultLayoutSpacing - David

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review58567 --- Unfortunately this way we cannot have a plural aware suffix.

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-27 Thread Martin Klapetek
On May 27, 2014, 3:52 p.m., Martin Klapetek wrote: Unfortunately this way we cannot have a plural aware suffix. What if you do this from code like setSuffix(i18np(signular, plural, value)); ? Oh but that's not a binding so it won't auto update...too much time in QML xD Nevermind.

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-27 Thread Martin Gräßlin
On May 27, 2014, 3:52 p.m., Martin Klapetek wrote: Unfortunately this way we cannot have a plural aware suffix. What if you do this from code like setSuffix(i18np(signular, plural, value)); ? Martin Klapetek wrote: Oh but that's not a binding so it won't auto update...too

Re: [RFC] Which icon to use for kwin's killer helper

2014-05-27 Thread Aleix Pol
On Tue, May 27, 2014 at 3:37 PM, Martin Gräßlin mgraess...@kde.org wrote: Hi all, I'm currently considering whether we should change the window icon used in KWin's killer helper (the dialog which gets shown when trying to close a hung window). Attached are three variants. 1.

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58575 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 27, 2014,

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58577 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 27, 2014,

Re: [RFC] Which icon to use for kwin's killer helper

2014-05-27 Thread Thomas Lübking
bomb, cashew - or ask nuno ;-) the kwin icon looks dull and has no meaning to the user. i don't like using the hung app icon - the icon shows up in the taskbar as well and creates a wrong idea about the source of the dialog (it feels odd that a process would detect that it does no more respond

Re: Re: [RFC] Which icon to use for kwin's killer helper

2014-05-27 Thread Martin Gräßlin
On Tuesday 27 May 2014 16:21:11 Aleix Pol wrote: On Tue, May 27, 2014 at 3:37 PM, Martin Gräßlin mgraess...@kde.org wrote: Hi all, I'm currently considering whether we should change the window icon used in KWin's killer helper (the dialog which gets shown when trying to close a hung

Jenkins build became unstable: plasma-workspace_master_qt5 #288

2014-05-27 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/288/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: [RFC] Which icon to use for kwin's killer helper

2014-05-27 Thread Aleix Pol
On Tue, May 27, 2014 at 4:55 PM, Martin Gräßlin mgraess...@kde.org wrote: On Tuesday 27 May 2014 16:21:11 Aleix Pol wrote: On Tue, May 27, 2014 at 3:37 PM, Martin Gräßlin mgraess...@kde.org wrote: Hi all, I'm currently considering whether we should change the window icon used in

Review Request 118357: Disable the agenda part of the calendar

2014-05-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/ --- Review request for Plasma. Repository: plasma-workspace Description

Jenkins build is back to stable : plasma-workspace_master_qt5 #289

2014-05-27 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/289/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58586 --- Ship it! Ship It! - Andrew Lake On May 27, 2014, 9:42

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread Andrew Lake
On May 27, 2014, 4:12 p.m., Andrew Lake wrote: Ship It! In case anyone is wondering why this arbitrary fellow said Ship It!, I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58588 --- I agree it makes sense, +1. Not adding ship it because the

Re: Review Request 118348: [klipper] Port KSaveFile - QSaveFile

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118348/ --- (Updated May 27, 2014, 4:48 p.m.) Status -- This change has been

Re: Review Request 118348: [klipper] Port KSaveFile - QSaveFile

2014-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118348/#review58591 --- This review has been submitted with commit

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58590 --- This review has been submitted with commit

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- (Updated May 27, 2014, 4:48 p.m.) Status -- This change has been

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58592 --- klipper/klipper.cpp

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Martin Gräßlin
On May 27, 2014, 7:10 p.m., Ömer Fadıl Usta wrote: klipper/klipper.cpp, line 888 https://git.reviewboard.kde.org/r/118351/diff/1/?file=275367#file275367line888 is this a forgotten KDialog or on purpose ? it's on purpose. This is currently dead code (see the #ifdef HAVE_PRISON),

Re: Review Request 105312: Add missing email addresses back into add widget tooltip.

2014-05-27 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105312/ --- (Updated May 27, 2014, 2:27 p.m.) Status -- This change has been

Review Request 118361: Don't hide Dialog when opening QMenu from it

2014-05-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread Christoph Feck
On May 27, 2014, 4:12 p.m., Andrew Lake wrote: Ship It! Andrew Lake wrote: In case anyone is wondering why this arbitrary fellow said Ship It!, I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread Andrew Lake
On May 27, 2014, 4:12 p.m., Andrew Lake wrote: Ship It! Andrew Lake wrote: In case anyone is wondering why this arbitrary fellow said Ship It!, I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

2014-05-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/#review58609 --- src/plasmaquick/dialog.cpp

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-27 Thread David Faure
On May 20, 2014, 3:08 p.m., Alexander Potashev wrote: You probably need to check in CMakeLists.txt that version of shared-mime-info is at least 0.40. Aurélien Gâteau wrote: shared-mime-info is only required at run time so I am not sure it makes sense to check at build time.

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/#review58611 --- Ship it! keditfiletype/mimetypedata.h

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

2014-05-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/#review58613 --- That's frickin' clever! We can remove a lot of hacks thanks

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 10:38 p.m.) Status -- This change has been

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58614 --- This review has been submitted with commit

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread David Edmundson
On May 27, 2014, 4:12 p.m., Andrew Lake wrote: Ship It! Andrew Lake wrote: In case anyone is wondering why this arbitrary fellow said Ship It!, I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG

Review Request 118367: Fix activities data engine by exporting toggleActivityManager method over DBus.

2014-05-27 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118367/ --- Review request for Plasma. Bugs: 335427