---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118382/#review58765
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118414/
---
Review request for kwin and Plasma.
Repository: kwin
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118414/#review58772
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 30, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118417/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118417/#review58779
---
Ship it!
Ship It!
- Marco Martin
On May 30, 2014, 10:22
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118417/#review58780
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118417/
---
(Updated May 30, 2014, 10:29 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118413/#review58778
---
Ship it!
On May 30, 2014, 10:42 a.m., David Edmundson wrote:
desktoppackage/contents/configuration/AppletConfiguration.qml, line 224
https://git.reviewboard.kde.org/r/118413/diff/1/?file=276339#file276339line224
is large/2 not just small ?
I have no idea, this was already there though.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118413/
---
(Updated May 30, 2014, 10:52 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118413/#review58786
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118419/
---
Review request for Plasma and Marco Martin.
Repository: plasma-workspace
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118419/#review58795
---
Ship it!
Ship It!
- Marco Martin
On May 30, 2014, 12:01
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118419/
---
(Updated May 30, 2014, 12:12 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118419/#review58796
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118421/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118421/#review58798
---
Ship it!
Ship It!
- Martin Klapetek
On May 30, 2014, 2:45
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118421/
---
(Updated May 30, 2014, 12:51 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118357/#review58803
---
Ship it!
Ship it since the changes look sane to me.
Mind
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118423/#review58802
---
klipper/urlgrabber.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118423/#review58804
---
klipper/urlgrabber.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118424/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118424/#review58805
---
Ship it!
Current behaviour is if you have something in your
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118357/#review58808
---
Ship it!
Since the visible flag is now static false, let's
On May 30, 2014, 3:21 p.m., David Edmundson wrote:
Current behaviour is if you have something in your clipboard on closing, it
will be there when you restart.
Can you confirm this still works before shipping.
sure, steps done:
1. recompiled and installed klipper
2. stopped running
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118424/#review58810
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118424/
---
(Updated May 30, 2014, 1:29 p.m.)
Status
--
This change has been
On May 30, 2014, 3:27 p.m., Sebastian Kügler wrote:
Since the visible flag is now static false, let's comment the agenda item
code, so we don't waste memory or CPU cycles. Once done, please ship.
I specifically opted out of commenting it as that would mean commenting stuff
all around
On May 30, 2014, 3:15 p.m., David Edmundson wrote:
klipper/urlgrabber.cpp, line 147
https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line147
this comment doesn't seem true, we explicitly check if the mimetype is
html
I read this comment different: if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118423/
---
(Updated May 30, 2014, 3:38 p.m.)
Review request for Plasma.
Changes
Hey,
First, thanks all for the reviews.
On Thursday, May 29, 2014 16:10:19 Andrew Lake wrote:
On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote:
Good improvements in general!
There are two changes which are not HIG-compliant:
- Control labels which are written next to the controls
On Thursday, May 29, 2014 15:09:33 Marco Martin wrote:
On Thursday 15 May 2014 11:39:00 Jens Reuterberg wrote:
Ok so after the feedback from the Beta Release an issue that we knew was
coming have happened. Visuals being the most easily accessible bit of
anything technical, people have
On Friday 30 May 2014 15:34:27 Sebastian Kügler wrote:
I'll not change to groupboxes in this review, but anticipate the HIG
catching up. :)
Yes, that's okay. We'll discuss the grouping HIG on our list. If we come out
with a different solution to what you implemented in the end, we'll notify
On May 30, 2014, 1:15 p.m., David Edmundson wrote:
klipper/urlgrabber.cpp, line 140
https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line140
we lose fast mode here.
I think this means if I drag a 100Gb file from the internet onto
klipper it will start
On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote:
Since the visible flag is now static false, let's comment the agenda item
code, so we don't waste memory or CPU cycles. Once done, please ship.
Martin Klapetek wrote:
I specifically opted out of commenting it as that would mean
On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote:
Since the visible flag is now static false, let's comment the agenda item
code, so we don't waste memory or CPU cycles. Once done, please ship.
Martin Klapetek wrote:
I specifically opted out of commenting it as that would mean
On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote:
File Attachment: Energy Saving page after -
powerdevil-kcm-profiles-after.png
https://git.reviewboard.kde.org/r/118390/#fcomment226
Why remove the icons? They make the individual settings recognizable
more quickly.
I don't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/
---
(Updated May 30, 2014, 2:19 p.m.)
Review request for Plasma, Solid and
See http://build.kde.org/job/plasma-workspace_master_qt5/317/changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
See http://build.kde.org/job/plasma-workspace_master_qt5/318/changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118417/#review58827
---
Shouldn't this rather use qCDebug() so that the output can be
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118428/
---
Review request for Plasma.
Repository: plasma-desktop
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118428/#review58830
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 30, 2014,
On Fri, May 30, 2014 at 6:44 AM, Sebastian Kügler wrote:
On Thursday, May 29, 2014 15:09:33 Marco Martin wrote:
just to give a shot on every and single options, i gave a try to
modifying
oxygen in order to make it look like breeze (therefore sharing all the
things that it does that are
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58836
---
Looks like there are still quite a few Title Case labels in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118340/
---
(Updated May 30, 2014, 11:42 p.m.)
Review request for KDE Frameworks,
46 matches
Mail list logo
