Re: 4.x transition blockage - workspace libs

2014-07-22 Thread Michael Palimaka
On 07/22/2014 06:10 AM, Martin Gräßlin wrote: On Tuesday 22 July 2014 05:28:36 Michael Palimaka wrote: On 07/18/2014 06:54 PM, Harald Sitter wrote: On Thu, Jul 17, 2014 at 1:37 PM, Michael Palimaka kensing...@gentoo.org wrote: I just discused this with mgraesslin on IRC and he's fine with

Re: Fallbacks for packages

2014-07-22 Thread Sebastian Kügler
On Monday, July 21, 2014 11:26:58 Marco Martin wrote: I have been thinking about the problem of the look and feel and shell packages: we want them to be easily customizable for distributions without forcing to copy and paste the mayority of the qml in the package (and also having things

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

2014-07-22 Thread Sebastian Kügler
On Monday, July 21, 2014 19:07:52 Martin Gräßlin wrote: On Monday 21 July 2014 16:40:48 David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/

Re: 4.x transition blockage - workspace libs

2014-07-22 Thread Sebastian Kügler
On Tuesday, July 22, 2014 19:09:26 Michael Palimaka wrote: On 07/22/2014 06:10 AM, Martin Gräßlin wrote: On Tuesday 22 July 2014 05:28:36 Michael Palimaka wrote: On 07/18/2014 06:54 PM, Harald Sitter wrote: wrote: I'm very interested in renaming libkworkspace in Plasma5 at a minimum.

Re: Review Request 118900: Improve dependencies.

2014-07-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118900/ --- (Updated July 22, 2014, 10:53 a.m.) Status -- This change has been

Re: Review Request 118638: Install bzip2 and LZMA filter and documentation based on available support in KArchive.

2014-07-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118638/ --- (Updated July 22, 2014, 10:57 a.m.) Status -- This change has been

[plasma-framework] src/desktoptheme/breeze: Optimize breeze theme

2014-07-22 Thread Aleix Pol
Git commit 0b1bb7edd84b77c4cf5baae8f9e59473c9265f26 by Aleix Pol. Committed on 22/07/2014 at 10:59. Pushed by apol into branch 'master'. Optimize breeze theme Breeze theme usually has borders and center that can be tiled, which ends up in more performant rendering, as we don't need to re-render

Re: Fallbacks for packages

2014-07-22 Thread Marco Martin
On Tuesday 22 July 2014 11:27:48 Sebastian Kügler wrote: And a last one, would be to just use two packages in the client code. It would be the solution i would normally prefer, but since the look and feel package is accessed by too many different processes, entry points, it would mean

Review Request 119402: Remove unused dependencies.

2014-07-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119402/ --- Review request for Plasma. Repository: powerdevil Description ---

Review Request 119404: Use full libexec location

2014-07-22 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119404/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 119384: Plasma-Active: Make widget explorer more friendly on touch devices.

2014-07-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119384/ --- (Updated July 22, 2014, 1:41 p.m.) Status -- This change has been

Re: Review Request 119402: Remove unused dependencies.

2014-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119402/#review62882 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 22, 2014,

Re: Review Request 119402: Remove unused dependencies.

2014-07-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119402/ --- (Updated July 22, 2014, 1:52 p.m.) Status -- This change has been

Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/#review62888 --- +1, this escentially means that it now will use the same code

Re: Review Request 119250: Events and trips according to date ranges

2014-07-22 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/ --- (Updated July 22, 2014, 3:28 p.m.) Status -- This change has been

Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 22, 2014, 3:40 p.m.) Review request for KDE Frameworks and

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/#review62891 --- src/scriptengines/qml/plasmoid/appletinterface.cpp

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555 Why can't you just call the method? You're not delaying it ah, no, because that thig is

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 22, 2014, 4:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Aleix Pol Gonzalez
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: Forgot to say, I think introducing a X-Plasma-Provides is ok. I guess that it will contain the concepts it's fulfilling, right? such as: X-Plasma-Provides=clock On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555 Why can't you just call the method? You're not delaying it Marco Martin wrote:

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Aleix Pol Gonzalez
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555 Why can't you just call the method? You're not delaying it Marco Martin wrote:

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555 Why can't you just call the method? You're not delaying it Marco Martin wrote:

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread David Edmundson
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555 Why can't you just call the method? You're not delaying it Marco Martin wrote:

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555 Why can't you just call the method? You're not delaying it Marco Martin wrote:

Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1

2014-07-22 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- Review request for Plasma. Repository: plasmate Description --- I

Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1

2014-07-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/#review62906 --- I have separated this task to two reviews, because there are

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/#review62911 --- Two issues: - Existing Dialog instances don't get the corner

Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1

2014-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/#review62912 --- plasmate/app/plasmateapp.cpp