---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119451/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119451/#review63040
---
Also another problem connected to this:
how to take the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119452/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119451/#review63037
---
lookandfeelaccess/lookandfeelaccess.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119452/#review63043
---
Ship it!
fine for me
- Marco Martin
On Lug. 24, 2014,
On July 24, 2014, 10:34 a.m., David Edmundson wrote:
lookandfeelaccess/lookandfeelaccess.cpp, line 89
https://git.reviewboard.kde.org/r/119451/diff/1/?file=292284#file292284line89
My concern is this will create more problems than it's worth.
Scenario:
- I add a
On July 24, 2014, 10:34 a.m., David Edmundson wrote:
lookandfeelaccess/shellpluginloader.h, line 31
https://git.reviewboard.kde.org/r/119451/diff/1/?file=292285#file292285line31
not used?
that is just the header 1:1 coming from libplasmaquick, usual old problem
- Marco
On July 24, 2014, 10:34 a.m., Marco Martin wrote:
I'd quite like to have a chat about the goals of look and feel (next Monday
meeting?). It was something where you guys clearly had a plan (or at least
a name) before I got more heavily involved in Plasma, and I'm really not on
the same
On July 24, 2014, 10:34 a.m., David Edmundson wrote:
lookandfeelaccess/lookandfeelaccess.cpp, line 89
https://git.reviewboard.kde.org/r/119451/diff/1/?file=292284#file292284line89
My concern is this will create more problems than it's worth.
Scenario:
- I add a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119425/#review63049
---
src/declarativeimports/core/framesvgitem.cpp
On July 24, 2014, 10:34 a.m., David Edmundson wrote:
lookandfeelaccess/lookandfeelaccess.cpp, line 89
https://git.reviewboard.kde.org/r/119451/diff/1/?file=292284#file292284line89
My concern is this will create more problems than it's worth.
Scenario:
- I add a
On July 24, 2014, 10:55 a.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 45
https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45
Having spoken to you offline this does make sense, but it needs
documentation as to why it's
On July 24, 2014, 10:55 a.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 45
https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45
Having spoken to you offline this does make sense, but it needs
documentation as to why it's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119425/
---
(Updated July 24, 2014, 11:14 a.m.)
Review request for Plasma.
Changes
On July 24, 2014, 12:34 p.m., David Edmundson wrote:
lookandfeelaccess/lookandfeelaccess.cpp, line 89
https://git.reviewboard.kde.org/r/119451/diff/1/?file=292284#file292284line89
My concern is this will create more problems than it's worth.
Scenario:
- I add a
On July 24, 2014, 10:55 a.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 45
https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45
Having spoken to you offline this does make sense, but it needs
documentation as to why it's
On July 24, 2014, 10:55 a.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 45
https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45
Having spoken to you offline this does make sense, but it needs
documentation as to why it's
On July 24, 2014, 10:55 a.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 45
https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45
Having spoken to you offline this does make sense, but it needs
documentation as to why it's
On July 24, 2014, 10:55 a.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 45
https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45
Having spoken to you offline this does make sense, but it needs
documentation as to why it's
On July 24, 2014, 10:55 a.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 45
https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45
Having spoken to you offline this does make sense, but it needs
documentation as to why it's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119452/
---
(Updated July 24, 2014, 3:40 p.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-desktop_master_qt5/487/changes
Changes:
[kensington] Fix header include to match plasma-workspace change.
--
[...truncated 2488 lines...]
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63086
---
Exciting!
Might this eventually support a ButtonStyle.qml
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63087
---
Concerning the icon names: for the Desktops Effects KCM the
On July 24, 2014, 4:18 p.m., Andrew Lake wrote:
Exciting!
Might this eventually support a ButtonStyle.qml in the plasma theme that
overrides the svg-based ButtonStyle if it's present? That way we could take
the already developed Breeze ButtonStyle.qml and just ship it in the
On July 24, 2014, 4:20 p.m., Martin Gräßlin wrote:
Concerning the icon names: for the Desktops Effects KCM the names are
working without me doing anything. So there must be a solution hidden in
the widgets emulating style.
yes, the native style figures out that internally, creates an
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 24, 2014, 4:31 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63091
---
On July 24, 2014, 4:56 p.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 41
https://git.reviewboard.kde.org/r/119455/diff/2/?file=292510#file292510line41
This isn't very declarative, is there a reason we can't do:
On July 24, 2014, 4:56 p.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 83
https://git.reviewboard.kde.org/r/119455/diff/2/?file=292510#file292510line83
style.labelImplicitWidth doesn't exist?
gah, leftover
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 24, 2014, 6:17 p.m.)
Review request for KDE Frameworks and
See http://build.kde.org/job/plasma-desktop_master_qt5/488/changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
33 matches
Mail list logo
