Re: Minimum translation percentage for Plasma 5 release

2014-08-11 Thread Franklin Weng
2014-08-12 2:37 GMT+08:00 Albert Astals Cid : > Hi, in the 4.x world we have something called "Essential Packages" for > translations that is basically a set of minimum percentage of some files > that > you need to get if you want the whole translation of your language to be > released with the 4.

Re: Review Request 119716: Handle the Return key on logout screen

2014-08-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119716/#review64334 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 11, 2014, 3

Re: Use of KDirWatch

2014-08-11 Thread Aleix Pol
On Mon, Aug 11, 2014 at 6:09 PM, Marco Martin wrote: > On Friday 08 August 2014, Eike Hein wrote: > > Hi, > > > > many things in Plasma use KDirWatch to keep an eye on changes, > > e.g. the theming and look-and-feel systems, and they usually > > go through the KDirWatch::self() instance. > > > >

Re: Review Request 119721: Don't explicitly set a height on button in notification delegate.

2014-08-11 Thread David Edmundson
> On Aug. 11, 2014, 9:35 p.m., Martin Klapetek wrote: > > Can you post a screenshot of a notification with three actions? > > Martin Klapetek wrote: > Note that the button still /has/ enough space for the text to fit in, it > is just ridiculously padded from top. Bah. It doesn't fit. >Not

Re: Review Request 119721: Don't explicitly set a height on button in notification delegate.

2014-08-11 Thread Martin Klapetek
> On Aug. 11, 2014, 11:35 p.m., Martin Klapetek wrote: > > Can you post a screenshot of a notification with three actions? Note that the button still /has/ enough space for the text to fit in, it is just ridiculously padded from top. - Martin

Re: Review Request 119721: Don't explicitly set a height on button in notification delegate.

2014-08-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119721/#review64329 --- Can you post a screenshot of a notification with three actions

Re: Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element

2014-08-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119683/ --- (Updated Aug. 11, 2014, 8:27 p.m.) Status -- This change has been ma

Re: Review Request 119721: Don't explicitly set a height on button in notification delegate.

2014-08-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119721/#review64326 --- "it'd be like complaining at LineEdit if you set the height to

Review Request 119721: Don't explicitly set a height on button in notification delegate.

2014-08-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119721/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element

2014-08-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119683/#review64322 --- Ship it! Ship It! - Marco Martin On Ago. 11, 2014, 7:16 p.

Jenkins build is back to stable : plasma-workspace_master_qt5 #724

2014-08-11 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119720: Streamline device notifier

2014-08-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119720/ --- (Updated Aug. 11, 2014, 7:18 p.m.) Status -- This change has been ma

Re: Review Request 119719: Streamline notifications plasmoid

2014-08-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119719/ --- (Updated Aug. 11, 2014, 7:18 p.m.) Status -- This change has been ma

Re: Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element

2014-08-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119683/ --- (Updated Aug. 11, 2014, 7:16 nachm.) Review request for Plasma. Changes

Re: Review Request 110216: Rename Screen Locker screensaver KCM to Lock Screen

2014-08-11 Thread Will Stephenson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110216/ --- (Updated ago. 11, 2014, 7:14 p.m.) Status -- This change has been di

Re: Review Request 110216: Rename Screen Locker screensaver KCM to Lock Screen

2014-08-11 Thread Albert Astals Cid
> On abr. 27, 2013, 2:09 p.m., Marco Martin wrote: > > Ship It! > > Albert Astals Cid wrote: > Janitorial dude question: Has this been commited and you forgot to mark > it as submitted or it does still need submitting? > > > Marco Martin wrote: > should still be committed > > Albert A

Re: Review Request 119720: Streamline device notifier

2014-08-11 Thread Marco Martin
> On Ago. 11, 2014, 6:36 p.m., Martin Klapetek wrote: > > Just a note - if you put this applet on the desktop, it won't have the big > > headline. I've asked a month ago if it should have the headline on the > > desktop too but I was told no, so maybe we want some "if (formFactor == > > deskto

Re: Review Request 109780: Enable following links/urls from the plasma notifications popup applet

2014-08-11 Thread Amín Guzmán Vargas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109780/ --- (Updated ago. 11, 2014, 7:08 p.m.) Status -- This change has been di

Re: Review Request 109780: Enable following links/urls from the plasma notifications popup applet

2014-08-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109780/#review64310 --- There is something like this already commited to 4.11 - Alber

Re: Review Request 119720: Streamline device notifier

2014-08-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119720/#review64309 --- Ship it! Ship It! - Marco Martin On Ago. 11, 2014, 6:25 p.

Re: Review Request 109711: Fixes a bug in the KDE dataengine to use the POST method instead of GET which allows large text to be sent to the server

2014-08-11 Thread Bhaskar Kandiyal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109711/ --- (Updated ago. 11, 2014, 7:06 p.m.) Status -- This change has been di

Re: Review Request 109711: Fixes a bug in the KDE dataengine to use the POST method instead of GET which allows large text to be sent to the server

2014-08-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109711/#review64308 --- This was fixed in commit a7d0ef49cb7839d42646334459f1140ed32c

Re: Minutes Monday Plasma Hangout

2014-08-11 Thread Marco Martin
On Monday 11 August 2014, Vishesh Handa wrote: > On Mon, Aug 11, 2014 at 12:40 PM, Sebastian Kügler wrote: > > Antonis: > > - finished port of PA's widget explorer and containment > > - New resource indexer based on Baloo merged > > Could someone please elaborate on this? I'm not sure what a "res

Re: Review Request 119719: Streamline notifications plasmoid

2014-08-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119719/#review64307 --- Ship it! Ship It! - Marco Martin On Ago. 11, 2014, 6:19 p.

Re: Review Request 119719: Streamline notifications plasmoid

2014-08-11 Thread Marco Martin
> On Ago. 11, 2014, 6:37 p.m., Martin Klapetek wrote: > > > I have no idea what's wrong with the action button. > > > > This broke since the port to QtQuick Controls' Button, not sure what to do > > about it tho > > Kai Uwe Broulik wrote: > Well, clearly the button's label does not honor t

Re: Review Request 119719: Streamline notifications plasmoid

2014-08-11 Thread Kai Uwe Broulik
> On Aug. 11, 2014, 6:37 nachm., Martin Klapetek wrote: > > > I have no idea what's wrong with the action button. > > > > This broke since the port to QtQuick Controls' Button, not sure what to do > > about it tho > > Kai Uwe Broulik wrote: > Well, clearly the button's label does not honor

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-08-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review64304 --- The patch does not apply. - Albert Astals Cid On mai. 15, 2

Re: Review Request 119719: Streamline notifications plasmoid

2014-08-11 Thread Martin Klapetek
> On Aug. 11, 2014, 8:37 p.m., Martin Klapetek wrote: > > > I have no idea what's wrong with the action button. > > > > This broke since the port to QtQuick Controls' Button, not sure what to do > > about it tho > > Kai Uwe Broulik wrote: > Well, clearly the button's label does not honor t

Re: Review Request 119719: Streamline notifications plasmoid

2014-08-11 Thread Kai Uwe Broulik
> On Aug. 11, 2014, 6:37 nachm., Martin Klapetek wrote: > > > I have no idea what's wrong with the action button. > > > > This broke since the port to QtQuick Controls' Button, not sure what to do > > about it tho Well, clearly the button's label does not honor the button's custom height as s

Re: Review Request 119719: Streamline notifications plasmoid

2014-08-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119719/#review64296 --- > I have no idea what's wrong with the action button. This br

Minimum translation percentage for Plasma 5 release

2014-08-11 Thread Albert Astals Cid
Hi, in the 4.x world we have something called "Essential Packages" for translations that is basically a set of minimum percentage of some files that you need to get if you want the whole translation of your language to be released with the 4.x SC. For KDE Frameworks we have decided to not have

Re: Review Request 119720: Streamline device notifier

2014-08-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119720/#review64295 --- Just a note - if you put this applet on the desktop, it won't

Review Request 119720: Streamline device notifier

2014-08-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119720/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 119719: Streamline notifications plasmoid

2014-08-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119719/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Jenkins build became unstable: plasma-workspace_master_qt5 #723

2014-08-11 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Minutes Monday Plasma Hangout

2014-08-11 Thread Vishesh Handa
On Mon, Aug 11, 2014 at 12:40 PM, Sebastian Kügler wrote: > Antonis: > - finished port of PA's widget explorer and containment > - New resource indexer based on Baloo merged > Could someone please elaborate on this? I'm not sure what a "resource indexer" means. -- Vishesh Handa _

Re: Review Request 119716: Handle the Return key on logout screen

2014-08-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119716/#review64287 --- - Martin Klapetek On Aug. 11, 2014, 5:24 p.m., Martin Klapet

Re: Review Request 119716: Handle the Return key on logout screen

2014-08-11 Thread Bhushan Shah
> On Aug. 11, 2014, 11:09 p.m., David Edmundson wrote: > > ! - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119716/#review64285 ---

Re: Review Request 119716: Handle the Return key on logout screen

2014-08-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119716/#review64285 --- - David Edmundson On Aug. 11, 2014, 3:24 p.m., Martin Klapet

Re: Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element

2014-08-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119683/#review64279 --- Almost good to go.. I wonder if the code would be slightly mor

Re: Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element

2014-08-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119683/ --- (Updated Aug. 11, 2014, 4:33 nachm.) Review request for Plasma. Changes

Re: Use of KDirWatch

2014-08-11 Thread Marco Martin
On Friday 08 August 2014, Eike Hein wrote: > Hi, > > many things in Plasma use KDirWatch to keep an eye on changes, > e.g. the theming and look-and-feel systems, and they usually > go through the KDirWatch::self() instance. > > The gotcha with using the shared instance is that slots > connected t

Re: Plasma 5.0.1 tars

2014-08-11 Thread Jonathan Riddell
Another update for baloo to add missing translations baloo;Plasma/5.0;4716974883972bed034ce9437489878248eff58d;baloo-5.0.1.tar.xz;9488a948b20b50bf46cba432912bc9f0cf7660b25d2d37520a8aa4382a0365e5 http://starsky.19inch.net/~jr/tmp/plasma-5.0.1/baloo-5.0.1.tar.xz coming soon to depot.. Jonathan _

Review Request 119716: Handle the Return key on logout screen

2014-08-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119716/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Minutes Monday Plasma Hangout

2014-08-11 Thread Marco Martin
On Monday 11 August 2014, Martin Gräßlin wrote: > > so, either lookandfeelaccess becomes a public library or gets copied in > > plasma-desktop.. > > > > opinions? > > plasma-desktop on first look sounds wrong to me as we probably want to have > look and feel also for other form factors, don't we

Re: Re: Minutes Monday Plasma Hangout

2014-08-11 Thread Martin Gräßlin
On Monday 11 August 2014 14:11:21 Marco Martin wrote: > On Monday 11 August 2014, Sebastian Kügler wrote: > > - Working on Look&Feel KCM > > One thing I would like to hear opinions about on this is: > the look and feel kcm depends from 2 things inside 2 repositories: > * the lookandfeelaccess clas

Re: Minutes Monday Plasma Hangout

2014-08-11 Thread Marco Martin
On Monday 11 August 2014, Sebastian Kügler wrote: > - Working on Look&Feel KCM One thing I would like to hear opinions about on this is: the look and feel kcm depends from 2 things inside 2 repositories: * the lookandfeelaccess class inside plasma-workspace, that at the moment is static * from pl

Re: Minutes Monday Plasma Hangout

2014-08-11 Thread Ivan Čukić
> Ivan: > - Per-activity favourites being discussed on the list > -> needs community-wide decision, see plasma-devel > - KWindowSystem can now set activities > - will port activities KCM - kamd plugins ported to kf5 (virtual desktop switching, and activity switching keyboard shortcuts) -- Chee

Re: Re: Re: OSD above fullscreen windows

2014-08-11 Thread Martin Gräßlin
On Monday 11 August 2014 12:48:30 Martin Klapetek wrote: > On Mon, Aug 11, 2014 at 11:51 AM, Martin Gräßlin wrote: > > honestly: no. There's a reason for the way it is and I'm quite sure we > > discussed it. If the arguments (e.g. private chat going over presentation) > > do > > not apply for OSD

Re: Re: OSD above fullscreen windows

2014-08-11 Thread Martin Klapetek
On Mon, Aug 11, 2014 at 11:51 AM, Martin Gräßlin wrote: > > honestly: no. There's a reason for the way it is and I'm quite sure we > discussed it. If the arguments (e.g. private chat going over presentation) > do > not apply for OSD then we have to realize that a OSD needs a dedicated > window >

Minutes Monday Plasma Hangout

2014-08-11 Thread Sebastian Kügler
Minutes Plasma Hangout, 11-8-2014 Present: Antonis, Marco, Jonathan, Marco, Martin G., Sebas Antonis: - finished port of PA's widget explorer and containment - New resource indexer based on Baloo merged Ivan: - Per-activity favourites being discussed on the list -> needs community-wide decision

Re: Re: OSD above fullscreen windows

2014-08-11 Thread Martin Gräßlin
On Monday 11 August 2014 11:14:09 Martin Klapetek wrote: > On Mon, Aug 11, 2014 at 8:48 AM, Martin Gräßlin wrote: > > On Sunday 10 August 2014 23:23:13 Kai Uwe Broulik wrote: > > > Hi there, > > > > > > I might have missed that in the discussion but is it deliberate that the > > > > OSD > > > >

Re: Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element

2014-08-11 Thread Kai Uwe Broulik
> On Aug. 9, 2014, 7:06 nachm., David Edmundson wrote: > > >It only uses arrow-top so might give issues with themes that have > > >different arrow looks(?) > > > > Yeah, that's quite a concern. One possible solution is to only rotate if > > there is only a up arrow element. That might mean upd

Re: Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element

2014-08-11 Thread Martin Klapetek
> On Aug. 9, 2014, 9:06 p.m., David Edmundson wrote: > > >It only uses arrow-top so might give issues with themes that have > > >different arrow looks(?) > > > > Yeah, that's quite a concern. One possible solution is to only rotate if > > there is only a up arrow element. That might mean updat

Re: OSD above fullscreen windows

2014-08-11 Thread Martin Klapetek
On Mon, Aug 11, 2014 at 8:48 AM, Martin Gräßlin wrote: > On Sunday 10 August 2014 23:23:13 Kai Uwe Broulik wrote: > > Hi there, > > > > I might have missed that in the discussion but is it deliberate that the > OSD > > doesn't raise itself above fullscreen windows? > > > > I found it uncomfortabl

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-08-11 Thread Martin Gräßlin
> On Aug. 11, 2014, 8:35 a.m., Martin Gräßlin wrote: > > I highly suggest to revert this change. Enforcing GLES means limiting to > > GLES (it's a subset after all) and also not all drivers do support GLES - > > that's still the smaller part. We are calling for lots of trouble if we go > > thi

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-08-11 Thread Aleix Pol Gonzalez
> On Aug. 11, 2014, 6:35 a.m., Martin Gräßlin wrote: > > I highly suggest to revert this change. Enforcing GLES means limiting to > > GLES (it's a subset after all) and also not all drivers do support GLES - > > that's still the smaller part. We are calling for lots of trouble if we go > > thi

Re: Review Request 119669: Fix broken creation of kstartupconfigfiles

2014-08-11 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119669/#review64233 --- Ship it! Once issue is fix, good to go! startkde/kstartupco