Re: Review Request 112208: KMix qml applet

2014-08-18 Thread Christian Esken
> On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote: > > For me it looks fine, with some questions: > > 1) Is this completely decoupled from KMix? I do not see a "open mixer" to > > open the main application. > > 2) Is it supposed to be integrated in KMix > > 3) In general, the question is how

Re: Review Request 119837: Fix keyboard navigation in lockscreen

2014-08-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119837/ --- (Updated Aug. 18, 2014, 11:08 p.m.) Review request for Plasma. Changes

Review Request 119837: Fix keyboard navigation in lockscreen

2014-08-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119837/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Eike Hein
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-18 Thread Bernd Steinhauser
> On June 26, 2014, 11:49 a.m., Hugo Pereira Da Costa wrote: > > Ship It! > > Hugo Pereira Da Costa wrote: > Ping ? Should I commit this myself ? Yes, please commit this. I don't have commit access myself. - Bernd --- This is an au

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Marco Martin
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119738/ --- (Updated Aug. 18, 2014, 5:34 p.m.) Status -- This change has been ma

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

2014-08-18 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/ --- (Updated Aug. 18, 2014, 5:27 p.m.) Review request for Plasma, Shantanu Tu

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119738/#review64785 --- Ship it! Good to me. - David Edmundson On Aug. 18, 2014, 5

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119738/ --- (Updated Aug. 18, 2014, 5:18 nachm.) Review request for Plasma. Changes

Re: Re: Re: Wayland protocols

2014-08-18 Thread Martin Gräßlin
On Monday 18 August 2014 17:48:03 Pier Luigi wrote: > 2014-08-15 7:35 GMT+02:00 Martin Gräßlin : > > On Thursday 14 August 2014 21:05:01 Marco Martin wrote: > >> On Thursday 14 August 2014, Pier Luigi wrote: > >> > Hi, > >> > > >> > Just pushed some initial draft of the Wayland protocols on Github

Re: Re: Wayland protocols

2014-08-18 Thread Pier Luigi
2014-08-18 17:48 GMT+02:00 Pier Luigi : > 2014-08-15 7:35 GMT+02:00 Martin Gräßlin : >> some more thoughts: >> * set_overlay_role: should we make the name more explicit: >> set_on_screen_display_role? > > I like set_overlay_role (well the overlay enum value for > set_surface_role now), less verbose

Re: Re: Wayland protocols

2014-08-18 Thread Pier Luigi
2014-08-15 7:35 GMT+02:00 Martin Gräßlin : > On Thursday 14 August 2014 21:05:01 Marco Martin wrote: >> On Thursday 14 August 2014, Pier Luigi wrote: >> > Hi, >> > >> > Just pushed some initial draft of the Wayland protocols on Github [1] >> > >> > I need people with knowledge of KF5 and plasmashel

Re: Re: Wayland protocols

2014-08-18 Thread Martin Gräßlin
On Monday 18 August 2014 17:21:55 Pier Luigi wrote: > 2014-08-15 7:25 GMT+02:00 Martin Gräßlin : > > On Thursday 14 August 2014 19:21:54 Pier Luigi wrote: > >> Hi, > >> > >> Just pushed some initial draft of the Wayland protocols on Github [1] > >> > >> I need people with knowledge of KF5 and pla

Re: OSD above fullscreen windows

2014-08-18 Thread Martin Klapetek
On Thu, Aug 14, 2014 at 12:03 PM, Thomas Pfeiffer wrote: > > I'm all for putting OSDs on a screen edge rather than the center in > general, > but the Plasma team has decided to put them in the center, and iirc you > guys > had a plausible reason for that (though I don't remember the exact reason

Re: Wayland protocols

2014-08-18 Thread Pier Luigi
2014-08-15 7:25 GMT+02:00 Martin Gräßlin : > On Thursday 14 August 2014 19:21:54 Pier Luigi wrote: >> Hi, >> >> Just pushed some initial draft of the Wayland protocols on Github [1] >> >> I need people with knowledge of KF5 and plasmashell to comment it and >> suggest improvements. >> >> As we are

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Eike Hein
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Aleix Pol Gonzalez
> On Aug. 18, 2014, 2:24 p.m., Aleix Pol Gonzalez wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 32 > > > > > > I don't see who is setting the value for capsLockOn, did I miss > > something? > >

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Marco Martin
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Dan Vrátil
> On Aug. 18, 2014, 4:24 p.m., Aleix Pol Gonzalez wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 32 > > > > > > I don't see who is setting the value for capsLockOn, did I miss > > something? > >

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64758 --- lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 119794: Add button to change keyboard layout in the lockscreen

2014-08-18 Thread Dan Vrátil
> On Aug. 16, 2014, 1:58 p.m., Emmanuel Pescosta wrote: > > lookandfeel/contents/components/KeyboardLayout.qml, line 28 > > > > > > really?! ;) Ooops, copy paste :) > On Aug. 16, 2014, 1:58 p.m., Emmanuel Pesco

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:21 p.m.) Review request for Plasma. Repositor

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Dan Vrátil
> On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 63 > > > > > > units.largeSpacing * 15 > > > > Nonetheless, that looks wrong to me, don't we

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:19 p.m.) Review request for Plasma. Changes -

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Ivan Čukić
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Eike Hein
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Marco Martin
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Eike Hein
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Marco Martin
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Look and feel stuff

2014-08-18 Thread Marco Martin
On Monday 18 August 2014, Sebastian Kügler wrote: > On Monday, August 18, 2014 14:12:33 Marco Martin wrote: > > so... please test it, especially how the kcm behaves when is closed and > > reopened and how behaves when changing the theme. > > there are now a couple of bugs that may be quite showstop

Re: Review Request 119817: Display notification popup at the top for top panel

2014-08-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119817/#review64740 --- Ship it! Pretty cool, thanks! - Martin Klapetek On Aug. 17

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-18 Thread Hugo Pereira Da Costa
> On June 26, 2014, 11:49 a.m., Hugo Pereira Da Costa wrote: > > Ship It! Ping ? Should I commit this myself ? - Hugo --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#review61017

Re: Look and feel stuff

2014-08-18 Thread Sebastian Kügler
On Monday, August 18, 2014 14:12:33 Marco Martin wrote: > so... please test it, especially how the kcm behaves when is closed and > reopened and how behaves when changing the theme. > there are now a couple of bugs that may be quite showstopper: > https://bugreports.qt-project.org/browse/QTBUG-370

Re: Review Request 119822: QScreen backend for libkscreen

2014-08-18 Thread Sebastian Kügler
> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > Besides the nitpits, here is a concern I have. > > > > KScreen is a library that should be used only by components of the shell > > (kwin, plasma, kscreen), the idea is to have a library that manipulates > > lowlevel stuff directly so we

Look and feel stuff

2014-08-18 Thread Marco Martin
Hi all, now, the look and feel selection KCM is merged. one thing to note, the name of the default l&f package is now org.kde.breeze.desktop (still open to renames until next frameworks release, so if you have issues with the name please speak now) ui-wise is still very simple, just a thumbnail

Re: Should favourites be shared between launchers, and launcher instances?

2014-08-18 Thread Sebastian Kügler
On Sunday, August 10, 2014 17:48:35 Ivan Čukić wrote: > It would be nice if we could collect the pros and cons of the different > options, and later decide which one has the most benefits compared to > downsides. My opinion, in short: The patch that went in was fine. To me, Kickoff's favorites ar

Re: Review Request 119822: QScreen backend for libkscreen

2014-08-18 Thread Martin Gräßlin
> On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: > > Besides the nitpits, here is a concern I have. > > > > KScreen is a library that should be used only by components of the shell > > (kwin, plasma, kscreen), the idea is to have a library that manipulates > > lowlevel stuff directly so we c

Re: Review Request 119822: QScreen backend for libkscreen

2014-08-18 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/#review64727 --- Besides the nitpits, here is a concern I have. KScreen is a l

Minutes Monday Plasma Hangout

2014-08-18 Thread Sebastian Kügler
Minutes Plasma Hangout, 18-8-2014 Present: Aleix, Antonis, Alex, David, Ivan, Kai Uwe, Marco, Vishesh, Martin G., Sebas For updates on TODO/status, see also Kanban board at: https://todo.kde.org/?controller=board&action=show&project_id=13 Aleix: - SDK discussions in Randa - Discussion about CI

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated Aug. 18, 2014, 11:48 a.m.) Status -- This change has been m

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Marco Martin
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Eike Hein
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: kdeplasma-addons

2014-08-18 Thread Aleix Pol
On Sat, Aug 16, 2014 at 2:34 PM, David Edmundson wrote: > Unless there are any objections my plan is: > > - Merge to master on Monday > (merge may be just renaming renaming the current branch) > > - Dropped plasmoids will be deleted > > - Only things which are finished (and pass my reviews) by

Re: Customized default behavior for new plasmoids and other KDE applications, how to do this?

2014-08-18 Thread Mario Fux
Am Donnerstag, 14. August 2014, 16.10:11 schrieb Aaron Peterson: > Hi, Morning Aaron I think you're searching this: https://techbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting griits Mario > I am a user experience and user interface enthusiast. > > I do a lot of Kubuntu installs,

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Ivan Čukić
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Eike Hein
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/ --- (Updated Aug. 18, 2014, 9:35 a.m.) Status -- This change has been ma

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-18 Thread Ivan Čukić
> On Aug. 17, 2014, 2:36 p.m., Eike Hein wrote: > > Looks good, but: I'm aware of at least one downstream that would like to > > hide activities support from plasmashell for complexity reasons. Is there a > > way to disable activities support, and does it have an API we could use to > > condit

Review Request 119822: QScreen backend for libkscreen

2014-08-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/ --- Review request for Plasma and Solid. Repository: libkscreen Description

Review Request 119822: QScreen backend for libkscreen

2014-08-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/ --- Review request for Plasma and Solid. Repository: libkscreen Description

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/#review64717 --- Ship it! See comments first. src/declarativeimports/plasmac

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/ --- (Updated Aug. 18, 2014, 9:25 a.m.) Review request for KDE Frameworks and

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread David Edmundson
> On Aug. 14, 2014, 4:58 p.m., David Edmundson wrote: > > applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 > > > > > > we don't need the i18n here, we'd be trying to translate an already > > tran

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread Marco Martin
> On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 30 > > > > > > I can see why you're doing this but I think this approach is

Re: kwin compile broken with qt5.4

2014-08-18 Thread Martin Gräßlin
On Monday 18 August 2014 10:56:19 Treeve Jelbert wrote: > FAILED: /var/lib/sorcery/build/c++ -DKCOREADDONS_LIB - > DKDE_DEFAULT_DEBUG_AREA=1212 -DQT_CONCURRENT_LIB - > DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB - > DQT_NETWORK_LIB -DQT_NO_DEBUG -D > QT_QML_LIB -DQT_Q

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Kai Uwe Broulik
> On Aug. 18, 2014, 8:55 vorm., Martin Klapetek wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 162 > > > > > > Thinking about the label... > > > > What if we'd remove the "Warning: " par

kwin compile broken with qt5.4

2014-08-18 Thread Treeve Jelbert
FAILED: /var/lib/sorcery/build/c++ -DKCOREADDONS_LIB - DKDE_DEFAULT_DEBUG_AREA=1212 -DQT_CONCURRENT_LIB - DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB - DQT_NETWORK_LIB -DQT_NO_DEBUG -D QT_QML_LIB -DQT_QUICK_LIB -DQT_SCRIPT_LIB -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64713 --- lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Dan Vrátil
> On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, lines 166-167 > > > > > > So you tell it to be centered horizontally, and wrap, but a maximum of > > one

JS/QML Plasmoid How I can add global shortcuts?

2014-08-18 Thread smith AR
Hello greetings. Currently I have a doubt that I want to confirm. I am developing a plasmoid at JS/QML to KDE 4.x, and I have the idea to create a global keyboard shortcuts to the applet /http://kde-apps.org/content/show.php/PlayBar?content=165396/[1] But I was limited because it seems that

Re: Minimum translation percentage for Plasma 5 releases (second take)

2014-08-18 Thread Chusslove Illich
> [: Albert Astals Cid :] > Of course, read the subject, we are speaking about Plasma here, not about > random applications [...] I did consider the subject, but through other messages I got a feeling the discussion had broadened. For my part, I don't see why we would ponder about this for Plasma

Re: Wayland protocols

2014-08-18 Thread Ivan Čukić
On Monday 18 August 2014 09:22:03 Martin Gräßlin wrote: > On Monday 18 August 2014 09:02:07 Pier Luigi wrote: > > > Activities should probably be also exposed to the kf5_window interface? > > > > What do you need for activities? > > @Ivan: that falls into your domain - what do you want? Apart fr

Re: Re: Wayland protocols

2014-08-18 Thread Martin Gräßlin
On Monday 18 August 2014 09:02:07 Pier Luigi wrote: > > Activities should probably be also exposed to the kf5_window interface? > > What do you need for activities? @Ivan: that falls into your domain - what do you want? Cheers Martin signature.asc Description: This is a digitally signed messa

Re: Wayland protocols

2014-08-18 Thread Pier Luigi
2014-08-15 7:49 GMT+02:00 Martin Gräßlin : > On Thursday 14 August 2014 19:21:54 Pier Luigi wrote: >> Hi, >> >> Just pushed some initial draft of the Wayland protocols on Github [1] >> >> I need people with knowledge of KF5 and plasmashell to comment it and >> suggest improvements. >> >> As we are

Re: Wayland protocols

2014-08-18 Thread Pier Luigi
2014-08-15 7:47 GMT+02:00 Martin Gräßlin : > On Thursday 14 August 2014 19:21:54 Pier Luigi wrote: >> Hi, >> >> Just pushed some initial draft of the Wayland protocols on Github [1] >> >> I need people with knowledge of KF5 and plasmashell to comment it and >> suggest improvements. >> >> As we are