---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120276/#review66919
---
Hey, thanks for working on this! Couple remarks below, but
On Sept. 19, 2014, 10:24 a.m., Martin Klapetek wrote:
dataengines/comic/comicprovider.h, lines 37-39
https://git.reviewboard.kde.org/r/120276/diff/1/?file=313373#file313373line37
Let's remove this macro, it's not just a substitute for
K_PLUGIN_FACTORY. So remove and replace usage
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---
Review request for Plasma.
Repository: kinfocenter
Description
---
Hi plasma-devs,
as discussed on Monday's hangout I split out KWin's Wayland handling code into
a dedicated repository and library:
git clone kde:kwayland
The repository provides two libraries:
* Client
* Server
At the moment Server doesn't get installed, but is used for the auto-tests of
the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---
Modules/base/info_wayland.cpp
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66928
---
Modules/base/info_wayland.cpp
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
On Sept. 19, 2014, 11:53 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 194
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line194
aren't we doing this in the ctor too?
good spot, I moved the code later-on to the class and oversaw that
On Sept. 18, 2014, 10:11 p.m., Aleix Pol Gonzalez wrote:
Shouldn't it be called SimpleCorona? Or maybe WindowedCorona?
It's not a shell anymore, in this case.
hmm, maybe. technically it is since it loads plasmoids.
but yeah, windowedcorona sounds good, +1
- Marco
On Sept. 19, 2014, 4:30 a.m., Bhushan Shah wrote:
plasma-windowed/simpleshellview.cpp, line 36
https://git.reviewboard.kde.org/r/120270/diff/1/?file=313276#file313276line36
This should come from arguments maybe? and should not be Plasma
mediacenter obviously.. :p
eww, forgot it,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---
(Updated Sept. 19, 2014, 12:49 p.m.)
Review request for Plasma.
Hi all,
After the discussions done at akademy and here about a standalone framework
for Package, due to the potential interest by other applications in order to
ship their own scripts/extensions/themes/graphics assets i did the surgical
operation, after living for a while in scratch it's now in
Martin GräßlinOn Friday 19 September 2014 11:06:56 wrote:
Hi plasma-devs,
Once the CI system is in place for the new library I will migrate KWin over
to it.
this is now done [1]:
62 files changed, 106 insertions(+), 8831 deletions(-)
Cheers
Martin
[1]
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120284/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120284/#review66950
---
Ship it!
Good catch, just a detail I would do differently.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120050/
---
(Updated Sept. 19, 2014, 12:53 p.m.)
Review request for Plasma.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120284/
---
(Updated Sept. 19, 2014, 1:19 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120284/#review66954
---
Ship it!
Ship It!
- Marco Martin
On Sept. 19, 2014, 1:19
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119764/#review66956
---
Ship it!
Makes sense to me and seems to work well in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120050/
---
(Updated Sept. 19, 2014, 2:08 p.m.)
Review request for Plasma.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120284/
---
(Updated Sept. 19, 2014, 2:04 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120050/#review66959
---
Ship it!
Ship It!
- Marco Martin
On Sept. 19, 2014, 2:08
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120050/
---
(Updated Sept. 19, 2014, 2:28 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120276/
---
(Updated Sept. 19, 2014, 10:15 p.m.)
Review request for Plasma, David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120276/#review66978
---
You need to select the Update diff to update the diff, not
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120276/
---
(Updated Sept. 19, 2014, 10:17 p.m.)
Review request for Plasma, David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120276/
---
(Updated Sept. 19, 2014, 10:17 p.m.)
Review request for Plasma, David
On Sept. 19, 2014, 10:17 p.m., Martin Klapetek wrote:
You need to select the Update diff to update the diff, not Add file ;)
Done :)
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120276/#review66979
---
Progressing nicely. A piece of advice - leave the codestyle
On Sept. 19, 2014, 10:33 p.m., Martin Klapetek wrote:
dataengines/comic/comic_package.cpp, line 49
https://git.reviewboard.kde.org/r/120276/diff/2/?file=313492#file313492line49
You're building this class as MODULE (ie. a plugin) but you don't
define any plugin macro
On Sept. 19, 2014, 10:33 p.m., Martin Klapetek wrote:
dataengines/comic/comic_package.cpp, line 49
https://git.reviewboard.kde.org/r/120276/diff/2/?file=313492#file313492line49
You're building this class as MODULE (ie. a plugin) but you don't
define any plugin macro
On Sept. 19, 2014, 9:33 p.m., Martin Klapetek wrote:
dataengines/comic/comic_package.cpp, line 49
https://git.reviewboard.kde.org/r/120276/diff/2/?file=313492#file313492line49
You're building this class as MODULE (ie. a plugin) but you don't
define any plugin macro
35 matches
Mail list logo
