Re: System tray icon sizes

On Sunday 21 September 2014, Andrew Lake wrote: > On Sun, Sep 21, 2014 at 2:06 AM, Marco Martin wrote: > > Btw, since we are refining systray icons, do they work also on a size of > > 22x22(if not I'll fix the code)? I would love to get rid of the old hack > > of 24x24, that is just a remnant of t

Re: System tray icon sizes

On Sunday 21 September 2014, Kai Uwe Broulik wrote: > > Btw, since we are refining systray icons, do they work also on a size of > > 22x22(if not I'll fix the code)? I would love to get rid of the old hack > > of 24x24, that is just a remnant of the xembed legacy icons > > Is that the reason why e

Re: KPackage framework in playground

Hi Marco, is kpackage successfully building on Linux already? I tried this on my OSX/CI system and got an error… Are you interested in me reporting about build issues on OSX already, or is this still too early? Greets, Marko ___ Plasma-devel mailing

Re: KPackage framework in playground

On Friday 19 September 2014, Marko Käning wrote: > Hi Marco, > > is kpackage successfully building on Linux already? > > I tried this on my OSX/CI system and got an error… > > Are you interested in me reporting about build issues on OSX already, or is > this still too early? yes, here builds fi

Minutes Monday Plasma Hangout

Minutes Plasma Hangout, 22-9-2014 Present: Jens, Marco, Martin K., Martin G., Kai Uwe, Sebas, Vishesh, Jonathan For updates on TODO/status, see also Kanban board at: https://todo.kde.org/?controller=board&action=show&project_id=13 Kai Uwe: - doing reviews - nagging mck182 about notifications a

Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Minutes Monday Plasma Hangout

On Monday 22 September 2014, Sebastian Kügler wrote: > Marco: > - continued refactoring dialog class with Vishesh > - has been testing gerrit for patch reviews > - standalone framework for Plasma::Package is in playground (git clone > kde:kpackage) - standalone application mode for plasmashell, in

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 12:56 p.m.) Review request for Plasma. Changes

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 1:05 p.m.) Review request for Plasma. Changes

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67181 --- Thanks for your work! :) applets/digital-clock/package/conte

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 2:55 p.m.) Review request for Plasma. Changes

Re: 5.0.2 candidate tars

On Thu, Sep 18, 2014 at 02:07:16PM +0200, David Edmundson wrote: >We seem to be missing tagsA a**for 5.0.1 and 5.02 in the plasma-workspace >repo (not checked others) tags pushed, sorry for the delay Jonathan ___ Plasma-devel mailing list Plasm

Re: Review Request 120279: Port to KWayland client library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 22, 2014, 3:46 p.m.) Review request for Plasma. Changes

Re: Review Request 120279: Port to KWayland client library

> On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote: > > Modules/base/info_wayland.cpp, line 289 > > > > > > Why make this a function and use it once? It seems rather pointless. > > Martin Gräßlin wrote: >

Re: Review Request 120279: Port to KWayland client library

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote: > > Modules/base/info_wayland.cpp, line 236 > > > > > > This will add a row when the keyboard is added, but won't delete it > > when you remove it. > >

Review Request 120316: standalone application mode for plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 120279: Port to KWayland client library

> On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote: > > Modules/base/info_wayland.cpp, line 236 > > > > > > This will add a row when the keyboard is added, but won't delete it > > when you remove it. > >

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 4:33 p.m.) Review request for Plasma. Changes

Re: Review Request 120279: Port to KWayland client library

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote: > > Modules/base/info_wayland.cpp, line 236 > > > > > > This will add a row when the keyboard is added, but won't delete it > > when you remove it. > >

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67205 --- The following steps lead to unexpected behavior for me: a) Ad

Review Request 120318: PoC: Package Manager integration for the AppsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Des

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67207 --- Hmm, overall approach seems fine I think :). Using the executa

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

> On Sept. 22, 2014, 3:05 p.m., Eike Hein wrote: > > Hmm, overall approach seems fine I think :). Using the executable as search > > key might not always find the right package, but then using the desktop > > file name isn't any more reliable, and the user can use muon-discover to > > check th

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 3:34 p.m.) Review request for Plasma and Eike He

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67209 --- I like the idea! Suggestion for the "which package manager to

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

> On Sept. 22, 2014, 3:38 p.m., Martin Gräßlin wrote: > > I like the idea! > > > > Suggestion for the "which package manager to use" part: add a package > > manager selection to the defaults application KCM and use the one which is > > configured there. Distros should be able to easily configu

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

> On Sept. 22, 2014, 5:38 p.m., Martin Gräßlin wrote: > > I like the idea! > > > > Suggestion for the "which package manager to use" part: add a package > > manager selection to the defaults application KCM and use the one which is > > configured there. Distros should be able to easily configu

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

> On Sept. 22, 2014, 3:38 p.m., Martin Gräßlin wrote: > > I like the idea! > > > > Suggestion for the "which package manager to use" part: add a package > > manager selection to the defaults application KCM and use the one which is > > configured there. Distros should be able to easily configu

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

> On Sept. 22, 2014, 3:38 nachm., Martin Gräßlin wrote: > > I like the idea! > > > > Suggestion for the "which package manager to use" part: add a package > > manager selection to the defaults application KCM and use the one which is > > configured there. Distros should be able to easily confi

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

> On Sept. 22, 2014, 3:38 p.m., Martin Gräßlin wrote: > > I like the idea! > > > > Suggestion for the "which package manager to use" part: add a package > > manager selection to the defaults application KCM and use the one which is > > configured there. Distros should be able to easily configu

[muon/frameworks] discover: Port Muon Discover away from PlasmaComponents

Git commit 5a331be3e90abb3e2fa942deb11347d33986c187 by Aleix Pol. Committed on 22/09/2014 at 16:57. Pushed by apol into branch 'frameworks'. Port Muon Discover away from PlasmaComponents Depending on org.kde.plasma.* components is problematic at the moment as plasma-framework is not coinstallable

Re: Review Request 120316: standalone application mode for plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 22, 2014, 6 p.m.) Review request for Plasma. Changes ---

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

> On Sept. 22, 2014, 3:38 nachm., Martin Gräßlin wrote: > > I like the idea! > > > > Suggestion for the "which package manager to use" part: add a package > > manager selection to the defaults application KCM and use the one which is > > configured there. Distros should be able to easily confi

Re: Review Request 120316: standalone application mode for plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 22, 2014, 6:27 p.m.) Review request for Plasma. Reposito

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67225 --- I think scaling could use a little more love: ![http://wstaw.

Re: Review Request 120314: Add timezones support into clock applet

> On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: > > I think scaling could use a little more love: > > > >  > > > > Specifically, notice how the time part isn't of uniform size. I guess it > > gets scaled to fit in with the city text si

Re: Review Request 120318: PoC: Package Manager integration for the AppsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 7:09 p.m.) Status -- This change has been m

Build failed in Jenkins: plasma-desktop_master_qt5 #637

See Changes: [hein] Add a context menu action to remove applications. -- [...truncated 2662 lines...] :125:48:

Jenkins build is back to normal : plasma-desktop_master_qt5 #638

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120314: Add timezones support into clock applet

> On Sept. 22, 2014, 9:03 p.m., Eike Hein wrote: > > I think scaling could use a little more love: > > > >  > > > > Specifically, notice how the time part isn't of uniform size. I guess it > > gets scaled to fit in with the city text si

Re: Review Request 120314: Add timezones support into clock applet

> On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: > > I think scaling could use a little more love: > > > >  > > > > Specifically, notice how the time part isn't of uniform size. I guess it > > gets scaled to fit in with the city text si

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 11:59 p.m.) Review request for Plasma. Changes

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67238 --- Patch doesn't apply cleanly to master: The next patch would

Re: Review Request 120314: Add timezones support into clock applet

> On Sept. 22, 2014, 10:18 p.m., Eike Hein wrote: > > Patch doesn't apply cleanly to master: > > > > > > The next patch would delete the file > > a/applets/digital-clock/plugin/processrunnerplugin.h, > > which does not exist! Assume -R? [n] Uh never mind - fat-fingered the patch level. It's

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67240 --- I can no longer reproduce my problem from earlier, but note it

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67241 --- Place names with multiple names use _ as word separator, and d

Re: Review Request 120314: Add timezones support into clock applet

> On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: > > I think scaling could use a little more love: > > > >  > > > > Specifically, notice how the time part isn't of uniform size. I guess it > > gets scaled to fit in with the city text si

Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---

Re: Review Request 120222: When the button is being pressed draw background like it has focus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120222/#review67247 --- bump. - David Edmundson On Sept. 15, 2014, 6:29 p.m., David

Re: Review Request 120222: When the button is being pressed draw background like it has focus

> On Sept. 22, 2014, 11:06 p.m., David Edmundson wrote: > > bump. In case it matters, I have no objection to this change. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120222/

Review Request 120327: Fix crash in ImageWallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120327/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Bugs

We've all slacked off on the bug triage a lot. It is far far easier if we deal with things as they come in, not let things pile up. What I found quite frustrating when cleaning up today is people commenting and then leaving bugs as unconfirmed. Bugs are either: - not going to be implemented (res

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120329/ --- (Updated Sept. 23, 2014, 7:39 a.m.) Review request for Plasma and Martin

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120329/#review67255 --- src/client/CMakeLists.txt

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120329/#review67256 --- I also need to point out that I won't accept the code unless i

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

> On Sept. 23, 2014, 5:39 a.m., Martin Gräßlin wrote: > > I am not comfortable with this going into the master branch yet. I do want > > master to get into the state where we can provide API and ABI stability. By > > adding development code it would become difficult to reach this state. > > >

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

> On Sept. 23, 2014, 5:55 a.m., Martin Gräßlin wrote: > > I also need to point out that I won't accept the code unless it has auto > > tests :-) Was waiting for a compositor with this interface and use that for the autotests and spawn it like the fullscreen shell test does, but I have the serv

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

> On Sept. 23, 2014, 7:39 a.m., Martin Gräßlin wrote: > > I am not comfortable with this going into the master branch yet. I do want > > master to get into the state where we can provide API and ABI stability. By > > adding development code it would become difficult to reach this state. > > >

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

> On Sept. 23, 2014, 5:51 a.m., Martin Gräßlin wrote: > > src/client/plasma_surface.h, lines 29-31 > > > > > > why wrapped in QT_BEGIN_NAMESPACE? I have never seen that in KDE code Qt can be built with a custom n

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

> On Sept. 23, 2014, 7:51 a.m., Martin Gräßlin wrote: > > src/client/plasma_shell.h, line 25 > > > > > > why the QtCore/ prefix? > > Pier Luigi Fiorini wrote: > force of habit, guess that on Qt is often done

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

> On Sept. 23, 2014, 5:51 a.m., Martin Gräßlin wrote: > > src/client/plasma_surface.h, line 125 > > > > > > I'm not sure whether we need this. Plasma is using kscreen and not > > QScreen. > > Pier Luigi Fiorini

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

> On Sept. 23, 2014, 7:51 a.m., Martin Gräßlin wrote: > > src/client/plasma_surface.h, line 125 > > > > > > I'm not sure whether we need this. Plasma is using kscreen and not > > QScreen. > > Pier Luigi Fiorini