Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread David Edmundson
On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: Code-wise, it has a few issues with the config saving and restoration, those are easily fixed, however. Otherwise, the problem is that we've frozen Plasma 4.x for more than a year already, so we won't accept new features. All

[kio-extras] [Bug 343153] New: kio_sftp crashes if sftp_write(...) fails (double-free in sftpProtocol::sftpPut)

2015-01-22 Thread Kevin Funk
https://bugs.kde.org/show_bug.cgi?id=343153 Bug ID: 343153 Summary: kio_sftp crashes if sftp_write(...) fails (double-free in sftpProtocol::sftpPut) Product: kio-extras Version: unspecified Platform: Other

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/#review74527 --- Hey. Thanks for writing a patch, at a quick glance it looks

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread Sebastian Kügler
On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: Code-wise, it has a few issues with the config saving and restoration, those are easily fixed, however. Otherwise, the problem is that we've frozen Plasma 4.x for more than a year already, so we won't accept new features. All

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-22 Thread David Edmundson
On Jan. 7, 2015, 6:18 p.m., David Edmundson wrote: startkde/startkde.cmake, line 12 https://git.reviewboard.kde.org/r/121903/diff/1/?file=338977#file338977line12 Order of evaluation: QtProject/qtlogging.ini setFilterRules() QT_LOGGING_CONF

Re: Review Request 122167: Unlink the temporary file for ShmPool from file system

2015-01-22 Thread Martin Gräßlin
On Jan. 22, 2015, 1:27 p.m., Vishesh Handa wrote: Seems like a sensible thing. Though perhaps we should think about improving QTemporaryFile to do the same internally. I had a look at QTemporaryFile but I didn't dare to touch it in the end as it's cross platform and I have no idea

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122184/ --- (Updated Jan. 22, 2015, 12:51 p.m.) Status -- This change has been

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread Patrick Uiterwijk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/ --- (Updated Jan. 22, 2015, 12:54 p.m.) Review request for Plasma. Changes

Re: Review Request 122167: Unlink the temporary file for ShmPool from file system

2015-01-22 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122167/#review74532 --- Ship it! Seems like a sensible thing. Though perhaps we

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread Patrick Uiterwijk
On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: Code-wise, it has a few issues with the config saving and restoration, those are easily fixed, however. Otherwise, the problem is that we've frozen Plasma 4.x for more than a year already, so we won't accept new features. All

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread Patrick Uiterwijk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/ --- (Updated Jan. 22, 2015, 12:53 p.m.) Review request for Plasma.

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread Patrick Uiterwijk
On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: Code-wise, it has a few issues with the config saving and restoration, those are easily fixed, however. Otherwise, the problem is that we've frozen Plasma 4.x for more than a year already, so we won't accept new features. All

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread Patrick Uiterwijk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/ --- (Updated Jan. 22, 2015, 1:13 p.m.) Status -- This change has been

5.3 schedule

2015-01-22 Thread Jonathan Riddell
I've put up a draft schedule for 5.3 with 5.2.1 and 5.2.2 bugfix releases both 4 weeks after the previous, 5.2.95 beta right after KF5 5.9 and 5.3 coming out at the end of April. Comments welcome https://techbase.kde.org/Schedules/Plasma_5

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread Sebastian Kügler
On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: applets/binary-clock/binaryclock.cpp, line 179 https://git.reviewboard.kde.org/r/122196/diff/1/?file=344087#file344087line179 I think you're forgetting to actually save the config value. Look at the cg.writeEntry(...) calls

Re: Review Request 122132: Expose inhibitions in power management dataengine

2015-01-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122132/#review74524 --- Ship it! Ship It! - Marco Martin On Jan. 20, 2015, 6:30

Re: Plasma 5.2 tars are up

2015-01-22 Thread Albert Astals Cid
El Dijous, 22 de gener de 2015, a les 16:41:53, Jonathan Riddell va escriure: Plasma 5.2 tars are up for packagers on depot at stable/plasma/5.2.0 Please check over for sanity. Please also check over the release announcement and suggest improvements

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

2015-01-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/#review74528 --- Code-wise, it has a few issues with the config saving and

Re: 5.2 features

2015-01-22 Thread Vishesh Handa
From Baloo * Optimizations on startup. We now consume a good 2-3x less cpu on startup. * All of the Baloo libraries have been merged. There is now just KF5Baloo * The query parser supports type / kind properties. So one can type kind:Audio in krunner to filter out Audio results * Removed Email

Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/ --- Review request for Plasma and Kai Uwe Broulik. Repository: kdeclarative

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/#review74546 --- Nitpick: Too many whitespaces other then +1. Makes sense to

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/ --- (Updated Jan. 22, 2015, 4:54 p.m.) Review request for Plasma and Kai Uwe

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/#review74548 --- src/qmlcontrols/kcoreaddons/formats.h

Re: Review Request 122171: Implement SystemTrayMenuItem::setMenu() correctly.

2015-01-22 Thread Dmitry Shachnev
On Jan. 20, 2015, 3:46 nachm., Marco Martin wrote: Ship It! Dmitry Shachnev wrote: I will need someone to push it for me, but first I want to get the meteo-qt developer to test it (I have sent him a link), wait until that please. Ok, I tested it myself on another machine, and the

[kio-extras] [Bug 343153] kio_sftp crashes if sftp_write(...) fails (double-free in sftpProtocol::sftpPut)

2015-01-22 Thread Andreas Schneider
https://bugs.kde.org/show_bug.cgi?id=343153 Andreas Schneider a...@cryptomilk.org changed: What|Removed |Added Latest Commit|http://commits.kde.org/kde-

[kio-extras] [Bug 343153] kio_sftp crashes if sftp_write(...) fails (double-free in sftpProtocol::sftpPut)

2015-01-22 Thread Andreas Schneider
https://bugs.kde.org/show_bug.cgi?id=343153 Andreas Schneider a...@cryptomilk.org changed: What|Removed |Added Latest Commit|http://commits.kde.org/kde-

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
On Jan. 22, 2015, 5:02 p.m., David Edmundson wrote: src/qmlcontrols/kcoreaddons/formats.h, line 92 https://git.reviewboard.kde.org/r/122200/diff/3/?file=344270#file344270line92 do these work? They are not used anywhere in plasma. But my guess would be they don't. - Martin

[kio-extras] [Bug 343153] kio_sftp crashes if sftp_write(...) fails (double-free in sftpProtocol::sftpPut)

2015-01-22 Thread Andreas Schneider
https://bugs.kde.org/show_bug.cgi?id=343153 Andreas Schneider a...@cryptomilk.org changed: What|Removed |Added Latest Commit|http://commits.kde.org/kio-

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/ --- (Updated Jan. 22, 2015, 4:52 p.m.) Review request for Plasma and Kai Uwe

[kio-extras] [Bug 343153] kio_sftp crashes if sftp_write(...) fails (double-free in sftpProtocol::sftpPut)

2015-01-22 Thread Andreas Schneider
https://bugs.kde.org/show_bug.cgi?id=343153 Andreas Schneider a...@cryptomilk.org changed: What|Removed |Added Resolution|--- |FIXED

[kio-extras] [Bug 343153] kio_sftp crashes if sftp_write(...) fails (double-free in sftpProtocol::sftpPut)

2015-01-22 Thread Andreas Schneider
https://bugs.kde.org/show_bug.cgi?id=343153 Andreas Schneider a...@cryptomilk.org changed: What|Removed |Added Latest Commit|http://commits.kde.org/kde-

Re: Review Request 122209: [plasma-workspace] Make tests optional

2015-01-22 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/ --- (Updated Jan. 22, 2015, 9:43 p.m.) Review request for Plasma.

Re: Finding all the Plasma Bugs

2015-01-22 Thread Christoph Feck
On Tuesday 20 January 2015 22:34:18 David Edmundson wrote: I was trying to triage some of the wider Plasma bugs and realised that I didn't have a full list of bugzilla components [...] Thank you for taking care of bugs. Could you please comment on kscreensaver/locker-qml component? Is this the

Re: Finding all the Plasma Bugs

2015-01-22 Thread David Edmundson
On Fri, Jan 23, 2015 at 1:33 AM, Christoph Feck cf...@kde.org wrote: On Tuesday 20 January 2015 22:34:18 David Edmundson wrote: I was trying to triage some of the wider Plasma bugs and realised that I didn't have a full list of bugzilla components [...] Thank you for taking care of bugs.

Moving plasmaengineexplorer to plasma-framework?

2015-01-22 Thread Bhushan Shah
Hello! So at moment plasmaengineexplorer is provided by plasmate which is not released at moment. Also IMHO it makes sense to move plasmaengineexplorer to plasma-frameowork repo due to the fact that is important tool to debug dataengine. So I went ahead and I made the move locally and pushed the

Review Request 122207: [plasma-desktop] Make tests optional

2015-01-22 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122207/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Plasma 5.2 tars are up

2015-01-22 Thread David Edmundson
On Thu, Jan 22, 2015 at 5:54 PM, Martin Klapetek martin.klape...@gmail.com wrote: On Thu, Jan 22, 2015 at 5:41 PM, Jonathan Riddell j...@jriddell.org wrote: Plasma 5.2 tars are up for packagers on depot at stable/plasma/5.2.0 Please check over for sanity. Please also check over the release

Plasma 5.2 tars are up

2015-01-22 Thread Jonathan Riddell
Plasma 5.2 tars are up for packagers on depot at stable/plasma/5.2.0 Please check over for sanity. Please also check over the release announcement and suggest improvements https://www.kde.org/announcements/plasma-5.2.0.php And have a look over the Errata and add any bugs you know of

Re: Plasma 5.2 tars are up

2015-01-22 Thread Martin Klapetek
On Thu, Jan 22, 2015 at 5:41 PM, Jonathan Riddell j...@jriddell.org wrote: Plasma 5.2 tars are up for packagers on depot at stable/plasma/5.2.0 Please check over for sanity. Please also check over the release announcement and suggest improvements

Re: Review Request 122207: [plasma-desktop] Make tests optional

2015-01-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122207/#review74560 --- Ship it! Ship It! - David Edmundson On Jan. 22, 2015,

Re: Review Request 122207: [plasma-desktop] Make tests optional

2015-01-22 Thread Andreas Sturmlechner
On Jan. 22, 2015, 8:48 p.m., David Edmundson wrote: Ship It! I should add that I don't have write access, so I ask for someone else to merge it. :) - Andreas --- This is an automatically generated e-mail. To reply, visit:

[Powerdevil] [Bug 340652] Regression: Activity-specific settings gone

2015-01-22 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=340652 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added CC||k...@privat.broulik.de

Re: Review Request 122065: Fix activity start and stop.

2015-01-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/#review74574 --- This looks still wrong to me. The service is still called

Re: Re: Finding all the Plasma Bugs

2015-01-22 Thread Martin Gräßlin
On Friday 23 January 2015 02:41:23 David Edmundson wrote: On Fri, Jan 23, 2015 at 1:33 AM, Christoph Feck cf...@kde.org wrote: On Tuesday 20 January 2015 22:34:18 David Edmundson wrote: I was trying to triage some of the wider Plasma bugs and realised that I didn't have a full list of