Re: Review Request 122259: [ksld/greeter] Disable all IM modules

2015-01-26 Thread Eike Hein
On Jan. 26, 2015, 12:41 p.m., David Edmundson wrote: ksmserver/screenlocker/greeter/main.cpp, line 56 https://git.reviewboard.kde.org/r/122259/diff/1/?file=345290#file345290line56 qunsetenv? Martin Gräßlin wrote: see bug report: Eike explicitly suggested to set it to empty,

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-26 Thread Marco Martin
On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: where do you want to use it? Iirc Bhushan is working o a global way to make series of kcms accessible from plasmoids David Edmundson wrote: Generic is always better. KDeclarative is used from places outside Plasma.

Re: Review Request 122259: [ksld/greeter] Disable all IM modules

2015-01-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122259/#review74765 --- ksmserver/screenlocker/greeter/main.cpp

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-26 Thread David Edmundson
On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: where do you want to use it? Iirc Bhushan is working o a global way to make series of kcms accessible from plasmoids Generic is always better. KDeclarative is used from places outside Plasma. Applications in future will need to open KCMs

Re: Review Request 122259: [ksld/greeter] Disable all IM modules

2015-01-26 Thread Eike Hein
On Jan. 26, 2015, 12:41 p.m., David Edmundson wrote: ksmserver/screenlocker/greeter/main.cpp, line 56 https://git.reviewboard.kde.org/r/122259/diff/1/?file=345290#file345290line56 qunsetenv? Martin Gräßlin wrote: see bug report: Eike explicitly suggested to set it to empty,

Review Request 122259: [ksld/greeter] Disable all IM modules

2015-01-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122259/ --- Review request for Plasma and Eike Hein. Bugs: 306932

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-26 Thread Bhushan Shah
On Jan. 26, 2015, 2:38 p.m., Marco Martin wrote: where do you want to use it? Iirc Bhushan is working o a global way to make series of kcms accessible from plasmoids David Edmundson wrote: Generic is always better. KDeclarative is used from places outside Plasma.

Re: Review Request 122259: [ksld/greeter] Disable all IM modules

2015-01-26 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122259/#review74776 --- Ship it! Ship It! - Eike Hein On Jan. 26, 2015, 1:22

Re: Review Request 121554: Simple network systemmonitor plasmoid rewrite

2015-01-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121554/ --- (Updated Jan. 26, 2015, 4:46 p.m.) Status -- This change has been

Re: Plasma 5.2 tars are up

2015-01-26 Thread Jonathan Riddell
Two more rerolls. Breeze gets a fix to the kconf_update scripts and baloo gets a fixed version number. Available on depot for packagers. breeze;Plasma/5.2;6c1132607a95c3c685f6292fac16108833fe9b2b;breeze-5.2.0.tar.xz;704e9bef93747eb3d8b2f159e874ef48f037edb3359b0cd669627d0d6d4003e9

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Ivan Čukić
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: This looks still wrong to me. The service is still called org.kde.kwin while it should be org.kde.KWin. Ideally this gets changed to a generated adaptor from the DBus interface KWin installs. To make things worse: the service name

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Martin Gräßlin
On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: This looks still wrong to me. The service is still called org.kde.kwin while it should be org.kde.KWin. Ideally this gets changed to a generated adaptor from the DBus interface KWin installs. To make things worse: the service name

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-26 Thread Marco Martin
On Monday 26 January 2015, Bhushan Shah wrote: So I think in general moving plasmaengineexplorer to plasma-framework is no go? i would prefer not and we should think of releasing plasmate? yep.. -- Marco Martin ___ Plasma-devel mailing list

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-26 Thread Bhushan Shah
On Mon, Jan 26, 2015 at 9:35 PM, Bhushan Shah bhus...@gmail.com wrote: Indeed that kdevplatform dep is already optional and there is cmake switch for that too So I think in general moving plasmaengineexplorer to plasma-framework is no go? and we should think of releasing plasmate? --

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-26 Thread Sebastian Kügler
On Friday, January 23, 2015 13:32:09 Luca Beltrame wrote: In data venerdì 23 gennaio 2015 13:25:51, David Edmundson ha scritto: The rationale seems to be there's no release of plasmate, which is something very easily fixable by releasing plasmate. Plasmate(5) depends on the KF5 version of

Re: Plasma 5.2 tars are up

2015-01-26 Thread Jonathan Riddell
Oxygen got rerolled for a crash Only delete our own style objects when a plugin is unloaded oxygen;Plasma/5.2;e0376e1597f6e6b49e6343874e141b439565b749;oxygen-5.2.0.tar.xz;5d816ce545debb63deb084a5bb2160bd9330874da1f347764a3e0c68462d4df1 kfilemetadata for rerolled because it had an ABI change

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-26 Thread Bhushan Shah
On Mon, Jan 26, 2015 at 9:33 PM, Sebastian Kügler se...@kde.org wrote: We can and should make that kdevplatform dependency optional, especially since it's in non-released code. I think, as David already suggested, that we should do a release of the plasmate repo, for now without plasmate (which

Re: Review Request 122259: [ksld/greeter] Disable all IM modules

2015-01-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122259/ --- (Updated Jan. 26, 2015, 2:22 p.m.) Review request for Plasma and Eike

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Ivan Čukić
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: This looks still wrong to me. The service is still called org.kde.kwin while it should be org.kde.KWin. Ideally this gets changed to a generated adaptor from the DBus interface KWin installs. To make things worse: the service name

Re: Review Request 122256: Turn pin into ToolButton

2015-01-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122256/ --- (Updated Jan. 26, 2015, 8:37 p.m.) Status -- This change has been

Re: [plasma-workspace] startkde/kcminit: qstring optimization, use qset to avoid n^2 complexity

2015-01-26 Thread Christoph Feck
On Tuesday 27 January 2015 02:47:52 Nick Shaforostoff wrote: Git commit a5d47846f572b325057627efc9b5d920fa34ca64 by Nick Shaforostoff. Committed on 27/01/2015 at 03:47. Pushed by shaforo into branch 'master'. qstring optimization, use qset to avoid n^2 complexity [...] +QString

Re: Review Request 122259: [ksld/greeter] Disable all IM modules

2015-01-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122259/ --- (Updated Jan. 27, 2015, 7:02 a.m.) Status -- This change has been

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/#review74808 --- src/service/ksmserver/KSMServer.cpp

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Martin Gräßlin
On Jan. 27, 2015, 8:27 a.m., Ivan Čukić wrote: src/service/ksmserver/KSMServer.cpp, line 72 https://git.reviewboard.kde.org/r/122065/diff/2/?file=345332#file345332line72 Can you add: - checking for the environment variable existence (and using it, if not empty) - a

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Ivan Čukić
On Jan. 27, 2015, 7:27 a.m., Ivan Čukić wrote: src/service/ksmserver/KSMServer.cpp, line 72 https://git.reviewboard.kde.org/r/122065/diff/2/?file=345332#file345332line72 Can you add: - checking for the environment variable existence (and using it, if not empty) - a

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Martin Gräßlin
On Jan. 27, 2015, 8:27 a.m., Ivan Čukić wrote: src/service/ksmserver/KSMServer.cpp, line 72 https://git.reviewboard.kde.org/r/122065/diff/2/?file=345332#file345332line72 Can you add: - checking for the environment variable existence (and using it, if not empty) - a

Re: Review Request 122167: Unlink the temporary file for ShmPool from file system

2015-01-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122167/ --- (Updated Jan. 26, 2015, 10:12 a.m.) Status -- This change has been

Re: Review Request 122256: Turn pin into ToolButton

2015-01-26 Thread Bjoern Balazs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122256/#review74751 --- Ship it! I think we should investigate the usefullness of

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Xuetian Weng
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: This looks still wrong to me. The service is still called org.kde.kwin while it should be org.kde.KWin. Ideally this gets changed to a generated adaptor from the DBus interface KWin installs. To make things worse: the service name

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Martin Gräßlin
On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: This looks still wrong to me. The service is still called org.kde.kwin while it should be org.kde.KWin. Ideally this gets changed to a generated adaptor from the DBus interface KWin installs. To make things worse: the service name

Re: Remove KQuickControls TextArea/TextField again

2015-01-26 Thread Marco Martin
On Sunday 25 January 2015, Kai Uwe Broulik wrote: Hi everyone, a couple of weeks ago I added proper widget-like context menus to TextArea and TextField and put them into KDeclarative [1]. I have now upstreamed these changes and they will be in 5.5 (dev atm is 5.5 right?). Given the other

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74750 --- where do you want to use it? Iirc Bhushan is working o a

Re: Review Request 122256: Turn pin into ToolButton

2015-01-26 Thread Kai Uwe Broulik
On Jan. 26, 2015, 12:28 vorm., Thomas Pfeiffer wrote: Definitely an improvement! I'm not really sure of the pin's usefulness either, but it's also unobtrusive enough to maybe keep it in for those who need it. I think for the calendar it's vital, so you can keep it open when booking a

Re: Review Request 122065: Fix activity start and stop.

2015-01-26 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/ --- (Updated Jan. 27, 2015, 12:23 a.m.) Review request for Plasma, Martin