Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread Rajeesh K Nambiar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/ --- (Updated Feb. 12, 2015, 6:34 p.m.) Status -- This change has been

Merging KCM Touchpad

2015-02-12 Thread David Edmundson
I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise testing before the 5.3 release. Any objections to me merging into plasma-desktop with the other KCMs? I don't think there's a reason to keep it in a separate repo now it's ready for usage. I'll filter branch to keep the

Re: Review Request 122540: Add screen reader to Accessibility KCM

2015-02-12 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122540/ --- (Updated Feb. 12, 2015, 6:12 p.m.) Review request for Plasma, Jonathan

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75939 --- The commit seems to have missed

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread Rex Dieter
On Feb. 12, 2015, 7:22 p.m., Rex Dieter wrote: The commit seems to have missed backends/x11/libinputproperties.c, it now fails to build for me: CMake Error at src/CMakeLists.txt:48 (add_library): Cannot find source file: backends/x11/libinputproperties.c Extracted from

Re: Review Request 122540: Add screen reader to Accessibility KCM

2015-02-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122540/#review75937 --- Ship it! Ship It! - David Edmundson On Feb. 12, 2015,

Re: Review Request 122540: Add screen reader to Accessibility KCM

2015-02-12 Thread Frederik Gladhorn
On Feb. 12, 2015, 5:16 p.m., David Edmundson wrote: kcms/access/kaccess.cpp, line 347 https://git.reviewboard.kde.org/r/122540/diff/2/?file=348506#file348506line347 Sorry I wasn't clear. Not here. This needs to remain a unique ID. I meant

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread Rajeesh K Nambiar
On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: Built my X with libinput support. Without this patch I get an erro, with this I get at least some options, though quite a few seemed disabled as they're just not available in libinput. Indeed, many options are disabled because

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread David Edmundson
On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: Built my X with libinput support. Without this patch I get an erro, with this I get at least some options, though quite a few seemed disabled as they're just not available in libinput. Rajeesh K Nambiar wrote: Indeed,

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread Rajeesh K Nambiar
On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: Built my X with libinput support. Without this patch I get an erro, with this I get at least some options, though quite a few seemed disabled as they're just not available in libinput. Rajeesh K Nambiar wrote: Indeed,

Re: Review Request 122540: Add screen reader to Accessibility KCM

2015-02-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122540/#review75911 --- +1 in general. kcms/access/kaccess.cpp

Re: Review Request 122383: Remove internal copy of KXmlRpcClient

2015-02-12 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122383/#review75906 --- Ship it! KXmlRpcClient is a framework now! - Daniel Vrátil

Build failed in Jenkins: plasma-workspace_master_qt5 #1309

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1309/changes Changes: [aleixpol] Remove the internal kxmlrpcclient copy -- [...truncated 2577 lines...] [ 70%] Building CXX object dataengines/weather/ions/CMakeFiles/weather_ion.dir/ion.cpp.o [

Re: Review Request 122383: Remove internal copy of KXmlRpcClient

2015-02-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122383/ --- (Updated Feb. 12, 2015, 11:55 a.m.) Status -- This change has been

Build failed in Jenkins: plasma-workspace_stable_qt5 #63

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_stable_qt5/63/changes Changes: [lukas] properly propagate info and error messages from kcheckpass and PAM -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on

Re: Review Request 122505: Warn about brightness getting too low

2015-02-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122505/ --- (Updated Feb. 12, 2015, 9:29 p.m.) Status -- This change has been

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

2015-02-12 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/ --- (Updated feb. 12, 2015, 10:58 p.m.) Status -- This change has been

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread Rajeesh K Nambiar
On Feb. 12, 2015, 7:22 p.m., Rex Dieter wrote: The commit seems to have missed backends/x11/libinputproperties.c, it now fails to build for me: CMake Error at src/CMakeLists.txt:48 (add_library): Cannot find source file: backends/x11/libinputproperties.c Rex Dieter wrote:

Build failed in Jenkins: plasma-workspace_master_qt5 #1313

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1313/changes Changes: [kde] Cleanup anchoring mess in battery monitor -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER

Re: Merging KCM Touchpad

2015-02-12 Thread Marco Martin
On Thursday 12 February 2015, David Edmundson wrote: I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise testing before the 5.3 release. Any objections to me merging into plasma-desktop with the other KCMs? I don't think there's a reason to keep it in a separate repo

Re: Merging KCM Touchpad

2015-02-12 Thread David Edmundson
On Fri, Feb 13, 2015 at 12:19 AM, Lukáš Tinkl lu...@kde.org wrote: Dne 12.2.2015 v 23:07 Marco Martin napsal(a): On Thursday 12 February 2015, David Edmundson wrote: I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise testing before the 5.3 release. Any objections

Re: Merging KCM Touchpad

2015-02-12 Thread Lukáš Tinkl
Dne 12.2.2015 v 23:07 Marco Martin napsal(a): On Thursday 12 February 2015, David Edmundson wrote: I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise testing before the 5.3 release. Any objections to me merging into plasma-desktop with the other KCMs? I don't think

Re: Merging KCM Touchpad

2015-02-12 Thread Aleix Pol
On Thu, Feb 12, 2015 at 8:51 PM, David Edmundson da...@davidedmundson.co.uk wrote: I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise testing before the 5.3 release. Any objections to me merging into plasma-desktop with the other KCMs? I don't think there's a reason

Build failed in Jenkins: plasma-workspace_master_qt5 #1308

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1308/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 2597 lines...] [ 73%] [ 73%] Generating notificationsadaptor.moc Building CXX object

Alternative desktop applet interaction

2015-02-12 Thread Eike Hein
Hi, yesterday I added a new Experimental page to the config dialog of the Folder View desktop containment in master. It offers two options that enable a different way of interacting with widgets on the desktop: - Pressing and holding for $platform_delay to engage a 'move' mode where as long

Build failed in Jenkins: plasma-workspace_master_qt5 #1312

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1312/changes Changes: [kde] Don't let the brightness sliders turn off the screen -- [...truncated 2588 lines...] [ 73%] Building CXX object

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

2015-02-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122533/#review75965 --- Ship it! Ship It! - Martin Gräßlin On Feb. 12, 2015, 5:50

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-12 Thread Martin Gräßlin
On Feb. 11, 2015, 5:14 p.m., Andrew Lake wrote: It might be worth investigating the use-case a bit further to try to understand if this is the best way to solve this. Is it useful? Yes. But there are potentiall negative impacts that should be balanced against the relative increase in

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-12 Thread Martin Gräßlin
On Feb. 10, 2015, 2:29 p.m., David Edmundson wrote: I'm not convinced this is right. From the doc you linked: This is necessary for the system to implement auto-suspend when all sessions are idle. When we lock the screen, powerdevil is still running, no? Powerdevil has

Re: Review Request 122540: Add screen reader to Accessibility KCM

2015-02-12 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122540/ --- (Updated Feb. 13, 2015, 7:18 a.m.) Status -- This change has been

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

2015-02-12 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122533/ --- (Updated Feb. 13, 2015, 7:18 a.m.) Status -- This change has been

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread Sebastian Kügler
On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: Built my X with libinput support. Without this patch I get an erro, with this I get at least some options, though quite a few seemed disabled as they're just not available in libinput. Rajeesh K Nambiar wrote: Indeed,

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread David Edmundson
On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: Built my X with libinput support. Without this patch I get an erro, with this I get at least some options, though quite a few seemed disabled as they're just not available in libinput. Rajeesh K Nambiar wrote: Indeed,

Build failed in Jenkins: plasma-workspace_master_qt5 #1311

2015-02-12 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1311/changes Changes: [lukas] properly propagate info and error messages from kcheckpass and PAM -- [...truncated 2580 lines...] [ 71%] Building CXX object

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-12 Thread Rajeesh K Nambiar
On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: Built my X with libinput support. Without this patch I get an erro, with this I get at least some options, though quite a few seemed disabled as they're just not available in libinput. Rajeesh K Nambiar wrote: Indeed,

Re: Review Request 122540: Add screen reader to Accessibility KCM

2015-02-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122540/#review75930 --- kcms/access/kaccess.cpp

Change in plasma-framework[master]: support for C++ applets

2015-02-12 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/374 Change subject: support for C++ applets .. support for C++ applets make possible for an applet to be implemented in c++ but still

Re: Review Request 122540: Add screen reader to Accessibility KCM

2015-02-12 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122540/ --- (Updated Feb. 12, 2015, 5:01 p.m.) Review request for Plasma, Jonathan

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

2015-02-12 Thread Frederik Gladhorn
On Feb. 12, 2015, 6:53 a.m., Martin Gräßlin wrote: kcms/access/kaccess.cpp, lines 379-385 https://git.reviewboard.kde.org/r/122533/diff/3/?file=348415#file348415line379 Is there no event type defined in xkb? I looked and finally checked how Qt does it, if you can find one, I'd be

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

2015-02-12 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122533/ --- (Updated Feb. 12, 2015, 4:50 p.m.) Review request for Plasma.