Re: Review Request 122598: Add separate checkbox for automatically lock screen

2015-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/#review76168 --- Personally I think a is better. - Martin Gräßlin On Feb. 16

Re: Review Request 122598: Add separate checkbox for automatically lock screen

2015-02-16 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/#review76163 --- This is fine from an interaction perspective, however layout-w

Build failed in Jenkins: plasma-workspace_master_qt5 #1328

2015-02-16 Thread KDE CI System
See Changes: [lukas] properly propagate info and error messages from kcheckpass and PAM [scripty] SVN_SILENT made messages (.desktop file) [kde] Offer editing only for text entries -- St

Re: Review Request 122598: Add separate checkbox for automatically lock screen

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/#review76156 --- File Attachment: aleix suggests doing this...thoughts? - a1.p

[ksystraycmd] [Bug 344168] there is no ksystray for plasma5

2015-02-16 Thread Bhushan Shah
https://bugs.kde.org/show_bug.cgi?id=344168 Bhushan Shah changed: What|Removed |Added CC||sit...@kde.org --- Comment #17 from Bhushan Shah

Build failed in Jenkins: plasma-workspace_master_qt5 #1327

2015-02-16 Thread KDE CI System
See Changes: [kde] Only show empty hint when the filter box is empty -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACK

Re: Review Request 122598: Add separate checkbox for automatically lock screen

2015-02-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/ --- (Updated Feb. 16, 2015, 7:38 p.m.) Review request for Plasma. Changes -

Build failed in Jenkins: plasma-workspace_master_qt5 #1326

2015-02-16 Thread KDE CI System
See Changes: [kde] Make configure context menu entry consistent with the other plasmoids -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on

Re: Review Request 122598: Add separate checkbox for automatically lock screen

2015-02-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/ --- (Updated Feb. 16, 2015, 7:29 p.m.) Review request for Plasma. Changes -

Review Request 122598: Add separate checkbox for automatically lock screen

2015-02-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 122594: Turn desktop toolbox into a dialog

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122594/ --- (Updated Feb. 16, 2015, 6:53 p.m.) Status -- This change has been ma

Re: Review Request 122594: Turn desktop toolbox into a dialog

2015-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122594/#review76154 --- Ship it! Ship It! - Marco Martin On Feb. 16, 2015, 5:53 p.

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-16 Thread Marco Martin
> On Feb. 16, 2015, 6:38 p.m., Kai Uwe Broulik wrote: > > Can't we resurrect, for instance, the X-Plasma-RequiredExtensions thing or > > so? I don't want to end up with dozens of X-Plasma-Requires-Internet, > > X-Plasma-Requires-This-and-that +1, it can be X-Plasma-RequiredExtensions=ExternalS

Review Request 122596: Kill lock logout checkLayout() function

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122596/ --- Review request for Plasma. Bugs: 337318 and 339435 https://bugs.kde.o

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/#review76152 --- Can't we resurrect, for instance, the X-Plasma-RequiredExtensi

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/#review76149 --- Ship it! +1, could you just add a short paragraph about this

Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/ --- Review request for Plasma. Repository: plasma-framework Description ---

Build failed in Jenkins: plasma-workspace_master_qt5 #1325

2015-02-16 Thread KDE CI System
See Changes: [kde] Bump framework version requirement to 5.8.0 [kde] Align digital clock to full minutes -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Buil

Review Request 122594: Turn desktop toolbox into a dialog

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122594/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/ --- (Updated Feb. 16, 2015, 5:48 p.m.) Status -- This change has been ma

Re: Review Request 122593: Distinguish relays by both interval and alignment

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122593/ --- (Updated Feb. 16, 2015, 5:48 p.m.) Status -- This change has been ma

Re: Review Request 122593: Distinguish relays by both interval and alignment

2015-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122593/#review76142 --- Ship it! Ship It! - Marco Martin On Feb. 16, 2015, 4:19 p.

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/#review76143 --- Ship it! Ship It! - Marco Martin On Feb. 16, 2015, 4:04 p.

Review Request 122593: Distinguish relays by both interval and alignment

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122593/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-02-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #70 from Christoph Feck --- This bug was fixed for 5.2.1, so there is no need to attach log files from 5.2.0. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-02-16 Thread Jürgen Scholz
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #69 from Jürgen Scholz --- Oh, please excuse my oversidght. ubuntu still uses 5.2.0 and *not* 5.2.1. I will check their bugtracker to either fix this as a backport or to switch to 5.2.1. -- You are receiving this mail because: You are the

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-02-16 Thread Jürgen Scholz
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #68 from Jürgen Scholz --- I updated to new versions of kded5 and plasma-desktop/plasma-framework a few days ago. The versions are now: kded (5.7.0-0ubuntu1) vivid; urgency=medium plasma-desktop (4:5.2.0-0ubuntu1) vivid; urgency=medium

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Marco Martin
> On Feb. 16, 2015, 3:53 p.m., Marco Martin wrote: > > applets/digital-clock/package/contents/ui/main.qml, line 57 > > > > > > perhaps should be noalignment when showing seconds? (however is very > > weird that i

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/ --- (Updated Feb. 16, 2015, 4:04 nachm.) Review request for Plasma and Martin

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Kai Uwe Broulik
> On Feb. 16, 2015, 3:53 nachm., Marco Martin wrote: > > applets/digital-clock/package/contents/ui/main.qml, line 57 > > > > > > perhaps should be noalignment when showing seconds? (however is very > > weird that

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/#review76138 --- applets/digital-clock/package/contents/ui/main.qml

Re: Review Request 122470: Optimize DataSource

2015-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122470/#review76137 --- Ship it! arriving late but that's nice :) - Marco Martin O

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Martin Klapetek
> On Feb. 16, 2015, 4:06 p.m., Martin Klapetek wrote: > > All I'm getting with this patch is "Error loading QML file: > > file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9: > > Cannot assign to non-existent property "intervalAlignment" " > > > > And

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Bhushan Shah
> On Feb. 16, 2015, 8:36 p.m., Martin Klapetek wrote: > > All I'm getting with this patch is "Error loading QML file: > > file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9: > > Cannot assign to non-existent property "intervalAlignment" " > > > > And

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/#review76131 --- All I'm getting with this patch is "Error loading QML file: f

[Powerdevil] [Bug 323754] When "Dim Screen" enabled, wrong brightness is applied when returned to AC

2015-02-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=323754 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/#review76128 --- Does this still work as intended even when seconds are shown?

[Powerdevil] [Bug 340427] PowerDevil should only inhibit systemd on active sessions

2015-02-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=340427 Kai Uwe Broulik changed: What|Removed |Added CC||primejyo...@engineer.com --- Comment #1 from

[Powerdevil] [Bug 328336] System does not hibernate when another user is logged in

2015-02-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=328336 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |DUPLICATE Status|CONFIRMED

Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/ --- Review request for Plasma and Martin Klapetek. Bugs: 343872 https://b

Re: Review Request 122470: Optimize DataSource

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122470/ --- (Updated Feb. 16, 2015, 1:57 p.m.) Status -- This change has been ma

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-16 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122382/#review76125 --- This came about partly due to my loud complaining that I was l

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

2015-02-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=304696 Kai Uwe Broulik changed: What|Removed |Added Component|powermanagement |general Version|4.9.0

[Powerdevil] [Bug 328336] System does not hibernate when another user is logged in

2015-02-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=328336 Kai Uwe Broulik changed: What|Removed |Added Product|solid |Powerdevil CC|

[Powerdevil] [Bug 323754] When "Dim Screen" enabled, wrong brightness is applied when returned to AC

2015-02-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=323754 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de Product|sol

Re: Review Request 122562: Add method for converting from QVariant to base64

2015-02-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122562/ --- (Updated Feb. 16, 2015, 1:22 p.m.) Status -- This change has been di

Re: Review Request 122589: [dataengine/mpris2] Drop workaround for VLC

2015-02-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122589/#review76119 --- Ship it! Somehow it seems to work with 2.1.4. And I agree tha

Re: Review Request 122562: Add method for converting from QVariant to base64

2015-02-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122562/#review76118 --- src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp

Re: Review Request 122588: [dataengines/mpris2] Use a dedicated component for the media control shortcuts

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122588/#review76113 --- Ship it! Ship It! - Kai Uwe Broulik On Feb. 16, 2015, 10:3

Re: Review Request 120500: Remove VLC workaround

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120500/ --- (Updated Feb. 16, 2015, 10:51 vorm.) Status -- This change has been

Re: Review Request 122589: [dataengine/mpris2] Drop workaround for VLC

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122589/#review76112 --- Ship it! Ship It! - Kai Uwe Broulik On Feb. 16, 2015, 10:4

Review Request 122589: [dataengine/mpris2] Drop workaround for VLC

2015-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122589/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 122588: [dataengines/mpris2] Use a dedicated component for the media control shortcuts

2015-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122588/ --- Review request for Plasma and Kai Uwe Broulik. Repository: plasma-workspa

Re: kcm_screensaver bugs

2015-02-16 Thread Christoph Feck
On Monday 16 February 2015 08:01:28 Martin Gräßlin wrote: > On Sunday 15 February 2015 17:31:37 Christoph Feck wrote: > > Hi, > > > > thank you very much for the recents efforts to triage > > "systemsettings" and "kscreensaver" bugs. > > > > I just noticed that "systemsettings/kcm_screensaver" is

Re: Review Request 122583: Prevent heading from expanding

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122583/ --- (Updated Feb. 16, 2015, 10:22 a.m.) Status -- This change has been m

Re: Review Request 122580: Fixed visibility of play/pause button

2015-02-16 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122580/#review76106 --- Sorry but I already fixed this one earlier. same patch http:/

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122382/ --- (Updated Feb. 16, 2015, 10:12 a.m.) Review request for Plasma and Eike He

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-16 Thread Martin Gräßlin
> On Feb. 3, 2015, 8:36 a.m., Martin Gräßlin wrote: > > David E. just pointed out that this could become quite heavy for the system > > as the history size can be large (up to 2048 items). > > Martin Gräßlin wrote: > Unfortunately I couldn't find out why we support up to 2048 items. Commit

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review76103 --- sorry for the delay. I was basically without Internet all of l

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-16 Thread Filip Wieladek
> On Feb. 3, 2015, 7:36 a.m., Martin Gräßlin wrote: > > David E. just pointed out that this could become quite heavy for the system > > as the history size can be large (up to 2048 items). > > Martin Gräßlin wrote: > Unfortunately I couldn't find out why we support up to 2048 items. Commit