Review Request 123494: Create DesktopView before connecting signals from the activity consumer

2015-04-24 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123494/ --- Review request for Plasma and Marco Martin. Repository: plasma-workspace

Re: Review Request 123493: Fix leaky incubation controller

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/#review79481 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 24, 2015,

Re: Review Request 123492: Fix memory leak in AppletQuickItem

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/#review79480 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 24, 2015,

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

2015-04-24 Thread Antonis Tsiapaliokas
> On April 22, 2015, 3:46 a.m., Kai Uwe Broulik wrote: > > -1 > > > > that's what the visible: pmSource.data["Battery"]["Has Cumulative"] is for. > > there just used to be a bug where that property wasn't created in the first > > place if no battery was present leading to an exception causing

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

2015-04-24 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated April 24, 2015, 7:02 p.m.) Status -- This change has been d

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

2015-04-24 Thread Kai Uwe Broulik
> On April 22, 2015, 3:46 vorm., Kai Uwe Broulik wrote: > > -1 > > > > that's what the visible: pmSource.data["Battery"]["Has Cumulative"] is for. > > there just used to be a bug where that property wasn't created in the first > > place if no battery was present leading to an exception causing

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

2015-04-24 Thread Antonis Tsiapaliokas
> On April 22, 2015, 3:46 a.m., Kai Uwe Broulik wrote: > > -1 > > > > that's what the visible: pmSource.data["Battery"]["Has Cumulative"] is for. > > there just used to be a bug where that property wasn't created in the first > > place if no battery was present leading to an exception causing

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

2015-04-24 Thread Kai Uwe Broulik
> On April 22, 2015, 3:46 vorm., Kai Uwe Broulik wrote: > > -1 > > > > that's what the visible: pmSource.data["Battery"]["Has Cumulative"] is for. > > there just used to be a bug where that property wasn't created in the first > > place if no battery was present leading to an exception causing

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

2015-04-24 Thread Antonis Tsiapaliokas
> On April 22, 2015, 3:46 a.m., Kai Uwe Broulik wrote: > > -1 > > > > that's what the visible: pmSource.data["Battery"]["Has Cumulative"] is for. > > there just used to be a bug where that property wasn't created in the first > > place if no battery was present leading to an exception causing

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

2015-04-24 Thread Antonis Tsiapaliokas
> On April 21, 2015, 9:47 p.m., David Edmundson wrote: > > lookandfeel/contents/components/InfoPane.qml, line 47 > > > > > > there's a visible here. > > > > If your two lines are needed, this isn't. > >

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

2015-04-24 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated April 24, 2015, 6:22 p.m.) Review request for Plasma. Changes

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

2015-04-24 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated April 24, 2015, 6:20 p.m.) Review request for Plasma. Bugs: 34

Re: Review Request 123457: Plasma-Workspace: we don't need QtWebkit as a depedency.

2015-04-24 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123457/ --- (Updated April 24, 2015, 6:16 p.m.) Status -- This change has been m

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

2015-04-24 Thread artoo
https://bugs.kde.org/show_bug.cgi?id=344456 ar...@manjaro.org changed: What|Removed |Added CC||ar...@manjaro.org --- Comment #25 from ar...

Re: Plasma 5.3.0 tars

2015-04-24 Thread Jonathan Riddell
Breeze updated for better wallpapers http://download.kde.org/stable/plasma/5.3.0/breeze-5.3.0.tar.xz ">breeze-5.3.0 - 22MB - f70eadd3b2c5cd20cbf939a564ceecf87237bf3c2a4e9de4d40e3cd0bf02bf89 + 27MB + 2def2f3f0d9528fe24424047f0342769eef75044af4873269d636f3a64d92406 Jonathan On 23 April 20

Review Request 123493: Fix leaky incubation controller

2015-04-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 123492: Fix memory leak in AppletQuickItem

2015-04-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/#review79466 --- Ship it! Ship It! - Marco Martin On April 24, 2015, 4:33 p

Review Request 123492: Fix memory leak in AppletQuickItem

2015-04-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Fredrik Höglund
> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well tou

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Martin Gräßlin
> On April 23, 2015, 1:31 p.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well toug

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/ --- (Updated April 24, 2015, 3:10 p.m.) Review request for Plasma. Reposito

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin
> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well tou

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Sebastian Kügler
> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well tou

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin
> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well tou

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Martin Gräßlin
> On April 23, 2015, 1:31 p.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well toug

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin
> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well tou

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Martin Gräßlin
> On April 23, 2015, 1:31 p.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well toug

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread David Edmundson
> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well tou

ISO for 2015-04-24

2015-04-24 Thread Harald Sitter
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist This ISO was created using the Plasma/5.3 branch as of earlier today. Which roughly approximates what is eventually going to become 5.3.0 next week. After release the ISO is then switching back to git master branches for next frid

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-24 Thread Marco Martin
> On April 23, 2015, 10:59 p.m., Luigi Toscano wrote: > > Apart from more technical issues, the patch includes changes to: > > applets/icontasks/metadata.desktop > > containments/folder/metadata.desktop > > kcms/access/kcmaccess.desktop > > kcms/baloo/kcm_baloofile.desktop > > > > which I th