Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

> On June 15, 2015, 7:29 p.m., Lukáš Tinkl wrote: > > A better option would be to call registerService() with > > QDBusConnectionInterface::ReplaceExistingService and > > DBusConnectionInterface::AllowReplacement > > Martin Klapetek wrote: > It's the "attempt to replace it." part of it tha

Re: [PATCH] [kcms/phonon] Don't overwrite audio profile entries with same priority

On Wednesday, June 17, 2015 14:44:59 Bernie Innocenti wrote: > On 17/06/15 01:03, Sebastian Kügler wrote: > > Sounds all sensible. It's a wiki, though, and I'm sure nobody will mind > > (but indeed anybody will be thankful) if you went ahead and changed these > > things. I just did a rough go-over

Re: Review Request 124112: Implement drag and drop for Trash applet

> On Juni 17, 2015, 7:36 nachm., Sebastian Kügler wrote: > > applets/trash/plugin/trashplugin.cpp, line 30 > > > > > > I think we still want to delete this one *somewhere*? >From the documentation: NOTE: A QObjec

Re: Review Request 124112: Implement drag and drop for Trash applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/#review81537 --- QFile::isWritable() is confusing, it falls back to QIODevice::

Re: [PATCH] [kcms/phonon] Don't overwrite audio profile entries with same priority

On 17/06/15 01:03, Sebastian Kügler wrote: Sounds all sensible. It's a wiki, though, and I'm sure nobody will mind (but indeed anybody will be thankful) if you went ahead and changed these things. I just did a rough go-over to update the most glaring anachronisms. If you're unsure about detailed

Jenkins-kde-ci: oxygen master kf5-qt5 » OSX,clang - Build # 11 - Fixed!

We thank you for fixing your build!___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124108: [kcms/phonon] Don't overwrite audio profile entries with same priority

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124108/ --- (Updated June 17, 2015, 5:30 p.m.) Status -- This change has been ma

Re: Review Request 124108: [kcms/phonon] Don't overwrite audio profile entries with same priority

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124108/#review81535 --- Ship it! Ship It! - Harald Sitter On June 16, 2015, 3:09 a

Jenkins-kde-ci: oxygen master kf5-qt5 » OSX,clang - Build # 10 - Failure!

Check console output at https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/10/ to view the results. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124114: Add "Lock Screen" to desktop toolbox

> On Juni 17, 2015, 3:29 vorm., David Edmundson wrote: > > > This does not check KAuthorized before to hide the entry but neither does > > > the context menu. > > > > Well that's a bit rubbish. > > Ship this, but lets remember to fix both, poke me if it gets near release > > and I haven't. >

Re: Review Request 124113: Ignore invalid X-Plasma-ConfigPlugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124113/ --- (Updated June 17, 2015, 4:29 p.m.) Status -- This change has been ma

Re: Review Request 124112: Implement drag and drop for Trash applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/ --- (Updated Juni 17, 2015, 4:24 nachm.) Review request for Plasma. Changes

Re: Review Request 124112: Implement drag and drop for Trash applet

> On Juni 17, 2015, 3:51 nachm., Marco Martin wrote: > > looks good. > > I wonder if should be ckecked also that the urls are actual filesystem urls > > or if is fine to just blindlt trash everything thrown at it since if it's > > not a filesystem one should fail > > Sebastian Kügler wrote: >

Re: Review Request 124112: Implement drag and drop for Trash applet

> On June 17, 2015, 3:51 p.m., Marco Martin wrote: > > looks good. > > I wonder if should be ckecked also that the urls are actual filesystem urls > > or if is fine to just blindlt trash everything thrown at it since if it's > > not a filesystem one should fail > > Sebastian Kügler wrote: >

Re: Review Request 124113: Ignore invalid X-Plasma-ConfigPlugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124113/#review81531 --- Ship it! Ship It! - Marco Martin On June 16, 2015, 6:33 p.

Re: Review Request 124112: Implement drag and drop for Trash applet

> On June 17, 2015, 3:51 p.m., Marco Martin wrote: > > looks good. > > I wonder if should be ckecked also that the urls are actual filesystem urls > > or if is fine to just blindlt trash everything thrown at it since if it's > > not a filesystem one should fail I think even isLocalFile() and i

Re: Review Request 124112: Implement drag and drop for Trash applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/#review81527 --- Ship it! looks good. I wonder if should be ckecked also that

Re: Lockscreen multiscreen behavior

Am 2015-06-17 14:39, schrieb David Kahles: On 06/17/2015 05:30 AM, Martin Gräßlin wrote: Am 2015-06-16 16:58, schrieb David Kahles: Hello, I want to hear some opinions about the multiscreen behavior of the lockscreen. Currently the lockscreen is displayed on all connected monitors. I would p

Re: Lockscreen multiscreen behavior

On 06/17/2015 05:30 AM, Martin Gräßlin wrote: Am 2015-06-16 16:58, schrieb David Kahles: Hello, I want to hear some opinions about the multiscreen behavior of the lockscreen. Currently the lockscreen is displayed on all connected monitors. I would prefer if the lockscreen is displayed only on