Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/ --- (Updated 9月 3, 2015, 10:22 a.m.) Review request for Plasma. Repository:

Re: Review Request 125030: kwayland contrast protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/#review84774 --- I'll re-raise general concerns about the contrast effect. Why

Review Request 125030: kwayland contrast protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/ --- Review request for kwin and Plasma. Repository: kwayland Description --

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/#review84772 --- Good stuff! +1 - Aleix Pol Gonzalez On Sept. 2, 2015, 5:18

Re: [plasma-framework] src/plasma: plasma: Fix applet actions might be nullptr

On Wed, Aug 26, 2015 at 5:38 AM, Christoph Feck wrote: > On Wednesday 26 August 2015 11:27:05 Leslie Zhai wrote: > > Git commit 4e9b32d80d6b43ad3d1ddd47c948ad066608b052 by Leslie > Zhai. > > Committed on 26/08/2015 at 09:24. > > Pushed by lesliezhai into branch 'master'. > > > > plasma: Fix apple

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- (Updated 9月 3, 2015, 12:18 a.m.) Review request for Plasma. Changes ---

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On 9月 2, 2015, 11:14 p.m., Alex Richardson wrote: > > startkde/kstartupconfig/kdostartupconfig.cpp, line 86 > > > > > > `QByteArray buf = keys.readLine()` > > > > I don't see the point of preallocation

Re: Review Request 125029: Monitor timezone changing from timedated rather than our clock KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125029/ --- (Updated Sept. 2, 2015, 2:54 p.m.) Status -- This change has been di

Re: Review Request 125029: Monitor timezone changing from timedated rather than our clock KCM

> On Sept. 2, 2015, 2:35 p.m., Martin Klapetek wrote: > > But the ktimezoned should do exactly that; it monitors various files which > > timedate modifies and then sends that signal. Does ktimezoned not work in > > that case (it did when I last test it)? I think better place for this > > signa

Re: Review Request 125029: Monitor timezone changing from timedated rather than our clock KCM

> On Sept. 2, 2015, 4:35 p.m., Martin Klapetek wrote: > > But the ktimezoned should do exactly that; it monitors various files which > > timedate modifies and then sends that signal. Does ktimezoned not work in > > that case (it did when I last test it)? I think better place for this > > signa

Re: Review Request 125029: Monitor timezone changing from timedated rather than our clock KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125029/#review84766 --- But the ktimezoned should do exactly that; it monitors various

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On Sept. 2, 2015, 3:14 p.m., Alex Richardson wrote: > > startkde/kstartupconfig/kdostartupconfig.cpp, line 86 > > > > > > `QByteArray buf = keys.readLine()` > > > > I don't see the point of preallocatio

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/#review84764 --- startkde/kstartupconfig/kdostartupconfig.cpp (line 86)

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On Aug. 31, 2015, 7 p.m., Aleix Pol Gonzalez wrote: > > To be honest, I don't see how this should make a difference... > > Takahiro Hashimoto wrote: > I'm sorry for lacking of my explanation... > > > Please see the difference of QString::fromLocal8Bit(const QByteArray > &str

Re: Review Request 125028: Monitor for the clock changes from the kernel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/#review84759 --- +1, modulo ifdefs - Marco Martin On Sept. 2, 2015, 10:29 a.

Re: Review Request 125029: Monitor timezone changing from timedated rather than our clock KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125029/#review84758 --- Ship it! Ship It! - Marco Martin On Sept. 2, 2015, 10:33 a

Re: Review Request 125016: stub effects implementation + blur implementation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125016/ --- (Updated Sept. 2, 2015, 12:44 p.m.) Status -- This change has been m

Re: Review Request 125017: make blur effect work in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125017/ --- (Updated Sept. 2, 2015, 12:44 p.m.) Status -- This change has been m

Re: Review Request 125015: Blur protocol in KWayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125015/ --- (Updated Sept. 2, 2015, 12:43 p.m.) Status -- This change has been m

Re: Review Request 125028: Monitor for the clock changes from the kernel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/#review84757 --- Looks good to me dataengines/time/timeengine.cpp (line 32) <

Re: Review Request 125016: stub effects implementation + blur implementation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125016/#review84755 --- Ship it! Ship It! - Martin Gräßlin On Sept. 2, 2015, 1:28

Re: Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121915/ --- (Updated Sept. 2, 2015, 11:38 a.m.) Status -- This change has been m

Re: Review Request 118275: Remove duplicated code in showEvent and constructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/ --- (Updated Sept. 2, 2015, 11:36 a.m.) Status -- This change has been d

Re: Review Request 109693: Try to complete locking screen before suspend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109693/ --- (Updated Sept. 2, 2015, 1:35 p.m.) Status -- This change has been di

Re: Review Request 109693: Try to complete locking screen before suspend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109693/#review84754 --- just as a late update to the review request: in 5.x the ksldap

Re: Review Request 125016: stub effects implementation + blur implementation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125016/ --- (Updated Sept. 2, 2015, 11:28 a.m.) Review request for kwin and Plasma.

Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110476/ --- (Updated Sept. 2, 2015, 1:27 p.m.) Status -- This change has been di

Re: Review Request 125017: make blur effect work in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125017/#review84752 --- Ship it! Ship It! - Martin Gräßlin On Sept. 1, 2015, 2:43

Re: Review Request 125015: Blur protocol in KWayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125015/#review84751 --- Ship it! Looks good autotests/client/test_wayland_blur.cpp

Re: Plasma Mobile Design (a new attempt)

* Martin Klapetek [2015-09-01 13:40:03 -0400]: > On Tue, Sep 1, 2015 at 6:52 AM, Jens Reuterberg wrote: > > > Ok so there has been a proposal for a set of Plasma Mobile HIG's and > > designs. > > It was sent out a while back (or so I thought because something must have > > gone > > weird with m

Re: Review Request 125016: stub effects implementation + blur implementation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125016/#review84750 --- src/windowsystem/windoweffects.h (line 30)

Re: Review Request 125026: Wayland implementation for DPMS

> On Sept. 2, 2015, 12:07 p.m., Kai Uwe Broulik wrote: > > daemon/actions/dpms/abstractdpmshelper.h, line 27 > > > > > > why = default not here? default in the header is problematic. E.g. if you use a QScopedPoin

Review Request 125029: Monitor timezone changing from timedated rather than our clock KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125029/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 125028: Monitor for the clock changes from the kernel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125026: Wayland implementation for DPMS

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125026/#review84747 --- Nice! Just a few style nitpicks below, haven't tested it yet.

Re: Review Request 124374: custom inline edit menu for plasma controls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/ --- (Updated Sept. 2, 2015, 9:58 a.m.) Status -- This change has been ma

Re: Review Request 124374: custom inline edit menu for plasma controls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/#review84746 --- Ship it! Ship It! - Kai Uwe Broulik On Sept. 2, 2015, 9:45

Re: Review Request 124374: custom inline edit menu for plasma controls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/ --- (Updated Sept. 2, 2015, 9:45 a.m.) Review request for Plasma. Repositor

Re: Review Request 124374: custom inline edit menu for plasma controls

> On Sept. 2, 2015, 9:15 a.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmastyle/EditMenuTouch.qml, line 62 > > > > > > Imho it's cleaner if we just have a floating paste button if you cannot > > copy

Re: Review Request 124374: custom inline edit menu for plasma controls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/#review84743 --- +1 A few style nitpicks I didn't explicitly mention below (sp

Review Request 125026: Wayland implementation for DPMS

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125026/ --- Review request for Plasma, Solid and Kai Uwe Broulik. Repository: powerde