Re: Review Request 125223: Add support for transient to ShellSurface(Interface)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125223/ --- (Updated Sept. 16, 2015, 6:26 a.m.) Status -- This change has been m

How to speed up QML for KDE5 without QML compiler

Hi great Qt and KDE developers, I like QML, it is high speed development language, easy to create candy UI and not difficult to debug. KDE4 began to use it in some projects, for example, KScreen`s kcm module, it used QML to take place of traditional QWidget. and KDE5, it is full of QML, for ex

Re: Review Request 125248: Display name of process which blocks umount / eject

> On Sept. 15, 2015, 10:41 p.m., Martin Klapetek wrote: > > dataengines/devicenotifications/ksolidnotify.cpp, line 122 > > > > > > This should be a private method rather than a static method > > > > (and

Re: Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/#review85474 --- dataengines/devicenotifications/ksolidnotify.cpp (line 39)

Re: Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/#review85473 --- dataengines/devicenotifications/ksolidnotify.cpp (line 131) <

Re: Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/#review85469 --- dataengines/devicenotifications/ksolidnotify.cpp (line 122) <

Re: Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- (Updated Сен. 15, 2015, 9:41 п.п.) Review request for Plasma and Solid.

Re: Review Request 125226: move EventForge from the desktop containment

> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 51 > > > > > > why do people need to do this? > > Eike Hein wrote: > It basically triggers

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/#review85466 --- src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp (

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/#review85465 --- kcms/baloo/kcm.cpp (line 168)

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/#review85462 --- Maybe we could just add this to our `IndexerConfig` class so t

Re: Review Request 125223: Add support for transient to ShellSurface(Interface)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125223/#review85459 --- Ship it! Ship It! - Sebastian Kügler On Sept. 14, 2015, 2:

Re: Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/#review85458 --- Yes!! Thank you. Couple nitpickings below. dataengines/devic

Review Request 125248: Display name of process which blocks umount / eject

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- Review request for Plasma and Solid. Repository: plasma-workspace Descr

Re: Review Request 125226: move EventForge from the desktop containment

> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 51 > > > > > > why do people need to do this? It basically triggers the onCanceled handler in

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 15, 2015, 5:32 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 15, 2015, 5:30 p.m.) Review request for KDE Frameworks, Pl

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #16 from Weng Xuetian --- (In reply to Igor Poboiko from comment #15) > (In reply to Weng Xuetian from comment #14) > > FYI, https://git.reviewboard.kde.org/r/125182/ > What's the status of that patch? > That check was there from very begin

Re: Review Request 125240: Use lineedit svg margins in sizeHint calculation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125240/#review85446 --- Ship it! Ship It! - Marco Martin On Sept. 15, 2015, 1:50 p

Review Request 125240: Use lineedit svg margins in sizeHint calculation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125240/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 125187: Stop requiring Frameworks 5.15

> On Sept. 14, 2015, 10:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > >

Jenkins-kde-ci: plasma-workspace Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Sep 2015 09:53:14 + Build duration: 7 min 17 sec CHANGE SET Revision 93bf81eea152e2b8261

Jenkins-kde-ci: plasma-workspace Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Sep 2015 09:53:14 + Build duration: 7 min 17 sec CHANGE SET Revision 93bf81eea152e2b8261

Re: Review Request 125187: Stop requiring Frameworks 5.15

> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > >

Re: Review Request 125235: Make sure the cancel and shutdown/logout button have the same size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125235/ --- (Updated Sept. 15, 2015, 9:52 a.m.) Status -- This change has been m

Re: Review Request 125198: by default do not restore the previous session on next login

> On Sept. 14, 2015, 6:05 a.m., Martin Gräßlin wrote: > > +1 - as a note: in openSUSE users were quite angry that we had broken > > session management, they won't be glad about the choice. My personal > > opinion is (as many probably known) that I would drop all session > > management support

Re: Review Request 125226: move EventForge from the desktop containment

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote: > > This class feels like it's just working round Qt bugs? > > > > Other than that if this is long-term useful, we should do sendPress(flags > > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened > > to need (or make i

Re: Review Request 125226: move EventForge from the desktop containment

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote: > > This class feels like it's just working round Qt bugs? > > > > Other than that if this is long-term useful, we should do sendPress(flags > > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened > > to need (or make i

Re: Review Request 125187: Stop requiring Frameworks 5.15

> On Sept. 14, 2015, 10:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > >

Re: Review Request 125226: move EventForge from the desktop containment

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote: > > This class feels like it's just working round Qt bugs? > > > > Other than that if this is long-term useful, we should do sendPress(flags > > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened > > to need (or make i

Re: Review Request 125198: by default do not restore the previous session on next login

> On Sept. 14, 2015, 6:05 a.m., Martin Gräßlin wrote: > > +1 - as a note: in openSUSE users were quite angry that we had broken > > session management, they won't be glad about the choice. My personal > > opinion is (as many probably known) that I would drop all session > > management support

Re: Review Request 125235: Make sure the cancel and shutdown/logout button have the same size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125235/#review85427 --- Ship it! Ship It! - Marco Martin On Sept. 15, 2015, 8:49 a

Review Request 125235: Make sure the cancel and shutdown/logout button have the same size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125235/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125198: by default do not restore the previous session on next login

> On Sept. 12, 2015, 9:25 p.m., Kai Uwe Broulik wrote: > > Same for me. +1 > > OS X has a check box on the logout dialog, perhaps we could have something > > similar to make thmore discoverable > > David Edmundson wrote: > Oooh! I like that idea a lot. It can default to what the user last

Re: Review Request 125198: by default do not restore the previous session on next login

> On Sept. 14, 2015, 6:05 a.m., Martin Gräßlin wrote: > > +1 - as a note: in openSUSE users were quite angry that we had broken > > session management, they won't be glad about the choice. My personal > > opinion is (as many probably known) that I would drop all session > > management support

Re: Review Request 125187: Stop requiring Frameworks 5.15

> On Sept. 14, 2015, 10:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > >

Re: Review Request 125187: Stop requiring Frameworks 5.15

> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > >

Re: Review Request 125234: [wayland] Add key repeat information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125234/#review85422 --- Ship it! Modules/base/info_wayland.cpp (line 100)

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #15 from Igor Poboiko --- (In reply to Weng Xuetian from comment #12) > Disable vsync helps me to workaround the issue, you may try that to see if > it works for you.. No, unfortunately it didn't. (In reply to Weng Xuetian from comment #14)

Review Request 125234: [wayland] Add key repeat information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125234/ --- Review request for Plasma. Repository: kinfocenter Description ---

Re: Adding further modules to api.kde.org

Hi Allen, is there anything I can do to help get the documentation updated? I want to include KWayland in inqlude (patch is prepared) and I find a little bit embarrassing for KDE to have the api docs to point to http://kde.martin-graesslin.com/kwayland/index.html Cheers Martin On Thursday, Se