Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread Marco Martin
> On Sept. 23, 2015, 4:46 p.m., David Edmundson wrote: > > src/plasma/private/applet_p.cpp, line 171 > > > > > > +1 to the idea, > > > > I'm not sure this is the right place though. > > We have an

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread Marco Martin
> On Sept. 23, 2015, 4:46 p.m., David Edmundson wrote: > > src/plasma/private/applet_p.cpp, line 171 > > > > > > +1 to the idea, > > > > I'm not sure this is the right place though. > > We have an

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/ --- (Updated Sept. 24, 2015, 10:12 a.m.) Review request for KDE Frameworks

Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

2015-09-24 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125369/ --- Review request for Baloo and Plasma. Repository: plasma-workspace

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/#review85868 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2015,

Review Request 125376: KNotification: don't update notification twice

2015-09-24 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125376/ --- Review request for Plasma and Martin Klapetek. Repository:

Re: Review Request 125376: KNotification: don't update notification twice

2015-09-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125376/#review85875 --- Thanks for the patch. Is it reproducible with anything else?

Re: Review Request 125336: if the desktop file has Icon=/foo.svgz use that file from package

2015-09-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125336/ --- (Updated Sept. 24, 2015, 7:03 p.m.) Status -- This change has been

Re: KFontInst bugs

2015-09-24 Thread Christoph Feck
Hi Craig, On Thursday 24 September 2015 18:47:36 Craig Drummond wrote: > Hi, > > Noticed that you've set a lot of font installation bug reports as > duplicates, etc. However, I no longer have the time to look after > the font manager and its related tools. Therefore, I think it'd be > better for

Re: Review Request 125328: kcm_keyboard: Remove Spare Layout option

2015-09-24 Thread David Edmundson
> On Sept. 24, 2015, 9:03 p.m., David Edmundson wrote: > > What doesn't work? I just tried spare layouts here, and it seemed to be > > behaving OK. > > David Rosca wrote: > Oops, you are right. It works with 3 and more layouts configured. > But there is a bug when you have 2 or less

Re: Review Request 125328: kcm_keyboard: Fix configuring Spare Layouts

2015-09-24 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125328/ --- (Updated Sept. 24, 2015, 11:10 p.m.) Review request for Plasma.

Re: Review Request 125280: kded_keyboard: Don't save default config in layout memory

2015-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125280/#review85886 --- Ship it! Ship It! - David Edmundson On Sept. 17, 2015,

Re: Review Request 125328: kcm_keyboard: Remove Spare Layout option

2015-09-24 Thread David Rosca
> On Sept. 24, 2015, 9:03 p.m., David Edmundson wrote: > > What doesn't work? I just tried spare layouts here, and it seemed to be > > behaving OK. Oops, you are right. It works with 3 and more layouts configured. But there is a bug when you have 2 or less configured layouts and when you open

Re: Review Request 125328: kcm_keyboard: Fix configuring Spare Layouts

2015-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125328/#review85901 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2015,

Re: Review Request 125327: kded_keyboard: Fix re-applying layout settings when plugging in new keyboard

2015-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125327/#review85700 --- Ship it! kcms/keyboard/layout_memory.cpp (line 131)

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

2015-09-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125369/#review85905 --- runners/baloo/baloosearchrunner.cpp (line 165)

Re: Review Request 125376: KNotification: don't update notification twice

2015-09-24 Thread Igor Poboiko
> On Сен. 24, 2015, 3:56 п.п., Martin Klapetek wrote: > > Thanks for the patch. Is it reproducible with anything else? Also, can you > > point me to the ktp code in question? > > > > Thanks It's

Re: Review Request 125328: kcm_keyboard: Remove Spare Layout option

2015-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125328/#review85894 --- What doesn't work? I just tried spare layouts here, and it