Re: Review Request 125618: Fixes to KameraConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125618/#review87639 --- Submitted with commit 891536d11f1779ee21a23b18fc2d3558f77bbc89

Re: Review Request 125618: Fixes to KameraConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125618/ --- (Updated Oct. 29, 2015, 7:09 a.m.) Status -- This change has been ma

Review Request 125858: Fix SystemLoadViewer freezing plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125858/ --- Review request for Plasma, David Edmundson and Martin Yrjölä. Repository:

Re: Review Request 125842: make most windows minimizable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125842/#review87640 --- Ship it! Ship It! - Martin Gräßlin On Oct. 28, 2015, 6:21

[Plasma Workspace Wallpapers] [Bug 354526] Background and panel disappears from virtual desktop

https://bugs.kde.org/show_bug.cgi?id=354526 David Rosca changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC|

Re: Review Request 125848: [kscreenlocker_greet] Fix QML fallback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125848/#review87649 --- Ship it! Ship It! - Martin Gräßlin On Oct. 28, 2015, 9:46

Re: Review Request 125849: [kscreenlocker_greet] Port fallback theme to SessionsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125849/#review87650 --- Ship it! Ship It! - Martin Gräßlin On Oct. 28, 2015, 9:52

Re: Review Request 125851: [kscreenlocker] Remove KWorkspace dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125851/#review87651 --- Ship it! Ship It! - Martin Gräßlin On Oct. 28, 2015, 10:01

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review87652 --- xembed-sni-proxy/COPYING.LIB (line 1)

Re: Review Request 125836: Support request resizing on ShellSurface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125836/ --- (Updated Oct. 29, 2015, 9:25 a.m.) Status -- This change has been ma

Re: Review Request 125828: Support request moving on ShellSurface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125828/ --- (Updated Oct. 29, 2015, 9:25 a.m.) Status -- This change has been ma

Re: Review Request 125842: make most windows minimizable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125842/ --- (Updated Oct. 29, 2015, 9:32 a.m.) Status -- This change has been ma

Re: Review Request 125858: Fix SystemLoadViewer freezing plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125858/#review87653 --- Ship it! ok with the patch, but the dataengine should be fixe

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/ --- (Updated Oct. 29, 2015, 4:23 p.m.) Review request for Plasma and Martin G

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/#review87657 --- Ship it! Ship It! - Martin Gräßlin On Oct. 29, 2015, 11:53

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/ --- (Updated Oct. 29, 2015, 11:12 a.m.) Status -- This change has been m

Re: Review Request 125858: Fix SystemLoadViewer freezing plasmashell

> On Oct. 29, 2015, 9:33 a.m., Marco Martin wrote: > > ok with the patch, but the dataengine should be fixed as well? Yes somebody should fix it, but I'm not familiar with the data engine... and in the bug report David Edmundson said: "for 5.5 I'm rewriting this garbage with a proper import wh

Re: Review Request 125858: Fix SystemLoadViewer freezing plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125858/#review87660 --- Ship it! Ship It! - David Edmundson On Oct. 29, 2015, 7:20

Re: Review Request 125858: Fix SystemLoadViewer freezing plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125858/ --- (Updated Oct. 29, 2015, 12:18 p.m.) Status -- This change has been m

Re: Review Request 125858: Fix SystemLoadViewer freezing plasmashell

> On Oct. 29, 2015, 11:55 a.m., David Edmundson wrote: > > Ship It! Should I backport to 5.4 branch? - Kåre --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125858/#review87660 --

Re: Review Request 125858: Fix SystemLoadViewer freezing plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125858/#review87663 --- can you push into branch Plamsa/5.4 too - David Edmundson O

Re: Review Request 125770: Emit correct signal for notifications expiring

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125770/ --- (Updated Oct. 29, 2015, 2:21 p.m.) Status -- This change has been ma

Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/#review87673 --- ksmserver/screenlocker/CMakeLists.txt (line 39)

Review Request 125864: Add back the Agenda part of the Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125864/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125775/#review87675 --- does this close: https://bugs.kde.org/show_bug.cgi?id=354543

Review Request 125870: Update drkonqui hints for relevant information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125870/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

> On Oct. 29, 2015, 4:44 p.m., David Edmundson wrote: > > does this close: https://bugs.kde.org/show_bug.cgi?id=354543 Yes - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125775/

Re: Review Request 125870: Update drkonqui hints for relevant information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125870/#review87677 --- Ship it! Ship It! - Sebastian Kügler On Oct. 29, 2015, 4:4

Re: Review Request 125864: Add back the Agenda part of the Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125864/#review87678 --- Ship it! Some minor things, otherwise, go for it. It looks ni

Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/ --- Review request for kwin and Plasma. Repository: kwayland Description --

Re: Review Request 125864: Add back the Agenda part of the Calendar

> On Oct. 29, 2015, 5:55 p.m., Sebastian Kügler wrote: > > applets/digital-clock/package/contents/ui/CalendarView.qml, line 99 > > > > > > if (updatedData === monthView.currentDate) ? > > > > I don't know

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

> On Oct. 29, 2015, 4:44 p.m., David Edmundson wrote: > > does this close: https://bugs.kde.org/show_bug.cgi?id=354543 > > David Rosca wrote: > Yes could you close it then? You don't want me claiming your bugzilla stats as my own :D - David --

Re: Review Request 125864: Add back the Agenda part of the Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125864/#review87682 --- applets/digital-clock/package/contents/ui/CalendarView.qml (l

Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- Review request for kwin and Plasma. Repository: kwin Description --

Re: Review Request 125864: Add back the Agenda part of the Calendar

> On Oct. 29, 2015, 4:55 p.m., Sebastian Kügler wrote: > > applets/digital-clock/package/contents/ui/CalendarView.qml, line 99 > > > > > > if (updatedData === monthView.currentDate) ? > > > > I don't know

Re: Review Request 125870: Update drkonqui hints for relevant information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125870/ --- (Updated Oct. 29, 2015, 5:12 p.m.) Status -- This change has been ma

Re: Review Request 125870: Update drkonqui hints for relevant information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125870/#review87686 --- drkonqi/applicationdetailsexamples.cpp (line 35)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 253 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/253/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 17:12:28 + Build duration: 13 min CHANGE SET Revision 9cce76bc4b12c18ef7796e8a62311275bd2

Re: Review Request 125870: Update drkonqui hints for relevant information

> On Oct. 29, 2015, 5:22 p.m., Kai Uwe Broulik wrote: > > drkonqi/applicationdetailsexamples.cpp, line 36 > > > > > > you forgot parenthesis after "kwin_x11" Thanks, I was obviously deliberately testing who'd not

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 254 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 17:45:24 + Build duration: 7 min 13 sec CHANGE SET Revision 1b312493995b4ae488786730308c7

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/ --- (Updated Oct. 29, 2015, 6:16 p.m.) Review request for Plasma. Changes -

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 255 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/255/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 18:58:44 + Build duration: 16 min CHANGE SET Revision 00e33656c2676a5447b940e327dc3bc8472

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 255 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/255/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 18:58:44 + Build duration: 16 min CHANGE SET Revision 00e33656c2676a5447b940e327dc3bc8472

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/#review87697 --- What's the point of client relative geometries? Afaics, there

Review Request 125878: fix lost QuickViewSharedEngine initialSize on initializing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/ --- Review request for Plasma, David Edmundson and David Faure. Summary (upda

Re: Review Request 125878: fix lost QuickViewSharedEngine initialSize on initializing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/ --- (Updated 10月 30, 2015, 12:03 p.m.) Review request for Plasma, David Edmun

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

> On Oct. 29, 2015, 9:31 p.m., Hrvoje Senjan wrote: > > ksmserver/screenlocker/CMakeLists.txt, line 39 > > > > > > you also didn't set the SOVERSION Fixed in : http://commits.kde.org/plasma-workspace/f33bd8ab57c

Re: Review Request 125878: fix lost QuickViewSharedEngine initialSize on initializing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/ --- (Updated 10月 30, 2015, 2:07 p.m.) Review request for Plasma, David Edmund

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review87715 --- CMakeLists.txt (line 31)

Re: Review Request 125870: Update drkonqui hints for relevant information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125870/#review87716 --- drkonqi/applicationdetailsexamples.cpp (lines 37 - 39)