Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

> On Oct. 29, 2015, 9:32 p.m., Thomas Lübking wrote: > > What's the point of client relative geometries? > > > > Afaics, there'll be two "problematic" scenarios. > > > > 1) >= 2 taskbars on >= 1 screens, the window is minimized from the taskbar > > 2) >= 2 taskbars on >= 2 screens, the window

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

> On Okt. 29, 2015, 8:32 nachm., Thomas Lübking wrote: > > What's the point of client relative geometries? > > > > Afaics, there'll be two "problematic" scenarios. > > > > 1) >= 2 taskbars on >= 1 screens, the window is minimized from the taskbar > > 2) >= 2 taskbars on >= 2 screens, the

Re: Review Request 125870: Update drkonqui hints for relevant information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125870/#review87716 --- drkonqi/applicationdetailsexamples.cpp (lines 37 - 39)

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review87715 --- CMakeLists.txt (line 31)

[Powerdevil] [Bug 354623] New: Full charge not trigger notification

https://bugs.kde.org/show_bug.cgi?id=354623 Bug ID: 354623 Summary: Full charge not trigger notification Product: Powerdevil Version: 5.4.2 Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED

Re: Review Request 125878: fix lost QuickViewSharedEngine initialSize on initializing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/ --- (Updated Oct. 30, 2015, 9:06 p.m.) Status -- This change has been

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/#review87736 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On

Re: Review Request 125878: fix lost QuickViewSharedEngine initialSize on initializing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/#review87734 --- +1 - Aleix Pol Gonzalez On Oct. 30, 2015, 6:07 a.m.,

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/ --- (Updated Oct. 30, 2015, 5:53 a.m.) Status -- This change has been

Re: Review Request 125622: Use better guard against recursion when changing volume with sliders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125622/#review87738 --- Sorry I put the wrong review number on the commit for 125662

Re: Review Request 125851: [kscreenlocker] Remove KWorkspace dependency

> On Oct. 29, 2015, 2:20 p.m., Martin Gräßlin wrote: > > Ship It! Submitted in http://commits.kde.org/plasma-workspace/ab258330725cc03af3a90c721e3dc684864d8cf1 on behalf of Kai, though forgot review: - Bhushan --- This is an

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/ --- (Updated Oct. 30, 2015, 12:09 p.m.) Status -- This change has been

Re: Review Request 125774: [Lock Screen] Use org.kde.plasma.private.sessions for User Switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125774/ --- (Updated Oct. 30, 2015, 12:09 p.m.) Status -- This change has been

Re: Review Request 125622: Use better guard against recursion when changing volume with sliders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125622/ --- (Updated Oct. 30, 2015, 5:54 a.m.) Status -- This change has been

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87768 --- src/declarativeimports/calendar/calendarplugin.cpp (line 36)

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 31, 2015, 2:08 a.m., David Edmundson wrote: > > src/declarativeimports/calendar/daysmodel.h, line 44 > > > > > > I think we need some sort of > > > > QStringList availablePlugins() > > > >

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

> On Oct. 29, 2015, 8:32 p.m., Thomas Lübking wrote: > > What's the point of client relative geometries? > > > > Afaics, there'll be two "problematic" scenarios. > > > > 1) >= 2 taskbars on >= 1 screens, the window is minimized from the taskbar > > 2) >= 2 taskbars on >= 2 screens, the window

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

> On Oct. 29, 2015, 8:32 p.m., Thomas Lübking wrote: > > What's the point of client relative geometries? > > > > Afaics, there'll be two "problematic" scenarios. > > > > 1) >= 2 taskbars on >= 1 screens, the window is minimized from the taskbar > > 2) >= 2 taskbars on >= 2 screens, the window

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/ --- (Updated Oct. 30, 2015, 1:13 p.m.) Review request for kwin and Plasma.

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 1:13 p.m.) Review request for kwin and Plasma.

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/ --- (Updated Oct. 30, 2015, 1:24 p.m.) Review request for kwin and Plasma.

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/ --- (Updated Oct. 30, 2015, 2:15 p.m.) Review request for kwin and Plasma.

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 1:43 p.m.) Review request for kwin and Plasma.

Re: HIG and components API

On Thu, Oct 22, 2015 at 7:15 PM, Thomas Pfeiffer wrote: > > If you're looking also for input on the HIG compliance, screenshots are > helpful :) sorry it taken a long time: https://www.youtube.com/watch?v=WfhcWRHCEtA (ignore the fixed scrollbars, that's because is on a

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 3:31 p.m.) Review request for kwin and Plasma.

Re: Review Request 125873: preliminar support for task geometries in wayland

> On Oct. 30, 2015, 2:32 p.m., Martin Gräßlin wrote: > > main_wayland.cpp, lines 378-380 > > > > > > only if you want to break kwin for everybody with an up to date Qt 5.6 ah, right sorry, forgot that :( > On

Re: Review Request 125873: preliminar support for task geometries in wayland

> On Oct. 30, 2015, 3:32 p.m., Martin Gräßlin wrote: > > abstract_client.h, line 830 > > > > > > why friend an inheriting class? > > Marco Martin wrote: > because m_windowManagementInterface is private in

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/#review87746 --- abstract_client.h (line 830)

[Differential] [Updated, 917 lines] D409: new mobile components

mart updated this revision to Diff 1110. REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D409?vs=1066=1110 REVISION DETAIL https://phabricator.kde.org/D409 AFFECTED FILES components/mobilecomponents/ActionGroup.qml

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Oct. 30, 2015, 7:51 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 31 > > > > > > Should it be a required dep? I think it wasn't in 4.x? And reading the > > code it should be easy to have it optional

Jenkins-kde-ci: plasma-workspace Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 39 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Oct 2015 16:20:01 + Build duration: 17 min CHANGE SET Revision

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- (Updated Oct. 30, 2015, 3:54 p.m.) Review request for Plasma.

Jenkins-kde-ci: plasma-workspace Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 39 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Oct 2015 16:20:01 + Build duration: 17 min CHANGE SET Revision

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 4:08 p.m.) Review request for kwin and Plasma.

Re: Review Request 125878: fix lost QuickViewSharedEngine initialSize on initializing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/#review87752 --- Ship it! Ship It! - Marco Martin On Oct. 30, 2015, 5:07

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/#review87751 --- src/client/plasmawindowmanagement.h (line 243)

Re: Review Request 125864: Add back the Agenda part of the Calendar

> On Oct. 29, 2015, 5:55 p.m., Sebastian Kügler wrote: > > applets/digital-clock/package/contents/ui/CalendarView.qml, line 46 > > > > > > Could you clean this out before committing as well? (I know, nothing to

Re: Review Request 125864: Add back the Agenda part of the Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125864/ --- (Updated Oct. 30, 2015, 8:11 p.m.) Review request for Plasma. Changes

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/#review87753 --- abstract_client.h (line 601)

Re: Review Request 125873: preliminar support for task geometries in wayland

> On Oct. 30, 2015, 4:52 p.m., Thomas Lübking wrote: > > shell_client.cpp, line 412 > > > > > > should the panel also be tested for being on the same screen (ie. same > > screen takes precedence over closer,

Re: Review Request 125873: preliminar support for task geometries in wayland

> On Oct. 30, 2015, 4:52 p.m., Thomas Lübking wrote: > > shell_client.cpp, line 413 > > > > > > just store the iterator? kindof prefer this way, but i can do it, sure - Marco

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 5:42 p.m.) Review request for kwin and Plasma.

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/ --- (Updated Oct. 30, 2015, 5:37 p.m.) Review request for kwin and Plasma.

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/ --- (Updated Oct. 30, 2015, 11:29 a.m.) Review request for kwin and Plasma.