Re: Review Request 126008: [wayland] use Qt::AA_DisableHighDpiScaling in Qt 5.6

2015-11-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126008/#review88212 --- *sigh* now I have to update my Qt... Thanks for fixing! - Ma

Re: Plasma 5.5 Release Anouncements

2015-11-09 Thread Martin Graesslin
On Monday, November 9, 2015 9:39:44 PM CET David Edmundson wrote: > On Mon, Nov 9, 2015 at 5:08 PM, Martin Klapetek > > wrote: > > On Sun, Nov 8, 2015 at 8:16 AM, David Edmundson < > > > > da...@davidedmundson.co.uk> wrote: > >> With the proposed no-delay beta, that means we need to start on our

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread Martin Graesslin
On Tuesday, November 10, 2015 12:33:17 AM CET Thomas Pfeiffer wrote: > That's why I now focus only on review requests or bug reports where the VDG > or usability team is explicitly added. I hope I catch most of the important > stuff that way, but there are definitely important emails falling throug

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread Martin Graesslin
On Monday, November 9, 2015 11:38:42 PM CET kainz.a wrote: > Yes different communication systems are one of the main problem. Different > tasks are the second problem. When I read the VDG forum threads or the > Telegram thread there was discussion about some stuff but less than 5% are > bugfixing a

Re: Review Request 125973: Remove completely duplicated function

2015-11-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/#review88210 --- By the duplicated function you mean PlasmoidTask::showMenu(int

Re: Plasma 5.5 Release Anouncements

2015-11-09 Thread Martin Klapetek
On Mon, Nov 9, 2015 at 4:39 PM, David Edmundson wrote: > >> Absolutely. Which Monday do you mean? Today? >> > > I did. > (unless you read this tomorrow, in which case I meant yesterday) > > Though the release has slipped by a day too, so it's all good. > Isn't the beta release in 10 days? I woul

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-09 Thread Johan Ouwerkerk
> On Nov. 10, 2015, 1:26 a.m., David Edmundson wrote: > > Ship It! Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep branch at: g...@github.com:cmacq2/plasma-desktop.git - Johan --- This is an automatically gene

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126013/#review88208 --- Ship it! Ship It! - David Edmundson On Nov. 10, 2015, 12:5

Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-09 Thread Johan Ouwerkerk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126013/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 125972: Don't list systray containment actions in systray context menu.

2015-11-09 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125972/#review88207 --- Why is that? How is the systray different from other widgets i

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread Thomas Pfeiffer
On Monday 09 November 2015 01:10:41 Valorie Zimmerman wrote: > First, are all the designers on this list? If not, it's difficult to > have a dialog. Please make sure that at least andreas_k and uriherrera > (irc nicks) become part of this conversation. After all, they are > Plasma devels. Just my

Re: Review Request 126008: [wayland] use Qt::AA_DisableHighDpiScaling in Qt 5.6

2015-11-09 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126008/ --- (Updated Nov. 9, 2015, 10:48 p.m.) Status -- This change has been ma

Review Request 125972: Don't list systray containment actions in systray context menu.

2015-11-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125972/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 125973: Remove completely duplicated function

2015-11-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread kainz.a
Hi, 2015-11-09 22:52 GMT+01:00 David Edmundson : > the thing is that we are depanded to an programmer but the programmer >> isn't related and when we make something by alone like the plasma theme or >> icons we get the message you have to ask first. >> > > Yes. All of us ask permission for all c

Re: Review Request 125997: Catch other openGL error gracefully

2015-11-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125997/ --- (Updated Nov. 9, 2015, 10:30 p.m.) Status -- This change has been ma

Review Request 126012: Fix crash if context gets unrefd

2015-11-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126012/ --- Review request for Plasma and Harald Sitter. Repository: plasma-pa Desc

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/#review88206 --- src/declarativeimports/calendar/eventpluginsmanager.cpp (line

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread David Edmundson
> > the thing is that we are depanded to an programmer but the programmer > isn't related and when we make something by alone like the plasma theme or > icons we get the message you have to ask first. > Yes. All of us ask permission for all changes we make. You've seen us do that. You can comment

Re: Review Request 126008: [wayland] use Qt::AA_DisableHighDpiScaling in Qt 5.6

2015-11-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126008/#review88204 --- Ship it! Ship It! - David Edmundson On Nov. 9, 2015, 5:48

Re: Plasma 5.5 Release Anouncements

2015-11-09 Thread David Edmundson
On Mon, Nov 9, 2015 at 5:08 PM, Martin Klapetek wrote: > On Sun, Nov 8, 2015 at 8:16 AM, David Edmundson < > da...@davidedmundson.co.uk> wrote: > >> With the proposed no-delay beta, that means we need to start on our >> release anouncement already. >> >> Can everyone write down their big changes

Review Request 126010: [digital-clock] Split the Calendar config stuff to it's own category + load the plugins configs

2015-11-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126010/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/ --- (Updated Nov. 9, 2015, 8:56 p.m.) Review request for KDE Frameworks and P

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/ --- (Updated Nov. 9, 2015, 8:40 p.m.) Review request for Plasma. Changes --

Review Request 126008: [wayland] use Qt::AA_DisableHighDpiScaling in Qt 5.6

2015-11-09 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126008/ --- Review request for Plasma. Repository: kwin Description --- Qt::AA

Re: Plasma 5.5 Release Anouncements

2015-11-09 Thread Martin Klapetek
On Sun, Nov 8, 2015 at 8:16 AM, David Edmundson wrote: > With the proposed no-delay beta, that means we need to start on our > release anouncement already. > > Can everyone write down their big changes that are coming in 5.5 that they > made that are worthy of being highlighted in the dot article

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread Sebastian Kügler
Hi, On Monday, November 09, 2015 01:10:41 AM Valorie Zimmerman wrote: > Hello folks, this afternoon my time, a discussion started in #plasma > with some rather upset designers, who said that they felt they are > treated by the Plasma devels as children. > > I waded into that discussion, and am re

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 3:15 p.m.) Status -- This change has been mar

Re: Review Request 126007: Fix ksmserver path in startkde

2015-11-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126007/#review88201 --- this is not the only usage of the path. We have the same for w

Re: Review Request 125976: add an update() method

2015-11-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88197 --- Ship it! Not sure if we can use the Package::JobError::Foo sy

Re: Review Request 126007: Fix ksmserver path in startkde

2015-11-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126007/#review88198 --- Ship it! Ship It! - Sebastian Kügler On Nov. 9, 2015, 2:57

Review Request 126007: Fix ksmserver path in startkde

2015-11-09 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126007/ --- Review request for Plasma and David Faure. Repository: plasma-workspace

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 2:51 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

2015-11-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88195 --- Ship it! Nice. Few issues with the wording in the comments, b

Re: Review Request 125977: Remove unused dependencies in breeze-gtk

2015-11-09 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125977/ --- (Updated Nov. 9, 2015, 2:35 p.m.) Status -- This change has been mar

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 2:40 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-09 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125984/ --- (Updated Nov. 9, 2015, 1:29 p.m.) Status -- This change has been mar

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 1:18 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/ --- (Updated Nov. 9, 2015, 1:15 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin
> On Nov. 7, 2015, 2:03 p.m., Sebastian Kügler wrote: > > src/kpackage/private/packagejobthread_p.h, line 58 > > > > > > As you note yourself, perhaps just make it an enum? It's not private > > API, OK, but the c

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread kainz.a
as I start the discussion I have to say a few words 1. I understand you. I understand that big changes are a problem and collaboration is not that easy. 2. I start this discussion to have in the end an better cooperation. I am not happy with the process now cause I don't know how it works. an A

Re: Review Request 125997: Catch other openGL error gracefully

2015-11-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125997/#review88188 --- Ship it! Ship It! - Martin Gräßlin On Nov. 8, 2015, 10:07

Re: Review Request 125997: Catch other openGL error gracefully

2015-11-09 Thread Martin Gräßlin
> On Nov. 9, 2015, 7:57 a.m., Martin Gräßlin wrote: > > Could you please explain the change? Reduce string comparison? > > > > Anyway: we should probably extend the checks to also include the EGL/XCB > > error messages an EGL/Wayland error messages > > David Edmundson wrote: > there's a se

Minutes Monday Plasma Hangout

2015-11-09 Thread Sebastian Kügler
Present: apol, Riddell, bshah, Kai Uwe, notmart, mgraesslin, sebas Date: 2 Nov, 2015 General, discussed collaboration problems with VDG * Nobody meant to piss anybody off, in case that happened, sincere apologies * Seems to be mostly friction in normal work, lots of stuff getting done, much of t

Re: Review Request 125997: Catch other openGL error gracefully

2015-11-09 Thread David Edmundson
> On Nov. 9, 2015, 6:57 a.m., Martin Gräßlin wrote: > > Could you please explain the change? Reduce string comparison? > > > > Anyway: we should probably extend the checks to also include the EGL/XCB > > error messages an EGL/Wayland error messages there's a second if message == "blah" which

[Powerdevil] [Bug 354623] Full charge not trigger notification

2015-11-09 Thread Sebastian Kügler via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354623 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org --- Comment #10 from Sebastian

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125984/#review88180 --- Ship it! Ship It! - Sebastian Kügler On Nov. 9, 2015, 8:28

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread Marco Martin
On Monday 09 November 2015, Valorie Zimmerman wrote: > Hello folks, this afternoon my time, a discussion started in #plasma > with some rather upset designers, who said that they felt they are > treated by the Plasma devels as children. I'm sorry if i sounded like that, wasn't the intention :/ wha

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread Marco Martin
On Monday 09 November 2015, Valorie Zimmerman wrote: > Hello folks, this afternoon my time, a discussion started in #plasma > with some rather upset designers, who said that they felt they are > treated by the Plasma devels as children. I'm sorry if i sounded like that, wasn't the intention :/ wha

Re: Review Request 125975: X11 build system cleanup

2015-11-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125975/ --- (Updated Nov. 9, 2015, 10:11 a.m.) Status -- This change has been ma

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread Ivan Čukić
Hi all, Before I chime in: 'developer' is the term commonly used for 'programmers' - at least in the IT world. Other professions have other meanings for the word like in civil engineering). And, even if we start using the word to mean something else, nobody else will. The account is for that reas

Re: Common purpose for the Plasma team, and VDG

2015-11-09 Thread Eike Hein
My thoughts on this are two-fold: (a) Non-VDG devs generally shouldn't question VDG dev decisions in detail and avoid push-back on small issues. The VDG is still a relatively new institution and needs to be given the latitude to try things, build up institutional knowledge (and learn

Common purpose for the Plasma team, and VDG

2015-11-09 Thread Valorie Zimmerman
Hello folks, this afternoon my time, a discussion started in #plasma with some rather upset designers, who said that they felt they are treated by the Plasma devels as children. I waded into that discussion, and am reluctant to write to the list about it, but I think there are some issues here tha

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-09 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125984/ --- (Updated Nov. 9, 2015, 8:28 a.m.) Review request for Plasma. Changes --