Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-12-06 Thread Vishesh Handa
> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interface. > > Pinak Ahuja

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

2015-12-06 Thread Vishesh Handa
> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote: > > runners/baloo/baloosearchrunner.cpp, line 165 > > > > > > Have a look at basicindexingjob.txt. We define that all Presentation > > and Spreadsheets are

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

2015-12-06 Thread Igor Poboiko
> On Сен. 24, 2015, 11:50 п.п., Vishesh Handa wrote: > > runners/baloo/baloosearchrunner.cpp, line 165 > > > > > > Have a look at basicindexingjob.txt. We define that all Presentation > > and Spreadsheets are

Re: Review Request 126248: change icons in breeze plasma theme

2015-12-06 Thread Hrvoje Senjan
> On Dec. 5, 2015, 5:56 p.m., Hrvoje Senjan wrote: > > Andreas, battery is almost invisible with breeze dark -> > > http://i.imgur.com/aY1igIu.jpg > > andreas kainz wrote: > you have right the problem is also the old one from master doesn't work > in breeze dark. maybe marco can have a

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-12-06 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/ --- (Updated Dec. 6, 2015, 2:18 p.m.) Review request for Plasma and Vishesh

Re: Review Request 126248: change icons in breeze plasma theme

2015-12-06 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126248/ --- (Updated Dec. 6, 2015, 12:01 p.m.) Status -- This change has been

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-06 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 mif...@gmail.com changed: What|Removed |Added CC||mif...@gmail.com --- Comment #72 from

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-12-06 Thread Pinak Ahuja
> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interface. > > Pinak Ahuja

Review Request 126268: Move shutdown scripts into ksmserver cleanup

2015-12-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126268/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 126268: Move shutdown scripts into ksmserver cleanup

2015-12-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126268/ --- (Updated Dec. 7, 2015, 12:26 a.m.) Review request for Plasma.

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-12-06 Thread Martin Gräßlin
> On Dec. 4, 2015, 7:52 p.m., Martin Klapetek wrote: > > I just found out that KHolidays is actually not a framework but part of KDE > > Applications. Will a dependency like that be ok? if it is optional and doesn't introduce a dependency loop I think it's fine. - Martin

Re: Review Request 126234: Fix build with Qt 5.6

2015-12-06 Thread Martin Gräßlin
> On Dec. 4, 2015, 7:44 p.m., Hrvoje Senjan wrote: > > Jan, Martin, i guess this can also go to 5.5 branch? yes, sure. - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126268: Move shutdown scripts into ksmserver cleanup

2015-12-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126268/#review89204 --- explanation sounds reasonable to me - Martin Gräßlin On