Re: Review Request 126301: Add protocol for server side decoration

2015-12-17 Thread Martin Gräßlin
> On Dec. 11, 2015, 2:54 p.m., Sebastian Kügler wrote: > > src/server/CMakeLists.txt, line 100 > > > > > > I don't get the name here, maybe surface_decoration would be better? > > (It's not about the server,

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-17 Thread Marco Martin
> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126276: Disable ptrace on kdesu

2015-12-17 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126276/#review89641 --- Ship it! ptrace: Operation not permitted. :'< shipit! -

Re: Evolving Appdash

2015-12-17 Thread Eike Hein
On 12/17/2015 01:01 PM, Martin Graesslin wrote: > I'll investigate after the Christmas break how to expose a downsampling blur > in the effects infrastructure. Ideally this can be achieved with zero costs > in > the rendering. Awesome :) > Cheers > Martin Cheers, Eike

Re: Draft split for qpt plugin from frameworkintegration

2015-12-17 Thread Aleix Pol
On Wed, Dec 16, 2015 at 4:12 PM, Martin Graesslin wrote: > Hi all, > > following up on [1] I have prepared a split of frameworkintegration to move > the QPT plugin into a dedicated repository. You can find it in [2]. Please > have > a look at the split repo to verify that it

Re: Draft split for qpt plugin from frameworkintegration

2015-12-17 Thread Martin Graesslin
forgot CC to plasma On Thursday, December 17, 2015 4:32:48 PM CET Aleix Pol wrote: > On Wed, Dec 16, 2015 at 4:12 PM, Martin Graesslin wrote: > > Hi all, > > > > following up on [1] I have prepared a split of frameworkintegration to > > move > > the QPT plugin into a

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89671 --- tests/CMakeLists.txt (line 43)

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-17 Thread Alex Merry
> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/ --- (Updated Dec. 17, 2015, 6:50 p.m.) Review request for Plasma, Solid,

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-17 Thread Sebastian Kügler
> On Dec. 16, 2015, 7:29 p.m., Daniel Vrátil wrote: > > backends/kwayland/waylandconfig.cpp, line 172 > > > > > > Not that I would not like lambda slots, but there should be limit on > > how much code you can

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-17 Thread Sebastian Kügler
> On Dec. 16, 2015, 9:08 a.m., Martin Gräßlin wrote: > > backends/kwayland/waylandbackend.cpp, line 46 > > > > > > where does it get deleted? > > Sebastian Kügler wrote: > Nowhere. :/ > > This is in

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/ --- (Updated Dec. 17, 2015, 6:53 p.m.) Review request for Plasma, Solid,

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

2015-12-17 Thread René Fürst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/ --- (Updated Dez. 17, 2015, 8:40 nachm.) Review request for Network

Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Mark Gaiser
Hi, I've (somewhat mildly) already stated that i do not like the oxygen fonts at all! Just having those installed always screws up "something" on my system. So what i used to do was simply removing the oxygen fonts once an update had the nerves to install it again. Which would be the

Review Request 126408: [notifications] Refactor the screen handling code

2015-12-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126408/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Mark Gaiser
On Thu, Dec 17, 2015 at 10:09 PM, Eike Hein wrote: > > Hi Mark, > > I think you might not be entirely clear on what we're doing. > Perhaps. > > It's not a forced dependency/font, it's a default font setting > which compells distro packagers to pull the font packages in as >

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Eike Hein
Hi Mark, I think you might not be entirely clear on what we're doing. It's not a forced dependency/font, it's a default font setting which compells distro packagers to pull the font packages in as dependency. However you can change the font in System Settings to your liking. As for why Noto:

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-17 Thread Johan Ouwerkerk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89681 --- backends/kwayland/waylandconfig.cpp (line 58)

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Eike Hein
On 12/18/2015 12:00 AM, Kai Uwe Broulik wrote: > I'll send you a bigger hard drive for Christmas as you constantly > complain about a few megs of dependencies without any runtime overhead. > I'm glad that we enforce some rules on fonts in Plasma 5 as in the 4.x > times it was usually just

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Mark Gaiser
On Fri, Dec 18, 2015 at 12:00 AM, Kai Uwe Broulik wrote: > ‎Hi, > > > It is a very hard forced dependency on that font. > > I'll send you a bigger hard drive for Christmas as you constantly complain > about a few megs of dependencies without any runtime overhead. I'm glad

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Eike Hein
On 12/18/2015 12:42 AM, Mark Gaiser wrote: > I consider that to be one of the biggest issues in plasma. It's a case-by-case thing. The actual installed size of Noto depends a lot on how a distro choses to package it (split by writing system vs big monolothic package). If a reasonable subset of

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Johan Ouwerkerk
> It is a very hard forced dependency on that font. At build time, yes. At run time, you can simply reconfigure your preferences in System Settings, uninstall both Oxygen and Noto completely (with package manager) and still continue to use Plasma. On Thu, Dec 17, 2015 at 11:09 PM, Mark Gaiser

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Eike Hein
On 12/17/2015 11:09 PM, Mark Gaiser wrote: > What you say might be true and might be the goal of that font. > But it is unusable for me at this moment and i'm not going to make bug > reports about that. > > It is the google font (noto) with the google browser (chromium) that > mainly screws

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Mark Gaiser
On Thu, Dec 17, 2015 at 11:43 PM, Eike Hein wrote: > > > On 12/17/2015 11:09 PM, Mark Gaiser wrote: > > What you say might be true and might be the goal of that font. > > But it is unusable for me at this moment and i'm not going to make bug > > reports about that. > > > > It is

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Martin Klapetek
On Thu, Dec 17, 2015 at 6:42 PM, Mark Gaiser wrote: > > If i report font issues, nobody is looking at them anyway. See [1] for > oxygen. > Vernon Adams, the Oxygen font designer, was in a serious road accident in May 2014 with incredibly hard recovery ahead of him. Maybe

Re: Review Request 126301: Add protocol for server side decoration

2015-12-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/#review89646 --- Ship it! Ship It! - Sebastian Kügler On Dec. 16, 2015,

Re: Review Request 126301: Add protocol for server side decoration

2015-12-17 Thread Sebastian Kügler
> On Dec. 11, 2015, 1:54 p.m., Sebastian Kügler wrote: > > src/server/display.cpp, line 330 > > > > > > Also, I'm confused. > > > > you connect to d, so d ends up being [this], which you then don't use,

Re: Review Request 126276: Disable ptrace on kdesu

2015-12-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126276/ --- (Updated Dec. 17, 2015, 12:28 p.m.) Status -- This change has been

Re: Review Request 126301: Add protocol for server side decoration

2015-12-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/ --- (Updated Dec. 17, 2015, 12:30 p.m.) Status -- This change has been

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 17, 2015, 11:15 a.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-17 Thread Marco Martin
> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: plasmoid visions

2015-12-17 Thread Marco Martin
On Wednesday 16 December 2015, kainz.a wrote: > 2. Plasmoid size > > if you click in the system tray at an plasmoid the size is always the same. they are all fixed to the same size partly because resizing that window would be expensive and look glitchy (and no, i do not

Re: Evolving Appdash

2015-12-17 Thread Marco Martin
On Wednesday 16 December 2015, Martin Klapetek wrote: > > Also the appdash is almost unusable without a blur effect (which for > > example > > happens with GLES, XRender and QPainter backends). > > How about generating blurred wallpaper at some point, storing it > and then using that as

Re: Evolving Appdash

2015-12-17 Thread Martin Graesslin
On Thursday, December 17, 2015 12:52:35 PM CET Marco Martin wrote: > On Wednesday 16 December 2015, Martin Klapetek wrote: > > > Also the appdash is almost unusable without a blur effect (which for > > > example > > > happens with GLES, XRender and QPainter backends). > > > > How about generating

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Martin Klapetek
On Thu, Dec 17, 2015 at 7:47 PM, Mark Gaiser wrote: > > Frameworkintegration is hereby forked [1]. > > I will keep this one in sync with frameworkintegration as it is on the kde > servers, but obviously without those fonts. > Once Noto starts to work normally the fork can die.

Review Request 126411: KF5::Plasma: Fix potential use-after-free in FrameSVG

2015-12-17 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126411/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 126411: KF5::Plasma: Fix potential use-after-free in FrameSVG

2015-12-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126411/#review89678 --- Ship it! Cool stuff. Thanks for checking on those! :) -

Re: Review Request 126411: KF5::Plasma: Fix potential use-after-free in FrameSVG

2015-12-17 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126411/ --- (Updated Dec. 18, 2015, 2:36 a.m.) Status -- This change has been

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Eike Hein
On 12/18/2015 12:31 AM, Mark Gaiser wrote: > You will hear me when my workflow is severely interrupted and when i > find the cause of it. plasma-devel@kde.org is not mark-gaisers-workf...@kde.org. Bug reports go to bugs.kde.org. User support happens on the user list and in the KDE Forums. >

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Mark Gaiser
On Fri, Dec 18, 2015 at 1:05 AM, Eike Hein wrote: > > > On 12/18/2015 12:42 AM, Mark Gaiser wrote: > > I consider that to be one of the biggest issues in plasma. > > It's a case-by-case thing. The actual installed size of Noto > depends a lot on how a distro choses to package it

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Mark Gaiser
On Fri, Dec 18, 2015 at 1:24 AM, Eike Hein wrote: > > > On 12/18/2015 12:31 AM, Mark Gaiser wrote: > > You will hear me when my workflow is severely interrupted and when i > > find the cause of it. > > plasma-devel@kde.org is not mark-gaisers-workf...@kde.org. > > Bug reports go to

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Jens Reuterberg
Hello, concerning fonts - the choice of fonts is always a tricky call. Aside from an exact, and more feature complete version of Oxygen which sadly doesn't exist, Noto is the perfect choice for us. It's a very well made standardized font and the only other contender was the Firefox Fira IIRC

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Eike Hein
On 12/18/2015 01:34 AM, Mark Gaiser wrote: > Ohh just stop it! > You're going into technical implementation details of a specification > (SVG in this case). Nope, I didn't. I'm saying this particular SVG (authored as such by someone) doesn't match the result you get when you throw the font data

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Aleix Pol
On Thu, Dec 17, 2015 at 9:51 PM, Mark Gaiser wrote: > Hi, > > I've (somewhat mildly) already stated that i do not like the oxygen fonts at > all! Just having those installed always screws up "something" on my system. > > So what i used to do was simply removing the oxygen fonts

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Eike Hein
On 12/18/2015 01:47 AM, Mark Gaiser wrote: > Frameworkintegration is hereby forked [1]. Yeah, and your fork's wrong. The feature_summary() call you removed prints info among the packages marked as required; there's no Noto package, and so it's not marked as required. The message() call after is

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Mark Gaiser
On Fri, Dec 18, 2015 at 1:24 AM, Eike Hein wrote: > > > On 12/18/2015 12:31 AM, Mark Gaiser wrote: > > You will hear me when my workflow is severely interrupted and when i > > find the cause of it. > > plasma-devel@kde.org is not mark-gaisers-workf...@kde.org. > > Bug reports go to