[Differential] [Closed] D781: Rename pot file

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONbe4eabe36eac: Also rename pot file (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.o

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/#review90950 --- src/plasma/svg.h (line 119)

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

> On Enero 11, 2016, 6:35 p.m., Marco Martin wrote: > > src/plasma/svg.cpp, line 164 > > > > > > coding style: > > void SvgPrivate::updateCustomStyleCrc() > > { > > Nico Rodsevich wrote: > I don't to

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 43 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/43/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 23:16:50 + Build duration: 1 min 21 sec CHANGE SET Revision 47e0866c813063c6134

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

> On Jan. 11, 2016, 6:35 p.m., Marco Martin wrote: > > src/plasma/svg.cpp, line 164 > > > > > > coding style: > > void SvgPrivate::updateCustomStyleCrc() > > { > > Nico Rodsevich wrote: > I don't tot

Re: Review Request 126721: Don't consider Unknown output an external monitor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126721/ --- (Updated Jan. 11, 2016, 10:52 p.m.) Status -- This change has been m

Re: Review Request 126721: Don't consider Unknown output an external monitor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126721/#review90945 --- Ship it! Ship It! - David Edmundson On Jan. 11, 2016, 7:51

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

> On Enero 11, 2016, 6:35 p.m., Marco Martin wrote: > > src/plasma/svg.cpp, line 164 > > > > > > coding style: > > void SvgPrivate::updateCustomStyleCrc() > > { I don't totally get why QVariantMap is tha

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

> On Jan. 11, 2016, 7:12 p.m., Marco Martin wrote: > > I would do it the following way: > > CustomColorScheme *customColorScheme() const; > > > > > > class CustomColorScheme : public QObject { > > Q_PROPERTY(QColor textColor READ textColor WRITE setTextColor NOTIFY > > textColorChanged) >

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/ --- (Updated Enero 11, 2016, 9:37 p.m.) Review request for Plasma, David Edmu

[Differential] [Accepted] D781: Rename pot file

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks good i guess. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH fix-messages REVISION DETAIL https://phabricator.kde.org/D781 EMAIL PREFERENCES http

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 9, 2016, 8:32 p.m., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just im

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126513/ --- (Updated Jan. 11, 2016, 8:54 p.m.) Status -- This change has been ma

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

> On Jan. 10, 2016, 6:43 p.m., David Edmundson wrote: > > kcms/touchpad/src/backends/x11/propertyinfo.cpp, line 51 > > > > > > Effectively we end up switching on the data type twice; both here and > > in value()

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 11, 2016, 8:12 nachm., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back >

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 11, 2016, 8:12 p.m., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back > >

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90936 --- Someone suggested to style it like this: https://i.imgur.com/n

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 42 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 20:03:43 + Build duration: 1 min 55 sec CHANGE SET Revision a4c6151e41d0c282495

Review Request 126721: Don't consider Unknown output an external monitor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126721/ --- Review request for Plasma and Kai Uwe Broulik. Repository: powerdevil D

Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 54 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 18:49:23 + Build duration: 7 min 16 sec CHANGE SET Revision 8d534f94a6de944dd2f99

Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 54 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 18:49:23 + Build duration: 7 min 16 sec CHANGE SET Revision 8d534f94a6de944dd2f99

Re: KDE Discover binary & library names

2016-01-11 16:34 GMT+01:00 Ivan Čukić : >> As a maintainer, I say no. Because it's just not my goal, I think that >> being part of Plasma makes it a more appealing product. > > Ok, got you :) GNOME-Software supports "profiles" for other desktop environments, which mostly means that it stops prefer

Review Request 126719: tasks.svgz: Add "progress" frame

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126719/ --- Review request for Plasma, KDE Usability, andreas kainz, and Ken Vermette.

Re: Review Request 126669: [Task Manager] Don't show on which virtual desktop a window is if there is just one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126669/#review90919 --- According to git log it did end up in Plasma/5.5 branch but th

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 11, 2016, 5:01 p.m.) Status -- This change has been ma

Re: high dpi issues wiki page

On Mon, Jan 11, 2016 at 5:39 PM, Marco Martin wrote: > On Monday 11 January 2016, Dirk Hohndel wrote: >> >> Or if there are things on the site that are obviously still correct and >> missing, leave those with an explanation that this page isn't well >> maintained but that as of early Jan 2016 thes

Re: high dpi issues wiki page

On Monday 11 January 2016, Dirk Hohndel wrote: > > Or if there are things on the site that are obviously still correct and > missing, leave those with an explanation that this page isn't well > maintained but that as of early Jan 2016 these were still lacking. > > It's always easier to edit somet

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/ --- (Updated Jan. 11, 2016, 4:19 nachm.) Review request for Plasma and KDE Us

[Differential] [Request, 2 lines] D787: Properly set modality on AuthDialog

graesslin created this revision. graesslin added a subscriber: plasma-devel. REVISION SUMMARY The modality was set through KWindowSystem before the window was mapped by Qt causing Qt to operwrite the X11 property. This change sets the modality through Qt API, so that Qt itself sets the

[Differential] [Updated] D787: Properly set modality on AuthDialog

graesslin added reviewers: davidedmundson, Plasma. graesslin added a project: Plasma. REPOSITORY rPOLKITKDEAGENT Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D787 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, davi

[Differential] [Updated] D787: Properly set modality on AuthDialog

graesslin updated the test plan for this revision. REPOSITORY rPOLKITKDEAGENT Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D787 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin Cc: plasma-devel ___

Re: KDE Discover binary & library names

> As a maintainer, I say no. Because it's just not my goal, I think that > being part of Plasma makes it a more appealing product. Ok, got you :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D782: Require Qt 5.5

apol added a subscriber: apol. apol added a comment. +1 REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D782 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: apol,

Re: high dpi issues wiki page

Hi, As the original author of this page I'd say let's kill it. Most tips and tricks for applications are obsolete with Qt's built-in high dpi support and in Plasma 5 we had high dpi support ‎as a high priority anyway.  If we were to keep something like this, it should be instead tips how to mak

Re: high dpi issues wiki page

On Monday, January 11, 2016 01:41:36 PM Sebastian Kügler wrote: > It seems that some like to refer to this page when it comes to high-dpi > readiness of Plasma and apps: > > https://community.kde.org/KDE/High-dpi_issues > > Problem is that the last real updates to this page are from April 2014, s

Re: high dpi issues wiki page

On Monday, January 11, 2016 06:17:16 AM Dirk Hohndel wrote: > On Mon, Jan 11, 2016 at 03:07:16PM +0100, Marco Martin wrote: > > On Monday 11 January 2016, Sebastian Kügler wrote: > > > How to go about it? I'd be cool with just deleting it. If anybody wants > > > to > > > keep it, please propose how

Re: high dpi issues wiki page

On Mon, Jan 11, 2016 at 03:07:16PM +0100, Marco Martin wrote: > On Monday 11 January 2016, Sebastian Kügler wrote: > > How to go about it? I'd be cool with just deleting it. If anybody wants to > > keep it, please propose how it should reflect that the info is not recent, > > or offer to update it.

Re: high dpi issues wiki page

On Monday 11 January 2016, Sebastian Kügler wrote: > How to go about it? I'd be cool with just deleting it. If anybody wants to > keep it, please propose how it should reflect that the info is not recent, > or offer to update it. delete it and if somebody wants to start catalogating issues invite

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> On Jan. 11, 2016, 1:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 215 > > > > > > Do we really not want the C++11 for here? If we don't, I'd prefer > > Q_FOREACH as replacement, the Q_ ma

[Differential] [Accepted] D784: Improve finding X11 dependencies

sebas added a subscriber: sebas. sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH improve-x11-dependency REVI

high dpi issues wiki page

It seems that some like to refer to this page when it comes to high-dpi readiness of Plasma and apps: https://community.kde.org/KDE/High-dpi_issues Problem is that the last real updates to this page are from April 2014, so it shows a snapshot of what we've been working on before Plasma 5. Today

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 355 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/355/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 13:11:25 + Build duration: 7 min 55 sec CHANGE SET Revision e83f15b0b02211ad91b34cf8030f6fa

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 355 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/355/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jan 2016 13:11:25 + Build duration: 7 min 55 sec CHANGE SET Revision e83f15b0b02211ad91b34cf8030f6fa

[Differential] [Changed Subscribers] D782: Require Qt 5.5

graesslin added a subscriber: plasma-devel. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D782 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel __

[Differential] [Request, 27 lines] D784: Improve finding X11 dependencies

graesslin created this revision. graesslin added a reviewer: Plasma. graesslin added a subscriber: plasma-devel. graesslin set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. graesslin added a project: Plasma. REVISION SUMMARY * xcb is no longer

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> On Jan. 11, 2016, 12:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 215 > > > > > > Do we really not want the C++11 for here? If we don't, I'd prefer > > Q_FOREACH as replacement, the Q_ m

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> On Jan. 11, 2016, 1:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 182 > > > > > > Why is clazy complaining here? I think the .first() API is actually > > quite nice, don't see anything wr

[Differential] [Request, 4 lines] D781: Rename pot file

graesslin created this revision. graesslin added a reviewer: aacid. graesslin set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. graesslin added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Was conflicting with t

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review90890 --- autotests/coronatest.cpp (line 182)

Re: KDE Discover binary & library names

On Sat, Jan 9, 2016 at 9:11 PM, Ivan Čukić wrote: > We are heading towards the Plasma Software Compilation :) > > One benefit of using Plasma 'everywhere' is that people will start > seeing the name Plasma more often and maybe speed up the > KDE-as-in-desktop -> Plasma transition. > >> if you were

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

> On Jan. 11, 2016, 12:14 p.m., David Edmundson wrote: > > >Gwenview switches to a dark palette when in fullscreen mode for instance > > > > and how does this help solve that? There's no method to get a palette from > > a ColorSet that may be useful to add then? - Marco ---

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90886 --- >Gwenview switches to a dark palette when in fullscreen mode f

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90879 --- +1 from me, too. - Sebastian Kügler On Jan. 5, 2016, 11:16

Minutes Monday Plasma Hangout

Minutes Plasma 'hangout', 11-1-2016, 12:00 CET Present: notmart,k broulik, starbuck, Riddell, sebas PSA: we tried Jitsi instead of Google Hangouts, it worked well for those with recent browsers. We will use that from now on, until further notice. URL is at https://meet.jit.si/PlasmaWeekly -- n

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just

[Differential] [Closed] D739: Disable ptrace

This revision was automatically updated to reflect the committed changes. Closed by commit rPOLKITKDEAGENT0b9a327bba3d: Disable ptrace (authored by graesslin). REPOSITORY rPOLKITKDEAGENT Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D739?vs=1742&id=1861

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90874 --- Ship it! looks good to me - Marco Martin On Jan. 10, 2016,

Re: Review Request 126356: change minimum size of clipboard

> On Dec. 15, 2015, 2:29 p.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/clipboard.qml, line 69 > > > > > > this is not the actual size of the systray, but a hardcoded value which > > might match (o

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90871 --- ping? - Marco Martin On Jan. 5, 2016, 11:16 a.m., Marco Mar

Re: Draft split for qpt plugin from frameworkintegration

Am 2016-01-06 22:18, schrieb Albert Astals Cid: El Friday 18 December 2015, a les 10:03:39, Martin Graesslin va escriure: On Thursday, December 17, 2015 5:48:47 PM CET Martin Graesslin wrote: > On Thursday, December 17, 2015 4:32:48 PM CET Aleix Pol wrote: > > On Wed, Dec 16, 2015 at 4:12 PM, Ma

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90868 --- +1 - Mark Gaiser On jan 10, 2016, 10:03 p.m., Kai Uwe Broul