[Differential] [Commented On] D827: Suspend/Hibernate through daemon instead of greeter

graesslin added inline comments. INLINE COMMENTS powermanagement.cpp:110 I thought about returning a reference, but considered it not really useful in this case, as it's a QObject, which would result in weird looking connect statements, like: connect(&PowerManagement::instance()... powerma

Re: Review Request 126807: Ensure connection to exist before using

> On Jan. 19, 2016, 6:35 p.m., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. > > Andreas Cord-Landwehr wrote: > If I am not mistaken, the root cause is the following: > * XLibTouchpad h

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

> On Jan. 19, 2016, 11:27 nachm., Luca Beltrame wrote: > > This broke the task manager: > > > > file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/main.qml:223:5: > > Type ToolTipDelegate unavailable > > file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/conten

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review91354 --- This broke the task manager: file:///usr/share/plasma/plasmo

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91352 --- there was also an discussion to use png files cause they are

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/ --- (Updated Jan. 19, 2016, 11:54 p.m.) Review request for KDE Frameworks and

[Differential] [Updated] D827: Suspend/Hibernate through daemon instead of greeter

broulik added a comment. +1 INLINE COMMENTS greeter/greeterapp.cpp:616 perhaps cache the end? for (auto it = m_views.constBegin(), end = m_views.constEnd(); it != end; ++it) powermanagement.cpp:110 I prefer returning a reference for singletons but I guess this way is just consistent w

Re: Review Request 126779: Fix for bug 358135: Media Player widget in expanded mode makes Amarok skip tracks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126779/ --- (Updated Jan. 19, 2016, 10:33 p.m.) Status -- This change has been m

Re: Review Request 125972: Don't list systray containment actions in systray context menu.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125972/#review91350 --- For some funny reason I now get an empty Panel Options contex

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/ --- (Updated Jan. 19, 2016, 9:47 p.m.) Status -- This change has been ma

[Differential] [Accepted] D742: Wayland integration: support for server-side decorations

mart accepted this revision. This revision is now accepted and ready to land. INLINE COMMENTS src/platformtheme/kwaylandintegration.cpp:94 since is a long name already, going all the way, waylandserverdecoration ? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANC

[Differential] [Requested Changes To] D742: Wayland integration: support for server-side decorations

sebas requested changes to this revision. sebas added a comment. This revision now requires changes to proceed. I'd prefer a hard dependency, not build time, to make it harder to screw this up. We're already depending on kwayland hard in libkscreen and kwin, so it's needed anyway to build Plasma

[Breeze] [Bug 350682] Double-click on GTK widgets initiates window movement, breaks control of the widget

https://bugs.kde.org/show_bug.cgi?id=350682 Christian Stadelmann changed: What|Removed |Added CC||dah5a...@genodeftest.de --- Comment #10

Re: Review Request 126811: Emit contextualAppletsAboutToShow in systemtray

> On Jan. 19, 2016, 8:41 nachm., Kai Uwe Broulik wrote: > > Doesn't compile, contextualActionsAboutToShow is in the Applet*interface* > > not Applet. Also, it should probably call it on the currently active applet, not the system tray. - Kai Uwe

Re: Review Request 126811: Emit contextualAppletsAboutToShow in systemtray

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126811/#review91348 --- Doesn't compile, contextualActionsAboutToShow is in the Apple

[Breeze] [Bug 358224] New: breeze dark plasma look and feel: KDE4 applications are using mixed (light and dark) colors, rendering text unreadable

https://bugs.kde.org/show_bug.cgi?id=358224 Bug ID: 358224 Summary: breeze dark plasma look and feel: KDE4 applications are using mixed (light and dark) colors, rendering text unreadable Product: Breeze Version: 5

Re: Review Request 126807: Ensure connection to exist before using

Hi Weng Xeutian, Any ideas on the below mentioned issue? On Tue, Jan 19, 2016 at 8:09 PM, Rajeesh K V wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126807/ > > On January 19th, 2016, 6:35 p.m. UTC, *Rajeesh K V* wrote: > > I must admit

Re: Review Request 126807: Ensure connection to exist before using

> On Jan. 19, 2016, 6:35 p.m., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. > > Andreas Cord-Landwehr wrote: > If I am not mistaken, the root cause is the following: > * XLibTouchpad h

Re: Review Request 126807: Ensure connection to exist before using

> On Jan. 19, 2016, 6:35 nachm., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. If I am not mistaken, the root cause is the following: * XLibTouchpad has a member variable m_touchpadOffAtom * th

Re: Review Request 126807: Ensure connection to exist before using

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/#review91343 --- Ship it! I must admit I don't understand the root cause or

[Breeze] [Bug 351099] krunner unusable with dark breeze theme

https://bugs.kde.org/show_bug.cgi?id=351099 --- Comment #3 from Salvo "LtWorf" Tomaselli --- I changed plasma theme to something that works with my colours. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mai

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/ --- (Updated Jan. 19, 2016, 7:02 p.m.) Review request for KDE Frameworks and

[Breeze] [Bug 351099] krunner unusable with dark breeze theme

https://bugs.kde.org/show_bug.cgi?id=351099 Christian Stadelmann changed: What|Removed |Added CC||dah5a...@genodeftest.de --- Comment #2 f

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review91342 --- Ship it! Ship It! - David Edmundson On Jan. 5, 2016, 11

Re: Review Request 126801: Ignore drag events on containment/panel when immutable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/ --- (Updated Jan. 19, 2016, 5:02 p.m.) Status -- This change has been ma

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/ --- (Updated Jan. 19, 2016, 5:02 p.m.) Status -- This change has been ma

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/#review91339 --- Ship it! Ship It! - David Edmundson On Jan. 19, 2016, 4

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

> On Jan. 19, 2016, 3:07 p.m., David Edmundson wrote: > > desktoppackage/contents/configuration/AppletConfiguration.qml, line 168 > > > > > > don't set width in a child of a Layout > > > > the layout wil

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/ --- (Updated Jan. 19, 2016, 4:12 p.m.) Review request for Plasma. Changes -

Re: Review Request 126811: Emit contextualAppletsAboutToShow in systemtray

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126811/#review91335 --- not tested, looks sensible to me - Marco Martin On Jan. 19

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/#review91331 --- desktoppackage/contents/configuration/AppletConfiguration.qm

Re: Review Request 126814: IconItem: Add usePlasmaIcons property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126814/#review91330 --- Ship it! wouls prefer the property to be called usesPlasma

Review Request 126814: IconItem: Add usePlasmaIcons property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126814/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

> On Jan. 19, 2016, 8:51 a.m., Marco Martin wrote: > > sure it's not just hiding it? > > some times if you do the syncing by javascript it goes undetected and you > > fin yourself with 100% cpu without knowing why > > David Rosca wrote: > That's possible, but I can't see any problems with c

Review Request 126812: plasma-framework: Fix document.svgz to use color from stylesheet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126812/ --- Review request for Plasma. Description --- Fixed "document-encrypt"

Re: Review Request 125972: Don't list systray containment actions in systray context menu.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125972/ --- (Updated Jan. 19, 2016, 12:29 p.m.) Status -- This change has been m

Review Request 126811: Emit contextualAppletsAboutToShow in systemtray

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126811/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: KWallet Runner

On Tue, Jan 19, 2016 at 12:55 PM, Marco Martin wrote: > On Mon, Jan 18, 2016 at 2:55 AM, James Augustus Zuccon > wrote: >> Hi guys, >> >> I'm in the process of developing a KWallet Runner to ease viewing, editing >> and creation of KWallet passwords. >> >> At present, the code only supports Sear

Re: Review Request 125973: Remove completely duplicated function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/ --- (Updated Jan. 19, 2016, 12:22 p.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 49 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 19 Jan 2016 12:07:48 + Build duration: 1 min 33 sec CHANGE SET Revision bb3e7c47f4a5d010475

Re: KWallet Runner

On Mon, Jan 18, 2016 at 2:55 AM, James Augustus Zuccon wrote: > Hi guys, > > I'm in the process of developing a KWallet Runner to ease viewing, editing > and creation of KWallet passwords. > > At present, the code only supports Searching/Viewing passwords and is > available here: > https://github.

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/#review91327 --- We really need a fix for this. There have yet again been cha

Re: KDE papercuts love

On Sun, Jan 17, 2016 at 12:01 AM, wrote: > Hi and thank you for providing us great software. The leap from KDE SC 4 > serie is giant and in the good direction imho. > I took some time to point out the little quirks I found using your latest > software on Arch Linux (Intel Broadwell). > I own a mi

Re: Review Request 126791: plasma-framework: Fix list.svgz to use color from stylesheet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126791/ --- (Updated Jan. 19, 2016, 1:37 p.m.) Status -- This change has been ma

Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126800/ --- (Updated Jan. 19, 2016, 9:29 a.m.) Status -- This change has been ma

Re: Review Request 126794: Use PlasmaCore.IconItem in WidgetExplorer and AlternativesDelegate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126794/ --- (Updated Jan. 19, 2016, 9:28 a.m.) Status -- This change has been ma

Re: Review Request 126807: Ensure connection to exist before using

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/#review91323 --- FWIW, fixes the issue for me. I'm clueless about whether it's

Re: Review Request 126807: Ensure connection to exist before using

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/ --- (Updated Jan. 19, 2016, 10:24 a.m.) Review request for Plasma and Alexand

Re: Review Request 126807: Ensure connection to exist before using

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/ --- (Updated Jan. 19, 2016, 9:18 vorm.) Review request for Plasma and Alexand

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126792/ --- (Updated Jan. 19, 2016, 10:17 a.m.) Status -- This change has been m

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

> On Jan. 19, 2016, 8:51 a.m., Marco Martin wrote: > > sure it's not just hiding it? > > some times if you do the syncing by javascript it goes undetected and you > > fin yourself with 100% cpu without knowing why That's possible, but I can't see any problems with cpu usage. The other fix is

KWallet Runner

Hi guys, I'm in the process of developing a KWallet Runner to ease viewing, editing and creation of KWallet passwords. At present, the code only supports Searching/Viewing passwords and is available here: https://github.com/jimtendo/kwallet-runner I contacted Ben Cooksley (via the KDE form) in r

KDE papercuts love

Hi and thank you for providing us great software. The leap from KDE SC 4 serie is giant and in the good direction imho. I took some time to point out the little quirks I found using your latest software on Arch Linux (Intel Broadwell). I own a micro-blog at www.archkde.blogspot.it if you wanna

Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

> On Jan. 19, 2016, 8:52 a.m., Marco Martin wrote: > > I'm fine with the change, but... wasn't iconitem supposed to get a property > > for not using the svg? > > David Rosca wrote: > No idea, but I don't think the Plasma components should be used in > QtQuickControls windows, exactly becau

Re: Review Request 126791: plasma-framework: Fix list.svgz to use color from stylesheet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126791/#review91320 --- Ship it! Ship It! - Marco Martin On Jan. 18, 2016, 10:2

Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

> On Jan. 19, 2016, 8:52 a.m., Marco Martin wrote: > > I'm fine with the change, but... wasn't iconitem supposed to get a property > > for not using the svg? No idea, but I don't think the Plasma components should be used in QtQuickControls windows, exactly because of this issue - using Plasma

Re: Review Request 126794: Use PlasmaCore.IconItem in WidgetExplorer and AlternativesDelegate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126794/#review91318 --- Ship it! Ship It! - Marco Martin On Jan. 18, 2016, 12:1

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126792/#review91317 --- Ship it! Ship It! - Marco Martin On Jan. 18, 2016, 3:21

Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126800/#review91315 --- Ship it! I'm fine with the change, but... wasn't iconitem

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/#review91314 --- sure it's not just hiding it? some times if you do the syncin

Re: Review Request 126767: Breeze Cursor (default) Update

> On Jan. 16, 2016, 11:04 a.m., Kai Uwe Broulik wrote: > > - The busy cursor looks unlike anything we use elsewhere and eerily similar > > to what Android has nowadays. It looks rather hectic and that the two lines > > briefly connect looks awkward. > > - The "shutter" effect draws even more at

Re: Review Request 126801: Ignore drag events on containment/panel when immutable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/#review91311 --- Ship it! Ship It! - Marco Martin On Jan. 19, 2016, 8:20

Re: PSA: KAccounts now requires two env vars set

Am 2016-01-18 21:06, schrieb Martin Klapetek: Because of a co-installability issue with other DEs [1] that use the accounts-sso tech, I had to change the location of the provider and service files we ship. This was decided after discussing with upstream. To make KAccounts/libaccounts actually re

Re: Review Request 126801: Ignore drag events on containment/panel when immutable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/ --- (Updated Jan. 19, 2016, 8:20 a.m.) Review request for Plasma. Summary (