Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> On Jan. 22, 2016, 9:33 p.m., Xuetian Weng wrote: > > pam_kwallet_init.desktop.cmake, line 7 > > > > > > Why limit to these desktop anyway? I don't see why this is necessary. > > (e.g. why not lxqt?) Hmm, I copi

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91457 --- pam_kwallet_init.desktop.cmake (line 7)

Re: Review Request 126210: [phonon] Do not set RPATH

2016-01-22 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126210/ --- (Updated Jan. 22, 2016, 8:35 p.m.) Review request for Plasma. Repositor

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 22, 2016, 7:08 p.m.) Review request for Plasma and Martin K

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 22, 2016, 7:02 p.m.) Review request for Plasma and Martin K

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 19-23 > > > > > > on syntax: else and endif don't need to repeat the condition any more. > > Also we tend to use the lower case varia

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Xuetian Weng
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 19-23 > > > > > > on syntax: else and endif don't need to repeat the condition any more. > > Also we tend to use the lower case varia

[Powerdevil] [Bug 337674] kded5 is eating CPU

2016-01-22 Thread Francesco via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 Francesco changed: What|Removed |Added CC||palmar...@unive.it --- Comment #85 from Francesco

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 2 > > > > > > out of interest: why is the version raise required? I see all the packages that use extra-cmake-modules use that version.

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 19-23 > > > > > > on syntax: else and endif don't need to repeat the condition any more. > > Also we tend to use the lower case varia

Re: Review Request 120566: Remove CMake cruft.

2016-01-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120566/ --- (Updated Jan. 22, 2016, 6:19 p.m.) Review request for Plasma. Changes -

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91445 --- Good idea and looks good (IMHO). CMakeLists.txt (line 2)

Review Request 126848: Remove unused dependency in kgamma

2016-01-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126848/ --- Review request for Plasma. Repository: kgamma5 Description --- I c

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/ --- (Updated Jan. 22, 2016, 8:52 p.m.) Status -- This change has been ma

Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- Review request for Plasma and Martin Klapetek. Repository: kwallet-pam

Re: Review Request 126840: KCM Keyboard: Use ECM to generate debug category

2016-01-22 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126840/ --- (Updated Jan. 22, 2016, 12:37 p.m.) Status -- This change has been m

Re: Review Request 126840: KCM Keyboard: Use ECM to generate debug category

2016-01-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126840/#review91439 --- Ship it! Ship It! - David Edmundson On Jan. 22, 2016, 1

Review Request 126841: Use PlasmaCore.IconItem in Kicker, Kickoff and Folder View

2016-01-22 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126841/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 126840: KCM Keyboard: Use ECM to generate debug category

2016-01-22 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126840/ --- Review request for Plasma. Repository: plasma-desktop Description -

[Differential] [Updated, 174 lines] D851: Port kded plugin to json metadata

2016-01-22 Thread heikobecker (Heiko Becker)
heikobecker updated this revision to Diff 2062. heikobecker added a comment. Used suggested kcoreaddons_add_plugin REPOSITORY rKWRITED KWriteD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D851?vs=2058&id=2062 BRANCH master REVISION DETAIL https://phabricator.kde.org/D851 AFF