Re: fatal error: libkonq_export.h: No such file or directory

2016-02-28 Thread David Faure
On Monday 29 February 2016 08:15:18 Martin Graesslin wrote: > Hi David, > > it looks like your change in plasma-desktop > (a00db7833250587c84d82f8957a70a0eb972e1e2) broke the build on the CI system. Oops. Fixed. > I'm not able to reproduce on local setup. Probably because you have libkonq

Re: Review Request 127199: Avoid blocking DBus calls in SNI startup

2016-02-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127199/#review92876 --- Ship it! Ship It! - Martin Gräßlin On Feb. 28, 2016,

Re: Review Request 127197: [kcm_colors] Port away from KDELibs4Support

2016-02-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127197/#review92875 --- Ship it! Please put the change into master not into the

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

2016-02-28 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/ --- (Updated Feb. 29, 2016, 2:23 a.m.) Review request for Plasma and Marco

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

2016-02-28 Thread Friedrich W. H. Kossebau
> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Re: Review Request 127214: Remove some warnings

2016-02-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127214/ --- (Updated Feb. 29, 2016, 1:06 a.m.) Status -- This change has been

Re: Review Request 127214: Remove some warnings

2016-02-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127214/#review92873 --- Ship it! Ship It! - David Edmundson On Feb. 28, 2016,

Review Request 127214: Remove some warnings

2016-02-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127214/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-28 Thread Sergey Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/ --- (Updated Feb. 28, 2016, 11:22 p.m.) Status -- This change has been

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review92872 --- Ship it! I'll fix the issues pointed out by Kai and

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-28 Thread Aleix Pol Gonzalez
> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote: > > src/plasma/private/packages.cpp, line 99 > > > > > > QByteArrayLiteral and below QByteArrayLiteral is a weird thing, let's not get there. - Aleix

Re: Review Request 127207: IconItem: Fix changing color of svg icons loaded from icon theme

2016-02-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127207/#review92868 --- Ship it! Ship It! - David Edmundson On Feb. 28, 2016,

Re: Review Request 127032: Add Frameworks version to system information in bug report

2016-02-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127032/ --- (Updated Feb. 28, 2016, 10:14 p.m.) Status -- This change has been

Re: Review Request 127199: Avoid blocking DBus calls in SNI startup

2016-02-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127199/ --- (Updated Feb. 28, 2016, 9:07 p.m.) Review request for Plasma.

[Differential] [Request, 55 lines] D1034: [Task Manager] Don't show task is on all activities if there is just one running one

2016-02-28 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This is similar to what we do with regards to virtual

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

2016-02-28 Thread Kai Uwe Broulik
> On Feb. 27, 2016, 10:27 vorm., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

2016-02-28 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/ --- (Updated Feb. 28, 2016, 8:11 p.m.) Review request for Plasma and Marco

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

2016-02-28 Thread Friedrich W. H. Kossebau
> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

2016-02-28 Thread Friedrich W. H. Kossebau
> On Feb. 27, 2016, 5:19 p.m., Marco Martin wrote: > > >Q: Is this ported correctly (a hack I found elsewhere), or is there a > > >better way meanwhile? > > >q->setBusy(false); > > > > > >to > > > > > >QObject *graphicObject = > > > q->property("_plasma_graphicObject").value(); > > >

Re: Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-28 Thread Xuetian Weng
> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so reliable if the icon is not rendered with

Re: Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-28 Thread Xuetian Weng
> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so reliable if the icon is not rendered with

Re: Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-28 Thread David Rosca
> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so reliable if the icon is not rendered with

Re: Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-28 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- (Updated Feb. 28, 2016, 5:15 p.m.) Review request for KDE Frameworks,

Re: Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-28 Thread Xuetian Weng
> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 253 > > > > > > This should be `QSize(32, 32)` as the comment says? I indented to use a size without exact match. > On

Review Request 127207: IconItem: Fix changing color of svg icons loaded from icon theme

2016-02-28 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127207/ --- Review request for Plasma. Repository: plasma-framework Description

[frameworks-kactivities] [Bug 339817] kactivities-frameworks 5.3.0 causes compiler errors

2016-02-28 Thread Ivan Čukić via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=339817 Ivan Čukić changed: What|Removed |Added Product|kactivitymanagerd |frameworks-kactivities

[frameworks-kactivities] [Bug 308653] kwin crashed when trying to send window to another desktop

2016-02-28 Thread Ivan Čukić via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=308653 Ivan Čukić changed: What|Removed |Added Product|kactivitymanagerd |frameworks-kactivities

[frameworks-kactivities] [Bug 306680] Regression in libkactivities: caching disrupts communication between KWin and kactivitymanagerd

2016-02-28 Thread Ivan Čukić via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=306680 Ivan Čukić changed: What|Removed |Added Product|kactivitymanagerd |frameworks-kactivities

Re: Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-28 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92843 --- autotests/iconitemtest.cpp (line 133)

Re: Review Request 127103: Add autotests for IconItem

2016-02-28 Thread David Rosca
On Sun, Feb 28, 2016 at 12:18 AM, Weng Xuetian wrote: > pixelColor is only in Qt 5.6. > > Does plasma-frameworks depend on Qt 5.6 right now? > No, fixed now. David > On Sat, Feb 27, 2016 at 12:25 PM, David Rosca wrote: > >> This is an automatically

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 439 - Still Failing!

2016-02-28 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/439/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 28 Feb 2016 09:26:42 + Build duration: 33 sec CHANGE SET Revision