Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Thomas Pfeiffer
> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Kai Uwe Broulik
> On März 24, 2016, 9:37 nachm., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Xuetian Weng
> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

2016-03-31 Thread Kai Uwe Broulik
> On März 31, 2016, 9:08 nachm., Kai Uwe Broulik wrote: > > > to be able to display Virtual, Real or both kind of streams > > > > I don't fully get the concept of "virtual stream", at least not from your > > screenshot, ie. what happens if I mute the "Chromium: Spotify" stream but > > not the

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

2016-03-31 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/ --- (Updated mars 31, 2016, 9:29 après-midi) Review request for Plasma.

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

2016-03-31 Thread Yoann Laissus
> On mars 31, 2016, 9:08 après-midi, Kai Uwe Broulik wrote: > > > to be able to display Virtual, Real or both kind of streams > > > > I don't fully get the concept of "virtual stream", at least not from your > > screenshot, ie. what happens if I mute the "Chromium: Spotify" stream but > > not

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

2016-03-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/#review94168 --- > to be able to display Virtual, Real or both kind of

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Kai Uwe Broulik
> On März 24, 2016, 9:37 nachm., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

2016-03-31 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/ --- (Updated mars 31, 2016, 9:01 après-midi) Review request for Plasma.

Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

2016-03-31 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/ --- Review request for Plasma. Repository: plasma-pa Description ---

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Xuetian Weng
> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

2016-03-31 Thread Kai Uwe Broulik
> On März 25, 2016, 7:24 nachm., Thomas Pfeiffer wrote: > > Two questions: > > 1. If there is only one device, are the comoboxes hidden (they should be)? > > 2. If I change the default device, are all streams automatically switched > > to that device? > > David Rosca wrote: > 1. Yes >

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

2016-03-31 Thread Xuetian Weng
> On March 25, 2016, 7:24 p.m., Thomas Pfeiffer wrote: > > Two questions: > > 1. If there is only one device, are the comoboxes hidden (they should be)? > > 2. If I change the default device, are all streams automatically switched > > to that device? > > David Rosca wrote: > 1. Yes >

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

2016-03-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/#review94163 --- Ship it! Ship It! - Sebastian Kügler On March 25,

Re: Review Request 127507: VolumeObject: Add channels and channelVolumes properties

2016-03-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127507/#review94162 --- Ship it! Ship It! - Sebastian Kügler On March 26,

Re: Review Request 127487: Fix bindings in KCM MuteButton

2016-03-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127487/#review94161 --- Ship it! Ship It! - Sebastian Kügler On March 24,

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/#review94160 --- Ship it! Ship It! - Sebastian Kügler On March 24,

[Differential] [Request, 327 lines] D1279: Add a template for Weather Ion dataengines

2016-03-31 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added a reviewer: apol. kossebau added a subscriber: plasma-devel. Herald added a project: Plasma. TEST PLAN Used kapptemplate (needs fix, was just commited) and created a new ion based on the installed template. Successfully tested the ion following

Re: Review Request 127498: Cleanup warnings

2016-03-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127498/ --- (Updated March 31, 2016, 7:14 p.m.) Review request for Plasma.

Re: Review Request 127498: Cleanup warnings

2016-03-31 Thread David Rosca
> On March 31, 2016, 1:47 p.m., Sebastian Kügler wrote: > > src/card.cpp, line 47 > > > > > > Perhaps we can just drop this conditional and make it require PA >= 5.0? > > > > The reason is to reduce

Re: Sunsetting khotkeys?

2016-03-31 Thread Martin Graesslin
On Thursday, March 31, 2016 5:15:26 PM CEST Ivan Čukić wrote: > > Input macro recorders/editors have fairly large userbase on competing > > systems (e.g. enthusiast gamers on Windows, who easily outnumber > > +1 > > When I read Martin's post, I expected 'kwin will do it', not 'we don't need >

Re: Review Request 127260: Experiment: cache svg icons from icon theme

2016-03-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/#review94156 --- autotests/themetest.cpp (line 71)

Re: Sunsetting khotkeys?

2016-03-31 Thread Ivan Čukić
> Input macro recorders/editors have fairly large userbase on competing > systems (e.g. enthusiast gamers on Windows, who easily outnumber +1 When I read Martin's post, I expected 'kwin will do it', not 'we don't need it'. Cheers, Ivan ___

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2016-03-31 Thread Heiko Tietze via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358957 Heiko Tietze changed: What|Removed |Added CC||tietze.he...@gmail.com

Re: Review Request 127498: Cleanup warnings

2016-03-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127498/#review94153 --- Fix it, then Ship it! Ship It! src/card.cpp (line 47)

Re: Review Request 127260: Experiment: cache svg icons from icon theme

2016-03-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/#review94152 --- autotests/themetest.cpp (line 45)

Re: Review Request 127260: Experiment: cache svg icons from icon theme

2016-03-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/ --- (Updated March 31, 2016, 1:07 p.m.) Review request for Plasma. Changes

5.7 Kickoff Meeting Minutes

2016-03-31 Thread Jonathan Riddell
We met and discussed Plasma 5.7 ** Agree to move Todo list to Phabricator Now at https://phabricator.kde.org/project/view/35/ ** Schedule for 5.7 beta 16 June (d_ed to lead), 5.7.0 tag on Thu 30th June, 5.7.0 release Tue 5th July https://community.kde.org/Schedules/Plasma_5

Re: Sunsetting khotkeys?

2016-03-31 Thread Eike Hein
On 03/30/2016 06:25 PM, Thomas Pfeiffer wrote: but anyone who knows how to do such things does not need a GUI for it. That's wrong, among other reasons because it's a view limited to the status quo. Input macro recorders/editors have fairly large userbase on competing systems (e.g.

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2016-03-31 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358957 Kai Uwe Broulik changed: What|Removed |Added Flags||Usability? ---

Re: Considering a Qt 5.6 dependency for plasma-workspace

2016-03-31 Thread Sebastian Kügler
On Friday, March 25, 2016 04:25:54 PM Martin Graesslin wrote: > On Thursday, March 24, 2016 5:31:21 PM CET Aleix Pol wrote: > > Hi, > > I'd like to suggest a Qt 5.6 dependency for plasma-workspace master > > (and maybe other repositories too). > > > > > > > > My personal interest is mostly

Re: kio-mtp

2016-03-31 Thread Dominik Haumann
On Thu, Mar 31, 2016 at 1:32 PM, Marco Martin wrote: > On Thursday 31 March 2016, Dominik Haumann wrote: >> > Still, if you get regressions with respect to pluggable mtp devices, >> > please let me know. >> >> Again me ;) >> >> Since Applications/16.04 seems to be already

Re: kio-mtp

2016-03-31 Thread Marco Martin
On Thursday 31 March 2016, Dominik Haumann wrote: > > Still, if you get regressions with respect to pluggable mtp devices, > > please let me know. > > Again me ;) > > Since Applications/16.04 seems to be already branched, is it ok to > cherry-pick this commit? i think so, as it's a fix --

Re: kio-mtp

2016-03-31 Thread Dominik Haumann
On Thu, Mar 31, 2016 at 1:01 PM, Dominik Haumann wrote: > On Thu, Mar 31, 2016 at 12:55 PM, Marco Martin wrote: >> On Thursday 31 March 2016, Dominik Haumann wrote: >> >>> Since the 16.04 release is about to happen, can we still get this >>> change committed?

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2016-03-31 Thread David Smid via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358957 --- Comment #5 from David Smid --- An ugly workaround: 1. In PowerDevil settings, set lid close action to "Do nothing" in all profiles 2. Add this to /etc/systemd/logind.conf : HandleLidSwitch=hybrid-sleep 3. Restart

Re: kio-mtp

2016-03-31 Thread Dominik Haumann
On Thu, Mar 31, 2016 at 12:55 PM, Marco Martin wrote: > On Thursday 31 March 2016, Dominik Haumann wrote: > >> Since the 16.04 release is about to happen, can we still get this >> change committed? For close to two weeks I got no reply/review. >> >> That's rather unfortunate,

Re: kio-mtp

2016-03-31 Thread Marco Martin
On Thursday 31 March 2016, Dominik Haumann wrote: > Since the 16.04 release is about to happen, can we still get this > change committed? For close to two weeks I got no reply/review. > > That's rather unfortunate, since imo the patch is ready and correct > (even confirmed by the libmtp authors

kio-mtp

2016-03-31 Thread Dominik Haumann
Hi all, I'm writing to this list, since the kio-mtp slave most certainly affects the experience of KDE Plasma5 users. In https://git.reviewboard.kde.org/r/127386/ I found out that the kio-mtp slave uses libmtp in a wrong way, namely it uses LIBMTP_Check_Specific_Device() for every device before

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2016-03-31 Thread David Smid via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358957 --- Comment #4 from David Smid --- (In reply to Martin Gräßlin from comment #2) > or maybe use HybridSuspend instead of Suspend if available. I am not sure > whether it makes sense to expose such a fine grained difference to the

[Differential] [Accepted] D1267: TaskManager: Group tasks when losing demands attention state

2016-03-31 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.6 REVISION DETAIL https://phabricator.kde.org/D1267 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca,

[Differential] [Accepted] D1271: Use a QTabWidget for the different modes in DebugConsole

2016-03-31 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. yes :D REPOSITORY rKWIN KWin BRANCH debug-console-tab-widget REVISION DETAIL https://phabricator.kde.org/D1271 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 7 - Still Unstable!

2016-03-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 31 Mar 2016 07:27:03 + Build duration: 16 min CHANGE SET Revision

[Differential] [Updated, 13 lines] D1267: TaskManager: Group tasks when losing demands attention state

2016-03-31 Thread drosca (David Rosca)
drosca updated this revision to Diff 3042. drosca added a comment. Always connect to windowChanged REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1267?vs=3035=3042 BRANCH Plasma/5.6 REVISION DETAIL

[Differential] [Commented On] D1271: Use a QTabWidget for the different modes in DebugConsole

2016-03-31 Thread Martin Gräßlin
graesslin added a comment. F102238: Spectacle.M16133.png F102240: Spectacle.B16133.png F102242: Spectacle.b16133.png REPOSITORY rKWIN KWin REVISION DETAIL

[Differential] [Request, 146 lines] D1271: Use a QTabWidget for the different modes in DebugConsole

2016-03-31 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Replaces the custom logic to switch between the three modes by tabs. REPOSITORY rKWIN KWin BRANCH debug-console-tab-widget

[Differential] [Closed] D1264: Input events mode in debug console

2016-03-31 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN3edf5a7b0a98: Input events mode in debug console (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1264?vs=3027=3040 REVISION DETAIL

[Differential] [Closed] D1262: [runners] Add a KWin runner to open KWin's debug console

2016-03-31 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPffe16922c0bf: [runners] Add a KWin runner to open KWin's debug console (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1262?vs=3023=3039#toc REPOSITORY

[Differential] [Updated] D1262: [runners] Add a KWin runner to open KWin's debug console

2016-03-31 Thread Martin Gräßlin
graesslin marked an inline comment as done. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH kwin-debug-console-runner REVISION DETAIL https://phabricator.kde.org/D1262 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: