Re: another Kirigami issue - overlap of header and listview

> On Apr 19, 2016, at 2:34 PM, Kai Uwe Broulik wrote: > > I don't know the code by heart but doesn't the ScrollView set a top margin? > If so, contentY should be set to it rather than assuming it's based on the > header height. I searched for just that margin and

Re: another Kirigami issue - overlap of header and listview

I don't know the code by heart but doesn't the ScrollView set a top margin? If so, contentY should be set to it rather than assuming it's based on the header height. ___ Plasma-devel mailing list Plasma-devel@kde.org

another Kirigami issue - overlap of header and listview

It feels like I'm the only one posting things like this here... should this go somewhere else? Same situation as usual. I have a ListView that's in a ScrollablePage. If I click/tap on the name of that page in the header, we scroll to the top. Makes sense - except that our scroll ends at a

Re: number of columns in Kirigami

> On Apr 19, 2016, at 12:32 PM, Kai Uwe Broulik wrote: > >> , or is this something I need to take to the Qt developers? > > Yes, please, the more they hear about it the more likely they are to start > doing something about it... Should I do this on your old bug

Re: number of columns in Kirigami

> , or is this something I need to take to the Qt developers? Yes, please, the more they hear about it the more likely they are to start doing something about it... As for iPhone 6 plus, the reason is that internally the device renders everything at 3x size, to make scaling easy as iOS was

number of columns in Kirigami

I finally figured out why Subsurface-mobile no longer shows multiple columns in landscape mode on the devices that I usually test on... In commit e73c014a0 ("simplify PageRow, fix currentItem calculation") the logic for how many columns to show changed in a subtle but significant way: -

[Differential] [Request, 1 line] D1449: Hook up virtual_desktop_changeable state.

hein created this revision. hein added a reviewer: graesslin. hein added a subscriber: plasma-devel. hein added a dependency: D1448: Add a virtual_desktop_changable state to the window protocol.. Restricted Application added a project: Plasma. REVISION SUMMARY Depends on

[Differential] [Updated] D1448: Add a virtual_desktop_changable state to the window protocol.

hein added a dependent revision: D1449: Hook up virtual_desktop_changeable state.. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1448 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin Cc: plasma-devel, sebas

[Differential] [Request, 62 lines] D1448: Add a virtual_desktop_changable state to the window protocol.

hein created this revision. hein added a reviewer: graesslin. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Analogous to NET::ActionChangeDesktop. KWindowInfo::actionSupported(NET::ActionChangeDesktop) is hardcoded to return true

Re: Kirigami: a feature needed for subsurface and api change feedback

> On Apr 19, 2016, at 7:31 AM, Kai Uwe Broulik wrote: > >> 2.) On your Nexus 7, the whole thing indeed is way too small. This seems to >> be a DPI scaling issue, though > > I've seen QScreen physical dots per inch reporting rubbish on some Android > devices, I think

Kirigami issue

With latest master of Kirigami we are observing an odd problem in Subsurface-mobile. This happens in landscape mode (at least I haven't been able to reproduce this in portrait mode). Our page stack has in position zero a vertical listview (dive list). If you select one of the dives in this

Re: Kirigami: a feature needed for subsurface and api change feedback

> 2.) On your Nexus 7, the whole thing indeed is way too small. This seems to > be a DPI scaling issue, though I've seen QScreen physical dots per inch reporting rubbish on some Android devices, I think Nexus 7 was even one of them. See my comment in QTBUG-35701 for a workaround (basically

[Differential] [Closed] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe0f2adaad6bc: expand window->desktopentry mapping heuristics to attempt RDN matching (authored by sitter). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Plasma 5.6.3

Plasma 5.6.3 is out with bugfixes and translation update from the last couple of weeks https://www.kde.org/announcements/plasma-5.6.3.php Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH fix/taskmanager-rdn-lookup REVISION DETAIL https://phabricator.kde.org/D1447 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Kirigami: a feature needed for subsurface and api change feedback

> On Apr 19, 2016, at 5:50 AM, Thomas Pfeiffer wrote: > > On Dienstag, 19. April 2016 05:26:35 CEST Dirk Hohndel wrote: >>> On Apr 19, 2016, at 5:12 AM, Dirk Hohndel wrote: >>> >>> So I've played with this on my phone and I'm not super excited with

[Differential] [Request, 92 lines] D1446: Fix naming: closable not closeable

graesslin created this revision. graesslin added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY All incorrect named methods are deprecated. In the interface it's just renamed, it's just an

[Differential] [Updated, 32 lines] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

sitter updated this revision to Diff 3424. sitter added a comment. improve comment a bit more. previous comment didn't really explain why more than one match can appear REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1447?vs=3423=3424

Re: Plasma 5.7 Test Days prep meeting #2 notes & log

On 04/19/2016 09:38 PM, Luca Beltrame wrote: I surely can - sorry for missing this, one of my thesis students is defending today. ;) Yay! Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org

[Differential] [Updated, 30 lines] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

sitter updated this revision to Diff 3423. sitter added a comment. refine documentation REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1447?vs=3422=3423 BRANCH fix/taskmanager-rdn-lookup REVISION DETAIL

Re: Kirigami: a feature needed for subsurface and api change feedback

> On Apr 19, 2016, at 5:33 AM, Marco Martin wrote: > > On Tuesday 19 April 2016, Dirk Hohndel wrote: >> This is an old Nexus 7; if I have my index finger hovering over the button >> it easily covers all three icons; yes, I can make it hit the right part of >> the button, but

[Differential] [Requested Changes To] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

hein requested changes to this revision. This revision now requires changes to proceed. INLINE COMMENTS libtaskmanager/taskitem.cpp:716 "that is be" is wrong grammar. Adding the Dragon example to the comment could actually help a reader. libtaskmanager/taskitem.cpp:726 Let's be verbose

Re: Kirigami: a feature needed for subsurface and api change feedback

On Tuesday 19 April 2016, Dirk Hohndel wrote: > This is an old Nexus 7; if I have my index finger hovering over the button > it easily covers all three icons; yes, I can make it hit the right part of > the button, but boy does that feel "tight". very tiny indeed :) -- Marco Martin

[Differential] [Request, 19 lines] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

sitter created this revision. sitter added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When no match can be made from classClass, attempt a fallback where we match any DesktopEntryName that

Re: Kirigami: a feature needed for subsurface and api change feedback

> On Apr 19, 2016, at 2:01 AM, Marco Martin wrote: > > On Monday 18 April 2016, Dirk Hohndel wrote: >> When Sebastian and I first talked about using the "mobile components" for >> Subsurface-mobile I explicitly agreed that I was happy with this being a >> bit of "learning by

Plasma 5.7 Test Days prep meeting #2 notes & log

attendees: eike, jensreu, bshah, d_ed, riddell, kbroulik, notmart, sitter, mgraesslin chair: eike (a) ISOs for testing - Riddell from Neon promises to get us test ISOs in time for test days, will poke him well ahead of time to plan more - No comm yet with other distros - einar77 may be able

[Differential] [Closed] D1434: Hook up movable and resizable states.

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN7804a352a896: Hook up movable and resizable states. (authored by hein). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1434?vs=3420=3421 REVISION DETAIL

[Differential] [Accepted] D1434: Hook up movable and resizable states.

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D1434 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin Cc: plasma-devel,

[Differential] [Updated, 14 lines] D1434: Hook up movable and resizable states.

hein updated this revision to Diff 3420. hein added a comment. Duplicate cursor warping a la useractions. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1434?vs=3397=3420 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1434 AFFECTED FILES

Re: Kirigami: a feature needed for subsurface and api change feedback

On Tue, Apr 19, 2016 at 01:54:10PM +0200, Thomas Pfeiffer wrote: > > > > As I go through our sources I notice that for Subsurface-mobile the new > > syntax isn't really better (but that's because we do weird things with pages > > that have multiple states). That isn't to say that I suddenly no

[Differential] [Closed] D1412: [kdecoration] Give a proper name to the Oxygen window decoration

This revision was automatically updated to reflect the committed changes. Closed by commit rOXYGEN36d7cdb340c2: [kdecoration] Give a proper name to the Oxygen window decoration (authored by graesslin). REPOSITORY rOXYGEN Oxygen Theme CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1434: Hook up movable and resizable states.

graesslin added inline comments. INLINE COMMENTS abstract_client.cpp:696-705 Cursor::pos() seems wrong to me. If it's triggered by e.g. the task manager the cursor will be on the task item and thus the first movement will make the window jump. My suggestions would be adding a:

[Differential] [Closed] D1432: Add states and request methods for move and resize.

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND26709a7ab7e5: Add states and request methods for move and resize. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1432?vs=3395=3418#toc REPOSITORY rKWAYLAND KWayland

Re: Kirigami: a feature needed for subsurface and api change feedback

> On Apr 19, 2016, at 4:45 AM, Marco Martin wrote: > > On Tuesday 19 April 2016, Dirk Hohndel wrote: >>> would be cool :) >> >> As I go through our sources I notice that for Subsurface-mobile the new >> syntax isn't really better (but that's because we do weird things with

[Differential] [Commented On] D1446: Fix naming: closable not closeable

graesslin added a comment. https://en.wiktionary.org/wiki/closable also says both is possible REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1446 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, hein Cc:

Re: Kirigami: a feature needed for subsurface and api change feedback

On Tuesday 19 April 2016, Dirk Hohndel wrote: > > would be cool :) > > As I go through our sources I notice that for Subsurface-mobile the new > syntax isn't really better (but that's because we do weird things with > pages that have multiple states). That isn't to say that I suddenly no > longer

[Differential] [Updated] D1446: Fix naming: closable not closeable

hein added a comment. Arf, sorry - I confused this with https://phabricator.kde.org/D1435. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1446 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, hein Cc:

Re: Kirigami: a feature needed for subsurface and api change feedback

> On Apr 19, 2016, at 4:19 AM, Marco Martin wrote: > > On Tuesday 19 April 2016, Dirk Hohndel wrote: >>> the look and behavior of buttons can be tested and adjusted (that >>> shouldn't involve further API changes), as the current implementaton >>> indeed is a bit cramped

[Differential] [Updated] D1446: Fix naming: closable not closeable

hein added a comment. Martin decided to change it to closable in kwayland; he's prepped changes to add new versions and deprecate the old ones, once that's in I will update this revision to follow suit. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1446

[Differential] [Closed] D1411: [kdecoration] Give a proper name to the Breeze window decoration

This revision was automatically updated to reflect the committed changes. Closed by commit rBREEZEe20fc84c475d: [kdecoration] Give a proper name to the Breeze window decoration (authored by graesslin). REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1446: Fix naming: closable not closeable

sebas added a comment. http://www.collinsdictionary.com/dictionary/english/closeable suggests that both, closable and closeable are correct. http://www.oxforddictionaries.com/definition/english/close?q=closable#close-2__50 says only closable is correct.

[Differential] [Closed] D1440: Move ShellClient initialization code into a dedicated init method

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN013de158b720: Move ShellClient initialization code into a dedicated init method (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1419: Move the WindowBasedEdge into the X11 platform and create Edge through Platform

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINe73a86d42024: Create screen edge through the Platform (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1419?vs=3356=3416#toc REPOSITORY rKWIN KWin CHANGES SINCE LAST

[Differential] [Closed] D1441: ShellClient's m_shellSurface might be null

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN8eab26c5776f: ShellClient's m_shellSurface might be null (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1441?vs=3400=3415 REVISION DETAIL

[Differential] [Accepted] D1412: [kdecoration] Give a proper name to the Oxygen window decoration

hpereiradacosta accepted this revision. This revision is now accepted and ready to land. REPOSITORY rOXYGEN Oxygen Theme BRANCH oxygen-deco-name REVISION DETAIL https://phabricator.kde.org/D1412 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1411: [kdecoration] Give a proper name to the Breeze window decoration

hpereiradacosta accepted this revision. This revision is now accepted and ready to land. REPOSITORY rBREEZE Breeze BRANCH breeze-deco-name REVISION DETAIL https://phabricator.kde.org/D1411 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

Re: Kirigami: a feature needed for subsurface and api change feedback

On Tuesday 19 April 2016, Dirk Hohndel wrote: > > the look and behavior of buttons can be tested and adjusted (that > > shouldn't involve further API changes), as the current implementaton > > indeed is a bit cramped making side buttons difficult to hit > > I take this to mean that you'd like me

Re: Kirigami: a feature needed for subsurface and api change feedback

> On Apr 19, 2016, at 2:01 AM, Marco Martin wrote: > > On Monday 18 April 2016, Dirk Hohndel wrote: >> When Sebastian and I first talked about using the "mobile components" for >> Subsurface-mobile I explicitly agreed that I was happy with this being a >> bit of "learning by

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 23 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 19 Apr 2016 10:52:53 + Build duration: 1 min 49 sec CHANGE SET Revision

[Differential] [Accepted] D1432: Add states and request methods for move and resize.

graesslin accepted this revision. This revision is now accepted and ready to land. INLINE COMMENTS src/server/plasmawindowmanagement_interface.h:146-153 I withdraw that comment - there are also minimizeableRequested and friends. So while they can be considered stupid, it's better to be API

[Differential] [Requested Changes To] D1432: Add states and request methods for move and resize.

graesslin requested changes to this revision. This revision now requires changes to proceed. INLINE COMMENTS src/server/plasmawindowmanagement_interface.cpp:472-477 as said abode: I don't think we need that. src/server/plasmawindowmanagement_interface.h:146-153 What's the point in

[Differential] [Closed] D1417: Add window shade support to protocol, interfaces and test.

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND44705e5a7634: Add window shade support to protocol, interfaces and test. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1417?vs=3409=3412#toc REPOSITORY rKWAYLAND

[Differential] [Closed] D1418: Expose client shade state to kwayland's interface.

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINef6a2cfa649c: Expose client shade state to kwayland's interface. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1418?vs=3410=3411#toc REPOSITORY rKWIN KWin CHANGES

[Differential] [Accepted] D1418: Expose client shade state to kwayland's interface.

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D1418 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin Cc: sebas,

[Differential] [Accepted] D1417: Add window shade support to protocol, interfaces and test.

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D1417 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin Cc:

[Differential] [Updated, 8 lines] D1418: Expose client shade state to kwayland's interface.

hein updated this revision to Diff 3410. hein added a comment. - Switch to naming suggested by native speakers. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1418?vs=3354=3410 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1418 AFFECTED

[Differential] [Updated, 217 lines] D1417: Add window shade support to protocol, interfaces and test.

hein updated this revision to Diff 3409. hein added a comment. - Add API version info; fix references to protocol version. - Fix comment, make explicit which object the slot is called on. - Add states and request methods for move and resize. REPOSITORY rKWAYLAND KWayland CHANGES SINCE

[Differential] [Updated, 21 lines] D1445: Get the logind session to take over through env variable instead of own PID

graesslin updated this revision to Diff 3408. graesslin added a comment. Use the standardized XDG_SESSION_ID instead of a custom env variable REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1445?vs=3407=3408 BRANCH logind-session-arg REVISION DETAIL

Re: Kirigami: a feature needed for subsurface and api change feedback

On Monday 18 April 2016, Dirk Hohndel wrote: > When Sebastian and I first talked about using the "mobile components" for > Subsurface-mobile I explicitly agreed that I was happy with this being a > bit of "learning by doing" and at least initially being a moving target. > > I guess I was confused

[Differential] [Updated] D1445: Get the logind session to take over through env variable instead of own PID

graesslin added a dependency: D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1445 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation

graesslin added a dependent revision: D1445: Get the logind session to take over through env variable instead of own PID. REPOSITORY rKWIN KWin BRANCH vt-integration-through-logind REVISION DETAIL https://phabricator.kde.org/D1444 EMAIL PREFERENCES

[Differential] [Request, 21 lines] D1445: Get the logind session to take over through env variable instead of own PID

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So far KWin resolved the logind session to take over by using its own PID with the method

[Differential] [Accepted] D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation

helio accepted this revision. helio added a reviewer: helio. helio added a comment. This revision is now accepted and ready to land. Sounds good to me REPOSITORY rKWIN KWin BRANCH vt-integration-through-logind REVISION DETAIL https://phabricator.kde.org/D1444 EMAIL PREFERENCES

[Differential] [Request, 111 lines] D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Get the Logind seat for our logind session In order to switch virtual terminals through logind we need

[Differential] [Accepted] D1415: Don't check for waylandServer() when accessing the platform in Compositor

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH composite-no-check-waylandServer REVISION DETAIL https://phabricator.kde.org/D1415 EMAIL PREFERENCES

[Differential] [Accepted] D1396: Add PROJECT_VERSION to CMakeLists.txt

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH project-version-cmakelist REVISION DETAIL https://phabricator.kde.org/D1396 EMAIL PREFERENCES

[Differential] [Request, 49 lines] D1415: Don't check for waylandServer() when accessing the platform in Compositor

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Less diversions between X11 and Wayland. REPOSITORY rKWIN KWin BRANCH

[Differential] [Request, 196 lines] D1413: Move the EglOnXBackend to the x11 platforms

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The EglOnXBackend is no longer needed in the core. It's only needed by the two x11 platform plugins.

[Differential] [Request, 2 lines] D1396: Add PROJECT_VERSION to CMakeLists.txt

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH project-version-cmakelist REVISION

[Differential] [Request, 49 lines] D1372: Fix unsetting associated application/urls for applets

kossebau created this revision. kossebau added a reviewer: mart. kossebau added a subscriber: plasma-devel. REVISION SUMMARY Current code does not properly handle any resetting, which results in Applet::hasValidAssociatedApplication() still returning true when urls have been set to an empty

[Differential] [Accepted] D1372: Fix unsetting associated application/urls for Plasma::Applets

mart accepted this revision. This revision is now accepted and ready to land. BRANCH allowAssignedUrlAppUnsetting REVISION DETAIL https://phabricator.kde.org/D1372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, mart Cc: plasma-devel, sebas

[Differential] [Updated, 43 lines] D1372: Fix unsetting associated application/urls for applets

kossebau updated this revision to Diff 3250. kossebau added a comment. Remove accidentally commited CMakeLists.txt work adaptions CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1372?vs=3249=3250 BRANCH allowAssignedUrlAppUnsetting REVISION DETAIL

[Differential] [Updated] D1396: Add PROJECT_VERSION to CMakeLists.txt

graesslin added a dependent revision: D1397: Depend on Breeze to set the default style name. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH project-version-cmakelist REVISION DETAIL https://phabricator.kde.org/D1396 EMAIL PREFERENCES

[Differential] [Accepted] D1353: Move backends/ to plugins/platforms/

sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH backends-become-platforms REVISION DETAIL https://phabricator.kde.org/D1353 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas,

[Differential] [Request, 15,220 lines] D1353: Move backends/ to plugins/platforms/

graesslin created this revision. graesslin added reviewers: Plasma, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Source code reorganization: The base class AbstractBackend got renamed to Platform, thus the

[Differential] [Accepted] D1340: Rename AbstractBackend to Platform

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH rename-abstract-backend-to-platform REVISION DETAIL https://phabricator.kde.org/D1340 EMAIL PREFERENCES

[Differential] [Accepted] D1339: waylandServer()->backend() replaced by kwinApp()->platform()

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH remove-wayland-server-backend REVISION DETAIL https://phabricator.kde.org/D1339 EMAIL PREFERENCES

Re: Review Request 127586: [calendar] Add a mark to days containing events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94703 --- Ship it! Ship It! - Marco Martin On April 19, 2016,

[Differential] [Accepted] D1419: Move the WindowBasedEdge into the X11 platform and create Edge through Platform

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH screen-edge-platform REVISION DETAIL https://phabricator.kde.org/D1419 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1435: Add missing data role for closable state.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH moveresize REVISION DETAIL https://phabricator.kde.org/D1435 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1441: ShellClient's m_shellSurface might be null

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH preparation-xdg-shell-shell-surface-may-be-null REVISION DETAIL https://phabricator.kde.org/D1441 EMAIL PREFERENCES

[Differential] [Accepted] D1440: Move ShellClient initialization code into a dedicated init method

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH preparation-xdg-shell REVISION DETAIL https://phabricator.kde.org/D1440 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D1441: ShellClient's m_shellSurface might be null

graesslin added inline comments. INLINE COMMENTS shell_client.cpp:295 Yes surface() is guaranteed to not be null. A shellsurface is created for a surface. If the surface is destroyed, the shellsurface also gets destroyed. REPOSITORY rKWIN KWin REVISION DETAIL