[Differential] [Accepted] D1660: [Milou] Take label height into account for delegate height

2016-05-24 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rMILOU Milou REVISION DETAIL https://phabricator.kde.org/D1660 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, mart Cc:

[Differential] [Accepted] D1657: kfontinst: Port away from KStandardDirs

2016-05-24 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1657 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1661: Support touch events on KWin internal windows

2016-05-24 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. While would be nice to have actual multitouch, for now is better than nothing, so let's go with this and think about multitouch if there will be a strong use case i

[Differential] [Closed] D1660: [Milou] Take label height into account for delegate height

2016-05-24 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rMILOUbd14a260e651: [Milou] Take label height into account for delegate height (authored by broulik). REPOSITORY rMILOU Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1660?vs=3944&id=3952

[Differential] [Closed] D1662: [Services Runner] Add launched applications to recently used list

2016-05-24 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE33b14f1f0734: [Services Runner] Add launched applications to recently used list (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://pha

[Differential] [Request, 19 lines] D1666: [libinput] Add the Device to Event

2016-05-24 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The Event class now holds a pointer to the Device and not only to the native libinput_device. REPOSITO

[Differential] [Updated] D1666: [libinput] Add the Device to Event

2016-05-24 Thread Martin Gräßlin
graesslin added a dependency: D1665: [libinput] Track all created Devices in Device. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1666 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas __

[Differential] [Updated] D1665: [libinput] Track all created Devices in Device

2016-05-24 Thread Martin Gräßlin
graesslin added a dependent revision: D1666: [libinput] Add the Device to Event. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1665 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas ___

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 98 - Still Unstable!

2016-05-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/98/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 May 2016 07:55:47 + Build duration: 10 min CHANGE SET Revision 33b14f1f073458925732f52f737655bbaf7

Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

2016-05-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127975/ --- (Updated May 24, 2016, 8:30 a.m.) Review request for Plasma. Changes --

[Differential] [Request, 421 lines] D1667: Pass LibInput::Device* through the event handlers

2016-05-24 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The signals emitted by LibInput::Connection carry the Device for which the input event was received. Th

[Differential] [Updated] D1666: [libinput] Add the Device to Event

2016-05-24 Thread Martin Gräßlin
graesslin added a dependent revision: D1667: Pass LibInput::Device* through the event handlers. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1666 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, s

[Differential] [Updated] D1667: Pass LibInput::Device* through the event handlers

2016-05-24 Thread Martin Gräßlin
graesslin added dependencies: D1666: [libinput] Add the Device to Event, D1665: [libinput] Track all created Devices in Device. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graes

[Differential] [Updated] D1667: Pass LibInput::Device* through the event handlers

2016-05-24 Thread Martin Gräßlin
graesslin added a dependent revision: D1668: Add the Device to the input event summary. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas ___

[Differential] [Request, 26 lines] D1668: Add the Device to the input event summary

2016-05-24 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Now that we have access to the actual LibInput Device from the event handler, let's also print out whic

[Differential] [Updated] D1668: Add the Device to the input event summary

2016-05-24 Thread Martin Gräßlin
graesslin added dependencies: D1667: Pass LibInput::Device* through the event handlers, D1666: [libinput] Add the Device to Event, D1665: [libinput] Track all created Devices in Device. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1668 EMAIL PREFERENCES https://phab

[Differential] [Updated] D1666: [libinput] Add the Device to Event

2016-05-24 Thread Martin Gräßlin
graesslin added a dependent revision: D1668: Add the Device to the input event summary. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1666 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas ___

[Differential] [Closed] D1661: Support touch events on KWin internal windows

2016-05-24 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINff88f938524d: Support touch events on KWin internal windows (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1661?vs=3945&id=3958 REVISION DET

Review Request 128000: [Quick Chat] Use onAccepted rather than Keys.onReturnPressed

2016-05-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128000/ --- Review request for Plasma. Repository: ktp-desktop-applets Description

Review Request 128001: [Quick Chat] Close chat window when pressing Escape

2016-05-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128001/ --- Review request for Plasma and KDE Usability. Repository: ktp-desktop-appl

Re: Review Request 128000: [Quick Chat] Use onAccepted rather than Keys.onReturnPressed

2016-05-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128000/#review95737 --- Ship it! Ship It! - David Edmundson On May 24, 2016, 9:

[Differential] [Updated, 977 lines] D1646: Drop KDElibs4Support dependency from time engine

2016-05-24 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 3960. davidedmundson added a comment. - New login screen REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1646?vs=3896&id=3960 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1

[Differential] [Abandoned] D1646: Drop KDElibs4Support dependency from time engine

2016-05-24 Thread davidedmundson (David Edmundson)
davidedmundson abandoned this revision. davidedmundson added a comment. What. Stupid Phabricator. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1646 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmu

[Differential] [Request, 967 lines] D1670: New login screen

2016-05-24 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Implemented the new login screen as designed by Andreas TEST PLAN As there is a dummydata fo

Re: New idea for Plasma's logo

2016-05-24 Thread Kåre Särs
Hi, Did you notice that the Qt logo has changed? The rounded corners are not round anymore: http://brand.qt.io/guidelines/ /Kåre On måndag 23 maj 2016 kl. 22:52:47 EEST Alessandro Longo wrote: > (resent because apparently mailman rejected it) > Hi, > after a lot of iterations I found a simple i

Re: Review Request 128001: [Quick Chat] Close chat window when pressing Escape

2016-05-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128001/#review95739 --- Ship it! Ship It! - David Edmundson On May 24, 2016, 9:

Re: Review Request 128000: [Quick Chat] Use onAccepted rather than Keys.onReturnPressed

2016-05-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128000/ --- (Updated May 24, 2016, 2:28 p.m.) Status -- This change has been mar

Re: Review Request 128001: [Quick Chat] Close chat window when pressing Escape

2016-05-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128001/ --- (Updated May 24, 2016, 11:28 a.m.) Status -- This change has been ma

[Differential] [Closed] D1671: [libinput] Expose whether an alpha-numeric keyboard is connected

2016-05-24 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN9cdd76f20dcd: [libinput] Expose whether an alpha-numeric keyboard is connected (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1671?vs=3962&id

[Differential] [Updated, 709 lines] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-24 Thread Martin Gräßlin
graesslin updated this revision to Diff 3964. graesslin added a comment. - Only enable virtual keyboard if no alpha numeric keyboard - add a SNI to enable/disable virtual keyboard nevertheless - add a Qt 5.6 (enterprise) variant, for easy testing with Qt 5.6 - show OSD on enable/disable

[Differential] [Request, 159 lines] D1672: Add support for touch events in fakeinput protocol and interface.

2016-05-24 Thread bdhruve (Bhavisha Dhruve)
bdhruve created this revision. bdhruve added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds support for following in fakeinput interface: - touch_down - touch_motion - touch_up - t

Re: New idea for Plasma's logo

2016-05-24 Thread Alessandro Longo
Il 24-05-2016 12:03 Kåre Särs ha scritto: Hi, Did you notice that the Qt logo has changed? The rounded corners are not round anymore: http://brand.qt.io/guidelines/ Yes I knew it, thanks. Also the font changed. I think me or others will update the Qt icons in Breeze, in the meanwhile I recy

[Differential] [Updated] D1672: Add support for touch events in fakeinput protocol and interface.

2016-05-24 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > fake-input.xml:19 >]]> > > when you add new requests to a protocol you need to increase the version number. This requires changes at a few more places. For reference on what needs to be changed check https://phabricator.kde.org

Re: DWD HIG Draft

2016-05-24 Thread Sebastian Kügler
Hi Ken, On dinsdag 17 mei 2016 10:49:08 CEST Ken Vermette wrote: > We have our first serious formal proposal for the DWD HIGs and the > functionality we are looking for; here's a link to the publicly editable > Google doc: > > https://docs.google.com/document/d/1mYzHjcuDitWmk99syjC0xzQPPmyUrpL_29

[Differential] [Commented On] D1673: [Libtaskmanager] Add launcher mapping for Google Chrome apps

2016-05-24 Thread broulik (Kai Uwe Broulik)
broulik added a comment. F133997: Screenshot_20160524_165059.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1673 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Request, 7 lines] D1673: [Libtaskmanager] Add launcher mapping for Google Chrome apps

2016-05-24 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY They are supposed to

[Differential] [Request, 80 lines] D1675: kfontinst: Port to QTemporaryDir

2016-05-24 Thread volkov (Alexander Volkov)
volkov created this revision. volkov added a reviewer: Plasma. volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION

[Differential] [Updated] D1657: kfontinst: Port away from KStandardDirs

2016-05-24 Thread volkov (Alexander Volkov)
volkov added a dependent revision: D1675: kfontinst: Port to QTemporaryDir. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1657 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov, Plasma, mart Cc: plasma-devel,

[Differential] [Request, 191 lines] D1676: kfontinst: Port to QApplication and QCommandLineParser

2016-05-24 Thread volkov (Alexander Volkov)
volkov created this revision. volkov added a reviewer: Plasma. volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION

[Differential] [Updated] D1676: kfontinst: Port to QApplication and QCommandLineParser

2016-05-24 Thread volkov (Alexander Volkov)
volkov added a dependency: D1675: kfontinst: Port to QTemporaryDir. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1676 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov, Plasma Cc: plasma-devel, sebas

[Differential] [Updated] D1675: kfontinst: Port to QTemporaryDir

2016-05-24 Thread volkov (Alexander Volkov)
volkov added a dependent revision: D1676: kfontinst: Port to QApplication and QCommandLineParser. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1675 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov, Plasma C

[Differential] [Updated] D1673: [Libtaskmanager] Add launcher mapping for Google Chrome apps

2016-05-24 Thread hein (Eike Hein)
hein added a comment. I won't accept this patch, sorry. I'm not willing to add special cases for individual applications, especially to compiled code. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1673 EMAIL PREFERENCES https://phabricator.k

[Differential] [Commented On] D1676: kfontinst: Port to QApplication and QCommandLineParser

2016-05-24 Thread apol (Aleix Pol Gonzalez)
apol added a comment. LGTM +1 INLINE COMMENTS > Viewer.cpp:131 > { > -for (int i = 0; i < args->count(); ++i) > +for (int i = 0; i < urlArgs.count(); ++i) > { Prefer foreach to iterate a QList REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION

[Differential] [Commented On] D1675: kfontinst: Port to QTemporaryDir

2016-05-24 Thread apol (Aleix Pol Gonzalez)
apol added a comment. I'd say it's generally better to use QDir::filePath there. it will be easier to read. INLINE COMMENTS > FontThumbnail.cpp:96 > { > -realPath=tempDir->name()+entry->name(); > + >

Fwd: I share project Astian OS

2016-05-24 Thread Alfonso Hernandez
Mensaje reenviado Asunto: I share project Astian OS Fecha: Tue, 24 May 2016 13:58:21 -0500 De: Alfonso Hernandez Para: Sandro Andrade , aleix...@kde.org Hi KDEcommunity ShareprojectAstianOScodeforthecollaborationbytheKDEcommunityandget involvedinthisideaist

[Differential] [Closed] D1651: Fix saving of calendar events plugins and holidays regions

2016-05-24 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7734b90eb9f1: Fix saving of calendar events plugins and holidays regions (authored by drosca). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

[Differential] [Commented On] D1673: [Libtaskmanager] Add launcher mapping for Google Chrome apps

2016-05-24 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Would you instead accept an extension of the taskmanagerrulesrc mechanism in the style of: [Rewrite Rules][google-chrome] crx_$1=chrome-$1-default ? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1673 EM

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 99 - Still Unstable!

2016-05-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/99/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 May 2016 19:09:27 + Build duration: 9 min 11 sec CHANGE SET Revision 7734b90eb9f10d73cf1d4e4db503a

[Differential] [Commented On] D1670: New login screen

2016-05-24 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. thanks INLINE COMMENTS > broulik wrote in Background.qml:36 > My gut feeling always makes me avoid QtGraphicalEffects where possible, ie. a > plain Rectangle; especially because the latter doesn't use a ShaderEffectItem > (2d renderer) I just go with the des

[Differential] [Commented On] D1670: New login screen

2016-05-24 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in Background.qml:36 > I just go with the design. > I could stick in a 1000x1 px png instead? Rectangle still allows Gradient with GradientStop, just that the gradient can only be top to bottom which is what we want here anyw

[Differential] [Requested Changes To] D1672: Add support for touch events in fakeinput protocol and interface.

2016-05-24 Thread bshah (Bhushan Shah)
bshah requested changes to this revision. bshah added a reviewer: bshah. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_fake_input.cpp:328 > +// without an authentication we shouldn't get the signals > +m_fakeInput->requestTouchDown(0,QP