[Differential] [Accepted] D1856: more creative output type detection in xrandr backend

2016-06-14 Thread Daniel Vrátil
dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Good idea with the fallback. REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/xrandrtype REVISION DETAIL https://phabricator.kde.org/D1856 EMAIL PREFERENCES https://phabricat

[Differential] [Request, 99 lines] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

2016-06-14 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY To use eglCreateImageKhr for an X11 pixmap we need an EGLDisplay cre

Re: Review Request 128179: add switch size for kate applet

2016-06-14 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128179/ --- (Updated Juni 14, 2016, 7:20 vorm.) Review request for Kate and Plasma.

Re: Review Request 128179: add switch size for kate applet

2016-06-14 Thread Andreas Kainz
> On Juni 14, 2016, 7:17 vorm., Dominik Haumann wrote: > > addons/sessionapplet/applet/contents/ui/katesessions.qml, line 37 > > > > > > please remove the trailing white spaces removed. - Andreas

Re: Review Request 128178: scaling konsole profile

2016-06-14 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128178/ --- (Updated June 14, 2016, 7:25 a.m.) Review request for Plasma. Changes -

Review Request 128180: device notifier applet size

2016-06-14 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128180/ --- Review request for Plasma. Repository: plasma-workspace Description ---

[Differential] [Commented On] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

2016-06-14 Thread bshah (Bhushan Shah)
bshah added a comment. +1, This patch definitely improved situation then earlier where kwin_wayland used to crash with this backtrace : https://ptpb.pw/Y_W1.txt REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1857 EMAIL PREFERENCES https://phabricator.kde.org/settin

Re: Review Request 128179: add switch size for kate applet

2016-06-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128179/#review96457 --- Ship it! yep, remove the trailing spaces and ship it - Ma

Re: Review Request 128178: scaling konsole profile

2016-06-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128178/#review96458 --- Ship it! Ship It! - Marco Martin On June 14, 2016, 7:25

[Differential] [Request, 2 lines] D1858: [platforms/drm] Apply new global position on DrmOutput for a changeset

2016-06-14 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, sebas. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY When we get a configuration request, we also need to update t

Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

2016-06-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128181/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

[Differential] [Changed Subscribers] D1856: more creative output type detection in xrandr backend

2016-06-14 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > xrandroutput.cpp:258 > + > +Q_FOREACH(const QString &pre, embedded) { > +if (name.toUpper().startsWith(pre)) { range for, embedded is const REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/xrandrtype REVISION DETAIL https:/

[Differential] [Request, 13 lines] D1859: Prepare KSplash for KDED dropping KSplash support

2016-06-14 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We want to drop workspace code from KDED as it doesn't make much sense semantically. Thi

[Differential] [Updated] D1859: Prepare KSplash for KDED dropping KSplash support

2016-06-14 Thread davidedmundson (David Edmundson)
davidedmundson added a reviewer: dfaure. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1859 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, dfaure Cc: plasma-devel, sebas __

[Differential] [Accepted] D1859: Prepare KSplash for KDED dropping KSplash support

2016-06-14 Thread dfaure (David Faure)
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! INLINE COMMENTS > splashapp.cpp:106 > { > +//filter out startup events from KDED as they will be removed in a > future release > +if (stage == QLatin1String("kded") || sta

[Differential] [Request, 102 lines] D1860: make kirigamiplugin also directly linkable

2016-06-14 Thread bearsh (Martin)
bearsh created this revision. bearsh added a reviewer: mart. bearsh set the repository for this revision to rKIRIGAMI Kirigami. bearsh added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this makes it possible to simply put kirigami in a subfolder

[Differential] [Closed] D1859: Prepare KSplash for KDED dropping KSplash support

2016-06-14 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb6058a09aed2: Prepare KSplash for KDED dropping KSplash support (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

Re: Review Request 128178: scaling konsole profile

2016-06-14 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128178/ --- (Updated June 14, 2016, 9:31 a.m.) Status -- This change has been ma

[Differential] [Reopened] D1859: Prepare KSplash for KDED dropping KSplash support

2016-06-14 Thread Martin Gräßlin
graesslin reopened this revision. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > startkde.cmake:354 > LD_BIND_NOW=true @CMAKE_INSTALL_FULL_LIBEXECDIR_KF5@/start_kdeinit_wrapper > --kded +kcminit_startup > +qdbus org.kde.KSplash /KSplash org.k

Re: Review Request 128179: add switch size for kate applet

2016-06-14 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128179/ --- (Updated June 14, 2016, 12:34 p.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 157 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/157/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 09:23:06 + Build duration: 10 min CHANGE SET Revision b6058a09aed209f752f96159283da0c825

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 158 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/158/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 09:37:17 + Build duration: 17 min CHANGE SET Revision c8cae6bf142f3741819a8bd15100bc912d

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 44 - Failure!

2016-06-14 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 09:54:57 + Build duration: 2 min 48 sec CHANGE SET Revision fd43f1f0d272e403d7acd

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 39 - Still Failing!

2016-06-14 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 09:56:06 + Build duration: 5 min 59 sec CHANGE SET Revision 26c3fe19e3502d2e2cd

Re: Review Request 128180: device notifier applet size

2016-06-14 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128180/#review96463 --- applets/devicenotifier/package/contents/ui/FullRepresentatio

Re: Review Request 128180: device notifier applet size

2016-06-14 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128180/#review96465 --- applets/devicenotifier/package/contents/ui/devicenotifier.qm

Re: Review Request 128180: device notifier applet size

2016-06-14 Thread Andreas Kainz
> On Juni 14, 2016, 10:09 vorm., Anthony Fieroni wrote: > > applets/devicenotifier/package/contents/ui/FullRepresentation.qml, line 113 > > > > > > This count looks mistaken, what you want to do? oh that's not g

Re: Review Request 128180: device notifier applet size

2016-06-14 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128180/ --- (Updated June 14, 2016, 10:24 a.m.) Review request for Plasma. Reposito

[Differential] [Accepted] D1860: make kirigamiplugin also directly linkable

2016-06-14 Thread mart (Marco Martin)
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. apart minor cosmetic issues is good to go. do you have permissions to push on git? INLINE COMMENTS > kirigamiplugin.h:69 > +QUrl componentPath(const QString &fileName) const; > +QS

[Differential] [Closed] D1832: [DrKonqi] Add config to directly show backtrace

2016-06-14 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE17597ee16fe0: [DrKonqi] Add config to directly show backtrace (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 40 - Failure!

2016-06-14 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 10:39:34 + Build duration: 2 min 17 sec CHANGE SET Revision 9ffcb3178cea8b06fdf

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 159 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/159/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 10:40:33 + Build duration: 13 min CHANGE SET Revision 17597ee16fe0a48bb9ab4eb686d4067824

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

2016-06-14 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364275 --- Comment #6 from d958x7...@mail.com --- (In reply to Christoph Feck from comment #3) > What packages did you update? From which version to which version? I > strongly suggest to report this on the bug tracker of your distribution, > because these hard

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

2016-06-14 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364275 --- Comment #7 from d958x7...@mail.com --- (In reply to Christoph Feck from comment #3) > What packages did you update? From which version to which version? I > strongly suggest to report this on the bug tracker of your distribution, > because these hard

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

2016-06-14 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128181/#review96467 --- src/scriptengines/qml/plasmoid/appletinterface.cpp (line 67)

[Differential] [Updated, 108 lines] D1860: make kirigamiplugin also directly linkable

2016-06-14 Thread bearsh (Martin)
bearsh updated this revision to Diff 4447. bearsh added a comment. rename toFile{Path,Url} to resolveFile{Path,Url} and fixed code style REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1860?vs=4439&id=4447 REVISION DETAIL https://phabricator.kde.org

[Differential] [Commented On] D1860: make kirigamiplugin also directly linkable

2016-06-14 Thread bearsh (Martin)
bearsh added a comment. In https://phabricator.kde.org/D1860#34489, @mart wrote: > do you have permissions to push on git? no but I can get send-email it to you... REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1860 EMAIL PREFERENCES https://pha

[Differential] [Accepted] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

2016-06-14 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH texture-from-pixmap-x11-only REVISION DETAIL https://phabricator.kde.org/D1857 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Closed] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

2016-06-14 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN2b196bfa291a: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1857?vs=4

[Differential] [Request, 15 lines] D1864: Handle ShellClient::windowShown in Workspace

2016-06-14 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY When a ShellClient gets unmapped and mapped again the signal windowS

[Differential] [Accepted] D1864: Handle ShellClient::windowShown in Workspace

2016-06-14 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH handle-window-shown REVISION DETAIL https://phabricator.kde.org/D1864 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D1847: [System Tray AbstractItem] Hide tooltip when clicking item

2016-06-14 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf117addb616a: [System Tray AbstractItem] Hide tooltip when clicking item (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricato

[Differential] [Commented On] D1860: make kirigamiplugin also directly linkable

2016-06-14 Thread mart (Marco Martin)
mart added a comment. ok, you can send me a patch with git format-patch, o with git am i can push it with you as author. for future ones, you gan do: https://identity.kde.org/index.php?r=developerApplication REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 160 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/160/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 11:52:58 + Build duration: 11 min CHANGE SET Revision f117addb616a13eb49add43d4f0d6324d9

[Differential] [Request, 30 lines] D1865: TasksModel: cache launcherCount().

2016-06-14 Thread dfaure (David Faure)
dfaure created this revision. dfaure added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This also allows to only emit launcherCountChanged() when it actually changed. The emit from TasksModel::fil

[Differential] [Commented On] D1856: more creative output type detection in xrandr backend

2016-06-14 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > graesslin wrote in xrandroutput.cpp:253 > sure you want to use a QStringList? It looks to me like you wanted to have > them as QLatin1Strings for the startsWith check. But that doesn't work when > converted to QString. So maybe QVector? This code

[Differential] [Closed] D1856: more creative output type detection in xrandr backend

2016-06-14 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREEN54ec74901a0f: more creative output type detection in xrandr backend (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1856?vs

[Differential] [Request, 10 lines] D1866: Use QVector and QLatin1String, and range-based for

2016-06-14 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. sebas added subscribers: graesslin, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This moves the code to the right string types and uses the C++11 t

[Differential] [Commented On] D1856: more creative output type detection in xrandr backend

2016-06-14 Thread Sebastian Kügler
sebas added a comment. https://phabricator.kde.org/D1866 there. REPOSITORY rLIBKSCREEN KScreen Library REVISION DETAIL https://phabricator.kde.org/D1856 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma, dvratil Cc: broulik, graesslin, p

[Differential] [Request, 810 lines] D1867: [Calendar Applet] Show day or week number in icon

2016-06-14 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Rather tha

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

2016-06-14 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Might need a new icon though F149458: Screenshot_20160614_144210.png F149459: Screenshot_20160614_144217.png F149460: Screenshot_20160614_144303.png

[Differential] [Request, 35 lines] D1868: [server] Introduce a Resource::unbound signal emitted from unbind handler

2016-06-14 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY So far for internal cleanup we mostly listen to QObject::destroyed. When a Resour

[Differential] [Accepted] D1868: [server] Introduce a Resource::unbound signal emitted from unbind handler

2016-06-14 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH resource-unbound REVISION DETAIL https://phabricator.kde.org/D1868 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Changed Subscribers] D1866: Use QVector and QLatin1String, and range-based for

2016-06-14 Thread apol (Aleix Pol Gonzalez)
apol added inline comments. INLINE COMMENTS > xrandroutput.cpp:258 > > -Q_FOREACH(const QString &pre, embedded) { > +for (const QLatin1String &pre : embedded) { > if (name.toUpper().startsWith(pre)) { This one is fine, but I wouldn't change from `foreach -> for` as a norm, as

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

2016-06-14 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Where did you take that icon from? We have apps/office-calendar and org.kde.plasma.calendar, both of which look quite different from this one. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1867 EMAIL PREFERENCES ht

[Differential] [Request, 8 lines] D1869: [Containment Actions] Offer "Remove this panel" option only when panel is being edited

2016-06-14 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We only sh

[Differential] [Changed Subscribers] D1865: TasksModel: cache launcherCount().

2016-06-14 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > tasksmodel.cpp:763 > + > +d->launcherCount = launchers.count(); > +} Better set the new value before emitting the change signal REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1865 EMAIL PREFERE

[Differential] [Updated, 29 lines] D1865: TasksModel: cache launcherCount().

2016-06-14 Thread dfaure (David Faure)
dfaure updated this revision to Diff 4458. dfaure added a comment. Set the new value before emitting the change signal, indeed. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1865?vs=4451&id=4458 BRANCH master REVISION DETAIL http

[Differential] [Accepted] D1866: Use QVector and QLatin1String, and range-based for

2016-06-14 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/xrandrtyperangefor REVISION DETAIL https://phabricator.kde.org/D1866 EMAIL PREFERENCES https://phabricator.kde.or

[Differential] [Closed] D1866: Use QVector and QLatin1String, and range-based for

2016-06-14 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREEN2792f55ff5c2: Use QVector and QLatin1String, and range-based for (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1866?vs=44

[Differential] [Accepted] D1868: [server] Introduce a Resource::unbound signal emitted from unbind handler

2016-06-14 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. REPOSITORY rKWAYLAND KWayland BRANCH resource-unbound REVISION DETAIL https://phabricator.kde.org/D1868 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas,

Plasma 5.6.5

2016-06-14 Thread Jonathan Riddell
Plasma 5.6.5 is out, the last of the current series https://www.kde.org/announcements/plasma-5.6.5.php The tars come with nifty new .sig files which are PGP signatures so you can verify they are made by the same person who put up the announce on the website and match the signature on the tars in

[Differential] [Closed] D1858: [platforms/drm] Apply new global position on DrmOutput for a changeset

2016-06-14 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf5b83d18b892: [platforms/drm] Apply new global position on DrmOutput for a changeset (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1858?vs=4

Re:Plasma 5.6.5

2016-06-14 Thread Antonio Rojas
Jonathan Riddell Wrote in message: > Plasma 5.6.5 is out, the last of the current series > > https://www.kde.org/announcements/plasma-5.6.5.php > > The tars come with nifty new .sig files which are PGP signatures so > you can verify they are made by the same person who put up the > announce on t

[Differential] [Accepted] D1858: [platforms/drm] Apply new global position on DrmOutput for a changeset

2016-06-14 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Cool! REPOSITORY rKWIN KWin BRANCH drm-apply-output-position-change REVISION DETAIL https://phabricator.kde.org/D1858 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

Re: Plasma 5.6.5

2016-06-14 Thread Kai Uwe Broulik
Yes, because there has been a: * unreviewed * not even compiled  * one day before release  Commit that broke it. People, this must not be ...  I fixed it in master but didn't notice (and didn't expect) such a change in 5.6. Cheers,  Kai Uwe  ___ Plasma

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

2016-06-14 Thread David Edmundson
> On June 14, 2016, 10:59 a.m., Anthony Fieroni wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 67 > > > > > > So, this connect and below must be removed? Same connections in newly > > setupCo

Re:Plasma 5.6.5

2016-06-14 Thread Jonathan Riddell
On Tue, Jun 14, 2016 at 04:17:30PM +0200, Antonio Rojas wrote: > Jonathan Riddell Wrote in message: > > Plasma 5.6.5 is out, the last of the current series > > > > https://www.kde.org/announcements/plasma-5.6.5.php > > > > The tars come with nifty new .sig files which are PGP signatures so > > y

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

2016-06-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128181/#review96484 --- > connect(applet(), &Plasma::Applet::contextualActionsAboutTo

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

2016-06-14 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 14:26:55 + Build duration: 13 min CHANGE SET Revision 521b257894b88b307b4fa0ce7

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

2016-06-14 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 14:26:55 + Build duration: 13 min CHANGE SET Revision 521b257894b88b307b4fa0ce7

[Differential] [Request, 2 lines] D1874: [XWindowTasksModel] Ignore when client is transient for itself

2016-06-14 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Now I get Android Studio wi

[Differential] [Accepted] D1874: [XWindowTasksModel] Ignore when client is transient for itself

2016-06-14 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1874 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc: plasma

[Differential] [Closed] D1874: [XWindowTasksModel] Ignore when client is transient for itself

2016-06-14 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE58ea81b94ba3: [XWindowTasksModel] Ignore when client is transient for itself (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabri

[Differential] [Accepted] D1865: TasksModel: cache launcherCount().

2016-06-14 Thread hein (Eike Hein)
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Since I'm only asking for comment changes I'm accepting it code-wise :) INLINE COMMENTS > tasksmodel.cpp:744 > if (!filterIndex.data(AbstractTasksModel::IsLauncher).toBool()) { > +

[Differential] [Closed] D1860: make kirigamiplugin also directly linkable

2016-06-14 Thread bearsh (Martin)
bearsh closed this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1860 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bearsh, mart Cc: plasma-devel ___ Plasma-devel mailin

[Breeze] [Bug 364313] Umbrello crash

2016-06-14 Thread Ralf Habacker via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364313 Ralf Habacker changed: What|Removed |Added Product|umbrello|Breeze Assignee|umbrello-de...@kde.or

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 161 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/161/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 19:31:20 + Build duration: 19 min CHANGE SET Revision 58ea81b94ba306e2a4039daf536ab96830

[Differential] [Closed] D1865: TasksModel: cache launcherCount().

2016-06-14 Thread dfaure (David Faure)
dfaure closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1865 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, hein Cc: broulik, plasma-devel, jensreuterberg, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 162 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/162/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 20:24:00 + Build duration: 19 min CHANGE SET Revision d845889d2c5fb1f400f954ec262928a810

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

2016-06-14 Thread broulik (Kai Uwe Broulik)
broulik added a comment. That icon has been shipped, but never used, with the calendar applet for so long I don't even find a trace of it being added in git log. It's plasma-workspace/applets/calendar/package/contents/images/mini-calendar.svgz REPOSITORY rPLASMAWORKSPACE Plasma Worksp

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 163 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/163/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 20:43:14 + Build duration: 18 min CHANGE SET Revision 8205d34657d2e83c28714c9568b87717f5

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 164 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 21:19:36 + Build duration: 17 min CHANGE SET Revision a543be48d486f335abaead0b1e33ff4ee6

Re: Review Request 128108: update weather applet ui

2016-06-14 Thread Friedrich W. H. Kossebau
> On June 14, 2016, 5:45 a.m., Andreas Kainz wrote: > > can I get a ship it to get it in plasma 5.7, or any feedback what I have to > > improve. Ah, pardon, missed that your last comment actually came with an update to the patch. Looks good codewise, besides that one issue which I just reopene

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 165 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/165/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 22:24:41 + Build duration: 9 min 58 sec CHANGE SET Revision b5a5c1584bea4aa04fbc4c8371f4

Re: SDDM Theme update

2016-06-14 Thread David Edmundson
On Wed, Jun 15, 2016 at 12:30 AM, David Edmundson < da...@davidedmundson.co.uk> wrote: > On Fri, Jun 10, 2016 at 10:53 PM, kainz.a wrote: > >> Hi David, >> >> kde neon dev ship the new breeze sddm theme (thanks jonathan). It look >> really good, but I have also some remarks: >> > > >> 1. the avat

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 166 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/166/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 22:34:58 + Build duration: 9 min 48 sec CHANGE SET Revision af6075e397b12c06b2ffda433f75

Re: Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 166 - Still Unstable!

2016-06-14 Thread David Edmundson
​Aleix, it is failing in plasmoid tests. Can you look into it? FWIW, ctest passes locally here - so it is a problem purely with the CI rather than the code itself. But having something broken for a month and a half isn't really on. David ___ Plasma-deve

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 167 - Still Unstable!

2016-06-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/167/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Jun 2016 22:47:41 + Build duration: 24 min CHANGE SET Revision 78db2802b6c09c1a6d789dbf5af2cccbc9

[Differential] [Request, 724 lines] D1881: Add an inline grouping mode.

2016-06-14 Thread hein (Eike Hein)
hein created this revision. hein added a reviewer: davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY When grouping inline, the group subtrees are flattened out into the top-level list, parents removed, and move() treats grou

[Differential] [Request, 36 lines] D1882: Expose inline grouping mode.

2016-06-14 Thread hein (Eike Hein)
hein created this revision. hein added a reviewer: davidedmundson. hein added a subscriber: plasma-devel. hein added a dependency: D1881: Add an inline grouping mode.. Restricted Application added a project: Plasma. REVISION SUMMARY In inline grouping mode, task buttons are smaller by default (a

[Differential] [Commented On] D1874: [XWindowTasksModel] Ignore when client is transient for itself

2016-06-14 Thread Martin Gräßlin
graesslin added a comment. now I have a headache after reading the explanation. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1874 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc:

Re: SDDM Theme update

2016-06-14 Thread kainz.a
Am 15.06.2016 00:43 schrieb "David Edmundson" : > > > > On Wed, Jun 15, 2016 at 12:30 AM, David Edmundson < da...@davidedmundson.co.uk> wrote: >> >> On Fri, Jun 10, 2016 at 10:53 PM, kainz.a wrote: >>> >>> Hi David, >>> >>> kde neon dev ship the new breeze sddm theme (thanks jonathan). It look rea