[Differential] [Accepted] D3229: Disable starting kactivitymanagerd throughout launchertasksmodeltest

hein accepted this revision. hein added a reviewer: hein. hein added a comment. This revision is now accepted and ready to land. Looks fine modulo apol's issue. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3229 EMAIL

[Differential] [Request, 3 lines] D3238: Use our tooling for installing components

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3238 AFFECTED FILES

Re: DrKonqi and BKO

On Wed, Nov 2, 2016 at 6:32 AM, Harald Sitter wrote: > On Wed, Nov 2, 2016 at 11:04 AM, René J. V. Bertin > wrote: > > Martin Klapetek wrote: > > > > > >> For improving readability, there is bugzilla-traceparser plugin, that > can > >> dynamically

Review Request 129315: Don't install plasmoid desktop files as services

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 128793: [kio_mtp] Improve warning message

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128793/#review100518 --- Ship it! Ship It! - Albert Astals Cid On Sept. 7,

[Differential] [Commented On] D3210: make scrollbar size configurable

colomar added a comment. It does make sense to me to give the option to turn the slim scroll bar as such on and off. I can imagine some people being uncomfortable with the animation on mouseover. Being able to configure individual parameters is probably overkill, however. REPOSITORY

[Differential] [Request, 10 lines] D3236: Enables grouping and sorting settings in Icons Only Task Manager

pedroarthurp created this revision. pedroarthurp added a reviewer: sandroandrade. pedroarthurp set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY

Re: Proposed SoK Project | Frozen Window Options Menu when out of focus (Plasma 5.7, KWIN)

Am 2016-11-02 20:44, schrieb Jordan Rushing: Hello - My name is Jordan and I have recently signed up to participate in the Season of KDE program as a student for 2016. I am a senior undergraduate Computer Science student based in the US and this is my first time contributing to OSS. Hi

Proposed SoK Project | Frozen Window Options Menu when out of focus (Plasma 5.7, KWIN)

Hello - My name is Jordan and I have recently signed up to participate in the Season of KDE program as a student for 2016. I am a senior undergraduate Computer Science student based in the US and this is my first time contributing to OSS. Valorie Zimmerman in the #kde-soc IRC channel advised me

Re: Review Request 129309: Fix broken systemloadviewer tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129309/ --- (Updated Nov. 2, 2016, 8:01 p.m.) Status -- This change has been

[Differential] [Changed Subscribers] D2894: Start KDE Cleanups

wbauer added inline comments. INLINE COMMENTS > startkde.cmake:295 > > $qdbus org.kde.KSplash /KSplash org.kde.KSplash.setStage kinit & > $qdbus is still being used here, so this won't work anymore I suppose... REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

Re: Review Request 129298: RFC: supporting dependencies on KPackage

> On Oct. 31, 2016, 6:19 p.m., Marco Martin wrote: > > autotests/data/testpackagesdep/metadata.json, line 14 > > > > > > if kns ends up using ids, maybe the server should be specified as well, > > as the id

[Differential] [Commented On] D3231: [Lock Screen] Show "Switch User" button only if allowed

davidedmundson added a comment. If switching is disabled, we still want to hide the button. I think we need: (count > 0 || canStartNew) && canSwitch --- > bool SessionsModel::canSwitchUser() const { return const_cast(this)->m_displayManager.isSwitchable() &&

[Differential] [Accepted] D3232: [Lock Screen] Don't assume last user is "New Session" entry

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3232 EMAIL PREFERENCES

[Differential] [Request, 3 lines] D3232: [Lock Screen] Don't assume last user is "New Session" entry

broulik created this revision. broulik added reviewers: Plasma, subdiff. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ask the model

[Differential] [Commented On] D3229: Disable starting kactivitymanagerd throughout launchertasksmodeltest

apol added a comment. LGTM +1 INLINE COMMENTS > launchertasksmodeltest.cpp:47 > > + > void LauncherTasksModelTest::initTestCase() Added a blank line? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3229 EMAIL PREFERENCES

[Differential] [Request, 3 lines] D3231: [Lock Screen] Show "Switch User" button only if allowed

broulik created this revision. broulik added reviewers: Plasma, subdiff. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Only the button

Re: Review Request 128793: [kio_mtp] Improve warning message

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128793/#review100508 --- +1 - Aleix Pol Gonzalez On Sept. 7, 2016, 12:35 p.m.,

[Differential] [Accepted] D3220: Introduce new pre-layout script hook

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. Let's go with this, maybe use two different wariables for the script paths, but let's go with it. even if is a new thing, it should go on 5.8 as well tough.

Re: Review Request 129308: Calendar: clear selection on opening

> On Nov. 2, 2016, 2:49 p.m., David Edmundson wrote: > > do you have commit access? I don't have commit access. - Miklós --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 129308: Calendar: clear selection on opening

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129308/#review100506 --- Ship it! do you have commit access? - David Edmundson

Re: Review Request 129308: Calendar: clear selection on opening

> On Nov. 2, 2016, 1:53 p.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/CalendarView.qml, line 53 > > > > > > This original code is trying to make sure we only reset once instead of >

Re: Review Request 129308: Calendar: clear selection on opening

> On Nov. 2, 2016, 1:53 p.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/CalendarView.qml, line 53 > > > > > > This original code is trying to make sure we only reset once instead of >

Re: Review Request 129308: Calendar: clear selection on opening

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129308/#review100502 --- applets/digital-clock/package/contents/ui/CalendarView.qml

[Differential] [Updated, 445 lines] D3089: Restore global menu support

broulik updated this revision to Diff 7832. broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Move comment - Check for service name / object path being empty before finding a client - Remove added empty line REPOSITORY rKWIN KWin CHANGES

[Differential] [Accepted] D3227: [helpers/killer] Use instead of

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH killer-para-to-p REVISION DETAIL https://phabricator.kde.org/D3227 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D3229: Disable starting kactivitymanagerd throughout launchertasksmodeltest

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently kactivitymanagerd is loaded halfway through this test, which has the net result of

[Differential] [Request, 1 line] D3228: [helpers/killer] Force to platform XCB

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The killer can only kill X11 windows. It is also only invoked for

[Differential] [Updated] D3227: [helpers/killer] Use instead of

graesslin added a reviewer: schwarzer. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3227 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma, schwarzer Cc: plasma-devel, kwin, lesliezhai, ali-mohamed,

[Differential] [Request, 8 lines] D3227: [helpers/killer] Use instead of

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY para works fine for English, but seems to break in translations. BUG: 363750 FIXED-IN:

[Differential] [Closed] D3222: Correctly set i18n suffix in mousemark spinbox.

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN254690e899dc: Correctly set i18n suffix in mousemark spinbox. (authored by davidedmundson). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3222?vs=7821=7828

[Differential] [Accepted] D3222: Correctly set i18n suffix in mousemark spinbox.

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > davidedmundson wrote in mousemark_config.ui:9-10 > that's a good theory, but I should reply in case you worry about that

[Differential] [Closed] D3188: Modified distance function to keep aspect ratio as close as possible

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE18858d16d6b1: Modified distance function to keep aspect ratio as close as possible (authored by antlarr). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3225: Don't snap to auto-hidden panels

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH dont-snap-to-auto-hidden-panel-5.8 REVISION DETAIL https://phabricator.kde.org/D3225 EMAIL PREFERENCES

[Differential] [Accepted] D3188: Modified distance function to keep aspect ratio as close as possible

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH arcpatch-D3188 REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 128793: [kio_mtp] Improve warning message

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128793/#review100497 --- Ping? 16.12 string freeze is slowly approaching - Elvis

[Differential] [Updated, 181 lines] D3188: Modified distance function to keep aspect ratio as close as possible

antlarr updated this revision to Diff 7823. antlarr added a comment. - Moved testfindpreferredimage to an autotests directory REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3188?vs=7764=7823 BRANCH arcpatch-D3188 REVISION DETAIL

[Differential] [Commented On] D3188: Modified distance function to keep aspect ratio as close as possible

mart added a comment. almost perfect :) last thing, can the test be moved in a subfolder called autotests? (just a convention) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES

[Differential] [Request, 3 lines] D3225: Don't snap to auto-hidden panels

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY When moving windows we don't want to snap against not visible windows like auto-hidden panels.

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 533 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/533/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Nov 2016 11:16:08 + Build duration: 10 min CHANGE SET Revision

[Differential] [Updated, 91 lines] D3222: Correctly set i18n suffix in mousemark spinbox.

davidedmundson updated this revision to Diff 7821. davidedmundson marked an inline comment as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. changes REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3222: Correctly set i18n suffix in mousemark spinbox.

davidedmundson marked 2 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in mousemark_config.ui:9-10 > careful here: you opened the UI on a high DPI system and doubled the size. that's a good theory, but I should reply in case you worry about that

[Differential] [Closed] D3212: Support drags from Widget Explorer onto System Tray

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEbd0eb992d8d9: Support drags from Widget Explorer onto System Tray (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Plasma 5.7.5 / 5.8.0 multiscreen: Menu and widgets react to mouse events with seconds of delay if Primary Display = external monitor

Hi, Fortunately, I was able to resolve this problem today with - the upgrade to Plasma 5.8.2 and KDE Frameworks 5.27.0, combined with - a cleanup of Plasma configuration files -- see the comments and solution inlined below. Another Fedora user upgraded from an older Plasma version to 5.8.2 as

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

https://bugs.kde.org/show_bug.cgi?id=370374 Jens Reuterberg changed: What|Removed |Added CC||jens...@kolabnow.com

Re: DrKonqi and BKO

On Wed, Nov 2, 2016 at 11:04 AM, René J. V. Bertin wrote: > Martin Klapetek wrote: > > >> For improving readability, there is bugzilla-traceparser plugin, that can >> dynamically >> hide long backtraces with a bit of JS magic to expand them and much >> more >> like

Re: Review Request 129309: Fix broken systemloadviewer tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129309/#review100492 --- Ship it! Oh, you're right. I forgot to add this to my

Re: DrKonqi and BKO

Martin Klapetek wrote: > For improving readability, there is bugzilla-traceparser plugin, that can > dynamically > hide long backtraces with a bit of JS magic to expand them and much > more > like finding duplicates and also auto-dupe. I still think this would help > tremendously to >

[Differential] [Updated] D3089: Restore global menu support

broulik marked 3 inline comments as done. broulik added inline comments. INLINE COMMENTS > graesslin wrote in abstract_client.cpp:75-77 > why carry the bool in the signal? That seems to make it way more complicated > here In DecoratedClient I do connect(client, ::hasApplicationMenuChanged,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 532 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/532/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Nov 2016 09:11:59 + Build duration: 7 min 35 sec CHANGE SET Revision

[Differential] [Commented On] D3089: Restore global menu support

graesslin added a comment. One more general thing: I'd love to see a test case for the new added code. INLINE COMMENTS > abstract_client.cpp:75-77 > +connect(ApplicationMenu::self(), > ::applicationMenuEnabledChanged, this, [this] { > +emit

[Differential] [Changed Subscribers] D3222: Correctly set i18n suffix in mousemark spinbox.

graesslin added inline comments. INLINE COMMENTS > CMakeLists.txt:79 > WindowSystem > +TextWidgets > IconThemes Please move down to the find_package section in line 84. It's a dependency only needed for a config module so it should be together with the other config modules. >

Review Request 129309: Fix broken systemloadviewer tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129309/ --- Review request for Plasma, David Edmundson and Miklós Máté. Repository: